Files
reverse-engineering-anything/src/providers/AnalysisClientCleanup.ts
T
RRFZandmorluto 0be83b62fc fix(binary): retain unconfirmed composite clients until close succeeds (#12599)
* fix(binary): retain unconfirmed composite clients until close succeeds

* fix(binary): settle synthesized close failures after client retry

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-20 00:40:51 +00:00

53 lines
1.9 KiB
TypeScript

import { ProviderCleanupError } from "../domain/providerCleanupError.js";
import { err, type Result } from "../domain/result.js";
import {
AnalysisError,
type AnalysisCleanupReleaseClaim,
} from "../domain/analysisErrorBase.js";
import type { AnalysisClient } from "../ports/AnalysisProvider.js";
/** Close one provider client and normalize unexpected adapter rejection. */
export const closeAnalysisClient = async (
client: AnalysisClient,
providerId: string,
options: Parameters<AnalysisClient["close"]>[0] = {},
closeRejectionRelease?: AnalysisCleanupReleaseClaim,
): Promise<Result<null, AnalysisError>> => {
// Nested/composite clients report failures before their final result settles.
// Own notification identity for this close attempt, including the fallback
// for clients that only return or reject with their cleanup failure.
const reported = new Set<AnalysisError>();
const report = (failure: AnalysisError): void => {
if (reported.has(failure)) return;
reported.add(failure);
options.onCleanupFailure?.(failure);
};
let result: Result<null, AnalysisError>;
try {
result = await client.close({
...options,
...(options.onCleanupFailure === undefined
? {}
: { onCleanupFailure: report }),
});
} catch (cause: unknown) {
if (cause instanceof AnalysisError && cause.cleanupIncomplete) {
result = err(cause);
} else {
// An unexpected rejection cannot attest this close's completion. A
// caller that retains the client can supply its own retry release.
const failure = new ProviderCleanupError(
providerId,
["provider-client"],
{ reason: "provider client close rejected unexpectedly" },
{ cause },
);
if (closeRejectionRelease !== undefined)
failure.bindCleanupReleaseClaim(closeRejectionRelease);
result = err(failure);
}
}
if (!result.ok) report(result.error);
return result;
};