mirror of
https://github.com/morluto/rea.git
synced 2026-10-28 02:15:44 +00:00
* feat(javascript): resolve exact package import aliases Resolve exact #alias specifiers against the importer's enclosing package.json imports map using the shared condition, array, and null target selection. Nested packages keep their own maps; missing keys, explicit nulls, and out-of-scope aliases report a precise reason. Wildcard, recursive, and external-package import targets remain unresolved. * fix(javascript): keep nested import aliases in CLI graphs Bound nested #alias requires produce application-graph require edges from the enclosing package. Node reports MODULE_NOT_FOUND when a nested package.json has no imports field, without inheriting the ancestor map. * fix(javascript): resolve literal package import keys before path admission * fix(javascript): preserve import keys and invalid-target fallback * fix(javascript): preserve unmatched package target arrays * fix(javascript): retain package target refusal evidence * test(browser): match real verifier startup budget --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
148 lines
3.8 KiB
TypeScript
148 lines
3.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import {
|
|
classifyPackageImportSpecifier,
|
|
classifyPackageImportTargetString,
|
|
lookupExactPackageImport,
|
|
} from "./javascriptPackageImportAliases.js";
|
|
|
|
describe("package import specifier classification", () => {
|
|
it("treats an exact hash alias as an exact key", () => {
|
|
expect(classifyPackageImportSpecifier("#config")).toEqual({
|
|
kind: "exact",
|
|
key: "#config",
|
|
});
|
|
});
|
|
|
|
it.each(["#internal/env", "#/hidden"])(
|
|
"treats %j as an exact key",
|
|
(specifier) => {
|
|
expect(classifyPackageImportSpecifier(specifier)).toEqual({
|
|
kind: "exact",
|
|
key: specifier,
|
|
});
|
|
},
|
|
);
|
|
|
|
it.each(["#", "#/", "#utils/"])(
|
|
"rejects reserved specifier %j",
|
|
(specifier) => {
|
|
expect(classifyPackageImportSpecifier(specifier)).toEqual({
|
|
kind: "invalid",
|
|
});
|
|
},
|
|
);
|
|
|
|
it.each(["#internal/*", "#*"])(
|
|
"leaves pattern specifier %j unresolved",
|
|
(specifier) => {
|
|
expect(classifyPackageImportSpecifier(specifier)).toEqual({
|
|
kind: "pattern",
|
|
});
|
|
},
|
|
);
|
|
});
|
|
|
|
describe("exact package import lookup", () => {
|
|
it("returns the exact target without falling through to another key", () => {
|
|
expect(
|
|
lookupExactPackageImport(
|
|
{ "#config": "./config.cjs", "#other": "./other.cjs" },
|
|
"#config",
|
|
),
|
|
).toEqual({
|
|
kind: "found",
|
|
target: "./config.cjs",
|
|
declared: ["#config", "#other"],
|
|
});
|
|
});
|
|
|
|
it("names declared exact keys when the requested alias is absent", () => {
|
|
expect(
|
|
lookupExactPackageImport({ "#config": "./config.cjs" }, "#missing"),
|
|
).toEqual({
|
|
kind: "missing-key",
|
|
declared: ["#config"],
|
|
});
|
|
});
|
|
|
|
it("does not claim a miss when the map only has pattern keys", () => {
|
|
expect(
|
|
lookupExactPackageImport({ "#internal/*": "./src/*.js" }, "#internal/a"),
|
|
).toEqual({
|
|
kind: "pattern-unresolved",
|
|
declared: ["#internal/*"],
|
|
});
|
|
});
|
|
|
|
it("still selects an exact key when the same map also has patterns", () => {
|
|
expect(
|
|
lookupExactPackageImport(
|
|
{ "#config": "./config.cjs", "#internal/*": "./src/*.js" },
|
|
"#config",
|
|
),
|
|
).toEqual({
|
|
kind: "found",
|
|
target: "./config.cjs",
|
|
declared: ["#config", "#internal/*"],
|
|
});
|
|
});
|
|
|
|
it.each([undefined, null, "./config.cjs", ["#config"], 7] as const)(
|
|
"treats non-object imports value %j as an undefined map",
|
|
(imports) => {
|
|
expect(lookupExactPackageImport(imports, "#config")).toEqual({
|
|
kind: "undefined-map",
|
|
});
|
|
},
|
|
);
|
|
|
|
it("does not treat a pattern key as an exact match for itself", () => {
|
|
expect(
|
|
lookupExactPackageImport({ "#internal/*": "./src/*.js" }, "#internal/*"),
|
|
).toEqual({
|
|
kind: "pattern-unresolved",
|
|
declared: ["#internal/*"],
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("package import target string classification", () => {
|
|
it("keeps package-local relative targets", () => {
|
|
expect(classifyPackageImportTargetString("./config.cjs")).toEqual({
|
|
kind: "relative",
|
|
target: "./config.cjs",
|
|
});
|
|
});
|
|
|
|
it("marks recursive hash aliases as recursive", () => {
|
|
expect(classifyPackageImportTargetString("#other")).toEqual({
|
|
kind: "recursive",
|
|
target: "#other",
|
|
});
|
|
});
|
|
|
|
it.each(["lodash", "pkg/subpath"])(
|
|
"marks %j as an external-package target",
|
|
(target) => {
|
|
expect(classifyPackageImportTargetString(target)).toEqual({
|
|
kind: "external-package",
|
|
target,
|
|
});
|
|
},
|
|
);
|
|
|
|
it.each([
|
|
"../outside.js",
|
|
"/outside.js",
|
|
"https://example.invalid/mod.js",
|
|
"file:///outside.js",
|
|
"node:fs",
|
|
])("marks %j as an invalid import target", (target) => {
|
|
expect(classifyPackageImportTargetString(target)).toEqual({
|
|
kind: "invalid",
|
|
target,
|
|
});
|
|
});
|
|
});
|