mirror of
https://github.com/morluto/rea.git
synced 2026-11-21 14:05:49 +00:00
Require delivered facts, exact cancellation and malformed-input boundaries, and independent metadata expectations. Transfer unique assertions into stronger keepers before removing duplicate cases and overwritten fixture writes; preserve all consumed core fixture bytes. Validation: 1,190 focused tests passed with 39 platform-dependent skips; 134 composition and conformance tests passed. Typecheck, lint, formatting, discovery and Knip passed. Independent preservation reviews and targeted regression controls passed.
230 lines
8.2 KiB
TypeScript
230 lines
8.2 KiB
TypeScript
import { mkdir, readFile, writeFile } from "node:fs/promises";
|
|
import { join, isAbsolute } from "node:path";
|
|
import { Client } from "@modelcontextprotocol/client";
|
|
import {
|
|
StdioClientTransport,
|
|
getDefaultEnvironment,
|
|
} from "@modelcontextprotocol/client/stdio";
|
|
import { expect, it, vi } from "vitest";
|
|
import { z } from "zod";
|
|
import { configureClientConfiguration } from "../../../src/application/SetupClientConfiguration.js";
|
|
import { readClientRegistrationStatuses } from "../../../src/application/ClientRegistrationStatus.js";
|
|
import { currentClientRegistrationCommand } from "../../../src/application/ClientRegistrationIdentity.js";
|
|
import { systemUninstallHost } from "../../../src/application/Uninstall.js";
|
|
import { PRODUCT_IDENTITY } from "../../../src/identity.js";
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
|
|
// These writer tests model setup running from REA's actual entrypoint, not Vitest's worker.
|
|
vi.mock(
|
|
"../../../src/process/CurrentEntrypointPath.js",
|
|
async (importOriginal) => {
|
|
const actual =
|
|
await importOriginal<
|
|
typeof import("../../../src/process/CurrentEntrypointPath.js")
|
|
>();
|
|
const { fileURLToPath } = await import("node:url");
|
|
return {
|
|
...actual,
|
|
CURRENT_ENTRYPOINT_PATH: fileURLToPath(
|
|
new URL("../../../scripts/rea.mjs", import.meta.url),
|
|
),
|
|
};
|
|
},
|
|
);
|
|
|
|
const configurationSchema = z.object({
|
|
mcpServers: z.object({
|
|
rea: z.object({ command: z.string(), args: z.array(z.string()) }),
|
|
}),
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
previousCommand: [
|
|
"npx",
|
|
"-y",
|
|
PRODUCT_IDENTITY.registrationPackageSpecifier,
|
|
"mcp",
|
|
],
|
|
},
|
|
{ previousCommand: ["cmd", "/c", "npx", "-y", "rea-agents@5.0.0", "mcp"] },
|
|
])(
|
|
"migrates Windows npx registration $previousCommand idempotently and uninstalls only REA",
|
|
async ({ previousCommand }) => {
|
|
const home = await createTestTempDirectory("rea-windows-registration-");
|
|
const configPath = join(home, ".claude.json");
|
|
const original = JSON.stringify({
|
|
theme: "dark",
|
|
mcpServers: {
|
|
other: { command: "another-server" },
|
|
rea: {
|
|
command: previousCommand[0],
|
|
args: previousCommand.slice(1),
|
|
},
|
|
},
|
|
});
|
|
await writeFile(configPath, original);
|
|
expect(
|
|
await readClientRegistrationStatuses(home, undefined, {
|
|
platform: "win32",
|
|
environment: {},
|
|
}),
|
|
).toContainEqual(
|
|
expect.objectContaining({ client: "claude_code", state: "stale" }),
|
|
);
|
|
const client = {
|
|
name: "claude_code",
|
|
configPath,
|
|
format: "claude_code",
|
|
} as const;
|
|
const command = currentClientRegistrationCommand({ platform: "win32" });
|
|
expect(
|
|
await configureClientConfiguration(client, {}, command),
|
|
).toMatchObject({ status: "configured" });
|
|
expect(
|
|
await readClientRegistrationStatuses(home, undefined, {
|
|
platform: "win32",
|
|
environment: {},
|
|
}),
|
|
).toContainEqual(
|
|
expect.objectContaining({ client: "claude_code", state: "aligned" }),
|
|
);
|
|
expect(await configureClientConfiguration(client, {}, command)).toEqual({
|
|
status: "unchanged",
|
|
});
|
|
expect(await readFile(`${configPath}.rea.backup`, "utf8")).toBe(original);
|
|
expect(await systemUninstallHost(home).removeClient(client)).toMatchObject({
|
|
status: "removed",
|
|
});
|
|
const remaining: unknown = JSON.parse(await readFile(configPath, "utf8"));
|
|
expect(remaining).toEqual({
|
|
theme: "dark",
|
|
mcpServers: { other: { command: "another-server" } },
|
|
});
|
|
},
|
|
);
|
|
|
|
it("keeps the Windows direct launcher aligned through Codex TOML setup and removal", async () => {
|
|
const home = await createTestTempDirectory("rea-windows-codex-");
|
|
await mkdir(join(home, ".codex"));
|
|
const configPath = join(home, ".codex", "config.toml");
|
|
const original =
|
|
'\uFEFF# Keep this explanation.\nnotify = ["a", "b"]\nliteral = \'C:\\demo\\path\'\ndisabled_mcp_servers = ["rea"]\n\n[mcp_servers.other]\ncommand = "another-server"\n';
|
|
await writeFile(configPath, original);
|
|
const client = { name: "codex", configPath, format: "toml" } as const;
|
|
const command = currentClientRegistrationCommand({ platform: "win32" });
|
|
expect(await configureClientConfiguration(client, {}, command)).toMatchObject(
|
|
{ status: "configured" },
|
|
);
|
|
expect(
|
|
await readClientRegistrationStatuses(home, undefined, {
|
|
platform: "win32",
|
|
environment: {},
|
|
}),
|
|
).toContainEqual(
|
|
expect.objectContaining({ client: "codex", state: "aligned" }),
|
|
);
|
|
expect(await configureClientConfiguration(client, {}, command)).toEqual({
|
|
status: "unchanged",
|
|
});
|
|
expect(await readFile(`${configPath}.rea.backup`, "utf8")).toBe(original);
|
|
expect(await systemUninstallHost(home).removeClient(client)).toMatchObject({
|
|
status: "removed",
|
|
});
|
|
expect(await readFile(configPath, "utf8")).toBe(original);
|
|
});
|
|
|
|
it("retains rea-named custom shell registrations without writing a backup", async () => {
|
|
const home = await createTestTempDirectory("rea-custom-shell-registration-");
|
|
const configPath = join(home, ".claude.json");
|
|
const client = {
|
|
name: "claude_code",
|
|
configPath,
|
|
format: "claude_code",
|
|
} as const;
|
|
for (const command of [
|
|
["cmd.exe", "/d", "/c", "node", "custom.js", "mcp"],
|
|
["cmd.exe", "/k", "npx", "-y", "rea-agents@5.0.0", "mcp"],
|
|
["cmd.exe", "/c", "npx -y rea-agents@5.0.0 mcp"],
|
|
["cmd.exe", "/c", "npx", "-y", "another-package", "mcp"],
|
|
["cmd.exe", "/c", "npx", "-y", "rea-agents@5.0.0", "mcp", "&", "other"],
|
|
["cmd.exe", "/c", "npx", "-y", "rea-agents@5.0.0 & other", "mcp"],
|
|
["cmd.exe", "/c", "bunx", "another-package", "mcp"],
|
|
["cmd.exe", "/c", "bunx", "-y", "rea-agents@5.0.0", "mcp"],
|
|
["cmd.exe", "/c", "bunx", "rea-agents@5.0.0", "mcp", "&", "other"],
|
|
]) {
|
|
const original = JSON.stringify({
|
|
mcpServers: { rea: { command: command[0], args: command.slice(1) } },
|
|
});
|
|
await writeFile(configPath, original);
|
|
expect(await systemUninstallHost(home).removeClient(client)).toMatchObject({
|
|
status: "retained",
|
|
});
|
|
expect(await readFile(configPath, "utf8")).toBe(original);
|
|
await expect(readFile(`${configPath}.rea.backup`)).rejects.toMatchObject({
|
|
code: "ENOENT",
|
|
});
|
|
}
|
|
});
|
|
|
|
it.skipIf(process.platform !== "win32")(
|
|
"starts the written Windows registration without current-directory package runners",
|
|
async () => {
|
|
const root = await createTestTempDirectory("rea-windows-mcp-");
|
|
const home = join(root, "home with spaces");
|
|
await mkdir(home);
|
|
const configPath = join(home, ".claude.json");
|
|
const setupClient = {
|
|
name: "claude_code",
|
|
configPath,
|
|
format: "claude_code",
|
|
} as const;
|
|
const command = currentClientRegistrationCommand({ platform: "win32" });
|
|
expect(await configureClientConfiguration(setupClient)).toMatchObject({
|
|
status: "configured",
|
|
});
|
|
const registration = configurationSchema.parse(
|
|
JSON.parse(await readFile(configPath, "utf8")),
|
|
).mcpServers.rea;
|
|
expect([registration.command, ...registration.args]).toEqual(command);
|
|
expect(isAbsolute(registration.command)).toBe(true);
|
|
const marker = join(home, "runner-called.txt");
|
|
for (const runner of ["npx", "bunx"])
|
|
await writeFile(
|
|
join(home, `${runner}.cmd`),
|
|
`@echo unexpected>"${marker}"\r\n@exit /b 73\r\n`,
|
|
);
|
|
await writeFile(join(home, ".npmrc"), "registry=http://127.0.0.1:9/\n");
|
|
const transport = new StdioClientTransport({
|
|
command: registration.command,
|
|
args: registration.args,
|
|
cwd: home,
|
|
env: getDefaultEnvironment(),
|
|
stderr: "pipe",
|
|
});
|
|
const client = new Client({
|
|
name: "windows-direct-registration",
|
|
version: "1",
|
|
});
|
|
try {
|
|
await client.connect(transport);
|
|
expect(client.getServerVersion()?.version).toBe(
|
|
PRODUCT_IDENTITY.packageVersion,
|
|
);
|
|
const status = await client.callTool({
|
|
name: "binary_session",
|
|
arguments: {},
|
|
});
|
|
expect(status.isError).not.toBe(true);
|
|
expect(status.structuredContent).toMatchObject({
|
|
result: { open: false },
|
|
});
|
|
await expect(readFile(marker)).rejects.toMatchObject({ code: "ENOENT" });
|
|
} finally {
|
|
await client.close();
|
|
await transport.close();
|
|
}
|
|
},
|
|
30_000,
|
|
);
|