mirror of
https://github.com/morluto/rea.git
synced 2026-11-14 18:52:48 +00:00
Vitest's expect.poll and vi.waitFor stop after one second by default, a host-speed guess that the project's deadline policy does not see. Under hosted-CI load, kunaProjectConcurrency failed that way twice on unrelated PRs. Another 256 waits relied on the default, and 97 passed literals picked to fit some host. Waits now take as long as their test may run, less the reporting reserve that children already keep. Each Vitest project sets expect.poll's default, and the new waitFor in tests/support/testWait.ts replaces vi.waitFor. Fixture readiness waits (awaitAcknowledgement and the provider process waits) default to the same deadline, and their host-speed literal arguments are removed. One remainingTestDeadline owns the arithmetic for both children and waits. Ten waits whose short timeout was the real check now assert it directly (Kuna version probe, Cutter discovery, doctor and Inspector cancellation, apktool fixture teardown, JADX disconnect): settlement before the production deadline that would otherwise also satisfy the wait, or a deadline pinned beyond every test deadline. The rea/project-wait-deadline lint rule rejects vi.waitFor and explicit expect.poll timeouts. The testing guide and the CI tests audit skill now document the policy. Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
117 lines
3.5 KiB
TypeScript
117 lines
3.5 KiB
TypeScript
import { spawn, type ChildProcess } from "node:child_process";
|
|
import { fileURLToPath } from "node:url";
|
|
import type { ProviderProcessHandle } from "../../src/process/ProviderProcess.js";
|
|
import { testWaitDeadline } from "../support/testWait.js";
|
|
|
|
const fixturePath = fileURLToPath(
|
|
new URL("./providerProcess.mjs", import.meta.url),
|
|
);
|
|
|
|
/** Spawn one deterministic process-lifecycle fixture with piped diagnostics. */
|
|
export const spawnProviderProcessFixture = (
|
|
mode:
|
|
| "burst"
|
|
| "detached-child"
|
|
| "exit"
|
|
| "graceful"
|
|
| "invalid-utf8"
|
|
| "valid-multibyte"
|
|
| "late-stderr"
|
|
| "stubborn",
|
|
value?: number,
|
|
): ChildProcess =>
|
|
spawn(
|
|
process.execPath,
|
|
[fixturePath, mode, ...(value === undefined ? [] : [String(value)])],
|
|
{
|
|
stdio:
|
|
mode === "late-stderr"
|
|
? ["ignore", "pipe", "pipe", "pipe"]
|
|
: ["ignore", "pipe", "pipe"],
|
|
},
|
|
);
|
|
|
|
/** Wait until a long-lived fixture has installed its signal behavior. */
|
|
export const waitForProviderProcessReady = (
|
|
child: ProviderProcessHandle,
|
|
timeoutMs = testWaitDeadline(),
|
|
): Promise<void> =>
|
|
new Promise((resolve, reject) => {
|
|
const stdout = child.stdout;
|
|
if (stdout === null) {
|
|
reject(new Error("Provider process fixture stdout is unavailable"));
|
|
return;
|
|
}
|
|
let output = "";
|
|
const detach = (): void => {
|
|
clearTimeout(timer);
|
|
stdout.off("data", onData);
|
|
child.off("exit", onExit);
|
|
};
|
|
const onData = (chunk: Buffer | string): void => {
|
|
output += chunk.toString();
|
|
if (output.includes("ready\n")) {
|
|
detach();
|
|
resolve();
|
|
}
|
|
};
|
|
const onExit = (): void => {
|
|
detach();
|
|
reject(new Error("Provider process fixture exited before readiness"));
|
|
};
|
|
const timer = setTimeout(() => {
|
|
detach();
|
|
reject(new Error("Provider process fixture readiness timed out"));
|
|
}, timeoutMs);
|
|
stdout.on("data", onData);
|
|
child.once("exit", onExit);
|
|
});
|
|
|
|
/** Read the distinct process-group leader created by the detached-child mode. */
|
|
export const waitForDetachedProviderChild = (
|
|
child: ProviderProcessHandle,
|
|
timeoutMs = testWaitDeadline(),
|
|
): Promise<number> =>
|
|
new Promise((resolve, reject) => {
|
|
const stdout = child.stdout;
|
|
if (stdout === null) {
|
|
reject(new Error("Provider process fixture stdout is unavailable"));
|
|
return;
|
|
}
|
|
let output = "";
|
|
const detach = (): void => {
|
|
clearTimeout(timer);
|
|
stdout.off("data", onData);
|
|
child.off("exit", onExit);
|
|
};
|
|
const onData = (chunk: Buffer | string): void => {
|
|
output += chunk.toString();
|
|
const match = /(?:^|\n)ready:(\d+)\n/u.exec(output);
|
|
if (match?.[1] === undefined) return;
|
|
detach();
|
|
resolve(Number(match[1]));
|
|
};
|
|
const onExit = (): void => {
|
|
detach();
|
|
reject(new Error("Provider process fixture exited before readiness"));
|
|
};
|
|
const timer = setTimeout(() => {
|
|
detach();
|
|
reject(new Error("Provider process fixture readiness timed out"));
|
|
}, timeoutMs);
|
|
stdout.on("data", onData);
|
|
child.once("exit", onExit);
|
|
});
|
|
|
|
/** Kill a fixture if necessary and wait for its process handle to settle. */
|
|
export const stopProviderProcessFixture = async (
|
|
child: ProviderProcessHandle,
|
|
): Promise<void> => {
|
|
if (child.exitCode !== null || child.signalCode !== null) return;
|
|
const exited = new Promise<void>((resolve) => {
|
|
child.once("exit", () => resolve());
|
|
});
|
|
child.kill("SIGKILL");
|
|
await exited;
|
|
};
|