Files
reverse-engineering-anything/src/browser/history/MitmproxyCaptureAdapter.ts
T
FazminandClaude Opus 5.5 a67dbf6a48 fix: reject directory paths for the Wakaru limiter and mitmdump
`REA_JAVASCRIPT_PRLIMIT_COMMAND` and `REA_MITMDUMP_COMMAND` were admitted
after an access check alone, which a searchable directory passes. Admission
then succeeded, and the failure surfaced later as a launch-time adapter
error instead of the capability refusal that names the configured path.

Require a regular file, as #751 did for the firmware engine and limiter.
Linux-only tests mirror that change; both checks only run on Linux hosts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-11 10:43:48 +08:00

63 lines
2.2 KiB
TypeScript

import { access, stat } from "node:fs/promises";
import { constants } from "node:fs";
import { isAbsolute } from "node:path";
import { fileURLToPath } from "node:url";
import { AnalysisCapabilityUnavailableError } from "../../domain/analysisErrorCore.js";
import type { HistoricalCaptureFormatAdapter } from "./HistoricalCaptureFormatAdapter.js";
import { MITMPROXY_CAPTURE_PROVIDER_IDENTITY } from "./CaptureRelease.js";
const OPERATION = "inspect_web_network_capture";
const MITMDUMP_REQUIREMENT =
"Native capture decoding requires Linux and an absolute REA_MITMDUMP_COMMAND path to caller-supplied mitmdump 12.2.3; HAR needs no external engine.";
/** Native mitmproxy decoding is offline and uses only an explicitly configured Linux tool. */
export class MitmproxyCaptureAdapter implements HistoricalCaptureFormatAdapter {
readonly format = "mitmproxy";
readonly identity = MITMPROXY_CAPTURE_PROVIDER_IDENTITY;
constructor(readonly environment: Readonly<NodeJS.ProcessEnv>) {}
async command(
requestPath: string,
runtimePath: string,
): Promise<{ command: string; arguments: readonly string[] }> {
const command = this.environment.REA_MITMDUMP_COMMAND;
if (
process.platform !== "linux" ||
command === undefined ||
!isAbsolute(command)
)
throw new AnalysisCapabilityUnavailableError(
"mitmproxy",
OPERATION,
MITMDUMP_REQUIREMENT,
{ userMessage: MITMDUMP_REQUIREMENT },
);
try {
await access(command, constants.R_OK | constants.X_OK);
if (!(await stat(command)).isFile())
throw new TypeError("Configured path is not a regular file");
} catch (cause: unknown) {
const reason = `Configured mitmdump executable is unavailable: ${command}.`;
throw new AnalysisCapabilityUnavailableError(
"mitmproxy",
OPERATION,
reason,
{ cause, userMessage: reason },
);
}
return {
command,
arguments: [
"--no-server",
"-q",
"--set",
`confdir=${runtimePath}`,
"--set",
`rea_request_path=${requestPath}`,
"-s",
fileURLToPath(
new URL("../../../bridge/mitmproxy/capture.py", import.meta.url),
),
],
};
}
}