Files
reverse-engineering-anything/tests/boundary/providers/desktopLongBuildController.test.ts
T
morluto c94f275667 test(desktop): verify cancellation before releasing the guest (#12812)
* test(desktop): verify controller cancellation against held guest execution

* test(desktop): settle the readiness probe with one return type
2026-11-20 13:01:11 +00:00

123 lines
4.1 KiB
TypeScript

import { execFile } from "node:child_process";
import { access, mkdir, readFile, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { promisify } from "node:util";
import { expect, it } from "vitest";
import { BuildComputerLongRuns } from "../../../src/desktop/BuildComputerLongRuns.js";
import type { ControlledComputer } from "../../../src/ports/BuildComputerControl.js";
import { awaitAcknowledgement } from "../../fixtures/lifecycleAcknowledgement.js";
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
import { testWaitDeadline, waitFor } from "../../support/testWait.js";
const execute = promisify(execFile);
const computerWithRea = async () => {
const home = await createTestTempDirectory("desktop-long-controller-");
const bin = join(home, "bin");
await mkdir(bin);
await writeFile(
join(bin, "rea"),
`#!/usr/bin/env python3
import os, signal, sys, time
signal.signal(signal.SIGINT, lambda *_: sys.exit(130))
if sys.argv[1] == "wait":
open(sys.argv[2], "w").close()
while not os.path.exists(sys.argv[3]):
time.sleep(0.02)
print(os.environ.get("AGENTENV_CONTROL_TOKEN", "no token"))
`,
{ mode: 0o755 },
);
const timeouts: number[] = [];
const computer = {
exec: async (
argv: readonly string[],
timeout: number,
signal?: AbortSignal,
) => {
timeouts.push(timeout);
const [command = "", ...args] = argv;
const { stdout, stderr } = await execute(command, args, {
cwd: home,
env: {
...process.env,
HOME: home,
PATH: `${bin}:${process.env.PATH ?? ""}`,
AGENTENV_CONTROL_TOKEN: "test-token",
},
...(signal === undefined ? {} : { signal }),
});
return {
exit_code: 0,
stdout,
stderr,
timed_out: false,
truncated: false,
};
},
homeFiles: async () => new Map(),
redacted: (text: string) => text,
} as ControlledComputer;
return { computer, home, timeouts };
};
it("runs a long-budget export through bounded controller calls and publishes its result", async () => {
const { computer, home, timeouts } = await computerWithRea();
const owner = new BuildComputerLongRuns(computer);
const result = await owner.run(["done"], {
work: ".rea-build",
stdout: ".rea-build/out.json",
timeoutS: 7080,
signal: new AbortController().signal,
});
expect(result).toMatchObject({ exitCode: 0, stdoutBytes: 9 });
expect(await readFile(join(home, ".rea-build/out.json"), "utf8")).toBe(
"no token\n",
);
expect(Math.max(...timeouts)).toBeLessThanOrEqual(3600);
expect(owner.cleanupResources).toEqual([]);
});
it("stops and joins the real supervised command when the caller cancels", async () => {
const { computer, home } = await computerWithRea();
const ready = join(home, "ready");
const release = join(home, "release");
const cancellation = new Error("cancelled");
const controller = new AbortController();
const owner = new BuildComputerLongRuns(computer);
const run = owner
.run(["wait", ready, release], {
work: ".rea-build",
stdout: ".rea-build/out.json",
timeoutS: Math.floor(testWaitDeadline() / 1000),
signal: controller.signal,
})
.catch((error: unknown) => error);
const started = waitFor(async () => {
if (!controller.signal.aborted) await access(ready);
});
try {
await awaitAcknowledgement(started, run, "the guest command's start");
controller.abort(cancellation);
await expect(run).resolves.toMatchObject({
_tag: "AnalysisCancelledError",
cause: cancellation,
diagnostics: {
completed_command: { exit_code: 130, settled: true, cancelled: true },
},
});
expect(owner.cleanupResources).toEqual([]);
} finally {
controller.abort(cancellation);
// Only open the guest's normal exit path after observing the cancellation.
try {
await writeFile(release, "");
} finally {
await Promise.allSettled([started, run]);
expect(await owner.release()).toMatchObject({ verified: true });
}
}
});