mirror of
https://github.com/morluto/rea.git
synced 2026-11-03 05:16:16 +00:00
* fix(kuna): reject dangling cache roots in doctor Treat a cache path as creatable only when no directory entry occupies it. A dangling symbolic link, including one hidden by a trailing separator, fails the cache check and clears provider availability while the installation check and caller-selected registration settings remain. Fixes #5554 Fixes #5105 Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(doctor): admit the same settings native analysis rejects Project parseConfig failures into scoped engine readiness. Invalid provider preferences, startup timeouts, and other shared settings now fail the selected provider and the full audit, while a JEB-only timeout stays outside that admission. Fixes #5454 Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(doctor): report an invalid log level from doctor The dispatcher rejected REA_LOG_LEVEL before every command, so doctor never emitted its readiness check. Doctor now runs and names that setting; other commands still stop before execution. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(doctor): require log-level failures in every scope An invalid REA_LOG_LEVEL stops the executable and MCP server before a client or skill can run, so those scopes now fail readiness too. Other native admission failures stay limited to a selected provider. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(kuna): strip only the platform cache separator On Darwin and Linux a trailing backslash is a filename character. Doctor now removes only the selected platform separator before inspecting the cache path. Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(doctor): fail every provider on an invalid Hopper timeout REA_HOPPER_STARTUP_TIMEOUT_MS is rejected before any native engine starts. A selected non-Hopper provider now includes the existing timeout check. Co-authored-by: morluto <morluto@users.noreply.github.com> * style(doctor): format the Hopper timeout regression Co-authored-by: morluto <morluto@users.noreply.github.com> * fix(doctor): fail client scopes on MCP startup errors A registered client starts the MCP server, and parseConfig rejects every native admission failure before that server starts. Client readiness now includes those failures, not only REA_LOG_LEVEL. Co-authored-by: morluto <morluto@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: morluto <morluto@users.noreply.github.com>
231 lines
7.7 KiB
TypeScript
231 lines
7.7 KiB
TypeScript
import { uniqueSorted } from "../domain/canonicalOrdering.js";
|
|
import { blocksProcessStart } from "../logger.js";
|
|
import type {
|
|
ClientRegistrationStatus,
|
|
UnhealthyClientRegistrationStatus,
|
|
} from "./ClientRegistrationStatus.js";
|
|
import { manualRegistrationRemediation } from "./SupportedClients.js";
|
|
import type {
|
|
DoctorCheck,
|
|
DoctorProviderInspection,
|
|
DoctorScope,
|
|
DoctorSkillState,
|
|
} from "./Doctor.js";
|
|
|
|
/** Normalized readiness boundary included in every doctor response. */
|
|
export interface DoctorScopeReport {
|
|
readonly mode: "audit-wide" | "explicit";
|
|
readonly clients: readonly string[];
|
|
readonly skill_clients?: readonly string[];
|
|
readonly providers: readonly string[];
|
|
readonly skill: boolean;
|
|
readonly target: string | null;
|
|
}
|
|
|
|
interface DoctorProviderState {
|
|
readonly hopperAvailable: boolean;
|
|
readonly hopperConfigured: boolean;
|
|
readonly providerInspections: readonly DoctorProviderInspection[] | undefined;
|
|
}
|
|
|
|
interface DoctorScopeInput {
|
|
readonly checks: readonly DoctorCheck[];
|
|
readonly registrations: readonly ClientRegistrationStatus[];
|
|
readonly skillState: DoctorSkillState;
|
|
readonly providers: DoctorProviderState;
|
|
readonly scope: DoctorScopeReport;
|
|
}
|
|
|
|
/** Normalize a caller-selected doctor readiness boundary. */
|
|
export const normalizeDoctorScope = (
|
|
requested: DoctorScope | undefined,
|
|
target: string | undefined,
|
|
): DoctorScopeReport => ({
|
|
mode: requested === undefined ? "audit-wide" : "explicit",
|
|
clients: uniqueSorted(requested?.clients ?? []),
|
|
...(requested?.skillClients === undefined
|
|
? {}
|
|
: { skill_clients: uniqueSorted(requested.skillClients) }),
|
|
providers: uniqueSorted(requested?.providers ?? []),
|
|
skill: requested?.skill === true,
|
|
target: target ?? null,
|
|
});
|
|
|
|
/** Partition diagnostics into required and informational scope checks. */
|
|
export const scopeDoctorChecks = (
|
|
input: DoctorScopeInput,
|
|
): {
|
|
readonly healthy: boolean;
|
|
readonly scopeChecks: readonly DoctorCheck[];
|
|
readonly informationalChecks: readonly DoctorCheck[];
|
|
} => {
|
|
const providerChecks = input.checks.filter((candidate) =>
|
|
isProviderCheck(candidate.name, input.providers.providerInspections),
|
|
);
|
|
const coreChecks = input.checks.filter(
|
|
({ name }) =>
|
|
name === "node" || (input.scope.target !== null && name === "target"),
|
|
);
|
|
const clientChecks = input.scope.clients.map((client) =>
|
|
selectedRegistrationCheck(
|
|
client,
|
|
input.registrations.find((candidate) => candidate.client === client),
|
|
),
|
|
);
|
|
const skillChecks = input.scope.skill
|
|
? [selectedSkillCheck(input.skillState, input.checks)]
|
|
: [];
|
|
const selectedProviderChecks = input.scope.providers.flatMap((providerId) =>
|
|
selectedProviderChecksFor(providerId, providerChecks, input.providers),
|
|
);
|
|
const hopperHostChecks = input.scope.providers.includes("hopper")
|
|
? input.checks.filter(({ name }) => name === "host")
|
|
: [];
|
|
// parseConfig rejects these before the MCP server starts. Hopper's own
|
|
// scope already includes hopper-startup-timeout through its provider checks.
|
|
const blocksMcpStartup = (check: DoctorCheck): boolean =>
|
|
check.name.startsWith("runtime-configuration:") ||
|
|
check.name === "hopper-startup-timeout";
|
|
const blocksProcess = (check: DoctorCheck): boolean => {
|
|
const setting = check.details?.setting;
|
|
return (
|
|
check.name.startsWith("runtime-configuration:") &&
|
|
typeof setting === "string" &&
|
|
blocksProcessStart(setting)
|
|
);
|
|
};
|
|
const exercisesMcpStartup =
|
|
input.scope.clients.length > 0 || input.scope.providers.length > 0;
|
|
const startupChecks = (
|
|
exercisesMcpStartup
|
|
? input.checks.filter(blocksMcpStartup)
|
|
: input.checks.filter(blocksProcess)
|
|
).filter(
|
|
(check) =>
|
|
check.name !== "hopper-startup-timeout" ||
|
|
!input.scope.providers.includes("hopper"),
|
|
);
|
|
const scopeChecks = [
|
|
...coreChecks,
|
|
...startupChecks,
|
|
...hopperHostChecks,
|
|
...selectedProviderChecks,
|
|
...clientChecks,
|
|
...skillChecks,
|
|
];
|
|
const selectedNames = new Set(scopeChecks.map(({ name }) => name));
|
|
return {
|
|
healthy:
|
|
coreChecks.every(({ ok }) => ok) &&
|
|
startupChecks.every(({ ok }) => ok) &&
|
|
hopperHostChecks.every(({ ok }) => ok) &&
|
|
clientChecks.every(({ ok }) => ok) &&
|
|
skillChecks.every(({ ok }) => ok) &&
|
|
selectedProviderChecks.every(({ ok }) => ok),
|
|
scopeChecks,
|
|
informationalChecks: input.checks.filter(
|
|
({ name }) => !selectedNames.has(name),
|
|
),
|
|
};
|
|
};
|
|
|
|
const isProviderCheck = (
|
|
name: string,
|
|
inspections: readonly DoctorProviderInspection[] | undefined,
|
|
): boolean =>
|
|
name.startsWith("hopper") ||
|
|
inspections?.some(({ id }) => doctorProviderCheckName(id, name)) === true;
|
|
|
|
const selectedProviderChecksFor = (
|
|
providerId: string,
|
|
checks: readonly DoctorCheck[],
|
|
providers: DoctorProviderState,
|
|
): readonly DoctorCheck[] => {
|
|
const selected = checks.filter(({ name }) =>
|
|
providerId === "hopper"
|
|
? name.startsWith("hopper")
|
|
: doctorProviderCheckName(providerId, name),
|
|
);
|
|
const available =
|
|
providerId === "hopper"
|
|
? providers.hopperAvailable
|
|
: providers.providerInspections?.find(({ id }) => id === providerId)
|
|
?.available === true;
|
|
if (available && selected.every(({ ok }) => ok)) return selected;
|
|
if (selected.some(({ ok }) => !ok)) return selected;
|
|
return [
|
|
...selected,
|
|
{
|
|
name: `provider:${providerId}`,
|
|
ok: false,
|
|
classification: "missing_analysis_engine",
|
|
detail: `Requested provider ${providerId} is unavailable.`,
|
|
remediation: `Configure the ${providerId} provider, then rerun rea doctor.`,
|
|
},
|
|
];
|
|
};
|
|
|
|
const selectedRegistrationCheck = (
|
|
client: string,
|
|
status: ClientRegistrationStatus | undefined,
|
|
): DoctorCheck => {
|
|
const manual = manualRegistrationRemediation(client);
|
|
if (status === undefined && manual !== undefined)
|
|
return {
|
|
name: `registration:${client}`,
|
|
ok: false,
|
|
classification: "config_drift",
|
|
detail: `${client} is not registered through a local configuration file.`,
|
|
remediation: manual,
|
|
};
|
|
return status === undefined
|
|
? {
|
|
name: `registration:${client}`,
|
|
ok: false,
|
|
classification: "config_drift",
|
|
detail: `Requested client ${client} was not detected.`,
|
|
remediation: `Install or select ${client}, then run rea setup --client ${client}.`,
|
|
}
|
|
: status.state === "aligned"
|
|
? {
|
|
name: `registration:${client}`,
|
|
ok: true,
|
|
classification: "healthy",
|
|
detail: status.config_path,
|
|
}
|
|
: registrationCheck(status);
|
|
};
|
|
|
|
const registrationCheck = (
|
|
status: UnhealthyClientRegistrationStatus,
|
|
): DoctorCheck => ({
|
|
name: `registration:${status.client}`,
|
|
ok: false,
|
|
classification: status.state === "unknown" ? "unknown" : "config_drift",
|
|
detail: status.config_path,
|
|
remediation: status.remediation,
|
|
});
|
|
|
|
const selectedSkillCheck = (
|
|
state: DoctorScopeInput["skillState"],
|
|
checks: readonly DoctorCheck[],
|
|
): DoctorCheck =>
|
|
checks.find(({ name }) => name === "skill:identity") ?? {
|
|
name: "skill:identity",
|
|
ok: state === "aligned",
|
|
classification: state === "aligned" ? "healthy" : "config_drift",
|
|
...(state === "aligned"
|
|
? { detail: "Installed REA skill identity is aligned." }
|
|
: {
|
|
remediation:
|
|
state === "unmanaged"
|
|
? "Use regular skill directories, or run rea setup with --skill=false to configure the client without installing the skill."
|
|
: state === "unknown"
|
|
? "Verify access to the reported skill files before retrying."
|
|
: "Run rea setup to update the installed REA skill.",
|
|
}),
|
|
};
|
|
|
|
const doctorProviderCheckName = (providerId: string, name: string): boolean =>
|
|
name === providerId || name.startsWith(`${providerId}-`);
|