mirror of
https://github.com/morluto/rea.git
synced 2026-11-15 19:23:24 +00:00
* refactor(process): give POSIX PATH search order one owner Program lookup, the packet-tool locator and Jadx's Java lookup each split PATH and resolved empty and relative entries themselves. They now take the candidates from posixPathCandidates in src/process/executableSearch and keep only their own probe and failure reporting. A counted architecture guard keeps new PATH splits from returning; the remaining Windows and Ghidra searches are baselined. * refactor(process): move the colon-split PATH searches onto the search owner REA's launcher-alias lookup and Ghidra's macOS Java lookup split PATH on ":" and skipped relative entries themselves; they now use posixPathCandidates with relativeEntries: "skip", and the guard counts colon splits of PATH as well. * fix(process): produce PATH candidates lazily so an unused entry cannot fail an earlier match * refactor(process): give Windows PATH/PATHEXT search order the executable search owner (#10916) * refactor(process): give Windows PATH/PATHEXT search order the executable search owner * fix(process): keep later PATH entries searchable after a stray quote or a removed working directory * fix(reverse): refuse a Windows objdump or Rizin command that PATH does not find (#10953) * fix(reverse): refuse an objdump or Rizin command Windows PATH does not find instead of launching the bare name * fix(reverse): report a Windows lookup refusal after cancellation and to capability discovery * fix(desktop): search a Windows host's PATH as Windows does when doctor looks up a program programOnPath sent every host through the POSIX PATH search, so on Windows a relative PATH entry reached absoluteCallerPath with platform linux and the Windows working directory, which resolved against itself until the stack overflowed. programOnPath now searches PATH and PATHEXT through windowsPathCandidates on a Windows host, and absoluteCallerPath refuses a non-POSIX working directory with a TypeError instead of recursing.
122 lines
3.8 KiB
TypeScript
122 lines
3.8 KiB
TypeScript
import { win32 } from "node:path";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
import { err, ok } from "../../src/domain/result.js";
|
|
import { RIZIN_PROVIDER_IDENTITY } from "../../src/rizin/RizinProviderIdentity.js";
|
|
import { resolveWindowsProviderExecutable } from "../../src/composition/resolveWindowsProviderExecutable.js";
|
|
import { createReverseEngineeringCommandPort } from "../../src/composition/reverseEngineering.js";
|
|
|
|
const windowsLookup = (cwd: string, files: readonly string[]) => {
|
|
const existingFiles = new Set(
|
|
files.map((path) => win32.normalize(path).toLowerCase()),
|
|
);
|
|
return {
|
|
cwd,
|
|
isFile: (path: string): boolean =>
|
|
existingFiles.has(win32.normalize(path).toLowerCase()),
|
|
};
|
|
};
|
|
|
|
describe("resolveWindowsProviderExecutable", () => {
|
|
it("resolves a bare name from quoted and relative Windows PATH entries", () => {
|
|
const cwd = "C:\\work";
|
|
const expected = "C:\\work\\Program Files\\REA Tools\\objdump.EXE";
|
|
expect(
|
|
resolveWindowsProviderExecutable(
|
|
"objdump",
|
|
{
|
|
PATH: `.;".\\Program Files\\REA Tools";D:\\unused`,
|
|
PATHEXT: ".COM;.EXE;.BAT",
|
|
},
|
|
windowsLookup(cwd, [expected]),
|
|
),
|
|
).toEqual(ok(expected));
|
|
});
|
|
|
|
it("resolves a relative configured path against the caller's Windows CWD", () => {
|
|
expect(
|
|
resolveWindowsProviderExecutable(
|
|
".\\tools\\objdump.exe",
|
|
{},
|
|
windowsLookup("D:\\analysis", []),
|
|
),
|
|
).toEqual(ok("D:\\analysis\\tools\\objdump.exe"));
|
|
});
|
|
|
|
it("resolves relative PATH hits to absolute drive paths", () => {
|
|
const expected = "D:\\analysis\\bin\\rizin.EXE";
|
|
expect(
|
|
resolveWindowsProviderExecutable(
|
|
"rizin",
|
|
{ PATH: ".\\bin", PATHEXT: ".EXE" },
|
|
windowsLookup("D:\\analysis", [expected]),
|
|
),
|
|
).toEqual(ok(expected));
|
|
});
|
|
|
|
it("skips script extensions and preserves a caller-selected absolute path", () => {
|
|
const expected = "C:\\tools\\rizin.EXE";
|
|
const selected = "C:\\tools\\rizin.exe";
|
|
expect(
|
|
resolveWindowsProviderExecutable(
|
|
"rizin",
|
|
{ PATH: "C:\\tools", PATHEXT: ".CMD;.BAT;.EXE;.COM" },
|
|
windowsLookup("C:\\work", ["C:\\tools\\rizin.CMD", expected]),
|
|
),
|
|
).toEqual(ok(expected));
|
|
expect(
|
|
resolveWindowsProviderExecutable(
|
|
selected,
|
|
{},
|
|
windowsLookup("D:\\work", []),
|
|
),
|
|
).toEqual(ok(selected));
|
|
});
|
|
|
|
it("refuses an unresolved bare name instead of letting Windows search the current directory", () => {
|
|
expect(
|
|
resolveWindowsProviderExecutable(
|
|
"missing-tool",
|
|
{ PATH: ".\\tools", PATHEXT: ".EXE" },
|
|
windowsLookup("C:\\work", []),
|
|
),
|
|
).toEqual(err({ kind: "not_found" }));
|
|
expect(
|
|
resolveWindowsProviderExecutable(
|
|
"missing-tool",
|
|
{ PATH: "C:\\tools", PATHEXT: ".EXE;C:\\bad" },
|
|
windowsLookup("C:\\work", []),
|
|
),
|
|
).toEqual(err({ kind: "invalid_extension", extension: "C:\\bad" }));
|
|
});
|
|
|
|
it("passes an absolute selected command through provider composition", () => {
|
|
const commands = createReverseEngineeringCommandPort(
|
|
{ REA_OBJDUMP_COMMAND: "C:\\tools\\objdump.exe" },
|
|
"win32",
|
|
);
|
|
expect(
|
|
commands.objdump({ path: "artifact", operation: "file_headers" }),
|
|
).toMatchObject({
|
|
ok: true,
|
|
value: { executable: "C:\\tools\\objdump.exe" },
|
|
});
|
|
});
|
|
|
|
it("reports a bare command missing from PATH as unavailable before launch", () => {
|
|
const commands = createReverseEngineeringCommandPort(
|
|
{ PATH: "", REA_RIZIN_COMMAND: "rea-missing-rizin" },
|
|
"win32",
|
|
);
|
|
expect(commands.rizin({ path: "artifact", command: "i" })).toMatchObject({
|
|
ok: false,
|
|
error: {
|
|
identity: { id: RIZIN_PROVIDER_IDENTITY.id },
|
|
command: "rea-missing-rizin",
|
|
reason: { kind: "not_found" },
|
|
},
|
|
});
|
|
});
|
|
});
|