mirror of
https://github.com/morluto/rea.git
synced 2026-11-09 16:26:36 +00:00
ab1b9e35d0
* fix(evidence)!: keep one Evidence identity across Windows path case On Windows, an existing caller path now takes its filesystem spelling when that spelling differs from the resolved path by letter case alone. One file spelled `C:\Temp\x.bin`, `c:\temp\x.bin` or `C:\TEMP\X.BIN` produces one `parameters.path`, `normalized_result` path and `evidence_id`, matching the existing separator and `.` folding. `caller_input_path` keeps the input. Links, junctions, `subst` drives, 8.3 short names and paths that do not exist yet keep the caller spelling, so no link is followed and requested output names keep their case. BREAKING CHANGE: Windows Evidence produced from a path spelled in a case other than its filesystem spelling now gets a different `evidence_id`. Fixes #9373 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(entropy): keep Windows casing lookup optional * ci(entropy): select Windows identity verification --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
73 lines
3.0 KiB
TypeScript
73 lines
3.0 KiB
TypeScript
import { Client, InMemoryTransport } from "@modelcontextprotocol/client";
|
|
import { createServer } from "../../src/server/createServer.js";
|
|
import { createTestBinarySession } from "../fixtures/binarySession.js";
|
|
import { realpath, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { describe, expect } from "vitest";
|
|
import { createTestTempDirectory } from "../fixtures/temporaryDirectory.js";
|
|
import { cliTest } from "../support/cli/cliFixture.js";
|
|
import { ByteEntropyService } from "../../src/application/binaryDiagnostics/ByteEntropyService.js";
|
|
import { parseEvidence } from "../../src/domain/evidence.js";
|
|
|
|
describe.skipIf(process.platform !== "win32")(
|
|
"Windows selected-file spelling",
|
|
() => {
|
|
cliTest(
|
|
"shares entropy identity across service/MCP admission and CLI case spellings",
|
|
async ({ cli }) => {
|
|
const root = await realpath(
|
|
await createTestTempDirectory("rea-EntropyCase-"),
|
|
);
|
|
const path = join(root, "Sample.BIN");
|
|
await writeFile(path, Buffer.from([1, 2, 3, 4]));
|
|
const service = new ByteEntropyService();
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("No analysis provider should start");
|
|
});
|
|
const server = createServer({ kind: "session", session });
|
|
const client = new Client({ name: "entropy-case", version: "1" });
|
|
const [clientTransport, serverTransport] =
|
|
InMemoryTransport.createLinkedPair();
|
|
await server.connect(serverTransport);
|
|
await client.connect(clientTransport);
|
|
try {
|
|
const ids = new Set<string>();
|
|
for (const spelling of [
|
|
path,
|
|
path.toUpperCase(),
|
|
path.toLowerCase(),
|
|
path.replaceAll("\\", "/"),
|
|
`${root}\\.\\Sample.BIN`,
|
|
]) {
|
|
const direct = await service.inspect({ path: spelling });
|
|
if (!direct.ok) throw direct.error;
|
|
const fromCli = await cli.run({
|
|
arguments: ["inspect-byte-entropy", spelling, "--json"],
|
|
});
|
|
expect(fromCli.exitCode, fromCli.stderr).toBe(0);
|
|
const evidence = parseEvidence(fromCli.json);
|
|
const response = await client.callTool({
|
|
name: "inspect_byte_entropy",
|
|
arguments: { path: spelling },
|
|
});
|
|
expect(response.isError).not.toBe(true);
|
|
const mcpEvidence = parseEvidence(response.structuredContent);
|
|
ids.add(mcpEvidence.evidence_id);
|
|
expect(mcpEvidence.caller_input_path).toBe(spelling);
|
|
ids.add(evidence.evidence_id);
|
|
ids.add(direct.value.evidence_id);
|
|
expect(direct.value.caller_input_path).toBe(spelling);
|
|
expect(evidence.caller_input_path).toBe(spelling);
|
|
}
|
|
expect(ids.size).toBe(1);
|
|
} finally {
|
|
await client.close();
|
|
await server.close();
|
|
await session.close();
|
|
await service.close();
|
|
}
|
|
},
|
|
);
|
|
},
|
|
);
|