mirror of
https://github.com/morluto/rea.git
synced 2026-11-15 19:23:24 +00:00
morluto
b0e32578ae
* feat(cli): warn after mcp add writes Claude Desktop's configuration rea mcp add resolves Claude Desktop from the client table, whose row says a running app can rewrite its configuration from memory, but the command never told the caller. Print that notice on stderr when it writes the file. Backup notices now use the client's display name instead of special-casing Amp. * fix(cli): warn about Claude Desktop whenever mcp add wrote its file Address review findings: a registration that failed after publication, such as cancellation during verification, still left the file written, so the running-app notice now follows the registration owner's written fact instead of overall success. The CLI test compares the delivered notice with its owner instead of freezing the sentence.
63 lines
2.1 KiB
TypeScript
63 lines
2.1 KiB
TypeScript
import { expect } from "vitest";
|
|
|
|
import { runningClientRewriteNotice } from "../../../src/application/SupportedClients.js";
|
|
import { mcpRegistrationReportSchema } from "../../../src/contracts/mcpRegistration.js";
|
|
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
import { cliTest } from "../../support/cli/cliFixture.js";
|
|
import { registrationEnvironment } from "../../support/cli/registrationEnvironment.js";
|
|
|
|
// The owner's own text; this test checks delivery, not wording.
|
|
const QUIT_NOTICE = runningClientRewriteNotice({
|
|
name: "claude_desktop",
|
|
displayName: "Claude Desktop",
|
|
quitBeforeSetup: true,
|
|
});
|
|
|
|
cliTest.skipIf(process.platform === "win32")(
|
|
"mcp add tells the caller to quit Claude Desktop only when it wrote that client",
|
|
async ({ cli }) => {
|
|
const home = await createTestTempDirectory("rea-mcp-add-quit-notice-");
|
|
const environment = await registrationEnvironment(home);
|
|
const run = (agent: string) =>
|
|
cli.run({
|
|
arguments: [
|
|
"mcp",
|
|
"add",
|
|
"--agent",
|
|
agent,
|
|
"--command",
|
|
"fixture-server --mcp",
|
|
"--json",
|
|
],
|
|
cwd: home,
|
|
environment,
|
|
});
|
|
|
|
if (QUIT_NOTICE === undefined)
|
|
throw new Error("Claude Desktop has no notice");
|
|
const first = await run("claude-desktop");
|
|
expect(first.exitCode, first.stderr).toBe(0);
|
|
expect(
|
|
mcpRegistrationReportSchema.parse(JSON.parse(first.stdout)).clients,
|
|
).toEqual([
|
|
expect.objectContaining({
|
|
client: "claude-desktop",
|
|
status: "configured",
|
|
}),
|
|
]);
|
|
expect(first.stderr).toContain(QUIT_NOTICE);
|
|
// The JSON report is unchanged: the notice is advice on stderr.
|
|
expect(first.stdout).not.toContain(QUIT_NOTICE);
|
|
|
|
// An identical repeat writes nothing, so there is nothing to lose.
|
|
const repeated = await run("claude-desktop");
|
|
expect(repeated.exitCode, repeated.stderr).toBe(0);
|
|
expect(repeated.stderr).not.toContain(QUIT_NOTICE);
|
|
|
|
const other = await run("cursor");
|
|
expect(other.exitCode, other.stderr).toBe(0);
|
|
expect(other.stderr).not.toContain(QUIT_NOTICE);
|
|
},
|
|
);
|