mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 03:33:25 +00:00
* feat(setup): manage fx registrations with its private profile modes fx becomes a client-table row, so doctor, update and uninstall see the registration rea mcp add wrote, and setup offers fx when ~/.fx or FX_HOME exists. Setup now publishes a private profile through the same owner as mcp add (folder 0700, file 0600) and repairs those modes when the row is otherwise current. Doctor parses fx's array launcher instead of reporting it invalid. * fix(setup): judge fx's private profile by its targets and keep its cleanup owner Address review: privateProfileModesCurrent reads the modes of the canonical file and folder, so a linked profile becomes current; clientConfigurationAligned applies the same modes rule as plan and apply; a private-folder close failure reaches the caller with its cleanup owner instead of becoming a write failure; and the setup plan names the folder and file modes it sets. * fix(setup): keep fx's recovery backups owner-only beside a linked profile Setup and uninstall copied a private profile's original bytes with copyFile, so a backup beside a linked ~/.fx/mcp.json kept the target's readable mode outside the folder setup secures. Both now use the owner-only backup owner that mcp add already used. * feat(setup): manage Junie registrations and apply its location policy (#10712) * feat(setup): manage Junie registrations and apply its location policy Junie becomes a client-table row, so doctor, update and uninstall see the registration rea mcp add wrote, and setup offers Junie when its home exists. Whether Junie loads its default user MCP file now has one owner, read through the client policy block that setup, doctor and mcp add already consult: setup and mcp add refuse, and doctor reports, a registration Junie would not load. * fix(setup): read Junie's user configuration as strict JSON Address review: Junie loads config.json as strict JSON, so comments, trailing commas or an empty file leave its MCP location choice unknown, as before the move into the row. Filesystem tests also clear JUNIE_*, FX_HOME and MCPORTER_CONFIG so a developer's own client locations cannot be inspected or removed. * test(setup): keep the detected client order out of the lifecycle suite body The expected detection order grew with each folded client until the suite callback exceeded the max-lines-per-function lint limit. * fix(update): report a client whose policy setup refuses instead of failing maintenance Junie's disabled default locations (and Gemini's settings policy) make doctor report the registration stale, but setup refuses that client, so selecting it failed every other client's maintenance. The registration inspection now carries the setup blocker, and maintenance lists that client with its reason instead of selecting it. * refactor(setup): read fx's private-profile host through HOST_PLATFORM The fx private-profile mode checks and permissions describe the host REA runs on, so they take it from the host-platform owner instead of reading process.platform (refused by the ratchet from #10911). * feat(setup): manage Goose registrations across its configuration layers (#10715) * feat(setup): manage Goose registrations across its configuration layers Goose becomes a client-table row, so doctor, update and uninstall see the registration rea mcp add wrote, and setup offers Goose when its user file or system file exists. Goose loads its system file and GOOSE_ADDITIONAL_CONFIG_FILES beneath the user file and overlays each extension one field deep; doctor now reports that effective registration, while setup, update and uninstall change only the user file. Doctor also parses Goose's cmd launcher instead of reporting it invalid. * fix(setup): keep Goose's layered environment and load order through setup and uninstall Address review: read Goose's env alias and apply requested settings over envs; keep an inherited lower envs map instead of masking it with an empty default; keep each layer's last load so a repeated user file keeps its precedence; split GOOSE_ADDITIONAL_CONFIG_FILES with Windows quoting; validate only the effective environment across read-only layers; refuse uninstall while a read-only layer keeps REA enabled; and clear Goose's location variables in tests. * fix(setup): apply requested Goose settings over the inherited environment * fix(setup): leave lower-layer Goose settings in force and read admin layers read-only Setup no longer writes its default timeout, enabled, name or description into Goose's user entry when only a lower layer declares that setting, so the inherited value keeps applying and a repeat setup stays current. Uninstall reads Goose's read-only lower layers where Goose reads them, without the write target's ownership check, so an administrator-owned system file no longer blocks removal. The client table accepts an injected Goose system-config path so tests no longer read or skip on the host's /etc/goose/config.yaml; adds a shadowed-invalid-lower-layer regression. * fix(setup): keep an inherited Goose env alias's spelling when writing the user entry Goose overlays each extension field separately, so writing envs into the user file beside a lower layer's env alias left both in force, which readers reject as ambiguous. Setup now writes the user map under the alias a lower layer declares, and mcp add neither adds a default envs map beside an inherited alias nor renames a user alias the lower layer shares. * test(setup): inject Goose's system layer into mcp add selection resolveMcpRegistrationClients accepts the caller's system configuration paths, so the Goose layers test no longer reads the host's /etc/goose/config.yaml. * fix(setup): report REA's Goose registration that only a read-only layer defines * test(setup): pass an isolated Goose system path through update maintenance and the mcp add table * fix(setup): judge Goose uninstall by the merged entry and stop on an unreadable lower layer * fix(setup): select Goose's env alias by presence so a null alias stays malformed * fix(setup): use the shared record predicate for Goose's layered merge after #10588 * feat(setup): give Kilo a client-table row with an async layered location (#10823) * feat(setup): give Kilo a client-table row with an async layered location The client table gains a layeredLocation hook and resolveSupportedClients, which awaits it. Kilo's row resolves its user-scope layers through the same owner rea mcp add uses (KiloClientLocation), so both pick the same write target; the synchronous row keeps kilo.json in Kilo's config root with every candidate layer. The table refuses a relative KILO_CONFIG, KILO_CONFIG_DIR or XDG_CONFIG_HOME because Kilo's working directory is unknown. Refs #7181 * fix(setup): treat every folder Kilo reads as evidence that it is installed * fix(setup): normalize Kilo's absolute table paths and parse its command array * feat(setup): resolve the client table's layered locations in setup, doctor, update and uninstall (#10832) SetupHost (detection and the selectable table), ClientRegistrationStatus, uninstall, doctor's selected-registration environment and the mcp add catalog now read resolveSupportedClients, so each sees the Kilo layer Kilo writes rather than the synchronous default. Refs #7181 * docs(adr): record the one-client-table decision for setup and mcp add * fix(setup): refuse to read a client row whose location is unresolved Doctor's selected-client settings read a Kilo row whose relative KILO_CONFIG left only path evidence, so it inspected a file relative to REA's folder. The shared configuration reader now refuses such a row, so every reader reports the registration as unreadable. * docs(adr): name the row's layeredLocation hook * feat(setup): read KILO_CONFIG_CONTENT as Kilo's top read-only layer (#10851) * feat(setup): read KILO_CONFIG_CONTENT as Kilo's top read-only layer * fix(setup): refuse a Kilo uninstall that would expose or keep another layer's rea entry (#10852) * fix(setup): recheck KILO_CONFIG_CONTENT at write time and name it in doctor's recovery * refactor(mcp): register Kilo through its table row and remove the registration-only catalog kind (#10862) * refactor(mcp): register Kilo through its table row and remove the registration-only catalog kind * refactor(mcp): resolve user-scope targets in the catalog so location modules never import the client table * test(setup): cover Kilo's KILO_CONFIG, home-folder and inline-only layers * fix(setup): report REA's Kilo entry that only KILO_CONFIG_CONTENT sets during uninstall Doctor reports a registration that KILO_CONFIG_CONTENT alone defines, but uninstall found no file entry and reported Kilo as skipped. Uninstall now reports it once as failed and names the variable to edit. * docs(adr): record Kilo's inline layer in the client-table decision * fix(setup): compare Windows environment names without case when a higher layer overrides REA's entry Kilo's inline-layer check and Gemini's system-override check compared environment maps by exact key, so an equal Path beside PATH on Windows was reported as an override and setup refused the client. Both compare the entry as the client launches it. * fix(update): leave a stale Kilo registration KILO_CONFIG_CONTENT sets out of maintenance Setup refuses a refresh the inline layer would override, and one refused client failed every other client's maintenance. The registration inspection now names the inline layer as the setup blocker of a stale entry, and maintenance reports Kilo with that recovery instead of selecting it. * fix(setup): refuse relative JUNIE_HOME and Cline CLI overrides like the other client roots (#10909) * fix(setup): refuse relative JUNIE_HOME and Cline CLI overrides like the other client roots * fix(setup): refuse Windows client paths without a drive that follow the client's current drive * fix(update): select maintenance clients through setup's own refresh refusal check Maintenance predicted setup's refusal with its own rule: any inline rea entry blocked a stale registration, while an aligned one was never checked. A harmless KILO_CONFIG_CONTENT entry (enabled: true) kept a stale Kilo launcher pinned, and an inline value setup would not write (an extra environment variable) let an aligned Kilo registration block every client's maintenance. Setup's refusal checks (client policy, then the inline override comparison of the entry it would write) now live in one reader that setup's alignment check and maintenance share. Maintenance asks it for every owned enabled candidate and reports a refused client with setup's remediation and its real state. * fix(update): keep failed refresh-check reads owned by the supplied maintenance scope clientRefreshRefusal read the client's layers, target file and policy without the caller's resource scope, so a close that failed during those reads threw a cleanup failure no scope retained; maintenance then reported it as text and the scope's close could not retry the descriptor. The refresh reader now takes the scope and passes it to every read. * fix(setup): take the Kilo layer readers' default host from HOST_PLATFORM and the shared record predicate After rebasing on main (#10911, #10588): the new inlineRegistrationOverride and resolveSupportedClients defaults read the running host through the host-platform owner, and the layered launcher merge uses isRecord. * fix(update): keep an unreadable layer's reason in the refresh refusal check readClientRefresh returned undefined for an unreadable or malformed layer, so clientRefreshRefusal reported no refusal and maintenance selected a client whose setup preflight then failed. The reader returns the typed file failure, and the refusal check reports its detail like setup's preflight does. * fix(setup): count REA's entry in KILO_CONFIG_CONTENT as Kilo lifecycle evidence Doctor, update and uninstall inspected a client only when one of its folders existed, so a registration set only by KILO_CONFIG_CONTENT was skipped. A read-only inline layer that sets REA's entry is now evidence on its own. * fix(update): report a client whose only conflict is a discovered provider path as needing setup * fix(update): match discovered settings by the platform's environment identity * fix(update): preflight maintenance with setup's write-target checks and treat discovered inline paths as unknown
751 lines
27 KiB
TypeScript
751 lines
27 KiB
TypeScript
import { mkdir, readFile, rm, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { afterEach, beforeEach, expect, it, vi } from "vitest";
|
|
|
|
import { readEffectiveClientRegistrationConfiguration } from "../../../src/application/ClientConfigurationFiles.js";
|
|
import { currentClientRegistrationCommand } from "../../../src/application/ClientRegistrationIdentity.js";
|
|
import { readClientRegistrationStatuses } from "../../../src/application/ClientRegistrationStatus.js";
|
|
import { registerMcpClients } from "../../../src/application/McpClientRegistration.js";
|
|
import { resolveMcpRegistrationClients } from "../../../src/application/McpRegistrationCatalog.js";
|
|
import {
|
|
resolveSupportedClients,
|
|
supportedClients,
|
|
} from "../../../src/application/SupportedClients.js";
|
|
import { detectClients } from "../../../src/application/SetupHost.js";
|
|
import {
|
|
clientRefreshRefusal,
|
|
configureClientConfiguration,
|
|
inspectClientConfiguration,
|
|
} from "../../../src/application/SetupClientConfiguration.js";
|
|
import {
|
|
runUninstall,
|
|
systemUninstallHost,
|
|
} from "../../../src/application/Uninstall.js";
|
|
import { existingMaintenanceScope } from "../../../src/application/UpdateMaintenance.js";
|
|
import { ArtifactResourceScope } from "../../../src/artifacts/ArtifactResourceScope.js";
|
|
import { PRODUCT_IDENTITY } from "../../../src/identity.js";
|
|
import { clearClientLocationEnvironment } from "../../fixtures/clientEnvironment.js";
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
|
|
const platform = process.platform;
|
|
const command = currentClientRegistrationCommand({ platform });
|
|
|
|
beforeEach(clearClientLocationEnvironment);
|
|
afterEach(() => vi.unstubAllEnvs());
|
|
|
|
const kiloRow = async (home: string, environment: NodeJS.ProcessEnv = {}) =>
|
|
(await resolveSupportedClients(home, platform, environment)).find(
|
|
({ name }) => name === "kilo",
|
|
);
|
|
|
|
/** The user-scope file `rea mcp add --agent kilo` selects from the same layers. */
|
|
const mcpAddTarget = async (home: string, environment: NodeJS.ProcessEnv) => {
|
|
const selected = await resolveMcpRegistrationClients(
|
|
{ agents: ["kilo"], global: true, cwd: home, home, platform, environment },
|
|
new ArtifactResourceScope(),
|
|
);
|
|
if (!selected.ok) throw selected.error;
|
|
return selected.value[0]?.configPath;
|
|
};
|
|
|
|
it("writes Kilo's kilo.json in its config root until another layer exists", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-default-");
|
|
const root = join(home, ".config", "kilo");
|
|
const synchronous = supportedClients(home, platform, {}).find(
|
|
({ name }) => name === "kilo",
|
|
);
|
|
expect(synchronous).toMatchObject({
|
|
configPath: join(root, "kilo.json"),
|
|
markerPath: root,
|
|
});
|
|
expect(synchronous?.configPaths).toContain(join(home, ".kilo", "kilo.jsonc"));
|
|
expect(await kiloRow(home)).toMatchObject({
|
|
configPath: join(root, "kilo.json"),
|
|
configPaths: [join(root, "kilo.json")],
|
|
});
|
|
});
|
|
|
|
it("selects the last present Kilo layer, as rea mcp add does", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-layers-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
await writeFile(join(root, "config.json"), "{}");
|
|
const legacy = join(home, ".kilocode");
|
|
await mkdir(legacy);
|
|
await writeFile(join(legacy, "kilo.jsonc"), "{}");
|
|
const row = await kiloRow(home);
|
|
expect(row).toMatchObject({
|
|
configPath: join(legacy, "kilo.jsonc"),
|
|
configPaths: [join(root, "config.json"), join(legacy, "kilo.jsonc")],
|
|
});
|
|
expect(await mcpAddTarget(home, {})).toBe(row?.configPath);
|
|
// Any folder Kilo reads is evidence that setup should offer it.
|
|
await rm(root, { recursive: true });
|
|
expect(
|
|
(await detectClients(home, platform, {})).map(({ name }) => name),
|
|
).toContain("kilo");
|
|
});
|
|
|
|
it("selects an existing file in a KILO_CONFIG_DIR spelled with a dot segment", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-config-dir-dot-");
|
|
const custom = join(home, "profiles", "kilo");
|
|
await mkdir(custom, { recursive: true });
|
|
await writeFile(join(custom, "kilo.jsonc"), "{}");
|
|
const environment = { KILO_CONFIG_DIR: `${home}/profiles/./kilo` };
|
|
const row = await kiloRow(home, environment);
|
|
expect(row?.configPath).toBe(join(custom, "kilo.jsonc"));
|
|
expect(row?.configPaths).toContain(row?.configPath);
|
|
expect(await mcpAddTarget(home, environment)).toBe(row?.configPath);
|
|
});
|
|
|
|
it("plans kilo.json in an empty KILO_CONFIG_DIR", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-config-dir-");
|
|
const custom = join(home, "custom-kilo");
|
|
const environment = { KILO_CONFIG_DIR: custom };
|
|
const row = await kiloRow(home, environment);
|
|
expect(row?.configPath).toBe(join(custom, "kilo.json"));
|
|
expect(await mcpAddTarget(home, environment)).toBe(row?.configPath);
|
|
});
|
|
|
|
it("loads KILO_CONFIG above Kilo's root files and below its home folders", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-config-file-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
await writeFile(join(root, "kilo.json"), "{}");
|
|
const explicit = join(home, "profiles", "kilo.json");
|
|
const environment = { KILO_CONFIG: explicit };
|
|
// A selected file that does not exist yet is still Kilo's last root layer.
|
|
const planned = await kiloRow(home, environment);
|
|
expect(planned).toMatchObject({
|
|
configPath: explicit,
|
|
configPaths: [join(root, "kilo.json"), explicit],
|
|
});
|
|
expect(await mcpAddTarget(home, environment)).toBe(explicit);
|
|
// A home folder layer loads after it and becomes the write target.
|
|
await mkdir(join(home, ".kilo"));
|
|
await writeFile(join(home, ".kilo", "kilo.jsonc"), "{}");
|
|
const layered = await kiloRow(home, environment);
|
|
expect(layered).toMatchObject({
|
|
configPath: join(home, ".kilo", "kilo.jsonc"),
|
|
configPaths: [
|
|
join(root, "kilo.json"),
|
|
explicit,
|
|
join(home, ".kilo", "kilo.jsonc"),
|
|
],
|
|
});
|
|
expect(await mcpAddTarget(home, environment)).toBe(layered?.configPath);
|
|
});
|
|
|
|
it("loads ~/.kilo after the legacy ~/.kilocode folder", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-home-folders-");
|
|
for (const folder of [".kilocode", ".kilo"]) {
|
|
await mkdir(join(home, folder));
|
|
await writeFile(join(home, folder, "kilo.json"), "{}");
|
|
}
|
|
const row = await kiloRow(home);
|
|
expect(row).toMatchObject({
|
|
configPath: join(home, ".kilo", "kilo.json"),
|
|
configPaths: [
|
|
join(home, ".kilocode", "kilo.json"),
|
|
join(home, ".kilo", "kilo.json"),
|
|
],
|
|
});
|
|
expect(await mcpAddTarget(home, {})).toBe(row?.configPath);
|
|
});
|
|
|
|
it("lets doctor and setup accept REA's entry that only KILO_CONFIG_CONTENT defines", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-inline-only-");
|
|
// Kilo is installed but none of its files exists yet.
|
|
await mkdir(join(home, ".config", "kilo"), { recursive: true });
|
|
const environment = {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { type: "local", command, enabled: true } },
|
|
}),
|
|
};
|
|
const statuses = await readClientRegistrationStatuses(home, command[1], {
|
|
platform,
|
|
environment,
|
|
});
|
|
expect(statuses.find(({ client }) => client === "kilo")).toMatchObject({
|
|
state: "aligned",
|
|
});
|
|
const row = await kiloRow(home, environment);
|
|
if (row === undefined) throw new Error("Kilo row is missing");
|
|
// Writing the same entry beneath it changes nothing Kilo loads, so setup
|
|
// may still record it in the file it manages.
|
|
expect(await inspectClientConfiguration(row, {}, command)).toMatchObject({
|
|
status: "create",
|
|
});
|
|
});
|
|
|
|
it("refuses a relative Kilo configuration path instead of guessing its folder", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-relative-");
|
|
for (const environment of [
|
|
{ KILO_CONFIG: "kilo.json" },
|
|
{ KILO_CONFIG_DIR: "kilo" },
|
|
{ XDG_CONFIG_HOME: "config" },
|
|
]) {
|
|
const row = supportedClients(home, platform, environment).find(
|
|
({ name }) => name === "kilo",
|
|
);
|
|
expect(row?.configPathError).toContain("is relative");
|
|
const resolved = await kiloRow(home, environment);
|
|
expect(resolved?.configPathError).toContain("is relative");
|
|
if (resolved === undefined) throw new Error("Kilo row is missing");
|
|
// Readers such as doctor's provider settings refuse it instead of reading
|
|
// a file relative to REA's own folder.
|
|
expect(
|
|
await readEffectiveClientRegistrationConfiguration(resolved),
|
|
).toMatchObject({ ok: false, error: { kind: "unreadable" } });
|
|
}
|
|
});
|
|
|
|
it.each(["\\kilo.json", "/kilo.json"])(
|
|
"refuses a drive-less Windows KILO_CONFIG %s that follows Kilo's current drive",
|
|
(value) => {
|
|
const row = supportedClients("C:\\Users\\x", "win32", {
|
|
KILO_CONFIG: value,
|
|
}).find(({ name }) => name === "kilo");
|
|
expect(row?.configPathError).toContain("has no drive");
|
|
},
|
|
);
|
|
|
|
it("lets doctor and uninstall act on the Kilo layer rea mcp add wrote", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-lifecycle-");
|
|
const legacy = join(home, ".kilocode");
|
|
await mkdir(legacy);
|
|
const target = join(legacy, "kilo.jsonc");
|
|
await writeFile(target, "{}\n");
|
|
const resources = new ArtifactResourceScope();
|
|
const selected = await resolveMcpRegistrationClients(
|
|
{
|
|
agents: ["kilo"],
|
|
global: true,
|
|
cwd: home,
|
|
home,
|
|
platform,
|
|
environment: {},
|
|
},
|
|
resources,
|
|
);
|
|
if (!selected.ok) throw selected.error;
|
|
const [outcome] = await registerMcpClients(
|
|
selected.value,
|
|
{ command: command[0] ?? "", args: command.slice(1) },
|
|
undefined,
|
|
resources,
|
|
);
|
|
expect(outcome).toMatchObject({ status: "completed" });
|
|
const statuses = await readClientRegistrationStatuses(home, command[1], {
|
|
platform,
|
|
environment: {},
|
|
});
|
|
expect(statuses.find(({ client }) => client === "kilo")).toMatchObject({
|
|
config_path: target,
|
|
state: "aligned",
|
|
});
|
|
const uninstall = await runUninstall(
|
|
false,
|
|
systemUninstallHost(home, undefined, {}, platform),
|
|
);
|
|
expect(uninstall.items).toContainEqual(
|
|
expect.objectContaining({ name: "kilo", status: "removed" }),
|
|
);
|
|
expect(await readFile(target, "utf8")).not.toContain('"rea"');
|
|
});
|
|
|
|
it("reads KILO_CONFIG_CONTENT as Kilo's top read-only layer", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-inline-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
const target = join(root, "kilo.json");
|
|
const registered = JSON.stringify({
|
|
mcp: { rea: { type: "local", command, enabled: true } },
|
|
});
|
|
await writeFile(target, registered);
|
|
const status = async (environment: NodeJS.ProcessEnv) =>
|
|
(
|
|
await readClientRegistrationStatuses(home, command[1], {
|
|
platform,
|
|
environment,
|
|
})
|
|
).find(({ client }) => client === "kilo");
|
|
// An inline layer that leaves REA alone keeps the file registration current.
|
|
const peer = {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({ mcp: { other: { command: ["x"] } } }),
|
|
};
|
|
expect(await status(peer)).toMatchObject({ state: "aligned" });
|
|
const row = await kiloRow(home, peer);
|
|
if (row === undefined) throw new Error("Kilo row is missing");
|
|
expect(await inspectClientConfiguration(row, {}, command)).toMatchObject({
|
|
status: "already_current",
|
|
});
|
|
const remediation = async (environment: NodeJS.ProcessEnv) => {
|
|
const overridden = await kiloRow(home, environment);
|
|
if (overridden === undefined) throw new Error("Kilo row is missing");
|
|
expect(overridden.configPath).toBe(target);
|
|
const inspection = await inspectClientConfiguration(
|
|
overridden,
|
|
{},
|
|
command,
|
|
);
|
|
if (inspection.status !== "invalid")
|
|
throw new Error(`Setup admitted the override: ${inspection.status}`);
|
|
return inspection.remediation;
|
|
};
|
|
// An inline launcher replaces the one setup wrote; its owner is unknown.
|
|
const launcher = {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { command: ["/opt/other/rea", "mcp"] } },
|
|
}),
|
|
};
|
|
// Doctor and setup name the layer the unowned launcher may come from.
|
|
const doctor = await status(launcher);
|
|
expect(doctor?.state).not.toBe("aligned");
|
|
expect(doctor?.remediation).toContain(", KILO_CONFIG_CONTENT has unknown");
|
|
expect(await remediation(launcher)).toContain(
|
|
"has unknown ownership and was not changed",
|
|
);
|
|
expect(await remediation(launcher)).toContain("KILO_CONFIG_CONTENT");
|
|
// An inline setting overrides the registration setup would write.
|
|
const disabled = {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({ mcp: { rea: { enabled: false } } }),
|
|
};
|
|
// Doctor's recovery names the layer setup cannot edit.
|
|
expect(await status(disabled)).toMatchObject({
|
|
state: "stale",
|
|
remediation: expect.stringContaining(
|
|
"KILO_CONFIG_CONTENT also sets the rea entry",
|
|
),
|
|
});
|
|
expect(await remediation(disabled)).toContain(
|
|
"KILO_CONFIG_CONTENT overrides REA's rea registration",
|
|
);
|
|
expect(await readFile(target, "utf8")).toBe(registered);
|
|
});
|
|
|
|
it("refuses a setup write that KILO_CONFIG_CONTENT would override", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-inline-write-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
const target = join(root, "kilo.json");
|
|
const environment = { HOPPER_LAUNCHER_PATH: "/opt/first/hopper" };
|
|
const registered = JSON.stringify({
|
|
mcp: { rea: { type: "local", command, enabled: true, environment } },
|
|
});
|
|
await writeFile(target, registered);
|
|
const row = await kiloRow(home, {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({ mcp: { rea: { environment } } }),
|
|
});
|
|
if (row === undefined) throw new Error("Kilo row is missing");
|
|
// Settings chosen after inspection, such as a newly installed Hopper,
|
|
// would be written beneath the inline value that Kilo keeps loading.
|
|
const result = await configureClientConfiguration(
|
|
row,
|
|
{ HOPPER_LAUNCHER_PATH: "/opt/second/hopper" },
|
|
command,
|
|
);
|
|
expect(result).toMatchObject({
|
|
status: "failed",
|
|
reason: "read_only_override",
|
|
});
|
|
expect(await readFile(target, "utf8")).toBe(registered);
|
|
});
|
|
|
|
it("refuses Kilo's location while KILO_CONFIG_CONTENT cannot be parsed", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-inline-malformed-");
|
|
const row = await kiloRow(home, { KILO_CONFIG_CONTENT: "{" });
|
|
expect(row?.configPathError).toContain(
|
|
"KILO_CONFIG_CONTENT cannot be admitted",
|
|
);
|
|
});
|
|
|
|
it("registers Kilo through its table row in rea mcp add", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-mcp-add-row-");
|
|
const resources = new ArtifactResourceScope();
|
|
const select = (environment: NodeJS.ProcessEnv) =>
|
|
resolveMcpRegistrationClients(
|
|
{
|
|
agents: ["kilo"],
|
|
global: true,
|
|
cwd: home,
|
|
home,
|
|
platform,
|
|
environment,
|
|
},
|
|
resources,
|
|
);
|
|
// A relative path is refused as setup refuses it, not resolved from cwd.
|
|
const relative = await select({ KILO_CONFIG: "kilo.json" });
|
|
expect(relative.ok).toBe(false);
|
|
if (!relative.ok) expect(relative.error.message).toContain("is relative");
|
|
// The row's inline layer still decides what Kilo loads.
|
|
const selected = await select({
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { command: ["/opt/other/rea", "mcp"] } },
|
|
}),
|
|
});
|
|
if (!selected.ok) throw selected.error;
|
|
expect(selected.value[0]?.inlineConfiguration?.origin).toBe(
|
|
"KILO_CONFIG_CONTENT",
|
|
);
|
|
const [outcome] = await registerMcpClients(
|
|
selected.value,
|
|
{ command: command[0] ?? "", args: command.slice(1) },
|
|
undefined,
|
|
resources,
|
|
);
|
|
if (outcome?.status !== "completed") throw new Error("Kilo did not run");
|
|
if (outcome.result.ok) throw new Error("The inline launcher was ignored");
|
|
expect(outcome.result.error.message).toContain(
|
|
"higher-priority configuration overrides",
|
|
);
|
|
});
|
|
|
|
/** Uninstall's Kilo outcome, and every action detail it reported. */
|
|
const uninstallKilo = async (home: string, environment: NodeJS.ProcessEnv) => {
|
|
const result = await runUninstall(
|
|
false,
|
|
systemUninstallHost(home, undefined, environment, platform),
|
|
);
|
|
const kilo = result.items.find(({ name }) => name === "kilo");
|
|
return {
|
|
kilo,
|
|
details: [kilo?.detail, ...(kilo?.actions ?? []).map((a) => a.detail)].join(
|
|
"\n",
|
|
),
|
|
};
|
|
};
|
|
|
|
it("refuses to uninstall when removal would expose a lower Kilo layer's unowned entry", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-uninstall-lower-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
const lower = join(root, "kilo.json");
|
|
const unowned = JSON.stringify({
|
|
mcp: { rea: { type: "local", command: ["/opt/other/rea", "mcp"] } },
|
|
});
|
|
await writeFile(lower, unowned);
|
|
await mkdir(join(home, ".kilo"));
|
|
const upper = join(home, ".kilo", "kilo.json");
|
|
const owned = JSON.stringify({
|
|
mcp: { rea: { type: "local", command, enabled: true } },
|
|
});
|
|
await writeFile(upper, owned);
|
|
const { kilo, details } = await uninstallKilo(home, {});
|
|
expect(kilo?.status).toBe("failed");
|
|
expect(details).toContain("another Kilo configuration layer");
|
|
expect(await readFile(lower, "utf8")).toBe(unowned);
|
|
expect(await readFile(upper, "utf8")).toBe(owned);
|
|
});
|
|
|
|
it("refuses to uninstall while KILO_CONFIG_CONTENT keeps REA's entry in effect", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-uninstall-inline-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
const target = join(root, "kilo.json");
|
|
const owned = JSON.stringify({
|
|
mcp: { rea: { type: "local", command, enabled: true } },
|
|
});
|
|
await writeFile(target, owned);
|
|
const { kilo, details } = await uninstallKilo(home, {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { type: "local", command } },
|
|
}),
|
|
});
|
|
expect(kilo?.status).toBe("failed");
|
|
expect(details).toContain("KILO_CONFIG_CONTENT, which REA does not edit");
|
|
expect(await readFile(target, "utf8")).toBe(owned);
|
|
});
|
|
|
|
it("reports REA's Kilo entry that only KILO_CONFIG_CONTENT sets instead of calling uninstall complete", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-uninstall-inline-only-");
|
|
// Kilo is installed, and both files exist without REA's entry.
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
const other = JSON.stringify({ mcp: { other: { command: ["x"] } } });
|
|
await writeFile(join(root, "kilo.json"), other);
|
|
await mkdir(join(home, ".kilo"));
|
|
await writeFile(join(home, ".kilo", "kilo.json"), other);
|
|
const { kilo, details } = await uninstallKilo(home, {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { type: "local", command, enabled: true } },
|
|
}),
|
|
});
|
|
expect(kilo?.status).toBe("failed");
|
|
expect(details).toContain("Remove the rea entry from KILO_CONFIG_CONTENT");
|
|
// One report although uninstall visits each Kilo file.
|
|
expect(details.match(/KILO_CONFIG_CONTENT sets/g)).toHaveLength(1);
|
|
expect(await readFile(join(root, "kilo.json"), "utf8")).toBe(other);
|
|
});
|
|
|
|
it("leaves a stale Kilo registration KILO_CONFIG_CONTENT pins out of update maintenance", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-update-inline-");
|
|
await mkdir(join(home, ".config", "kilo"), { recursive: true });
|
|
const environment = {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: {
|
|
rea: {
|
|
type: "local",
|
|
command: [
|
|
"npx",
|
|
"-y",
|
|
`${PRODUCT_IDENTITY.packageName}@3.2.0`,
|
|
"mcp",
|
|
],
|
|
enabled: true,
|
|
},
|
|
},
|
|
}),
|
|
};
|
|
const scope = await existingMaintenanceScope(
|
|
home,
|
|
command[1] ?? "",
|
|
environment,
|
|
);
|
|
expect(scope.clients).not.toContain("kilo");
|
|
expect(scope.unresolved).toEqual([
|
|
expect.objectContaining({
|
|
client: "kilo",
|
|
state: "stale",
|
|
remediation: expect.stringContaining(
|
|
"KILO_CONFIG_CONTENT overrides REA's rea registration",
|
|
),
|
|
}),
|
|
]);
|
|
});
|
|
|
|
it("maintains a stale Kilo registration whose KILO_CONFIG_CONTENT entry setup's refresh keeps", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-update-inline-kept-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
await writeFile(
|
|
join(root, "kilo.json"),
|
|
JSON.stringify({
|
|
mcp: {
|
|
rea: {
|
|
type: "local",
|
|
command: [
|
|
"npx",
|
|
"-y",
|
|
`${PRODUCT_IDENTITY.packageName}@3.2.0`,
|
|
"mcp",
|
|
],
|
|
enabled: true,
|
|
},
|
|
},
|
|
}),
|
|
);
|
|
const scope = await existingMaintenanceScope(home, command[1] ?? "", {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({ mcp: { rea: { enabled: true } } }),
|
|
});
|
|
expect(scope.clients).toContain("kilo");
|
|
expect(scope.unresolved).toBeUndefined();
|
|
});
|
|
|
|
it("leaves an aligned Kilo registration out of update maintenance when KILO_CONFIG_CONTENT adds what setup would not write", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-update-inline-aligned-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
await writeFile(
|
|
join(root, "kilo.json"),
|
|
JSON.stringify({ mcp: { rea: { type: "local", command, enabled: true } } }),
|
|
);
|
|
const environment = {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { environment: { FOO: "bar" } } },
|
|
}),
|
|
};
|
|
const [status] = await readClientRegistrationStatuses(
|
|
home,
|
|
command[1] ?? "",
|
|
{ environment, selectedClientIds: ["kilo"] },
|
|
);
|
|
expect(status).toMatchObject({ client: "kilo", state: "aligned" });
|
|
const scope = await existingMaintenanceScope(
|
|
home,
|
|
command[1] ?? "",
|
|
environment,
|
|
);
|
|
expect(scope.clients).not.toContain("kilo");
|
|
expect(scope.unresolved).toEqual([
|
|
expect.objectContaining({
|
|
client: "kilo",
|
|
state: "aligned",
|
|
remediation: expect.stringContaining(
|
|
"KILO_CONFIG_CONTENT overrides REA's rea registration",
|
|
),
|
|
}),
|
|
]);
|
|
});
|
|
|
|
it("reports a Kilo registration whose KILO_CONFIG_CONTENT differs only in a discovered provider path as needing setup", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-update-discovered-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
await writeFile(
|
|
join(root, "kilo.json"),
|
|
JSON.stringify({ mcp: { rea: { type: "local", command, enabled: true } } }),
|
|
);
|
|
const inline = (environment: Record<string, string>) =>
|
|
JSON.stringify({ mcp: { rea: { environment } } });
|
|
const hopper = "/Applications/Hopper Disassembler.app/Contents/MacOS/hopper";
|
|
const scope = await existingMaintenanceScope(home, command[1] ?? "", {
|
|
KILO_CONFIG_CONTENT: inline({ HOPPER_LAUNCHER_PATH: hopper }),
|
|
});
|
|
// Setup may discover this launcher and write the same value, so update
|
|
// can neither maintain nor refuse the client: its alignment is unknown.
|
|
expect(scope.clients).not.toContain("kilo");
|
|
expect(scope.unresolved).toEqual([
|
|
expect.objectContaining({
|
|
client: "kilo",
|
|
state: "unknown",
|
|
remediation: expect.stringMatching(
|
|
/KILO_CONFIG_CONTENT sets HOPPER_LAUNCHER_PATH .*Run rea setup to check and refresh it\.$/,
|
|
),
|
|
}),
|
|
]);
|
|
|
|
// An explicit selection or another setting is a conflict update can prove.
|
|
for (const environment of [
|
|
{
|
|
HOPPER_LAUNCHER_PATH: "/opt/hopper",
|
|
KILO_CONFIG_CONTENT: inline({ HOPPER_LAUNCHER_PATH: hopper }),
|
|
},
|
|
{
|
|
KILO_CONFIG_CONTENT: inline({ HOPPER_LAUNCHER_PATH: hopper, FOO: "bar" }),
|
|
},
|
|
]) {
|
|
const refused = await existingMaintenanceScope(
|
|
home,
|
|
command[1] ?? "",
|
|
environment,
|
|
);
|
|
expect(refused.unresolved).toEqual([
|
|
expect.objectContaining({
|
|
client: "kilo",
|
|
state: "aligned",
|
|
remediation: expect.stringContaining(
|
|
"KILO_CONFIG_CONTENT overrides REA's rea registration",
|
|
),
|
|
}),
|
|
]);
|
|
}
|
|
});
|
|
|
|
it("reports a Kilo registration whose matching KILO_CONFIG_CONTENT sets a discovered provider path as needing setup", async () => {
|
|
const home = await createTestTempDirectory(
|
|
"rea-kilo-update-discovered-match-",
|
|
);
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
const hopper = "/opt/hopper/hopper";
|
|
await writeFile(
|
|
join(root, "kilo.json"),
|
|
JSON.stringify({
|
|
mcp: {
|
|
rea: {
|
|
type: "local",
|
|
command,
|
|
enabled: true,
|
|
environment: { HOPPER_LAUNCHER_PATH: hopper },
|
|
},
|
|
},
|
|
}),
|
|
);
|
|
const scope = await existingMaintenanceScope(home, command[1] ?? "", {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { environment: { HOPPER_LAUNCHER_PATH: hopper } } },
|
|
}),
|
|
});
|
|
// The entry matches today, but setup may discover another launcher that
|
|
// the inline layer would then override.
|
|
expect(scope.clients).not.toContain("kilo");
|
|
expect(scope.unresolved).toEqual([
|
|
expect.objectContaining({
|
|
client: "kilo",
|
|
state: "unknown",
|
|
remediation: expect.stringContaining(
|
|
"KILO_CONFIG_CONTENT sets HOPPER_LAUNCHER_PATH",
|
|
),
|
|
}),
|
|
]);
|
|
});
|
|
|
|
it("leaves a Kilo file whose own launcher REA does not own out of update maintenance", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-update-foreign-file-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
await writeFile(
|
|
join(root, "kilo.json"),
|
|
JSON.stringify({
|
|
mcp: {
|
|
rea: { type: "local", command: ["/opt/other/server"], enabled: true },
|
|
},
|
|
}),
|
|
);
|
|
const scope = await existingMaintenanceScope(home, command[1] ?? "", {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({ mcp: { rea: { command } } }),
|
|
});
|
|
// The effective entry is REA's, but setup refuses to replace the file's
|
|
// foreign launcher, so maintenance must not select Kilo.
|
|
expect(scope.clients).not.toContain("kilo");
|
|
expect(scope.unresolved).toEqual([
|
|
expect.objectContaining({ client: "kilo" }),
|
|
]);
|
|
});
|
|
|
|
it("matches a discovered setting by Windows environment identity in KILO_CONFIG_CONTENT", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-update-discovered-win-");
|
|
const root = join(home, ".config", "kilo");
|
|
await mkdir(root, { recursive: true });
|
|
await writeFile(
|
|
join(root, "kilo.json"),
|
|
JSON.stringify({ mcp: { rea: { type: "local", command, enabled: true } } }),
|
|
);
|
|
const environment = {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { environment: { Java_Home: "/opt/java" } } },
|
|
}),
|
|
};
|
|
const kilo = await kiloRow(home, environment);
|
|
if (kilo === undefined) throw new Error("Kilo row missing");
|
|
// `Java_Home` is the JAVA_HOME setup discovers on Windows, and a distinct
|
|
// name elsewhere.
|
|
expect(
|
|
await clientRefreshRefusal(kilo, {}, command, {
|
|
platform: "win32",
|
|
currentCommandPath: command[1] ?? "",
|
|
}),
|
|
).toMatchObject({
|
|
alignment: "unknown",
|
|
remediation: expect.stringContaining("KILO_CONFIG_CONTENT sets JAVA_HOME"),
|
|
});
|
|
expect(
|
|
await clientRefreshRefusal(kilo, {}, command, {
|
|
platform: "linux",
|
|
currentCommandPath: command[1] ?? "",
|
|
}),
|
|
).toMatchObject({
|
|
alignment: "refused",
|
|
});
|
|
});
|
|
|
|
it("inspects REA's Kilo entry that only KILO_CONFIG_CONTENT sets when no Kilo folder exists", async () => {
|
|
const home = await createTestTempDirectory("rea-kilo-inline-evidence-");
|
|
const statuses = await readClientRegistrationStatuses(
|
|
home,
|
|
command[1] ?? "",
|
|
{
|
|
environment: {
|
|
KILO_CONFIG_CONTENT: JSON.stringify({
|
|
mcp: { rea: { type: "local", command, enabled: true } },
|
|
}),
|
|
},
|
|
},
|
|
);
|
|
expect(statuses).toContainEqual(
|
|
expect.objectContaining({ client: "kilo", state: "aligned" }),
|
|
);
|
|
});
|