Files
reverse-engineering-anything/tests/boundary/javascriptSemanticTraceEvidence.test.ts
T
morluto 1f24b3fa57 feat(evidence)!: name the Evidence subject by its target identity (format revision 2) (#11416)
* feat(evidence)!: name the Evidence subject by its target identity (format revision 2)

The Evidence subject carries subject.identity (kind, sha256, format,
architecture, selection) and the Evidence ID commits to it, so raw/DOL
entry points and ESP flash offsets of the same bytes are different
subjects. Every record declares evidence_format: 2; revision 1 bundles,
standalone records and snapshots are refused with the recreate guidance.
binaryTargetIdentity is the one projection of an open target, used by
Evidence and snapshot comparison.

BREAKING CHANGE: Evidence format revision 2. Evidence IDs commit to the
subject's target identity (subject.identity, including the raw/DOL entry
point or ESP flash offsets), and every record declares evidence_format: 2.
Evidence bundles, records and analysis snapshots from earlier releases are
refused; recreate the observations with this release.

* refactor(analysis-view): read parent subjects through the Evidence identity accessors (#11423)

Analysis views compare their parent's file identity (evidenceFileTarget)
and take path and digest from evidenceSubjectTarget instead of reading
the subject's digest, format and architecture members, which duplicate
subject.identity until they are removed. A counted guard
(evidence-subject-declaration-read) keeps new direct reads out and
records the 20 remaining files.

* fix(evidence): carry format refusals through Evidence readers and bind target selections

- safeParseEvidence/safeParseImmutableEvidence return the format refusal as
  an expected failure; every consumer maps it to the one integrity refusal
  with the recreate guidance. An unmarked object is an earlier record only
  when it has every member records have always carried.
- ArtifactProvider inventory roots and provider subjects that name the
  target's own bytes carry the target's selection (ESP flash offsets).
- Snapshot rows bind only Evidence whose identity, selection included,
  matches the snapshot target.
- Entry-point selections use the raw-binary entry point form.

* fix(evidence): refuse unauthenticated or earlier-format records instead of reading them as absent

- recognizeEvidence (evidenceValidation) replaces tryParseEvidence: input
  without an evidence_id is not Evidence (ok(undefined)); a record that names
  one but fails authentication or is from another format revision is an
  EvidenceIntegrityError carrying the recreate guidance, never undefined.
- Direct analysis retains that refusal as a secondary failure instead of
  silently skipping source capture; cleanup projection, source-closure
  annotation and the flutter, debugger and release-exposure recoveries use
  the same owner (the last three previously read the unauthenticated schema).
- A desktop capture.json from an earlier format is refused with the recreate
  guidance instead of "not desktop application capture Evidence".

* fix(evidence): advertise revision 2 ledger examples and rank delivery omissions by serialized size

- The obligation ledger and reconstruction coverage examples named
  evidence_format 1, which revision 2 refuses; they now use
  EVIDENCE_FORMAT_REVISION.
- MCP delivery chose which unretained recovery to omit by a parsed-storage
  lower bound clipped at the response budget. Once revision 2 subjects made
  the source record's estimate cross the budget, both candidates tied at the
  clip and the smaller source was omitted ahead of the larger completed
  observation. Candidates are now ranked by serialized size, which is what
  the budget counts.

* refactor(native): compare function snapshots by their Evidence target identity (#11450)

Function snapshots carry the subject's file target identity instead of the
duplicated subject declaration. Call paths and function comparisons compare
targets through sameTargetIdentity, so the same bytes opened at a different
raw entry point or ESP flash offset no longer count as one coordinate space:
build_call_path refuses the mix, and compare_functions no longer matches
entries by address across selections. Structural candidates and native
function matching read the architecture and digest through
evidenceFileTarget.

Refs #11417

* refactor(artifacts): compare artifact and WASM summaries by their Evidence target identity (#11461)

Artifact comparison authenticates a summary against its retained inventory
through sameTargetIdentity and rebinds the alias with the whole target,
selection included, so a flash-selected inventory summary taken under an
alias path is no longer refused. WASM comparison, the analysis view
artifact projection and the inventory root check read the digest, format
and display path through the Evidence identity accessors.

Refs #11417

* refactor(evidence): read record subjects through the identity accessors in JS, managed, ledger and bundle readers (#11470)

JavaScript application graphs, runtime reconciliation, managed inspection
and native verification sources, the record summary filter, the ledger's
residual-unknown target and bundle scope selection read the subject digest,
format and display path through evidenceFileTarget and
evidenceSubjectDisplay. No comparison changes: each reader matches one
record's facts against its own payload or a caller filter.

Refs #11417

* refactor(evidence)!: name the Evidence subject only by its target identity (#11497)

* refactor(evidence)!: name the Evidence subject only by its target identity

The subject keeps `identity` and the display facts `name` and `local_path`.
The duplicated `digest`, `format` and `architecture` members are removed; the
format-owned declaration now validates the identity itself. Readers the type
checker found move to the owner accessors; untyped reads in verify scripts,
the efficiency harness and test matchers move to `subject.identity`. The
`evidence-subject-declaration-read` text guard and its baseline are deleted.

Fixes #11473
Refs #11417

BREAKING CHANGE: the Evidence subject no longer has `digest`, `format` or
`architecture`; read `subject.identity.sha256`, `subject.identity.format` and
`subject.identity.architecture`. A record that still carries them is refused.

* test(evidence): give the Flutter verifier fixture the identity subject and check the DOL declaration without the ID

* test(evidence): drop the removed subject members from the declaration matrix and tamper fixtures

* feat(evidence)!: give every Evidence record an explicit subject identity (#11536)

* feat(evidence)!: give every Evidence record an explicit subject identity

A producer that cannot name a file passes an `unknown` target identity
with a closed reason (derived-from-linked-evidence, not-observed,
unsupported-subject) instead of no subject. The subject is non-null;
unknown subjects have no display facts. The generic missing-subject
limitation and `subjectUnavailableReason` are removed; producer-specific
explanations are ordinary limitations. Comparison identity requires the
derived unknown, and null-subject consumers ask the owner accessors.

Refs #11417

BREAKING CHANGE: every Evidence record has a subject. A record without a
file target names `subject.identity` `{ "kind": "unknown", "reason": … }`
with `name` and `local_path` null, instead of `subject: null` and the
limitation "Artifact identity is unavailable for this observation.".
Their Evidence IDs change.

* fix(evidence): name explicit unknown subjects in JavaScript callers and keep a managed graph's file subject

The verification scripts are not type-checked, so five createEvidence
callers still passed undefined (or a missing first target) after the subject
became required. They now pass unknownTarget("not-observed").

A managed application graph chose the first present input subject. Every
subject is now present, so an unknown artifact subject hid a file subject on
the member or boundary Evidence. The graph now takes the first input subject
that names a file.

* test(evidence): assert the subject kind instead of a presence the type now guarantees

Every Evidence record has a subject after this change, so test guards and
assertions that checked it for null always passed. Each now checks that the
fixture subject names a file, or is removed where a later fileIdentity,
fileSubjectTarget or fileSubjectDisplay call already requires that. Non-null
assertions on Evidence subjects are removed; analysis-view inputs, whose
subject is optional, keep an undefined check.

* test(evidence): expect the Evidence subject format under its identity

Two boundary tests still matched subject.format, which slice 2e moved into
subject.identity. toMatchObject is not type-checked against the Evidence
shape, so they failed only when run (the signature test on macOS).
2026-11-16 06:28:01 +08:00

472 lines
15 KiB
TypeScript

import { fileSubjectTarget } from "../fixtures/evidenceSubject.js";
import { canonicalOutputSchema } from "../fixtures/canonicalOutputSchema.js";
import { mkdir, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { afterAll, expect, it } from "vitest";
import { Ajv2020 } from "ajv/dist/2020.js";
import { createApplicationMcpHarness } from "../fixtures/applicationMcpHarness.js";
import { parseMcpToolError } from "../fixtures/mcpToolError.js";
import { createTestTempDirectory } from "../fixtures/temporaryDirectory.js";
import { closeCliResources, createCli } from "../../src/cli.js";
import { createEvidence, parseEvidence } from "../../src/domain/evidence.js";
import type { JsonValue } from "../../src/domain/jsonValue.js";
import { analysisCliErrorEnvelopeSchema } from "../../src/contracts/errorSchemas.js";
import { toolContract } from "../../src/contracts/toolContracts.js";
import { javascriptApplicationAnalysisResultSchema } from "../../src/domain/javascript/javascriptApplicationAnalysis.js";
import { javaScriptSemanticTraceResultSchema } from "../../src/domain/javascript/javascriptSemanticTraceSchemas.js";
const SEMANTIC_GRAPH_ID = `jsrg_${"0".repeat(64)}`;
// In-process serve keeps the CLI worker for this file. Stop it before the
// worker process exits so the private runtime root is not left behind.
afterAll(closeCliResources);
it("reports invalid nested semantic graph Evidence as caller input through CLI and SDK MCP", async () => {
const root = await createTestTempDirectory("rea-semantic-trace-input-");
await mkdir(join(root, "src"));
await writeFile(
join(root, "src", "main.js"),
"export function parse(value) { return JSON.parse(value); }\n",
);
const cli = createCli({});
const analyzed = await serveCli(cli, [
"analyze-javascript-application",
root,
"--json",
]);
expect(analyzed.exitCode).toBe(0);
const sourceEvidence = parseEvidence(JSON.parse(analyzed.stdout));
const normalizedResult = structuredClone(sourceEvidence.normalized_result);
if (!isJsonObject(normalizedResult))
throw new Error("CLI analysis result must be an object");
const semanticGraph = normalizedResult.semantic_graph;
if (!isJsonObject(semanticGraph))
throw new Error("CLI analysis must include a semantic graph");
const firstNode = semanticGraph.nodes;
if (!Array.isArray(firstNode) || !isJsonObject(firstNode[0]))
throw new Error("CLI semantic graph must include a node");
const seedNodeId = firstNode[0].node_id;
if (typeof seedNodeId !== "string")
throw new Error("CLI semantic graph node must have an identifier");
semanticGraph.graph_id = SEMANTIC_GRAPH_ID;
const subject = sourceEvidence.subject;
const malformedEvidence = createEvidence(
fileSubjectTarget(subject),
sourceEvidence.provider,
{
predicateType: sourceEvidence.predicate_type,
operation: sourceEvidence.operation,
parameters: sourceEvidence.parameters,
result: normalizedResult,
confidence: sourceEvidence.confidence,
authority: sourceEvidence.authority,
},
);
expect(malformedEvidence.evidence_id).not.toBe(sourceEvidence.evidence_id);
const arguments_ = {
application: malformedEvidence,
query: {
seed: { kind: "semantic-node", node_id: seedNodeId },
direction: "backward-provenance",
},
};
const cliTrace = await serveCli(cli, [
"trace-javascript-semantics",
JSON.stringify(arguments_),
"--json",
]);
const cliEnvelope = analysisCliErrorEnvelopeSchema.parse(
JSON.parse(cliTrace.stdout),
);
const { error: _label, ...cliError } = cliEnvelope;
expect(cliError).toMatchObject({
code: "invalid_request",
category: "invalid_input",
details: {
issues: [
{
path: [
"application",
"normalized_result",
"semantic_graph",
"graph_id",
],
reason: "invalid_value",
},
],
},
});
const harness = await createApplicationMcpHarness();
try {
await assertSuccessfulTraceParity(
cli,
harness,
sourceEvidence,
arguments_.query,
);
const mcpTrace = await harness.client.callTool({
name: "trace_javascript_semantics",
arguments: arguments_,
});
const { error: mcpError } = parseMcpToolError(mcpTrace);
expect(mcpError).toEqual(cliError);
} finally {
await harness.close();
}
});
it("excludes local exports from writes-only traces through CLI and MCP", async () => {
const root = await createTestTempDirectory("rea-semantic-export-trace-");
await mkdir(join(root, "src"));
await writeFile(
join(root, "src", "main.js"),
[
"const answer = 42;",
"export { answer, answer as result };",
"let mutable = 0;",
"mutable = 1;",
"export { mutable };",
].join("\n"),
);
const cli = createCli({});
const analyzed = await serveCli(cli, [
"analyze-javascript-application",
root,
"--json",
]);
expect(analyzed.exitCode).toBe(0);
const application = parseEvidence(JSON.parse(analyzed.stdout));
const analysisResult = javascriptApplicationAnalysisResultSchema.parse(
application.normalized_result,
);
const bindingId = (label: string): string => {
const binding = analysisResult.semantic_graph.nodes.find(
(node) => node.kind === "binding" && node.label === label,
);
if (binding === undefined)
throw new Error(`CLI semantic graph must include the ${label} binding`);
return binding.node_id;
};
const harness = await createApplicationMcpHarness();
try {
const exportTrace = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "semantic-node", node_id: bindingId("answer") },
direction: "backward-provenance",
allowed_relations: ["writes"],
},
);
expect(exportTrace.summary).toMatchObject({
total_seed_matches: 1,
traversed_relations: 0,
});
expect(exportTrace.relations).toEqual([]);
const assignmentTrace = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "semantic-node", node_id: bindingId("mutable") },
direction: "backward-provenance",
allowed_relations: ["writes"],
},
);
expect(assignmentTrace.summary).toMatchObject({
total_seed_matches: 1,
traversed_relations: 1,
});
expect(assignmentTrace.relations).toHaveLength(1);
} finally {
await harness.close();
}
});
it("traces exact empty property names through CLI and MCP", async () => {
const root = await createTestTempDirectory("rea-semantic-empty-property-");
await writeFile(
join(root, "main.js"),
"const routes = {'': 'HOME', x: 'NAMED'}; const root = routes['']; const named = routes.x;\n",
);
const cli = createCli({});
const analyzed = await serveCli(cli, [
"analyze-javascript-application",
root,
"--json",
]);
expect(analyzed.exitCode).toBe(0);
const application = parseEvidence(JSON.parse(analyzed.stdout));
const { semantic_graph: graph } =
javascriptApplicationAnalysisResultSchema.parse(
application.normalized_result,
);
const harness = await createApplicationMcpHarness();
try {
for (const name of ["", "x"]) {
const slots = graph.nodes.filter(
(node) =>
node.kind === "property-slot" && node.properties.name === name,
);
expect(slots).toHaveLength(1);
const slot = slots[0];
if (slot === undefined)
throw new Error("Expected retained property slot");
const exact = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "semantic-node", node_id: slot.node_id },
direction: "forward-influence",
},
);
const selected = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "property", name },
direction: "forward-influence",
},
);
expect(selected.seed_node_ids).toEqual([slot.node_id]);
expect(selected.nodes).toEqual(exact.nodes);
expect(selected.relations).toEqual(exact.relations);
expect(selected.nodes).toHaveLength(2);
expect(selected.relations).toHaveLength(1);
expect(selected.coverage.status).toBe("partial");
}
const absent = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "property", name: "missing" },
direction: "forward-influence",
},
);
expect(absent.seed_node_ids).toEqual([]);
expect(absent.nodes).toEqual([]);
expect(absent.relations).toEqual([]);
expect(absent.coverage.status).toBe("partial");
} finally {
await harness.close();
}
});
it("traces transformed operands through CLI and advertised MCP output", async () => {
const root = await createTestTempDirectory("rea-semantic-expression-trace-");
await writeFile(
join(root, "main.js"),
'const base = "https://example.test"; const url = base + "/x"; fetch(url); consume("only-direct"); const nested = "nested-token"; const box = { url: wrap(nested + "/x") };',
);
const cli = createCli({});
const analyzed = await serveCli(cli, [
"analyze-javascript-application",
root,
"--json",
]);
expect(analyzed.exitCode, analyzed.stdout).toBe(0);
const application = parseEvidence(JSON.parse(analyzed.stdout));
const harness = await createApplicationMcpHarness();
try {
const result = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "literal", value: "https://example.test" },
direction: "forward-influence",
},
);
expect(result.nodes.map((node) => node.label)).toContain("argument 0");
expect(
result.relations.some((edge) => edge.relation === "influences"),
).toBe(true);
const direct = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "literal", value: "only-direct" },
direction: "forward-influence",
},
);
expect(direct.summary.total_seed_matches).toBe(1);
expect(
direct.nodes.find((node) => node.node_id === direct.seed_node_ids[0])
?.label,
).toBe("argument 0");
const nested = await assertSuccessfulTraceParity(
cli,
harness,
application,
{
seed: { kind: "literal", value: "nested-token" },
direction: "forward-influence",
},
);
expect(nested.status).not.toBe("found");
expect(nested.unknowns).toContainEqual(
expect.objectContaining({
reason: "dynamic-call",
family: "data-flow",
relation_kinds: ["influences"],
}),
);
} finally {
await harness.close();
}
});
it("reports offered semantic capacity when a large template exceeds it", async () => {
const root = await createTestTempDirectory("rea-semantic-expression-budget-");
const expressions = Array.from({ length: 500 }, () => "${base}").join("");
await writeFile(
join(root, "main.js"),
`const base = "token"; const value = \`${expressions}\`;`,
);
const analyzed = await serveCli(createCli({}), [
"analyze-javascript-application",
root,
"--max-semantic-nodes-per-file",
"4",
"--json",
]);
expect(analyzed.exitCode, analyzed.stdout).toBe(0);
const application = parseEvidence(JSON.parse(analyzed.stdout));
const result = javascriptApplicationAnalysisResultSchema.parse(
application.normalized_result,
);
expect(result.semantic_graph.coverage.truncated).toBe(true);
expect(result.semantic_graph.coverage.status).toBe("partial");
});
const assertSuccessfulTraceParity = async (
cli: ReturnType<typeof createCli>,
harness: Awaited<ReturnType<typeof createApplicationMcpHarness>>,
application: ReturnType<typeof parseEvidence>,
query: {
readonly seed: unknown;
readonly direction: string;
readonly allowed_relations?: readonly string[];
},
): Promise<ReturnType<typeof javaScriptSemanticTraceResultSchema.parse>> => {
const arguments_ = { application, query };
const cliResponse = await serveCli(cli, [
"trace-javascript-semantics",
JSON.stringify(arguments_),
"--json",
]);
expect(cliResponse.exitCode, cliResponse.stdout).toBe(0);
expect(JSON.parse(cliResponse.stdout), cliResponse.stdout).not.toHaveProperty(
"error",
);
const cliEvidence = parseEvidence(JSON.parse(cliResponse.stdout));
const cliResult = javaScriptSemanticTraceResultSchema.parse(
cliEvidence.normalized_result,
);
expect(cliEvidence.parameters.query).toMatchObject({
seed: query.seed,
direction: query.direction,
include_ambiguous_dynamic_edges: false,
expected: null,
});
if (query.allowed_relations === undefined)
expect(cliEvidence.parameters.query).not.toHaveProperty(
"allowed_relations",
);
else
expect(cliEvidence.parameters.query).toHaveProperty(
"allowed_relations",
query.allowed_relations,
);
assertTraceContextsResolve(cliResult);
const mcpResponse = await harness.client.callTool({
name: "trace_javascript_semantics",
arguments: arguments_,
});
expect(mcpResponse.isError).not.toBe(true);
const { tools } = await harness.client.listTools();
const advertised = tools.find(
({ name }) => name === "trace_javascript_semantics",
);
if (advertised === undefined)
throw new Error("Semantic trace SDK output schema is missing");
const ajv = new Ajv2020({
strict: false,
validateFormats: false,
inlineRefs: false,
code: { optimize: false },
});
const outputSchema: Record<string, unknown> = canonicalOutputSchema(
advertised.name,
);
expect(ajv.validateSchema(outputSchema)).toBe(true);
expect(ajv.validate(outputSchema, mcpResponse.structuredContent)).toBe(true);
const mcpEvidence = toolContract(
"trace_javascript_semantics",
).outputSchema.parse(mcpResponse.structuredContent);
expect(mcpEvidence.normalized_result).toEqual(cliResult);
expect(mcpEvidence).toEqual(cliEvidence);
return cliResult;
};
const assertTraceContextsResolve = (
result: ReturnType<typeof javaScriptSemanticTraceResultSchema.parse>,
): void => {
const contexts = new Map(
result.evidence_contexts.map((context) => [context.context_id, context]),
);
const references = [
...result.nodes.map(({ evidence }) => evidence),
...result.relations.map(({ evidence }) => evidence),
...result.unknowns.map(({ evidence }) => evidence),
];
const referencedIds = new Set<string>();
for (const reference of references) {
const context = contexts.get(reference.context_id);
expect(context, reference.context_id).toBeDefined();
if (context === undefined) continue;
referencedIds.add(reference.context_id);
}
expect([...referencedIds].toSorted()).toEqual(
[...contexts.keys()].toSorted(),
);
};
const serveCli = async (
cli: ReturnType<typeof createCli>,
arguments_: readonly string[],
): Promise<{ readonly stdout: string; readonly exitCode: number }> => {
let stdout = "";
let exitCode = 0;
await cli.serve([...arguments_], {
env: {},
exit: (code) => {
exitCode = code;
},
stdout: (text) => {
stdout += text;
},
});
return { stdout, exitCode };
};
const isJsonObject = (value: unknown): value is Record<string, JsonValue> =>
typeof value === "object" && value !== null && !Array.isArray(value);