mirror of
https://github.com/morluto/rea.git
synced 2026-11-03 05:16:16 +00:00
Edgar ArakelyanandClaude Fable 5.1
136d073fa0
Addresses the follow-on finding on the signal latch: the HTTP entry now owns its exit status, so a 0 returned by startup after a recorded signal keeps the signal's 130 or 143 while a real failure still wins; a process test sends the signal as the listening line appears. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
55 lines
2.0 KiB
TypeScript
55 lines
2.0 KiB
TypeScript
import { once } from "node:events";
|
|
import { describe, expect } from "vitest";
|
|
|
|
import { MCP_SHUTDOWN_FAILED } from "../../../src/main/messages.js";
|
|
import { rawHttpRequest } from "../../support/http/rawRequest.js";
|
|
import { startMcpHttpProcess } from "../../support/mcp/streamableHttpProcess.js";
|
|
import { processTest } from "../../support/process/processFixture.js";
|
|
|
|
const SHUTDOWN_TIMEOUT_MS = 90_000;
|
|
|
|
const shutdownSignals: readonly (readonly [NodeJS.Signals, number])[] =
|
|
process.platform === "win32"
|
|
? [["SIGINT", 130]]
|
|
: [
|
|
["SIGTERM", 143],
|
|
["SIGINT", 130],
|
|
];
|
|
|
|
describe("rea mcp --http shutdown", () => {
|
|
for (const [signal, status] of shutdownSignals)
|
|
processTest(
|
|
`releases the listener and exits ${String(status)} on ${signal}`,
|
|
async ({ processes }) => {
|
|
const started = await startMcpHttpProcess(processes);
|
|
// The live transport refuses a GET that does not accept an event stream.
|
|
const before = await rawHttpRequest(started.url);
|
|
expect(before.status).toBe(406);
|
|
started.child.kill(signal);
|
|
const [code, signalCode] = await once(started.child, "close");
|
|
expect(code).toBe(status);
|
|
expect(signalCode).toBeNull();
|
|
expect(started.stderr()).not.toContain(MCP_SHUTDOWN_FAILED);
|
|
await expect(rawHttpRequest(started.url)).rejects.toMatchObject({
|
|
code: "ECONNREFUSED",
|
|
});
|
|
},
|
|
SHUTDOWN_TIMEOUT_MS,
|
|
);
|
|
|
|
processTest(
|
|
"exits with the signal status when the signal lands as startup completes",
|
|
async ({ processes }) => {
|
|
const started = await startMcpHttpProcess(processes);
|
|
// No request first: the signal arrives at the edge between startup and the lifecycle owner.
|
|
const [signal, status] = shutdownSignals[0]!;
|
|
started.child.kill(signal);
|
|
const [code, signalCode] = await once(started.child, "close");
|
|
expect(code).toBe(status);
|
|
expect(signalCode).toBeNull();
|
|
expect(started.stderr()).not.toContain(MCP_SHUTDOWN_FAILED);
|
|
},
|
|
SHUTDOWN_TIMEOUT_MS,
|
|
);
|
|
});
|