mirror of
https://github.com/morluto/rea.git
synced 2026-11-12 01:41:21 +00:00
* fix(desktop): keep an empty env value empty An empty assignment is not a path. Resolving it named the working directory and rewrote the value when that directory's spelling moved. * fix(desktop): keep a run's font on the run, not the frame's text A formatting attribute such as Scribus FONT is not the document's words. Joining it across runs made a frame-wide text check of ItalicBold that failed when a run was split. The font stays a value check on its own run. * fix(desktop): do not pair JSON records by a selector-shaped field A field named @record_id matched the id suffix and became [@record_id=one], which reads an XML attribute. Records paired while their pointers matched nothing. Names that start with @ or > are not id fields. * fix(desktop): count a save-numbered id once when pairing members xml:id and draw:id values such as id123456 were both generated and numbered, so the same selector was counted twice and refused. A text edit of two elements keyed only by those ids now keeps its check. * fix(desktop): count members of root JSON arrays * fix(desktop): preserve selected state directory aliases * docs(desktop): explain tool and skill refresh prerequisites * fix(desktop): align nested state selections with aliases * fix(desktop): check build runtime export capability * fix(desktop): provide complete runtime repack command * fix(desktop): retain runtime probe failures * test(desktop): identify capture independently of schema preflight * fix(desktop): preserve document URLs and value formats * fix(desktop): bound added checks and omit noisy text guards * fix(desktop): exclude unseeded locks from task checks * fix(desktop): preserve draft bounds and launch URLs * fix(desktop): render draft values using their source format * fix(desktop): preserve launch URLs and JSON draft values * fix(desktop): recognize captured file URL documents * fix(desktop): render captured file URLs for runtime home * fix(desktop): distinguish phone numbers from save metadata * fix(desktop): preserve launch URLs and user text * fix(desktop): preserve captured URLs and user text * fix(desktop): preserve local file URL authority * fix(desktop): preserve local file URL authority * fix(desktop): preserve local file URL authority * fix(desktop): render captured file URLs at launch * fix(desktop): classify numeric timestamps using field context * fix(desktop): classify numeric timestamps using field context * fix(desktop): classify numeric timestamps using field context * fix(desktop): retain context for generated draft values * fix(desktop): retain context for generated draft values * fix(desktop): retain context for generated draft values * test(desktop): cover generated IDs in text guards * test(desktop): cover generated IDs in text guards * test(desktop): cover generated IDs in text guards * fix(desktop): isolate launcher URL encoding * fix(desktop): isolate launcher URL encoding * fix(desktop): isolate launcher URL encoding * fix(desktop): isolate launcher URL encoding * fix(desktop): retain clean text in noisy record fields * fix(desktop): classify added line values in one pass * fix(desktop): apply XML quote rules to text drafts * fix(desktop): distinguish XML attributes from quoted text * fix(desktop): preserve parsed XML line context * Format appTaskChecks.ts with the pinned oxfmt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(desktop): retain partial XML syntax facts * fix(desktop): recognize markdown autolinks in drafts * fix(desktop): reuse export exclusions in task drafts * fix(desktop): report unchecked client build paths * docs(desktop): clarify gzip scrub limits * fix(desktop): reuse export exclusions in task drafts * docs(desktop): clarify gzip scrub limits * fix(setup): own desktop build process cleanup * fix(doctor): compare desktop settings with resolved defaults * style(desktop): format the noisy-record draft files with the pinned oxfmt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(desktop): give the root-array draft test its own describe The records describe grew past the 150-line lint limit with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(doctor): inspect client-recorded desktop runners * fix(doctor): reuse matching runner probes * fix(setup): propagate cancellation to desktop actions * fix(setup): stop Hopper on cancel, never report a cancelled setup ready, and keep a failed action's client setting - The Hopper install gets setup's signal: Linux already honoured it, and the macOS installer now stops its downloads and stops before mounting or copying. - runSetup checks the signal after the final doctor and close, so a cancellation there raises instead of returning ready. - A failed pack or agentenv install no longer writes its archive or runner to client configs, so the setting the client already had stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(setup): keep the completed setup result in a cancellation after cleanup A cancellation during the final doctor or host close carried only the applied actions, dropping each client's result and backup path and the doctor report. It now carries the whole result as setup_result, as doctor's cancellation carries its report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(desktop): move launch execution to boundary suite * fix(desktop): redact build schema failure output * refactor(desktop): normalize schema failure once * fix(desktop): omit unsafe schema parser snippets * fix(desktop): preserve draft change and selected path evidence * test(desktop): group retained dconf note regressions * fix(desktop): respect archive entry format in draft checks * test(desktop): separate unowned-file draft note cases * fix(desktop): preserve explicitly selected journal documents * fix(xml): avoid scanning selected ancestors per tag * fix(desktop): exclude covered text runs from draft counts * fix: preserve text when drafting desktop checks * fix: restore nested desktop state aliases * refactor: share UUID recognition across draft checks * fix: retain multiline XML attribute context * fix: retain relationship identifiers in task drafts * docs: clarify desktop draft identifier handling * test(desktop): type formatting run cases as pairs * fix(desktop): carry document format into selector evaluation * test(desktop): separate markup boundary regression group * fix(desktop): propagate formats through draft selectors * fix(desktop): switch selector format within archive entries * test(desktop): remove duplicate seed filename case * fix(setup): retain diagnostics when cancellation overlaps failure * refactor(setup): keep command cancellation at its owner * test(setup): verify cancellation at the application boundary * test(desktop): pass JSON format in exported index parity * docs(desktop): clarify task checks before scratch export * fix(desktop): respell selected paths in file URLs * test(desktop): group captured document spelling cases * fix(desktop): bound draft preview serialization * fix(desktop): restore selected state aliases * fix(desktop): respect entry format in draft noise * test(desktop): match exported alias evidence at its JSON boundary * fix(desktop): retain app state logs in exported seeds * fix: align desktop numeric seed comparisons * test(desktop): keep one draft exclusion fixture import * test(desktop): retain log eligibility across draft test groups * fix(doctor): resolve empty registered desktop runner * style: fix desktop launch test formatting * style: format native command path schema * fix(desktop): map selected external launch paths * style(desktop): format seed document regressions * test(desktop): group launch URL regressions * fix(desktop): omit redundant nested state aliases * fix(desktop): compare added free text as a whole * fix(desktop): check recompressed seeds as shipped * docs(desktop): clarify recovered seed format * test(desktop): group shipped gzip seed checks * fix: retain quoted identifier text in task drafts * fix: recognize Unicode XML in desktop state readers * fix(desktop): bound nested draft checks * fix(desktop): explain missing arrays in truncated views * fix(desktop): find XML type references in archives * test(desktop): remove duplicated capture assertions * fix(desktop): retain nested omitted text boundaries * style(desktop): format draft value imports * test(desktop): group model and draft value checks * fix(desktop): map captured launch paths once * refactor: remove unused whole-text guard state * refactor: stop passing unused text children * test: align free-text checks with whole-note policy * fix: validate recompressed desktop archive seeds * style(desktop): format archive seed regression * fix(desktop): retain placed-item sibling guards * fix(desktop): preserve archive paths and bound doctor reads * fix(doctor): refuse non-files before descriptor admission * fix(setup): track remaining cleanup resources across retries * test(desktop): specify XML format in heap pairing fixture * fix(doctor): query agentenv for model endpoint * fix(doctor): preserve uncertainty for empty endpoint override * fix(desktop): redact runtime schema errors * fix(desktop): normalize captured file URLs * fix(desktop): report seeded files by capture path * fix(desktop): retain startup readiness failure stage * fix(desktop): retain JSON date checks * fix(desktop): preserve archive formatting checks * fix(desktop): preserve explicitly selected journal files * fix(desktop): report build command transport limits * docs(desktop): clarify unreadable dconf versions * test(desktop): remove duplicate history regression * fix(desktop): align XML names with exported reader * fix(desktop): create selected state alias targets * fix(desktop): inspect supported runtime archives * fix(desktop): retain record identity in draft checks * fix(desktop): scrub XML independently of reader compatibility * fix(desktop): preserve file aliases and reader diagnostics * style(desktop): format review fixes * style(desktop): format capture review fixes --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
220 lines
8.5 KiB
TypeScript
220 lines
8.5 KiB
TypeScript
import { DESKTOP_EXPORT_FRAMEWORK_VERSION } from "../domain/desktop/appExport.js";
|
|
import { AGENTENV_INSTALL_COMMAND } from "./DesktopBuildDoctor.js";
|
|
import { DESKTOP_BUILD_PROVIDER_ID } from "./DoctorProviderIds.js";
|
|
import { assertSetupActive } from "./SetupCancellation.js";
|
|
import type {
|
|
SetupAction,
|
|
SetupOptions,
|
|
SetupProgressEvent,
|
|
SetupProviderEnvironment,
|
|
} from "./SetupTypes.js";
|
|
|
|
/** What setup reads from a host before it plans a desktop build setup. */
|
|
export interface DesktopBuildSetupFacts {
|
|
/** Each build setting resolved to an absolute path; absent when none resolves. */
|
|
readonly settings: SetupProviderEnvironment;
|
|
/** Settings the caller's environment selected, which setup records as they are. */
|
|
readonly selected: readonly string[];
|
|
readonly archive: string;
|
|
readonly archivePacked: boolean;
|
|
/** Why this REA cannot pack its runtime, when it cannot. */
|
|
readonly packBlocker?: string;
|
|
readonly agentEnvVersion?: string | undefined;
|
|
/** uv on PATH and the agent-env its tool install places. */
|
|
readonly uv?: { readonly path: string; readonly agentEnv: string };
|
|
/** Per client, the build settings its registration already records with a value of its own. */
|
|
readonly recorded: Readonly<Record<string, readonly string[]>>;
|
|
}
|
|
|
|
/** Effects `rea setup --desktop-build` needs from its host. */
|
|
export interface DesktopBuildSetupHost {
|
|
facts(clientIds: readonly string[]): Promise<DesktopBuildSetupFacts>;
|
|
/** Pack this REA as the build-computer runtime; the reason when it failed. */
|
|
packRuntime(
|
|
archive: string,
|
|
signal?: AbortSignal,
|
|
): Promise<string | undefined>;
|
|
/** Install the pinned agentenv-framework with uv; the reason when it failed. */
|
|
installAgentenv(
|
|
uv: string,
|
|
signal?: AbortSignal,
|
|
): Promise<string | undefined>;
|
|
}
|
|
|
|
/** A desktop build setup as runSetup drives it; inert when it was not selected. */
|
|
export interface DesktopBuildSetup {
|
|
readonly selected: boolean;
|
|
readonly blocker?: string;
|
|
readonly actions: readonly SetupAction[];
|
|
/**
|
|
* Settings added to each selected client's registration only; after apply, a
|
|
* setting whose pack or install failed is left as the client records it.
|
|
*/
|
|
readonly clientEnvironments: Readonly<
|
|
Record<string, SetupProviderEnvironment>
|
|
>;
|
|
readonly remediation?: string;
|
|
/** Run the approved install and pack; the remediation for whatever failed. */
|
|
apply(
|
|
appliedActions: string[],
|
|
onProgress?: (event: SetupProgressEvent) => void,
|
|
signal?: AbortSignal,
|
|
): Promise<string | undefined>;
|
|
/** Where to look when the build host is not ready after setup. */
|
|
readinessRemediation(healthy: boolean): string | undefined;
|
|
}
|
|
|
|
const inert = (blocker?: string): DesktopBuildSetup => ({
|
|
selected: blocker !== undefined,
|
|
...(blocker === undefined ? {} : { blocker }),
|
|
actions: [],
|
|
clientEnvironments: {},
|
|
apply: () => Promise.resolve(undefined),
|
|
readinessRemediation: () => undefined,
|
|
});
|
|
|
|
/** Plan packing, the optional agentenv install and the settings each registration lacks. */
|
|
export const planDesktopBuild = async (
|
|
host: DesktopBuildSetupHost | undefined,
|
|
options: Pick<SetupOptions, "desktopBuild" | "installAgentenv">,
|
|
clientIds: readonly string[],
|
|
): Promise<DesktopBuildSetup> => {
|
|
if (options.desktopBuild !== true) return inert();
|
|
if (host === undefined)
|
|
return inert("This setup host cannot set up desktop builds.");
|
|
const facts = await host.facts(clientIds);
|
|
const pinned = facts.agentEnvVersion === DESKTOP_EXPORT_FRAMEWORK_VERSION;
|
|
const install = options.installAgentenv === true && !pinned;
|
|
const uv = install ? facts.uv : undefined;
|
|
const actions: SetupAction[] = [];
|
|
if (uv !== undefined) actions.push(installAction(uv.agentEnv));
|
|
// An archive the caller selected is recorded instead of packing REA's own.
|
|
if (
|
|
!facts.archivePacked &&
|
|
!facts.selected.includes("REA_BUILD_COMPUTER_REA_ARCHIVE")
|
|
) {
|
|
if (facts.packBlocker !== undefined) return inert(facts.packBlocker);
|
|
actions.push(packAction(facts.archive));
|
|
}
|
|
const settings: SetupProviderEnvironment = {
|
|
...facts.settings,
|
|
...(uv !== undefined && !facts.selected.includes("REA_AGENT_ENV_COMMAND")
|
|
? { REA_AGENT_ENV_COMMAND: uv.agentEnv }
|
|
: {}),
|
|
};
|
|
const remediation = agentenvRemediation(pinned, install, uv);
|
|
const failed = new Set<string>();
|
|
return {
|
|
selected: true,
|
|
actions,
|
|
get clientEnvironments() {
|
|
return Object.fromEntries(
|
|
clientIds.map((client) => [
|
|
client,
|
|
Object.fromEntries(
|
|
Object.entries(settings).filter(
|
|
([name]) =>
|
|
!failed.has(name) &&
|
|
(facts.selected.includes(name) ||
|
|
!(facts.recorded[client] ?? []).includes(name)),
|
|
),
|
|
),
|
|
]),
|
|
);
|
|
},
|
|
...(remediation === undefined ? {} : { remediation }),
|
|
apply: (appliedActions, onProgress, signal) =>
|
|
applyActions(host, actions, uv?.path, {
|
|
appliedActions,
|
|
onProgress,
|
|
signal,
|
|
failed: (kind) => {
|
|
if (kind === "pack_build_runtime")
|
|
failed.add("REA_BUILD_COMPUTER_REA_ARCHIVE");
|
|
else if (!facts.selected.includes("REA_AGENT_ENV_COMMAND"))
|
|
failed.add("REA_AGENT_ENV_COMMAND");
|
|
},
|
|
}),
|
|
readinessRemediation: (healthy) =>
|
|
healthy
|
|
? undefined
|
|
: `Run rea doctor --provider ${DESKTOP_BUILD_PROVIDER_ID} and apply each reported fix.`,
|
|
};
|
|
};
|
|
|
|
const agentenvRemediation = (
|
|
pinned: boolean,
|
|
install: boolean,
|
|
uv: DesktopBuildSetupFacts["uv"],
|
|
): string | undefined =>
|
|
pinned || uv !== undefined
|
|
? undefined
|
|
: install
|
|
? `uv is not on PATH. Install agentenv with ${AGENTENV_INSTALL_COMMAND}, then rerun setup.`
|
|
: `Desktop builds need agentenv-framework ${DESKTOP_EXPORT_FRAMEWORK_VERSION}: ${AGENTENV_INSTALL_COMMAND}, or rerun setup with --install-agentenv.`;
|
|
|
|
const applyActions = async (
|
|
host: DesktopBuildSetupHost,
|
|
actions: readonly SetupAction[],
|
|
uv: string | undefined,
|
|
progress: {
|
|
readonly appliedActions: string[];
|
|
readonly onProgress?: ((event: SetupProgressEvent) => void) | undefined;
|
|
readonly signal?: AbortSignal | undefined;
|
|
/** Leave the setting this failed action produces as each client records it. */
|
|
readonly failed: (kind: SetupAction["kind"]) => void;
|
|
},
|
|
): Promise<string | undefined> => {
|
|
const failures: string[] = [];
|
|
for (const { id, kind, label, target } of actions) {
|
|
assertSetupActive(progress.signal);
|
|
progress.onProgress?.({ actionId: id, label, state: "started" });
|
|
const failure =
|
|
kind === "install_agentenv"
|
|
? await host.installAgentenv(uv ?? "uv", progress.signal)
|
|
: await host.packRuntime(target, progress.signal);
|
|
progress.onProgress?.({
|
|
actionId: id,
|
|
label,
|
|
state: failure === undefined ? "completed" : "failed",
|
|
...(failure === undefined ? {} : { detail: failure }),
|
|
});
|
|
if (failure === undefined) progress.appliedActions.push(id);
|
|
assertSetupActive(progress.signal, failure);
|
|
if (failure === undefined) continue;
|
|
progress.failed(kind);
|
|
failures.push(
|
|
kind === "install_agentenv"
|
|
? `Installing agentenv failed: ${failure} Run ${AGENTENV_INSTALL_COMMAND} yourself, then rerun setup.`
|
|
: `Packing REA's build-computer runtime failed: ${failure} Fix the reported problem, then rerun setup with --desktop-build.`,
|
|
);
|
|
}
|
|
return failures.length === 0 ? undefined : failures.join(" ");
|
|
};
|
|
|
|
const installAction = (agentEnv: string): SetupAction => ({
|
|
id: "install_agentenv",
|
|
kind: "install_agentenv",
|
|
label: `agentenv-framework ${DESKTOP_EXPORT_FRAMEWORK_VERSION}`,
|
|
target: agentEnv,
|
|
detail:
|
|
"Install the agentenv-framework release that desktop bundles target as a uv tool; REA runs its agent-env program for build computers.",
|
|
external: true,
|
|
operation: "install",
|
|
networkOrigins: ["https://pypi.org", "https://files.pythonhosted.org"],
|
|
commands: [AGENTENV_INSTALL_COMMAND],
|
|
});
|
|
|
|
const packAction = (archive: string): SetupAction => ({
|
|
id: "pack_build_runtime",
|
|
kind: "pack_build_runtime",
|
|
label: "REA build-computer runtime",
|
|
target: archive,
|
|
detail:
|
|
"Pack this REA checkout as the runtime a build computer installs: npm pack, its production dependencies from npm ci --omit=dev --omit=optional, then a .tar.xz named by this REA version, packed again when the version changes.",
|
|
external: true,
|
|
operation: "create",
|
|
networkOrigins: ["https://registry.npmjs.org"],
|
|
commands: [`npm run pack:build-computer-runtime -- ${archive}`],
|
|
});
|