mirror of
https://github.com/morluto/rea.git
synced 2026-11-12 01:41:21 +00:00
* fix(desktop): keep an empty env value empty An empty assignment is not a path. Resolving it named the working directory and rewrote the value when that directory's spelling moved. * fix(desktop): keep a run's font on the run, not the frame's text A formatting attribute such as Scribus FONT is not the document's words. Joining it across runs made a frame-wide text check of ItalicBold that failed when a run was split. The font stays a value check on its own run. * fix(desktop): do not pair JSON records by a selector-shaped field A field named @record_id matched the id suffix and became [@record_id=one], which reads an XML attribute. Records paired while their pointers matched nothing. Names that start with @ or > are not id fields. * fix(desktop): count a save-numbered id once when pairing members xml:id and draw:id values such as id123456 were both generated and numbered, so the same selector was counted twice and refused. A text edit of two elements keyed only by those ids now keeps its check. * fix(desktop): count members of root JSON arrays * fix(desktop): preserve selected state directory aliases * docs(desktop): explain tool and skill refresh prerequisites * fix(desktop): align nested state selections with aliases * fix(desktop): check build runtime export capability * fix(desktop): provide complete runtime repack command * fix(desktop): retain runtime probe failures * test(desktop): identify capture independently of schema preflight * fix(desktop): preserve document URLs and value formats * fix(desktop): bound added checks and omit noisy text guards * fix(desktop): exclude unseeded locks from task checks * fix(desktop): preserve draft bounds and launch URLs * fix(desktop): render draft values using their source format * fix(desktop): preserve launch URLs and JSON draft values * fix(desktop): recognize captured file URL documents * fix(desktop): render captured file URLs for runtime home * fix(desktop): distinguish phone numbers from save metadata * fix(desktop): preserve launch URLs and user text * fix(desktop): preserve captured URLs and user text * fix(desktop): preserve local file URL authority * fix(desktop): preserve local file URL authority * fix(desktop): preserve local file URL authority * fix(desktop): render captured file URLs at launch * fix(desktop): classify numeric timestamps using field context * fix(desktop): classify numeric timestamps using field context * fix(desktop): classify numeric timestamps using field context * fix(desktop): retain context for generated draft values * fix(desktop): retain context for generated draft values * fix(desktop): retain context for generated draft values * test(desktop): cover generated IDs in text guards * test(desktop): cover generated IDs in text guards * test(desktop): cover generated IDs in text guards * fix(desktop): isolate launcher URL encoding * fix(desktop): isolate launcher URL encoding * fix(desktop): isolate launcher URL encoding * fix(desktop): isolate launcher URL encoding * fix(desktop): retain clean text in noisy record fields * fix(desktop): classify added line values in one pass * fix(desktop): apply XML quote rules to text drafts * fix(desktop): distinguish XML attributes from quoted text * fix(desktop): preserve parsed XML line context * Format appTaskChecks.ts with the pinned oxfmt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(desktop): retain partial XML syntax facts * fix(desktop): recognize markdown autolinks in drafts * fix(desktop): reuse export exclusions in task drafts * fix(desktop): report unchecked client build paths * docs(desktop): clarify gzip scrub limits * fix(desktop): reuse export exclusions in task drafts * docs(desktop): clarify gzip scrub limits * fix(setup): own desktop build process cleanup * fix(doctor): compare desktop settings with resolved defaults * style(desktop): format the noisy-record draft files with the pinned oxfmt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(desktop): give the root-array draft test its own describe The records describe grew past the 150-line lint limit with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(doctor): inspect client-recorded desktop runners * fix(doctor): reuse matching runner probes * fix(setup): propagate cancellation to desktop actions * fix(setup): stop Hopper on cancel, never report a cancelled setup ready, and keep a failed action's client setting - The Hopper install gets setup's signal: Linux already honoured it, and the macOS installer now stops its downloads and stops before mounting or copying. - runSetup checks the signal after the final doctor and close, so a cancellation there raises instead of returning ready. - A failed pack or agentenv install no longer writes its archive or runner to client configs, so the setting the client already had stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(setup): keep the completed setup result in a cancellation after cleanup A cancellation during the final doctor or host close carried only the applied actions, dropping each client's result and backup path and the doctor report. It now carries the whole result as setup_result, as doctor's cancellation carries its report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(desktop): move launch execution to boundary suite * fix(desktop): redact build schema failure output * refactor(desktop): normalize schema failure once * fix(desktop): omit unsafe schema parser snippets * fix(desktop): preserve draft change and selected path evidence * test(desktop): group retained dconf note regressions * fix(desktop): respect archive entry format in draft checks * test(desktop): separate unowned-file draft note cases * fix(desktop): preserve explicitly selected journal documents * fix(xml): avoid scanning selected ancestors per tag * fix(desktop): exclude covered text runs from draft counts * fix: preserve text when drafting desktop checks * fix: restore nested desktop state aliases * refactor: share UUID recognition across draft checks * fix: retain multiline XML attribute context * fix: retain relationship identifiers in task drafts * docs: clarify desktop draft identifier handling * test(desktop): type formatting run cases as pairs * fix(desktop): carry document format into selector evaluation * test(desktop): separate markup boundary regression group * fix(desktop): propagate formats through draft selectors * fix(desktop): switch selector format within archive entries * test(desktop): remove duplicate seed filename case * fix(setup): retain diagnostics when cancellation overlaps failure * refactor(setup): keep command cancellation at its owner * test(setup): verify cancellation at the application boundary * test(desktop): pass JSON format in exported index parity * docs(desktop): clarify task checks before scratch export * fix(desktop): respell selected paths in file URLs * test(desktop): group captured document spelling cases * fix(desktop): bound draft preview serialization * fix(desktop): restore selected state aliases * fix(desktop): respect entry format in draft noise * test(desktop): match exported alias evidence at its JSON boundary * fix(desktop): retain app state logs in exported seeds * fix: align desktop numeric seed comparisons * test(desktop): keep one draft exclusion fixture import * test(desktop): retain log eligibility across draft test groups * fix(doctor): resolve empty registered desktop runner * style: fix desktop launch test formatting * style: format native command path schema * fix(desktop): map selected external launch paths * style(desktop): format seed document regressions * test(desktop): group launch URL regressions * fix(desktop): omit redundant nested state aliases * fix(desktop): compare added free text as a whole * fix(desktop): check recompressed seeds as shipped * docs(desktop): clarify recovered seed format * test(desktop): group shipped gzip seed checks * fix: retain quoted identifier text in task drafts * fix: recognize Unicode XML in desktop state readers * fix(desktop): bound nested draft checks * fix(desktop): explain missing arrays in truncated views * fix(desktop): find XML type references in archives * test(desktop): remove duplicated capture assertions * fix(desktop): retain nested omitted text boundaries * style(desktop): format draft value imports * test(desktop): group model and draft value checks * fix(desktop): map captured launch paths once * refactor: remove unused whole-text guard state * refactor: stop passing unused text children * test: align free-text checks with whole-note policy * fix: validate recompressed desktop archive seeds * style(desktop): format archive seed regression * fix(desktop): retain placed-item sibling guards * fix(desktop): preserve archive paths and bound doctor reads * fix(doctor): refuse non-files before descriptor admission * fix(setup): track remaining cleanup resources across retries * test(desktop): specify XML format in heap pairing fixture * fix(doctor): query agentenv for model endpoint * fix(doctor): preserve uncertainty for empty endpoint override * fix(desktop): redact runtime schema errors * fix(desktop): normalize captured file URLs * fix(desktop): report seeded files by capture path * fix(desktop): retain startup readiness failure stage * fix(desktop): retain JSON date checks * fix(desktop): preserve archive formatting checks * fix(desktop): preserve explicitly selected journal files * fix(desktop): report build command transport limits * docs(desktop): clarify unreadable dconf versions * test(desktop): remove duplicate history regression * fix(desktop): align XML names with exported reader * fix(desktop): create selected state alias targets * fix(desktop): inspect supported runtime archives * fix(desktop): retain record identity in draft checks * fix(desktop): scrub XML independently of reader compatibility * fix(desktop): preserve file aliases and reader diagnostics * style(desktop): format review fixes * style(desktop): format capture review fixes --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
295 lines
10 KiB
TypeScript
295 lines
10 KiB
TypeScript
import type { ClientConfigurationWriteProblem } from "./ClientConfigurationPublication.js";
|
|
import type { DoctorReport, DoctorScope, runDoctor } from "./Doctor.js";
|
|
import type { LinuxDistribution } from "./LinuxHopper.js";
|
|
import type { HopperRequestFailure } from "./HopperDownload.js";
|
|
import type { HopperReleaseError } from "./HopperReleaseFeed.js";
|
|
import type {
|
|
SkillDestination,
|
|
SkillInstallResult,
|
|
SetupSkillInstallError,
|
|
} from "./SetupSkill.js";
|
|
import type { Result } from "../domain/result.js";
|
|
import type {
|
|
AnalysisCleanupObservation,
|
|
AnalysisError,
|
|
} from "../domain/analysisErrorBase.js";
|
|
import type { SetupClient } from "./SupportedClients.js";
|
|
import type { DesktopBuildSetupHost } from "./SetupDesktopBuild.js";
|
|
import type {
|
|
SetupFailureCode,
|
|
SetupHopperInstallResult,
|
|
} from "./SetupInstallFailure.js";
|
|
|
|
/** Exact non-secret provider variables propagated into managed registrations. */
|
|
export type SetupProviderEnvironment = Readonly<Record<string, string>>;
|
|
|
|
/** Read-only host facts shared by the initial setup plan. */
|
|
export interface SetupInitialState {
|
|
readonly hopperPath?: string;
|
|
/** Whether the caller explicitly selected a Hopper launcher in its environment. */
|
|
readonly hopperLauncherConfigured?: boolean;
|
|
/** Whether the caller or host has an analysis provider configuration. */
|
|
readonly providerConfigured: boolean;
|
|
readonly providerEnvironment: SetupProviderEnvironment;
|
|
readonly doctor: DoctorReport;
|
|
}
|
|
|
|
/** Result of one backup/write/readback transaction. */
|
|
export type ClientConfigurationResult =
|
|
| {
|
|
readonly status: "failed";
|
|
readonly reason: "registration_ownership";
|
|
readonly detail: string;
|
|
}
|
|
| {
|
|
readonly status: "failed";
|
|
readonly reason: "conflict";
|
|
readonly backupPath?: string;
|
|
}
|
|
| {
|
|
readonly status: "unchanged" | "configured" | "skipped";
|
|
readonly backupPath?: string;
|
|
}
|
|
| {
|
|
readonly status: "failed";
|
|
readonly reason: "path" | "target_changed" | "backup";
|
|
}
|
|
| {
|
|
readonly status: "failed";
|
|
readonly reason: "write";
|
|
readonly failure?: ClientConfigurationWriteProblem;
|
|
readonly backupPath?: string;
|
|
}
|
|
| {
|
|
readonly status: "failed";
|
|
/** Removing the member a client reads would activate an earlier duplicate. */
|
|
readonly reason: "shadowed_member";
|
|
readonly path: readonly string[];
|
|
}
|
|
| {
|
|
readonly status: "failed";
|
|
readonly reason: "readback";
|
|
/** Snapshot of the restored original, when this transaction made one. */
|
|
readonly backupPath?: string;
|
|
}
|
|
| {
|
|
readonly status: "failed";
|
|
readonly reason: "target_unavailable";
|
|
readonly failure: {
|
|
readonly kind: "inspect";
|
|
readonly path: string;
|
|
readonly detail: string;
|
|
};
|
|
}
|
|
| {
|
|
readonly status: "failed";
|
|
readonly reason: "rollback";
|
|
readonly backupPath?: string;
|
|
readonly failure: {
|
|
readonly kind: "restore";
|
|
readonly path: string;
|
|
readonly detail: string;
|
|
};
|
|
};
|
|
|
|
/** Read-only state used to block unsafe setup plans before any mutation. */
|
|
export type ClientConfigurationInspection =
|
|
| { readonly status: "already_current" }
|
|
| {
|
|
readonly status: "create" | "update";
|
|
readonly backupPath?: string;
|
|
}
|
|
| {
|
|
readonly status: "invalid";
|
|
readonly remediation: string;
|
|
};
|
|
/** Effects required by the idempotent, non-blocking setup workflow. */
|
|
export interface SetupHost {
|
|
readonly platform: NodeJS.Platform;
|
|
readonly homeDirectory: string;
|
|
readonly linuxHopperReleaseCache?: Result<string, HopperReleaseError>;
|
|
skillDestinations(clientIds: readonly string[]): readonly SkillDestination[];
|
|
readonly registrationCommand: readonly string[];
|
|
/** Why client registration cannot proceed from this host. */
|
|
readonly registrationCommandBlocker?: string;
|
|
readonly nodeVersion: string;
|
|
macosVersion(): Promise<string | undefined>;
|
|
linuxDistribution(): Promise<LinuxDistribution | undefined>;
|
|
initialSetupState(scope?: DoctorScope): Promise<SetupInitialState>;
|
|
/** Cancellation stops downloads and later steps; a started package transaction finishes. */
|
|
installHopper(
|
|
replaceExisting: boolean,
|
|
signal?: AbortSignal,
|
|
): Promise<SetupHopperInstallResult>;
|
|
/** Retry retained owners. Returned or thrown errors with explicit cleanup
|
|
* owners follow live release state; ownerless failures remain unconfirmed.
|
|
* runSetup does not observe later direct calls to a caller-supplied host. */
|
|
close?(): Promise<AnalysisError | undefined>;
|
|
detectedClients(): Promise<readonly SetupClient[]>;
|
|
supportedClients(): Promise<readonly SetupClient[]>;
|
|
configureClient(
|
|
client: SetupClient,
|
|
providerEnvironment: SetupProviderEnvironment,
|
|
command: readonly string[],
|
|
): Promise<ClientConfigurationResult>;
|
|
clientNeedsConfigure(
|
|
client: SetupClient,
|
|
providerEnvironment: SetupProviderEnvironment,
|
|
command: readonly string[],
|
|
): Promise<boolean>;
|
|
inspectClientConfiguration(
|
|
client: SetupClient,
|
|
providerEnvironment: SetupProviderEnvironment,
|
|
command: readonly string[],
|
|
): Promise<ClientConfigurationInspection>;
|
|
skillNeedsInstall(clientIds: readonly string[]): Promise<boolean>;
|
|
validateSkillDirectories(
|
|
clientIds: readonly string[],
|
|
): Promise<Result<void, SetupSkillInstallError>>;
|
|
installSkill(clientIds: readonly string[]): Promise<SkillInstallResult>;
|
|
doctor(scope?: DoctorScope): Promise<Awaited<ReturnType<typeof runDoctor>>>;
|
|
/** Present where setup can prepare this host for desktop builds. */
|
|
readonly desktopBuild?: DesktopBuildSetupHost;
|
|
}
|
|
/** Structured setup outcome carrying remediation instead of prompting. */
|
|
export interface SetupResult {
|
|
readonly status:
|
|
| "planned"
|
|
| "cancelled"
|
|
| "needs_confirmation"
|
|
| "ready"
|
|
| "needs_human";
|
|
readonly plannedActions: readonly SetupAction[];
|
|
readonly appliedActions: readonly string[];
|
|
readonly clients: Readonly<Record<string, ClientConfigurationResult>>;
|
|
readonly doctor: SetupDoctorSummary;
|
|
/** Supported-client discovery state captured before setup mutations. */
|
|
readonly clientStates: readonly SetupClientState[];
|
|
readonly remediation?: string;
|
|
readonly code?: SetupFailureCode;
|
|
/** The Hopper vendor request (stage, URL and observed outcome) whose failure stopped installation. */
|
|
readonly download?: HopperRequestFailure;
|
|
/** Identified resources still retained after finalization; absent after confirmed release. */
|
|
readonly cleanup?: AnalysisCleanupObservation | undefined;
|
|
}
|
|
|
|
/** Whether the requested setup actions still need approval or human repair. */
|
|
export const isSetupFailure = (result: SetupResult): boolean => {
|
|
const status = result.status;
|
|
switch (status) {
|
|
case "planned":
|
|
case "cancelled":
|
|
case "ready":
|
|
return false;
|
|
case "needs_confirmation":
|
|
case "needs_human":
|
|
return true;
|
|
default: {
|
|
const exhaustive: never = status;
|
|
throw new TypeError(
|
|
`Unhandled setup result status: ${String(exhaustive)}`,
|
|
);
|
|
}
|
|
}
|
|
};
|
|
|
|
/** Relevant health and identity evidence for the selected setup scope. */
|
|
export interface SetupDoctorSummary {
|
|
readonly healthy: boolean;
|
|
readonly environment_healthy: boolean;
|
|
readonly scope: DoctorReport["scope"];
|
|
readonly hopperPath?: string;
|
|
readonly availableProviders: readonly string[];
|
|
readonly providerInspections?: DoctorReport["providerInspections"];
|
|
readonly identity?: Pick<
|
|
NonNullable<DoctorReport["identity"]>,
|
|
"skill" | "registrations"
|
|
>;
|
|
}
|
|
|
|
/** Read-only state for one supported client location. */
|
|
export interface SetupClientState {
|
|
readonly client: SetupClient;
|
|
readonly detected: boolean;
|
|
readonly configured: boolean;
|
|
readonly status:
|
|
| "configured"
|
|
| "missing"
|
|
| "needs_configuration"
|
|
| "invalid"
|
|
| "unknown";
|
|
}
|
|
|
|
/** One concrete setup mutation disclosed before approval. */
|
|
export interface SetupAction {
|
|
readonly id: string;
|
|
readonly kind:
|
|
| "install_hopper"
|
|
| "configure_client"
|
|
| "install_skill"
|
|
| "install_agentenv"
|
|
| "pack_build_runtime";
|
|
readonly label: string;
|
|
readonly target: string;
|
|
readonly detail: string;
|
|
readonly external: boolean;
|
|
readonly operation: "create" | "update" | "install";
|
|
readonly backupPath?: string;
|
|
readonly networkOrigins?: readonly string[];
|
|
readonly commands?: readonly string[];
|
|
readonly integrity?: string;
|
|
}
|
|
|
|
/** Explicit authorization supplied by an interactive or unattended CLI adapter. */
|
|
export interface SetupOptions {
|
|
/** Caller cancellation, carried through approved effects and cleanup. */
|
|
readonly signal?: AbortSignal;
|
|
readonly approved: boolean;
|
|
readonly installHopper: boolean;
|
|
readonly structured: boolean;
|
|
readonly proposeHopper?: boolean;
|
|
readonly clientIds?: readonly string[];
|
|
/** Skill roots to update independently of MCP registrations (maintenance). */
|
|
readonly skillClientIds?: readonly string[];
|
|
readonly installSkill?: boolean;
|
|
/** Comma-separated tool families the MCP registration advertises. */
|
|
readonly toolFamilies?: string;
|
|
readonly readinessScope?: DoctorScope;
|
|
readonly dryRun?: boolean;
|
|
readonly allDetectedClients?: boolean;
|
|
/** Pack the build-computer runtime and record the build settings in the selected registrations. */
|
|
readonly desktopBuild?: boolean;
|
|
/** With desktopBuild, install the pinned agentenv-framework with uv. */
|
|
readonly installAgentenv?: boolean;
|
|
readonly onProgress?: (event: SetupProgressEvent) => void;
|
|
}
|
|
|
|
/** One settled or active setup operation projected to the interactive adapter. */
|
|
export interface SetupProgressEvent {
|
|
readonly actionId: string;
|
|
readonly label: string;
|
|
readonly state: "started" | "completed" | "warning" | "failed";
|
|
readonly detail?: string;
|
|
}
|
|
|
|
/** Interactive selection and final consent returned by the CLI adapter. */
|
|
export interface SetupConfirmationDecision {
|
|
readonly approved: boolean;
|
|
readonly selectedActionIds: readonly string[];
|
|
readonly cancelled?: boolean;
|
|
}
|
|
|
|
/** Read-only context shown while selecting clients or reviewing exact actions. */
|
|
export interface SetupConfirmationContext {
|
|
readonly stage: "select" | "confirm";
|
|
readonly clientStates: readonly SetupClientState[];
|
|
readonly selectedClientIds: readonly string[];
|
|
readonly clientSelectionAllowed: boolean;
|
|
}
|
|
|
|
/** Adapter-owned selection and confirmation for the setup workflow. */
|
|
export type SetupConfirmation = (
|
|
actions: readonly SetupAction[],
|
|
context?: SetupConfirmationContext,
|
|
) => Promise<boolean | SetupConfirmationDecision>;
|