Files
reverse-engineering-anything/tests/boundary/mcp/callGraphCleanupIncomplete.test.ts
T
morluto 1f24b3fa57 feat(evidence)!: name the Evidence subject by its target identity (format revision 2) (#11416)
* feat(evidence)!: name the Evidence subject by its target identity (format revision 2)

The Evidence subject carries subject.identity (kind, sha256, format,
architecture, selection) and the Evidence ID commits to it, so raw/DOL
entry points and ESP flash offsets of the same bytes are different
subjects. Every record declares evidence_format: 2; revision 1 bundles,
standalone records and snapshots are refused with the recreate guidance.
binaryTargetIdentity is the one projection of an open target, used by
Evidence and snapshot comparison.

BREAKING CHANGE: Evidence format revision 2. Evidence IDs commit to the
subject's target identity (subject.identity, including the raw/DOL entry
point or ESP flash offsets), and every record declares evidence_format: 2.
Evidence bundles, records and analysis snapshots from earlier releases are
refused; recreate the observations with this release.

* refactor(analysis-view): read parent subjects through the Evidence identity accessors (#11423)

Analysis views compare their parent's file identity (evidenceFileTarget)
and take path and digest from evidenceSubjectTarget instead of reading
the subject's digest, format and architecture members, which duplicate
subject.identity until they are removed. A counted guard
(evidence-subject-declaration-read) keeps new direct reads out and
records the 20 remaining files.

* fix(evidence): carry format refusals through Evidence readers and bind target selections

- safeParseEvidence/safeParseImmutableEvidence return the format refusal as
  an expected failure; every consumer maps it to the one integrity refusal
  with the recreate guidance. An unmarked object is an earlier record only
  when it has every member records have always carried.
- ArtifactProvider inventory roots and provider subjects that name the
  target's own bytes carry the target's selection (ESP flash offsets).
- Snapshot rows bind only Evidence whose identity, selection included,
  matches the snapshot target.
- Entry-point selections use the raw-binary entry point form.

* fix(evidence): refuse unauthenticated or earlier-format records instead of reading them as absent

- recognizeEvidence (evidenceValidation) replaces tryParseEvidence: input
  without an evidence_id is not Evidence (ok(undefined)); a record that names
  one but fails authentication or is from another format revision is an
  EvidenceIntegrityError carrying the recreate guidance, never undefined.
- Direct analysis retains that refusal as a secondary failure instead of
  silently skipping source capture; cleanup projection, source-closure
  annotation and the flutter, debugger and release-exposure recoveries use
  the same owner (the last three previously read the unauthenticated schema).
- A desktop capture.json from an earlier format is refused with the recreate
  guidance instead of "not desktop application capture Evidence".

* fix(evidence): advertise revision 2 ledger examples and rank delivery omissions by serialized size

- The obligation ledger and reconstruction coverage examples named
  evidence_format 1, which revision 2 refuses; they now use
  EVIDENCE_FORMAT_REVISION.
- MCP delivery chose which unretained recovery to omit by a parsed-storage
  lower bound clipped at the response budget. Once revision 2 subjects made
  the source record's estimate cross the budget, both candidates tied at the
  clip and the smaller source was omitted ahead of the larger completed
  observation. Candidates are now ranked by serialized size, which is what
  the budget counts.

* refactor(native): compare function snapshots by their Evidence target identity (#11450)

Function snapshots carry the subject's file target identity instead of the
duplicated subject declaration. Call paths and function comparisons compare
targets through sameTargetIdentity, so the same bytes opened at a different
raw entry point or ESP flash offset no longer count as one coordinate space:
build_call_path refuses the mix, and compare_functions no longer matches
entries by address across selections. Structural candidates and native
function matching read the architecture and digest through
evidenceFileTarget.

Refs #11417

* refactor(artifacts): compare artifact and WASM summaries by their Evidence target identity (#11461)

Artifact comparison authenticates a summary against its retained inventory
through sameTargetIdentity and rebinds the alias with the whole target,
selection included, so a flash-selected inventory summary taken under an
alias path is no longer refused. WASM comparison, the analysis view
artifact projection and the inventory root check read the digest, format
and display path through the Evidence identity accessors.

Refs #11417

* refactor(evidence): read record subjects through the identity accessors in JS, managed, ledger and bundle readers (#11470)

JavaScript application graphs, runtime reconciliation, managed inspection
and native verification sources, the record summary filter, the ledger's
residual-unknown target and bundle scope selection read the subject digest,
format and display path through evidenceFileTarget and
evidenceSubjectDisplay. No comparison changes: each reader matches one
record's facts against its own payload or a caller filter.

Refs #11417

* refactor(evidence)!: name the Evidence subject only by its target identity (#11497)

* refactor(evidence)!: name the Evidence subject only by its target identity

The subject keeps `identity` and the display facts `name` and `local_path`.
The duplicated `digest`, `format` and `architecture` members are removed; the
format-owned declaration now validates the identity itself. Readers the type
checker found move to the owner accessors; untyped reads in verify scripts,
the efficiency harness and test matchers move to `subject.identity`. The
`evidence-subject-declaration-read` text guard and its baseline are deleted.

Fixes #11473
Refs #11417

BREAKING CHANGE: the Evidence subject no longer has `digest`, `format` or
`architecture`; read `subject.identity.sha256`, `subject.identity.format` and
`subject.identity.architecture`. A record that still carries them is refused.

* test(evidence): give the Flutter verifier fixture the identity subject and check the DOL declaration without the ID

* test(evidence): drop the removed subject members from the declaration matrix and tamper fixtures

* feat(evidence)!: give every Evidence record an explicit subject identity (#11536)

* feat(evidence)!: give every Evidence record an explicit subject identity

A producer that cannot name a file passes an `unknown` target identity
with a closed reason (derived-from-linked-evidence, not-observed,
unsupported-subject) instead of no subject. The subject is non-null;
unknown subjects have no display facts. The generic missing-subject
limitation and `subjectUnavailableReason` are removed; producer-specific
explanations are ordinary limitations. Comparison identity requires the
derived unknown, and null-subject consumers ask the owner accessors.

Refs #11417

BREAKING CHANGE: every Evidence record has a subject. A record without a
file target names `subject.identity` `{ "kind": "unknown", "reason": … }`
with `name` and `local_path` null, instead of `subject: null` and the
limitation "Artifact identity is unavailable for this observation.".
Their Evidence IDs change.

* fix(evidence): name explicit unknown subjects in JavaScript callers and keep a managed graph's file subject

The verification scripts are not type-checked, so five createEvidence
callers still passed undefined (or a missing first target) after the subject
became required. They now pass unknownTarget("not-observed").

A managed application graph chose the first present input subject. Every
subject is now present, so an unknown artifact subject hid a file subject on
the member or boundary Evidence. The graph now takes the first input subject
that names a file.

* test(evidence): assert the subject kind instead of a presence the type now guarantees

Every Evidence record has a subject after this change, so test guards and
assertions that checked it for null always passed. Each now checks that the
fixture subject names a file, or is removed where a later fileIdentity,
fileSubjectTarget or fileSubjectDisplay call already requires that. Non-null
assertions on Evidence subjects are removed; analysis-view inputs, whose
subject is optional, keep an undefined check.

* test(evidence): expect the Evidence subject format under its identity

Two boundary tests still matched subject.format, which slice 2e moved into
subject.identity. toMatchObject is not type-checked against the Evidence
shape, so they failed only when run (the signature test on macOS).
2026-11-16 06:28:01 +08:00

461 lines
15 KiB
TypeScript

import { writeFile } from "node:fs/promises";
import { join } from "node:path";
import { Client, InMemoryTransport } from "@modelcontextprotocol/client";
import { afterEach, describe, expect, it } from "vitest";
import { z } from "zod";
import {
createAnalysisExecution,
type AnalysisOperationPort,
} from "../../../src/ports/AnalysisProvider.js";
import { AnalysisError } from "../../../src/domain/analysisErrorBase.js";
import { createAnalysisProfile } from "../../../src/domain/analysisProfile.js";
import { AnalysisCapabilityUnavailableError } from "../../../src/domain/analysisErrorCore.js";
import { createAnalysisExecutionEvidence } from "../../../src/domain/analysisObservation.js";
import { parseEvidence } from "../../../src/domain/evidence.js";
import { evidenceBundleSchema } from "../../../src/domain/evidenceBundle.js";
import { err, ok } from "../../../src/domain/result.js";
import { createServer } from "../../../src/server/createServer.js";
import { cleanupStoppedTraversal } from "../../../src/application/CallRelationshipTraversal.js";
import { createTestBinarySession } from "../../fixtures/binarySession.js";
import { parseMcpToolError } from "../../fixtures/mcpToolError.js";
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
import {
closeEnhancedToolResources,
connect,
jsonResult,
resources,
} from "./enhancedToolsHarness.js";
afterEach(closeEnhancedToolResources);
const provider = {
id: "fixture",
name: "Fixture analysis provider",
version: "1",
} as const;
const directions = [
["forward", "procedure_callees"],
["backward", "procedure_callers"],
] as const;
const tools = ["get_call_graph", "trace_call_path"] as const;
type Tool = (typeof tools)[number];
type Relationships = Readonly<
Record<string, readonly string[] | AnalysisError>
>;
const childFailure = (operation: string, cleanup: boolean) =>
new AnalysisCapabilityUnavailableError(
provider.id,
operation,
"child failed",
cleanup
? {
cleanup: {
reason: "worker cleanup failed",
resources: ["owned worker"],
},
}
: undefined,
);
/** Answer each selector's relationship read and record every read in order. */
const relationshipPort = (
relationships: Relationships,
reads: string[],
completeDiscovery = false,
): AnalysisOperationPort => ({
execute: async (operation, parameters) => {
const procedure = String(parameters.procedure);
if (operation === "procedure_address")
return ok(createAnalysisExecution(procedure, provider));
if (operation !== "procedure_callees" && operation !== "procedure_callers")
return ok(createAnalysisExecution(null, provider));
reads.push(`${operation}:${procedure}`);
const answer = relationships[procedure] ?? [];
return answer instanceof AnalysisError
? err(answer)
: ok(
createAnalysisExecution(answer, provider, {
relationshipCoverage: {
status: "complete",
...(completeDiscovery
? {
discovery: {
callers: { status: "complete" },
callees: { status: "complete" },
},
}
: {}),
},
}),
);
},
});
const call = (
tool: Tool,
direction: (typeof directions)[number][0],
goal = "0x4",
) => ({
name: tool,
arguments:
tool === "get_call_graph"
? { address: "0x1", direction }
: { start: "0x1", goal, direction },
});
describe.each(directions)("%s relationship reads", (direction, operation) => {
it("keeps discovery unknown when cleanup stops an otherwise complete trace", async () => {
const reads: string[] = [];
const client = await connect(
relationshipPort(
{ "0x1": ["0x2"], "0x2": childFailure(operation, true) },
reads,
true,
),
);
const response = await client.callTool(call("trace_call_path", direction));
const { error } = parseMcpToolError(response);
expect(error.code).toBe("cleanup_incomplete");
expect(reads).toEqual([`${operation}:0x1`, `${operation}:0x2`]);
expect(
parseEvidence(error.details?.partial_observation).normalized_result,
).toMatchObject({
goal_status: "unknown",
search_scope: { discovery: "unknown", observed_goal_status: "unknown" },
});
});
it.each(tools)(
"%s stops at unconfirmed cleanup and reports it with the admitted result",
async (tool) => {
const reads: string[] = [];
const client = await connect(
relationshipPort(
{
"0x1": ["0x2", "0x3"],
"0x2": childFailure(operation, true),
"0x3": ["0x4"],
},
reads,
),
);
const response = await client.callTool(call(tool, direction));
expect(reads).toEqual([`${operation}:0x1`, `${operation}:0x2`]);
const { error } = parseMcpToolError(response);
expect(error).toMatchObject({
code: "cleanup_incomplete",
details: {
operation,
cleanup: "incomplete",
resources: ["owned worker"],
cleanup_reason: "worker cleanup failed",
execution_failure: "capability_unavailable",
},
});
// Without an Evidence writer the admitted result stays inline.
const partial = parseEvidence(error.details?.partial_observation);
expect(partial).toMatchObject({
operation: tool,
confidence: "derived",
parameters: call(tool, direction).arguments,
});
// The stop names 0x2 and its one queued sibling; the formatter owns prose.
const stopped = cleanupStoppedTraversal("0x2", 1);
if (tool === "get_call_graph")
expect(partial.normalized_result).toEqual({
graph: {
"0": [
{
address: "0x1",
status: "ok",
calls: ["0x2", "0x3"],
relationship_coverage: { status: "complete" },
},
],
},
limitations: [stopped],
});
else
expect(partial.normalized_result).toMatchObject({
goal: "0x4",
goal_status: "unknown",
nodes: [
{ address: "0x1", depth: 0 },
{ address: "0x2", depth: 1 },
{ address: "0x3", depth: 1 },
],
traversal_path: [],
failures: [],
relationship_coverage: { "0x1": { status: "complete" } },
truncated: true,
residual_unknowns: [stopped],
});
},
);
it.each(tools)(
"%s keeps an ordinary expansion failure as a usable partial result",
async (tool) => {
const reads: string[] = [];
const client = await connect(
relationshipPort(
{
"0x1": ["0x2", "0x3"],
"0x2": childFailure(operation, false),
"0x3": ["0x4"],
},
reads,
),
);
const response = await client.callTool(call(tool, direction));
expect(response.isError).not.toBe(true);
expect(reads).toEqual([
`${operation}:0x1`,
`${operation}:0x2`,
`${operation}:0x3`,
...(tool === "get_call_graph" ? [`${operation}:0x4`] : []),
]);
const failed = {
address: "0x2",
error: {
code: "capability_unavailable",
details: { operation },
},
};
expect(jsonResult(response)).toMatchObject(
tool === "get_call_graph"
? {
graph: {
"1": [{ ...failed, status: "error" }, { address: "0x3" }],
},
}
: {
goal_status: "reached",
traversal_path: ["0x1", "0x3", "0x4"],
failures: [failed],
},
);
},
);
});
it.each(tools)(
"%s keeps earlier ordinary failures and dispatches nothing after a later cleanup failure",
async (tool) => {
const reads: string[] = [];
const client = await connect(
relationshipPort(
{
"0x1": ["0x2", "0x3", "0x4"],
"0x2": childFailure("procedure_callees", false),
"0x3": childFailure("procedure_callees", true),
"0x4": ["0x5"],
},
reads,
),
);
const response = await client.callTool(call(tool, "forward", "0x5"));
expect(reads).toEqual([
"procedure_callees:0x1",
"procedure_callees:0x2",
"procedure_callees:0x3",
]);
const { error } = parseMcpToolError(response);
expect(error).toMatchObject({
code: "cleanup_incomplete",
details: { resources: ["owned worker"] },
});
const partial = parseEvidence(error.details?.partial_observation);
const stopped = cleanupStoppedTraversal("0x3", 1);
const ordinary = {
address: "0x2",
error: { code: "capability_unavailable" },
};
expect(partial.normalized_result).toMatchObject(
tool === "get_call_graph"
? {
graph: {
"0": [{ address: "0x1", status: "ok" }],
"1": [{ ...ordinary, status: "error" }],
},
limitations: [stopped],
}
: {
goal_status: "unknown",
failures: [ordinary],
residual_unknowns: [
"Call relationships were unavailable for 0x2.",
stopped,
],
},
);
},
);
/** Serve one fixed provider through a production session with a committed profile. */
const openSession = async (port: AnalysisOperationPort) => {
const directory = await createTestTempDirectory("rea-call-graph-cleanup-");
const target = join(directory, "fixture.com");
await writeFile(target, Buffer.from([0xb8, 0x00, 0x4c, 0xcd, 0x21]));
const session = createTestBinarySession(
() => ({
execute: (operation, parameters, options) =>
port.execute(operation, parameters, options),
close: async () => ok(null),
}),
{
// A committed profile lets the session retain each admitted read.
resolveAnalysisProfile: async () =>
ok({ profile: createAnalysisProfile(provider, { fixture: true }) }),
},
);
const server = createServer({ kind: "session", session });
const client = new Client({ name: "call-graph-cleanup", version: "1" });
const [clientTransport, serverTransport] =
InMemoryTransport.createLinkedPair();
resources.push(client, server);
await server.connect(serverTransport);
await client.connect(clientTransport);
const opened = await client.callTool({
name: "open_binary",
arguments: { path: target, format: "dos-com" },
});
expect(opened.isError).not.toBe(true);
return { client, session };
};
/** Resolve a failure's retained partial and prove a complete export keeps it. */
const retainedPartial = async (
client: Client,
session: ReturnType<typeof createTestBinarySession>,
error: ReturnType<typeof parseMcpToolError>["error"],
) => {
const reference = z
.strictObject({
kind: z.literal("retained-evidence"),
evidence_id: z.string(),
})
.parse(error.details?.partial_observation);
const exported = await client.callTool({
name: "get_evidence_bundle",
arguments: {},
});
expect(exported.isError).not.toBe(true);
const bundle = evidenceBundleSchema.parse(
z.object({ result: z.unknown() }).parse(exported.structuredContent).result,
);
expect(bundle.records.map(({ evidence_id }) => evidence_id)).toContain(
reference.evidence_id,
);
return session.evidenceForAnalysis(reference.evidence_id);
};
it.each(tools)(
"%s retains the admitted result as session Evidence and references it",
async (tool) => {
const reads: string[] = [];
const { client, session } = await openSession(
relationshipPort(
{
"0x1": ["0x2", "0x3"],
"0x2": childFailure("procedure_callees", true),
"0x3": ["0x4"],
},
reads,
),
);
const response = await client.callTool(call(tool, "forward"));
expect(reads).toEqual(["procedure_callees:0x1", "procedure_callees:0x2"]);
const { error } = parseMcpToolError(response);
expect(error).toMatchObject({
code: "cleanup_incomplete",
details: { resources: ["owned worker"] },
});
const retained = await retainedPartial(client, session, error);
expect(retained).toMatchObject({
operation: tool,
subject: { identity: { format: "dos-com" } },
normalized_result:
tool === "get_call_graph"
? { graph: { "0": [{ address: "0x1", status: "ok" }] } }
: { goal_status: "unknown", truncated: true },
});
// The admitted read stays linked as the partial result's source.
expect(retained?.evidence_links).toHaveLength(1);
expect(
session.evidenceForAnalysis(retained?.evidence_links?.[0] ?? ""),
).toMatchObject({
operation: "procedure_callees",
parameters: { procedure: "0x1" },
});
},
);
it.each(tools)(
"%s retains a failed read's own partial Evidence instead of the workflow's",
async (tool) => {
const failure = childFailure("procedure_callees", true);
const own = createAnalysisExecutionEvidence(
"procedure_callees",
{ procedure: "0x2" },
createAnalysisExecution(["0x9"], provider),
"observed",
);
failure.retainPartialObservation(own);
const reads: string[] = [];
const { client, session } = await openSession(
relationshipPort({ "0x1": ["0x2", "0x3"], "0x2": failure }, reads),
);
const { error } = parseMcpToolError(
await client.callTool(call(tool, "forward")),
);
expect(reads).toEqual(["procedure_callees:0x1", "procedure_callees:0x2"]);
expect(error).toMatchObject({
code: "cleanup_incomplete",
details: { resources: ["owned worker"] },
});
expect(await retainedPartial(client, session, error)).toEqual(own);
},
);
it.each(tools)(
"%s stops at a root read cleanup failure without dispatching more reads",
async (tool) => {
const reads: string[] = [];
const client = await connect(
relationshipPort(
{ "0x1": childFailure("procedure_callees", true), "0x4": [] },
reads,
),
);
const { error } = parseMcpToolError(
await client.callTool(call(tool, "forward")),
);
expect(reads).toEqual(["procedure_callees:0x1"]);
expect(error.code).toBe("cleanup_incomplete");
const stopped = cleanupStoppedTraversal("0x1", 0);
expect(
parseEvidence(error.details?.partial_observation).normalized_result,
).toMatchObject(
tool === "get_call_graph"
? { graph: {}, limitations: [stopped] }
: { goal_status: "unknown", residual_unknowns: [stopped] },
);
},
);