mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 19:53:50 +00:00
* fix(mcp)!: require absolute local paths for pcap capture and debugger sessions The MCP server's working directory is not the caller's, so sibling local file contracts refuse a relative path. inspect_pcap_capture (path), start_rizin_debug_session (path, inferior_tty) and start_gdb_session (inferior_tty) admitted one and resolved it against the server's directory. They now use absoluteLocalPathStringSchema. The inspect-pcap-capture CLI command declares path as a caller path, so a relative CLI argument is still resolved against the caller's working directory before the contract sees it. debug-with-rizin and debug-with-gdb call their managers directly and are unchanged. BREAKING CHANGE: MCP calls to inspect_pcap_capture, start_rizin_debug_session and start_gdb_session with a relative path or inferior_tty are refused with invalid_request. Pass absolute paths. Fixes #11079 * test(mcp): call the debugger session tools with absolute paths * fix(cli): describe the inspect-pcap-capture path without the MCP absolute requirement The CLI resolves a relative capture path, so its help keeps the caller-path description instead of inheriting the contract's absolute wording. * test(pcap): expect the absolute-path format issue beside the empty-path bound
31 lines
1.1 KiB
TypeScript
31 lines
1.1 KiB
TypeScript
import { it } from "vitest";
|
|
|
|
import { expectConfigurationRefusal, serveCli } from "./cliServeHarness.js";
|
|
|
|
it.each([
|
|
["inspect-pcap-client"],
|
|
["inspect-pcap-capture", "/nonexistent/capture.pcap"],
|
|
// The CLI resolves a relative capture against its working directory.
|
|
["inspect-pcap-capture", "nonexistent/capture.pcap"],
|
|
])("%s names the missing Wireshark tool to configure", async (...argv) => {
|
|
const result = await serveCli([...argv, "--json"], {
|
|
REA_TSHARK_COMMAND: "/nonexistent/tshark",
|
|
REA_CAPINFOS_COMMAND: "/nonexistent/capinfos",
|
|
});
|
|
expectConfigurationRefusal(
|
|
result,
|
|
"The selected tshark executable /nonexistent/tshark could not be found",
|
|
);
|
|
expectConfigurationRefusal(result, "through absolute REA_TSHARK_COMMAND");
|
|
});
|
|
|
|
it("names a relative tool selection as configuration to fix", async () => {
|
|
const result = await serveCli(["inspect-pcap-client", "--json"], {
|
|
REA_TSHARK_COMMAND: "tshark",
|
|
});
|
|
expectConfigurationRefusal(
|
|
result,
|
|
"REA_TSHARK_COMMAND must be an absolute path to the tshark binary",
|
|
);
|
|
});
|