mirror of
https://github.com/morluto/rea.git
synced 2026-10-29 02:45:58 +00:00
Return tagged string-document parsing failures instead of fabricating one unparsed entry. Preserve XML failure reasons and publish unknown counts with partial coverage; count only examined unsupported entries in validated documents. Migrate every consumer, remove the superseded throwing XML wrapper, and retain completed failure Evidence through cancellation and failed cleanup. Adapt the document-versus-entry distinction from PR #4804 using the shared Result and XML owner. Multi-table projection and its aggregate bounds remain under review in #4777. Validation before incoming main rebase: 229 focused tests in 15 files, four baseline controls fail, static/docs checks and two source reviews. Twelve tiny actual MCP workflows and four CLI controls; authored launchers only, no real Apktool/JVM/Windows qualification. Fixes #4820 Co-authored-by: Abhay Tiwari <abhaytiwari0821@gmail.com>
204 lines
6.3 KiB
TypeScript
204 lines
6.3 KiB
TypeScript
import type { Element, Node } from "@xmldom/xmldom";
|
|
import { parseXmlDocument } from "../domain/xmlDocument.js";
|
|
import { ok, err, type Result } from "../domain/result.js";
|
|
import {
|
|
isMap,
|
|
isScalar,
|
|
parseDocument,
|
|
type Document as YamlDocument,
|
|
} from "yaml";
|
|
|
|
/** Project only the Apktool metadata fields REA publishes. */
|
|
export interface ApktoolMetadata {
|
|
readonly versionName: string | null;
|
|
readonly versionCode: string | null;
|
|
readonly minSdkVersion: string | null;
|
|
readonly targetSdkVersion: string | null;
|
|
}
|
|
|
|
const metaInfoTag = {
|
|
tag: "tag:yaml.org,2002:brut.androlib.meta.MetaInfo",
|
|
collection: "map" as const,
|
|
resolve: (map: unknown) => map,
|
|
};
|
|
|
|
/**
|
|
* Read values from Apktool's tagged metadata document. YAML's core schema
|
|
* distinguishes null from quoted strings; numeric values use their source
|
|
* range so version codes retain the spelling Apktool emitted.
|
|
*/
|
|
export const parseApktoolYml = (yml: string): ApktoolMetadata => {
|
|
const document = parseDocument(yml, {
|
|
schema: "core",
|
|
customTags: [metaInfoTag],
|
|
strict: true,
|
|
uniqueKeys: true,
|
|
});
|
|
if (document.errors.length > 0)
|
|
throw new TypeError(
|
|
`apktool.yml is not valid Apktool metadata: ${document.errors[0]?.message ?? "YAML parse error"}`,
|
|
);
|
|
if (!isMap(document.contents))
|
|
throw new TypeError("apktool.yml root must be an Apktool metadata mapping");
|
|
return {
|
|
versionName: yamlScalar(document, ["versionInfo", "versionName"], yml),
|
|
versionCode: yamlScalar(document, ["versionInfo", "versionCode"], yml),
|
|
minSdkVersion: yamlScalar(document, ["sdkInfo", "minSdkVersion"], yml),
|
|
targetSdkVersion: yamlScalar(
|
|
document,
|
|
["sdkInfo", "targetSdkVersion"],
|
|
yml,
|
|
),
|
|
};
|
|
};
|
|
|
|
/** Read the package attribute from the decoded Android manifest root. */
|
|
export const parseManifestPackage = (manifest: string): string | null => {
|
|
const parsed = parseXmlDocument(manifest, {
|
|
doctype: "allow",
|
|
lineEndings: "preserve",
|
|
});
|
|
if (!parsed.ok)
|
|
throw new TypeError(
|
|
`AndroidManifest.xml is not well-formed XML: ${parsed.error.message}`,
|
|
{ cause: parsed.error },
|
|
);
|
|
const root = parsed.value.documentElement;
|
|
if (root === null || root.nodeName !== "manifest")
|
|
throw new TypeError("AndroidManifest.xml root must be <manifest>");
|
|
return root.getAttribute("package") || null;
|
|
};
|
|
|
|
export interface DecodedStringEntry {
|
|
readonly name: string;
|
|
readonly value: string;
|
|
}
|
|
|
|
/** A whole-document failure does not establish an omitted-entry count. */
|
|
export class ApktoolStringsDocumentError extends Error {
|
|
readonly _tag = "ApktoolStringsDocumentError";
|
|
constructor(
|
|
readonly reason: "malformed" | "wrong_root",
|
|
message: string,
|
|
options?: ErrorOptions,
|
|
) {
|
|
super(message, options);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Project direct `<string>` children from decoded resources XML. DOM parsing
|
|
* identifies elements and attributes; text values are sliced from the input
|
|
* at parser-reported locations so entity spelling and whitespace are kept.
|
|
* Markup-bearing string values are omitted and counted as partial evidence.
|
|
*/
|
|
export const parseDecodedStrings = (
|
|
stringsXml: string,
|
|
): Result<
|
|
{
|
|
readonly entries: readonly DecodedStringEntry[];
|
|
readonly unparsedCount: number;
|
|
},
|
|
ApktoolStringsDocumentError
|
|
> => {
|
|
const parsed = parseXmlDocument(stringsXml, {
|
|
doctype: "allow",
|
|
lineEndings: "preserve",
|
|
});
|
|
if (!parsed.ok)
|
|
return err(
|
|
new ApktoolStringsDocumentError("malformed", parsed.error.message, {
|
|
cause: parsed.error,
|
|
}),
|
|
);
|
|
const root = parsed.value.documentElement;
|
|
if (root === null || root.nodeName !== "resources")
|
|
return err(
|
|
new ApktoolStringsDocumentError(
|
|
"wrong_root",
|
|
"String resource document root must be <resources>",
|
|
),
|
|
);
|
|
|
|
const entries: DecodedStringEntry[] = [];
|
|
let unparsedCount = 0;
|
|
const offsets = sourceLineOffsets(stringsXml);
|
|
for (const child of childNodes(root)) {
|
|
if (child.nodeType !== 1) continue;
|
|
const element = child as Element;
|
|
if (element.nodeName !== "string") continue;
|
|
const name = element.getAttribute("name");
|
|
if (name === null || name.length === 0) {
|
|
unparsedCount += 1;
|
|
continue;
|
|
}
|
|
const content = childNodes(element);
|
|
if (content.some((node) => node.nodeType !== 3 && node.nodeType !== 8)) {
|
|
unparsedCount += 1;
|
|
continue;
|
|
}
|
|
if (content.every((node) => node.nodeType === 8)) {
|
|
entries.push({ name, value: "" });
|
|
continue;
|
|
}
|
|
const value = content
|
|
.filter((node) => node.nodeType === 3)
|
|
.map((node) => {
|
|
const start = sourceOffset(node, offsets);
|
|
if (start === undefined) return null;
|
|
// A literal '<' cannot appear in well-formed XML text. Ending here
|
|
// also excludes comments after the document element from this value.
|
|
const end = stringsXml.indexOf("<", start);
|
|
if (end < start) return null;
|
|
return stringsXml.slice(start, end);
|
|
});
|
|
if (value.some((part) => part === null)) {
|
|
unparsedCount += 1;
|
|
continue;
|
|
}
|
|
entries.push({ name, value: value.join("") });
|
|
}
|
|
return ok({ entries, unparsedCount });
|
|
};
|
|
|
|
const yamlScalar = (
|
|
document: YamlDocument,
|
|
path: readonly string[],
|
|
source: string,
|
|
): string | null => {
|
|
const node = document.getIn(path, true);
|
|
if (!isScalar(node) || node.value === null) return null;
|
|
if (typeof node.value === "string") return node.value;
|
|
const range = node.range;
|
|
return range === null || range === undefined
|
|
? String(node.value)
|
|
: source.slice(range[0], range[1]);
|
|
};
|
|
|
|
const childNodes = (node: Node): Node[] => {
|
|
const children: Node[] = [];
|
|
for (let child = node.firstChild; child !== null; child = child.nextSibling)
|
|
children.push(child);
|
|
return children;
|
|
};
|
|
|
|
const sourceLineOffsets = (source: string): readonly number[] => {
|
|
const offsets = [0];
|
|
for (const match of source.matchAll(/\r\n?|\n/gu)) {
|
|
const index = match.index;
|
|
offsets.push(index + match[0].length);
|
|
}
|
|
return offsets;
|
|
};
|
|
|
|
const sourceOffset = (
|
|
node: Node,
|
|
lineOffsets: readonly number[],
|
|
): number | undefined => {
|
|
const line = node.lineNumber;
|
|
const column = node.columnNumber;
|
|
if (line === undefined || column === undefined) return undefined;
|
|
const lineStart = lineOffsets[line - 1];
|
|
return lineStart === undefined ? undefined : lineStart + column - 1;
|
|
};
|