mirror of
https://github.com/morluto/rea.git
synced 2026-11-08 15:56:35 +00:00
* fix(artifacts): describe ZIP non-entry coverage accurately * fix(process): report no remaining time after a provider deadline fires Node timers can fire while performance.now() is still a fraction of a millisecond short of the monotonic deadline. ProviderStartupDeadline then reported interruption "timeout" and an aborted signal while remainingMs() returned ceil(0.x) = 1, so polling loops guarded by remainingMs() > 0 (Hopper and Ghidra startup) could run past an elapsed deadline, and the real-timer test "aborts a bounded wait when its real monotonic deadline expires" failed intermittently in CI (expected 1 to be 0). Once the deadline's own timer has classified a timeout, report zero remaining time. A deterministic regression test fires the timer with the monotonic clock 0.4 ms short of the deadline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * style: format comparison and IDA sources --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com> Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
89 lines
3.1 KiB
TypeScript
89 lines
3.1 KiB
TypeScript
import { AsarArtifactReader } from "../AsarArtifactReader.js";
|
|
import type {
|
|
ArtifactReader,
|
|
ArtifactReaderTraversal,
|
|
} from "../ArtifactReader.js";
|
|
import { DirectoryArtifactReader } from "../DirectoryArtifactReader.js";
|
|
import { MachOSliceArtifactReader } from "../MachOSliceArtifactReader.js";
|
|
import { NativeDmgArtifactReader } from "../NativeDmgArtifactReader.js";
|
|
import { ZipArtifactReader } from "../ZipArtifactReader.js";
|
|
import type {
|
|
ArtifactInventoryCoverage,
|
|
ArtifactOccurrence,
|
|
} from "../../domain/artifactGraph.js";
|
|
import {
|
|
isZipPackageFormat,
|
|
ZIP_NON_ENTRY_LIMITATION,
|
|
} from "../../domain/zipPackageFormat.js";
|
|
import type { StableRegularFileDescriptor } from "../../filesystem/RegularFile.js";
|
|
|
|
export const createReader = (
|
|
path: string,
|
|
format: ArtifactOccurrence["artifact_format"],
|
|
environment: Readonly<NodeJS.ProcessEnv>,
|
|
rootSource?: StableRegularFileDescriptor,
|
|
): ArtifactReader | undefined => {
|
|
if (isZipPackageFormat(format))
|
|
return new ZipArtifactReader(path, format, undefined, rootSource);
|
|
switch (format) {
|
|
case "directory":
|
|
return new DirectoryArtifactReader(path);
|
|
case "asar":
|
|
return new AsarArtifactReader(path);
|
|
case "mach-o-universal":
|
|
return process.platform === "darwin"
|
|
? new MachOSliceArtifactReader(path, environment, undefined, rootSource)
|
|
: undefined;
|
|
case "dmg":
|
|
if (process.platform !== "darwin") return undefined;
|
|
return new NativeDmgArtifactReader(path, environment);
|
|
default:
|
|
return undefined;
|
|
}
|
|
};
|
|
|
|
/** Decide traversal scope and availability once, independently of diagnostic wording. */
|
|
export const inventoryCoverage = (
|
|
format: ArtifactOccurrence["artifact_format"],
|
|
reader: ArtifactReader | undefined,
|
|
traversal: ArtifactReaderTraversal,
|
|
): {
|
|
readonly coverage: ArtifactInventoryCoverage;
|
|
readonly limitations: string[];
|
|
} => {
|
|
if (reader !== undefined)
|
|
return {
|
|
coverage: { scope: "container-entries", status: traversal.status },
|
|
limitations: [
|
|
...(isZipPackageFormat(reader.format)
|
|
? [ZIP_NON_ENTRY_LIMITATION]
|
|
: []),
|
|
...traversal.limitations,
|
|
],
|
|
};
|
|
// dmg and pkg reach here only after classifyRootFormat matched their bytes.
|
|
if (format === "dmg" || format === "pkg")
|
|
return {
|
|
coverage: { scope: "container-entries", status: "unknown" },
|
|
limitations: [
|
|
`${format.toUpperCase()} root hash is observed; child inventory requires a native macOS adapter.`,
|
|
],
|
|
};
|
|
if (format === "mach-o-universal")
|
|
return {
|
|
coverage: { scope: "container-entries", status: "unknown" },
|
|
limitations: [
|
|
"Universal Mach-O slices require the native macOS lipo adapter.",
|
|
],
|
|
};
|
|
if (isZipPackageFormat(format) || format === "directory" || format === "asar")
|
|
return {
|
|
coverage: { scope: "container-entries", status: "unknown" },
|
|
limitations: [`${format} child inventory reader is unavailable.`],
|
|
};
|
|
return {
|
|
coverage: { scope: "root", status: "complete" },
|
|
limitations: ["Artifact has no child container entries."],
|
|
};
|
|
};
|