Files
reverse-engineering-anything/src/domain/javascript/javascriptSemanticAnalysis.scope_depth.test.ts
T
Kaoru0822andClaude Opus 5.5 81afb043f7 fix(javascript): evaluate each short-circuit left operand once (#7126)
Logical branch selection evaluated the left operand to decide which
branches stay reachable, and value evaluation then evaluated the selected
left branch again. In a left-nested `a || b || c ...` chain every level
repeated that, so semantic analysis doubled per operand and a 24-operand
chain exhausted the per-source deadline.

The selection now carries the left operand's value with the branch, and
value evaluation reuses it. Provenance still walks the branch nodes.
Results are unchanged.

Fixes #7115

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 05:25:54 -07:00

248 lines
7.9 KiB
TypeScript

import * as t from "@babel/types";
import { expect, it, vi } from "vitest";
import {
analyzeJavaScriptSemantics,
analyzeParsedJavaScriptSemantics,
} from "./javascriptSemanticAnalysis.js";
import { onlyBinding } from "./javascriptSemanticAnalysis.fixture.js";
import type { JavaScriptSemanticIr } from "./javascriptSemanticIr.js";
import { traverseJavaScriptAst } from "./javascriptSemanticTraversal.js";
import { parseJavaScriptSource } from "./javascriptSourceParser.js";
/** Count AST ancestry lookups made while analyzing one source. */
const ancestryReads = (
source: string,
inspect: (ir: JavaScriptSemanticIr) => void,
): number => {
const original = WeakMap.prototype.get;
let reads = 0;
const get = vi.spyOn(WeakMap.prototype, "get").mockImplementation(function (
this: WeakMap<object, unknown>,
key,
) {
const value: unknown = original.call(this, key);
if (
typeof value === "object" &&
value !== null &&
"type" in value &&
typeof value.type === "string"
)
reads++;
return value;
});
try {
inspect(analyzeJavaScriptSemantics(source));
return reads;
} finally {
get.mockRestore();
}
};
it.each(["const a=1;", "let a; a=1;"])(
"bounds ancestry reads for repeated deep lexical references after %s",
(declaration) => {
const reads = (depth: number): number =>
ancestryReads(
`${declaration} module.exports.value=${"a+(".repeat(depth)}a${")".repeat(depth)};`,
(ir) => {
expect(ir.coverage).toEqual({ status: "complete", omittedCount: 0 });
expect(onlyBinding(ir, "a").value).toEqual({
status: "literal",
value: 1,
});
},
);
const smaller = reads(80);
const larger = reads(160);
expect(smaller).toBeGreaterThan(0);
expect(larger).toBeLessThan(3 * smaller);
},
);
it("bounds ancestry reads after a write in the same expression", () => {
const reads = (depth: number): number =>
ancestryReads(
`let a=0; module.exports.value={set:(a=1),value:${"a+(".repeat(depth)}a${")".repeat(depth)}};`,
(ir) => {
expect(ir.coverage).toEqual({ status: "complete", omittedCount: 0 });
expect(onlyBinding(ir, "a").value.status).toBe("ambiguous");
},
);
const smaller = reads(80);
const larger = reads(160);
expect(smaller).toBeGreaterThan(0);
expect(larger).toBeLessThan(3 * smaller);
});
it.each([
[
"object",
(index: number) => `var s${String(index + 1)}={x:s${String(index)}};`,
],
[
"array",
(index: number) => `var s${String(index + 1)}=[s${String(index)}];`,
],
[
"sequence-assigned object",
(index: number) =>
`var s${String(index + 1)}; 0, s${String(index + 1)}={x:s${String(index)}};`,
],
])(
"keeps the expression depth budget across a chain of %s wrappers",
(_, wrap) => {
// Reusing each wrapper's value for the next would nest without limit.
const nesting = (length: number): number => {
const ir = analyzeJavaScriptSemantics(
`var s0={};${Array.from({ length: length - 1 }, (unused, index) => wrap(index)).join("")}`,
);
let value = onlyBinding(ir, `s${String(length - 1)}`).value;
let depth = 0;
while (value.status === "object" || value.status === "array") {
const [slot] =
value.status === "object" ? value.properties : value.items;
if (slot === undefined) return depth;
value = slot.value;
depth++;
}
expect(value).toMatchObject({ resourceLimit: "expression-depth" });
expect(ir.coverage.status).toBe("partial");
return depth;
};
expect(nesting(40)).toBe(39);
const bounded = nesting(300);
expect(bounded).toBeLessThan(256);
expect(nesting(600)).toBe(bounded);
},
);
it.each([
["an object", "{ value: 1 }", "object"],
["a self-referential namespace", "s0 || {}", "ambiguous"],
["an unknown parameter", "seed", "unknown"],
])(
"bounds nested closures that alias %s from the enclosing scope",
(_, root, status) => {
// Each closure reads its parent's local once live and once at its own
// capture point; re-deriving the parent each time doubles work per level.
const reads = (depth: number): number =>
ancestryReads(
`function f0(seed){ var s0=${root};${Array.from(
{ length: depth - 1 },
(unused, index) =>
` function f${String(index + 1)}(){ var s${String(index + 1)}=s${String(index)};`,
).join("")}${"}".repeat(depth)}`,
(ir) => {
expect(ir.coverage).toEqual({ status: "complete", omittedCount: 0 });
expect(onlyBinding(ir, `s${String(depth - 1)}`).value).toEqual(
onlyBinding(ir, "s1").value,
);
expect(onlyBinding(ir, "s1").value.status).toBe(status);
},
);
const smaller = reads(8);
const larger = reads(16);
expect(smaller).toBeGreaterThan(0);
// Doubling per level would multiply the reads by 256.
expect(larger).toBeLessThan(8 * smaller);
},
);
/** Count reads of short-circuit left operands while analyzing one source. */
const logicalOperandReads = (
source: string,
inspect: (ir: JavaScriptSemanticIr) => void,
): number => {
const file = parseJavaScriptSource(source);
if (file === null) throw new Error("fixture must parse");
let reads = 0;
traverseJavaScriptAst(file, {
enter: (node) => {
if (!t.isLogicalExpression(node)) return;
const left = node.left;
Object.defineProperty(node, "left", {
enumerable: true,
configurable: true,
get: () => {
reads++;
return left;
},
});
},
});
reads = 0;
inspect(analyzeParsedJavaScriptSemantics(file));
return reads;
};
/** A left-nested chain `o0 op1 o1 op2 o2 ...` as written in tokenizers. */
const logicalChain = (
length: number,
operand: (index: number) => string,
operator: (index: number) => string,
): string =>
Array.from({ length: length - 1 }, (unused, index) => index + 1).reduce(
(chain, index) => `(${chain}) ${operator(index)} ${operand(index)}`,
operand(0),
);
const call = (index: number): string => `f${String(index)}(s)`;
it.each([
["||", call, () => "||"],
["&&", (index: number) => `s.k${String(index)}`, () => "&&"],
["??", call, () => "??"],
[
"mixed ||/&&/?? and conditional",
(index: number) =>
index % 4 === 0
? `(s.k ? ${call(index)} : s.k${String(index)})`
: call(index),
(index: number) => ["||", "&&", "??"][index % 3] ?? "||",
],
])(
"reads each operand of a long %s chain a bounded number of times",
(_, operand, operator) => {
// Logical branch selection evaluates the left operand. Evaluating it again
// as a value branch at every level doubles the work per operand.
const reads = (length: number): number =>
logicalOperandReads(
`function next(s){ var tok=${logicalChain(length, operand, operator)}; return tok; } module.exports=next;`,
(ir) => {
expect(ir.coverage).toEqual({ status: "complete", omittedCount: 0 });
expect(onlyBinding(ir, "tok").value.status).not.toBe("literal");
},
);
const smaller = reads(8);
const larger = reads(16);
expect(smaller).toBeGreaterThan(0);
// Doubling per operand would multiply the reads by 256.
expect(larger).toBeLessThan(4 * smaller);
},
);
it("keeps established logical operands across a long chain", () => {
// Known-falsy operands select the right branch at every level; the value and
// provenance must still come from the one reachable operand.
const ir = analyzeJavaScriptSemantics(
`const tok = ${'false || null || 0 || "" || '.repeat(10)}require("electron").app;`,
);
expect(ir.coverage).toEqual({ status: "complete", omittedCount: 0 });
expect(onlyBinding(ir, "tok").provenance).toEqual({
status: "module",
origins: [
{
specifier: "electron",
importedPath: ["app"],
resolutionMode: "require",
},
],
reason: null,
});
});