mirror of
https://github.com/morluto/rea.git
synced 2026-10-30 03:15:54 +00:00
morluto
cbc0dd1e7c
* fix(contracts)!: require absolute local paths for remaining caller-supplied file inputs Follow-up to the session snapshot/export tightening: the same invisible server-cwd resolution applied to open_binary target paths (parseBinaryTarget(path, process.cwd())), import_evidence_bundle bundle reads, firmware input files (resolve(raw)), browser executable launch paths (resolve-then-spawn), Electron executable/application/root paths (realpath on raw input), and the expected server path check. Each field gains the shared isAbsoluteLocalPath refinement plus a catalog-visible description, since JSON Schema cannot express the rule. Examples, scenario fixtures, and contract tests updated to absolute paths; new schema cases cover rejection/acceptance/omission per field. Explicitly unchanged (verified rooted or out of scope): inspect_plist paths (resolved against the target bundle dir), firmware output_directory (already provider-enforced), filesystem observation paths (resolved against the caller-supplied working_directory), keyed-archive member paths (archive-relative), JS evidence member paths (evidence-relative under root_alias), provider-internal execution schemas, CLI-only doctor flows, and CLI options (own resolve against the operator cwd). * fix(cli): resolve operator-relative paths before shared absolute-path validation The contract tightening rejects relative paths, but three CLI commands forward operator-relative input into the shared schemas: firmware commands pass raw args to FirmwareAnalysisService, and the Electron/browser scenario commands validate parsed scenario JSON directly. CLI paths are relative to the operator shell, so resolve them against the working directory first: resolve() in firmwareCommands, and a shared resolveCliJsonPaths JSON key-path helper (cliJsonInput) applied in electronCommands and cliBrowserScenarioCommands. MCP behavior is unchanged — MCP callers must still send absolute paths. Covers the regression with a relative-path firmware CLI acceptance test (asserts provider-stage capability_unavailable, not a validation error) and unit tests for the helper.
90 lines
3.4 KiB
TypeScript
90 lines
3.4 KiB
TypeScript
import { z } from "zod";
|
|
|
|
import { isAbsoluteLocalPath } from "../domain/localPath.js";
|
|
|
|
import { artifactComparisonInputSchema } from "../domain/artifactComparison.js";
|
|
import { bundleComparisonInputSchema } from "../domain/bundleComparison.js";
|
|
import { callPathInputSchema } from "../domain/callPath.js";
|
|
import { changedBehaviorInputSchema } from "../domain/changedBehavior.js";
|
|
import { functionComparisonInputSchema } from "../domain/functionComparison.js";
|
|
import { jsonValueSchema } from "../domain/jsonValue.js";
|
|
import { processScenarioSchema } from "../domain/process/processCapture.js";
|
|
import { processTraceSpecificationSchema } from "../domain/process/processTraceComparison.js";
|
|
import { recordUnknownInputSchema } from "../domain/residualUnknown.js";
|
|
import { reconstructionVerificationInputSchema } from "../domain/reconstructionVerification.js";
|
|
import { staticRuntimeCorrelationInputSchema } from "../domain/staticRuntimeCorrelation.js";
|
|
import { evidenceSchema } from "../domain/evidence.js";
|
|
import { updateUnknownInputSchema } from "../domain/residualUnknown.js";
|
|
import {
|
|
openBinaryInputSchema,
|
|
closeBinaryInputSchema,
|
|
} from "./sessionLifecycleInputs.js";
|
|
import { binarySessionInputSchema } from "./sessionStatusContract.js";
|
|
import { prefixedDigestSchema } from "./../domain/digests.js";
|
|
|
|
/** Return the current canonical Evidence bundle inline. */
|
|
export const getEvidenceBundleInputSchema = z.strictObject({});
|
|
|
|
/** Optional document selection for volatile navigation context. */
|
|
export const navigationContextInputSchema = z.strictObject({
|
|
document: z.string().min(1).optional(),
|
|
});
|
|
|
|
/** Explicit reproducible address context query. */
|
|
export const addressContextInputSchema = z.strictObject({
|
|
address: z.string().min(1),
|
|
document: z.string().min(1).optional(),
|
|
});
|
|
|
|
/** Session-owned Evidence bundle import options. */
|
|
export const importEvidenceBundleInputSchema = z.strictObject({
|
|
path: z
|
|
.string()
|
|
.min(1)
|
|
.refine(isAbsoluteLocalPath, {
|
|
message:
|
|
"path must be an absolute local filesystem path (for example /tmp/evidence.json or C:\\rea\\evidence.json)",
|
|
})
|
|
.describe(
|
|
"Absolute local filesystem path for the evidence bundle to import; relative paths are rejected.",
|
|
),
|
|
});
|
|
|
|
/** Evidence references for deterministic process comparison. */
|
|
export const processComparisonInputSchema = z.strictObject({
|
|
left: evidenceSchema,
|
|
right: evidenceSchema,
|
|
trace_spec: processTraceSpecificationSchema.optional(),
|
|
max_capture_age_ms: z.number().int().nonnegative().optional(),
|
|
});
|
|
|
|
/** Residual-unknown list filters. */
|
|
export const listUnknownsInputSchema = z.strictObject({
|
|
status: z
|
|
.enum(["open", "investigating", "blocked", "contradicted", "resolved"])
|
|
.optional(),
|
|
severity: z.enum(["low", "medium", "high", "critical"]).optional(),
|
|
domain: z.string().trim().min(1).optional(),
|
|
});
|
|
|
|
/** Exact residual-unknown identity to revalidate. */
|
|
export const verifyUnknownResolutionInputSchema = z.strictObject({
|
|
unknown_id: prefixedDigestSchema("unk"),
|
|
});
|
|
|
|
export {
|
|
artifactComparisonInputSchema,
|
|
binarySessionInputSchema,
|
|
bundleComparisonInputSchema,
|
|
callPathInputSchema,
|
|
changedBehaviorInputSchema,
|
|
closeBinaryInputSchema,
|
|
functionComparisonInputSchema,
|
|
openBinaryInputSchema,
|
|
processScenarioSchema,
|
|
reconstructionVerificationInputSchema,
|
|
recordUnknownInputSchema,
|
|
staticRuntimeCorrelationInputSchema,
|
|
updateUnknownInputSchema,
|
|
};
|