mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 11:43:20 +00:00
* feat(evidence)!: name the Evidence subject by its target identity (format revision 2) The Evidence subject carries subject.identity (kind, sha256, format, architecture, selection) and the Evidence ID commits to it, so raw/DOL entry points and ESP flash offsets of the same bytes are different subjects. Every record declares evidence_format: 2; revision 1 bundles, standalone records and snapshots are refused with the recreate guidance. binaryTargetIdentity is the one projection of an open target, used by Evidence and snapshot comparison. BREAKING CHANGE: Evidence format revision 2. Evidence IDs commit to the subject's target identity (subject.identity, including the raw/DOL entry point or ESP flash offsets), and every record declares evidence_format: 2. Evidence bundles, records and analysis snapshots from earlier releases are refused; recreate the observations with this release. * refactor(analysis-view): read parent subjects through the Evidence identity accessors (#11423) Analysis views compare their parent's file identity (evidenceFileTarget) and take path and digest from evidenceSubjectTarget instead of reading the subject's digest, format and architecture members, which duplicate subject.identity until they are removed. A counted guard (evidence-subject-declaration-read) keeps new direct reads out and records the 20 remaining files. * fix(evidence): carry format refusals through Evidence readers and bind target selections - safeParseEvidence/safeParseImmutableEvidence return the format refusal as an expected failure; every consumer maps it to the one integrity refusal with the recreate guidance. An unmarked object is an earlier record only when it has every member records have always carried. - ArtifactProvider inventory roots and provider subjects that name the target's own bytes carry the target's selection (ESP flash offsets). - Snapshot rows bind only Evidence whose identity, selection included, matches the snapshot target. - Entry-point selections use the raw-binary entry point form. * fix(evidence): refuse unauthenticated or earlier-format records instead of reading them as absent - recognizeEvidence (evidenceValidation) replaces tryParseEvidence: input without an evidence_id is not Evidence (ok(undefined)); a record that names one but fails authentication or is from another format revision is an EvidenceIntegrityError carrying the recreate guidance, never undefined. - Direct analysis retains that refusal as a secondary failure instead of silently skipping source capture; cleanup projection, source-closure annotation and the flutter, debugger and release-exposure recoveries use the same owner (the last three previously read the unauthenticated schema). - A desktop capture.json from an earlier format is refused with the recreate guidance instead of "not desktop application capture Evidence". * fix(evidence): advertise revision 2 ledger examples and rank delivery omissions by serialized size - The obligation ledger and reconstruction coverage examples named evidence_format 1, which revision 2 refuses; they now use EVIDENCE_FORMAT_REVISION. - MCP delivery chose which unretained recovery to omit by a parsed-storage lower bound clipped at the response budget. Once revision 2 subjects made the source record's estimate cross the budget, both candidates tied at the clip and the smaller source was omitted ahead of the larger completed observation. Candidates are now ranked by serialized size, which is what the budget counts. * refactor(native): compare function snapshots by their Evidence target identity (#11450) Function snapshots carry the subject's file target identity instead of the duplicated subject declaration. Call paths and function comparisons compare targets through sameTargetIdentity, so the same bytes opened at a different raw entry point or ESP flash offset no longer count as one coordinate space: build_call_path refuses the mix, and compare_functions no longer matches entries by address across selections. Structural candidates and native function matching read the architecture and digest through evidenceFileTarget. Refs #11417 * refactor(artifacts): compare artifact and WASM summaries by their Evidence target identity (#11461) Artifact comparison authenticates a summary against its retained inventory through sameTargetIdentity and rebinds the alias with the whole target, selection included, so a flash-selected inventory summary taken under an alias path is no longer refused. WASM comparison, the analysis view artifact projection and the inventory root check read the digest, format and display path through the Evidence identity accessors. Refs #11417 * refactor(evidence): read record subjects through the identity accessors in JS, managed, ledger and bundle readers (#11470) JavaScript application graphs, runtime reconciliation, managed inspection and native verification sources, the record summary filter, the ledger's residual-unknown target and bundle scope selection read the subject digest, format and display path through evidenceFileTarget and evidenceSubjectDisplay. No comparison changes: each reader matches one record's facts against its own payload or a caller filter. Refs #11417 * refactor(evidence)!: name the Evidence subject only by its target identity (#11497) * refactor(evidence)!: name the Evidence subject only by its target identity The subject keeps `identity` and the display facts `name` and `local_path`. The duplicated `digest`, `format` and `architecture` members are removed; the format-owned declaration now validates the identity itself. Readers the type checker found move to the owner accessors; untyped reads in verify scripts, the efficiency harness and test matchers move to `subject.identity`. The `evidence-subject-declaration-read` text guard and its baseline are deleted. Fixes #11473 Refs #11417 BREAKING CHANGE: the Evidence subject no longer has `digest`, `format` or `architecture`; read `subject.identity.sha256`, `subject.identity.format` and `subject.identity.architecture`. A record that still carries them is refused. * test(evidence): give the Flutter verifier fixture the identity subject and check the DOL declaration without the ID * test(evidence): drop the removed subject members from the declaration matrix and tamper fixtures * feat(evidence)!: give every Evidence record an explicit subject identity (#11536) * feat(evidence)!: give every Evidence record an explicit subject identity A producer that cannot name a file passes an `unknown` target identity with a closed reason (derived-from-linked-evidence, not-observed, unsupported-subject) instead of no subject. The subject is non-null; unknown subjects have no display facts. The generic missing-subject limitation and `subjectUnavailableReason` are removed; producer-specific explanations are ordinary limitations. Comparison identity requires the derived unknown, and null-subject consumers ask the owner accessors. Refs #11417 BREAKING CHANGE: every Evidence record has a subject. A record without a file target names `subject.identity` `{ "kind": "unknown", "reason": … }` with `name` and `local_path` null, instead of `subject: null` and the limitation "Artifact identity is unavailable for this observation.". Their Evidence IDs change. * fix(evidence): name explicit unknown subjects in JavaScript callers and keep a managed graph's file subject The verification scripts are not type-checked, so five createEvidence callers still passed undefined (or a missing first target) after the subject became required. They now pass unknownTarget("not-observed"). A managed application graph chose the first present input subject. Every subject is now present, so an unknown artifact subject hid a file subject on the member or boundary Evidence. The graph now takes the first input subject that names a file. * test(evidence): assert the subject kind instead of a presence the type now guarantees Every Evidence record has a subject after this change, so test guards and assertions that checked it for null always passed. Each now checks that the fixture subject names a file, or is removed where a later fileIdentity, fileSubjectTarget or fileSubjectDisplay call already requires that. Non-null assertions on Evidence subjects are removed; analysis-view inputs, whose subject is optional, keep an undefined check. * test(evidence): expect the Evidence subject format under its identity Two boundary tests still matched subject.format, which slice 2e moved into subject.identity. toMatchObject is not type-checked against the Evidence shape, so they failed only when run (the signature test on macOS).
672 lines
23 KiB
TypeScript
672 lines
23 KiB
TypeScript
import { EventEmitter } from "node:events";
|
|
import { open, writeFile, type FileHandle } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { expect, it, onTestFinished, vi } from "vitest";
|
|
import { projectAnalysisError } from "../domain/analysisErrorProjection.js";
|
|
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
|
|
import { NativeMacOSProvider } from "./NativeMacOSProvider.js";
|
|
import {
|
|
NativeCommandFailure,
|
|
XcrunCommandRunner,
|
|
} from "../providers/NativeCommandRunner.js";
|
|
import { ProviderProcessSupervisor } from "../process/ProviderProcess.js";
|
|
import { err } from "../domain/result.js";
|
|
import { primaryAnalysisError } from "../domain/analysisErrorBase.js";
|
|
import { MachoCommandNamesLimitError } from "../domain/apple/machoCommandNames.js";
|
|
import {
|
|
NativeFixtureRunner,
|
|
nativeMachoTargetForFile,
|
|
} from "../../tests/fixtures/nativeCommands.js";
|
|
import { createTestTempDirectory } from "../../tests/fixtures/temporaryDirectory.js";
|
|
import { inspectionImage } from "./NativeMachoInspection.fixture.js";
|
|
|
|
const control = vi.hoisted(() => ({
|
|
read: undefined as undefined | (() => Promise<never>),
|
|
}));
|
|
|
|
it.each(
|
|
(["inspect_macho", "list_architectures"] as const).flatMap((operation) =>
|
|
[false, true].map((cancelDuringClose) => ({
|
|
operation,
|
|
cancelDuringClose,
|
|
})),
|
|
),
|
|
)(
|
|
"retains verified $operation evidence through close retry (late cancellation: $cancelDuringClose)",
|
|
async ({ operation, cancelDuringClose }) => {
|
|
const root = await createTestTempDirectory("rea-macho-completed-close-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, inspectionImage());
|
|
const target = await nativeMachoTargetForFile(path);
|
|
const probe = await open(path, "r");
|
|
const prototype = Object.getPrototypeOf(probe) as FileHandle;
|
|
await probe.close();
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({
|
|
lipo: `Non-fat file: ${path} is architecture: arm64\n`,
|
|
}),
|
|
"darwin",
|
|
).createClient(target);
|
|
const controller = new AbortController();
|
|
const reason = new Error("cancelled during descriptor close");
|
|
const state = { failing: true, attempts: 0 };
|
|
const original = prototype.stat;
|
|
const stat = vi
|
|
.spyOn(prototype, "stat")
|
|
.mockImplementationOnce(async function (
|
|
this: FileHandle,
|
|
...args: Parameters<FileHandle["stat"]>
|
|
) {
|
|
const close = this.close.bind(this);
|
|
this.close = async () => {
|
|
state.attempts += 1;
|
|
if (state.failing) {
|
|
if (cancelDuringClose) controller.abort(reason);
|
|
throw new Error("controlled descriptor close failure");
|
|
}
|
|
await close();
|
|
};
|
|
return Reflect.apply(original, this, args);
|
|
});
|
|
onTestFinished(async () => {
|
|
stat.mockRestore();
|
|
state.failing = false;
|
|
await client.close();
|
|
});
|
|
const result = await client.execute(
|
|
operation,
|
|
{ native_command_timeout_ms: 5000 },
|
|
{ signal: controller.signal },
|
|
);
|
|
if (result.ok) throw new Error("Expected cleanup failure");
|
|
expect(result.error).toBeInstanceOf(ProviderCleanupError);
|
|
if (!(result.error instanceof ProviderCleanupError))
|
|
throw new Error("Expected provider cleanup failure");
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources).toEqual([path]);
|
|
expect(result.error.partialObservation).toMatchObject({
|
|
operation,
|
|
parameters: { native_command_timeout_ms: 5000 },
|
|
subject: { local_path: path, identity: { sha256: target.sha256 } },
|
|
normalized_result: { provenance: expect.any(Array) },
|
|
locations: expect.any(Array),
|
|
});
|
|
if (cancelDuringClose) {
|
|
expect(result.error.completedObservation).toBeUndefined();
|
|
expect(result.error.cleanupPrimary).toMatchObject({
|
|
_tag: "AnalysisCancelledError",
|
|
cause: reason,
|
|
partialObservation: result.error.partialObservation,
|
|
});
|
|
expect(result.error.diagnostics?.previous_error).not.toHaveProperty(
|
|
"details.partial_observation",
|
|
);
|
|
} else {
|
|
expect(result.error.cleanupPrimary).toBeUndefined();
|
|
expect(result.error.completedObservation).toEqual(
|
|
result.error.partialObservation,
|
|
);
|
|
}
|
|
expect(
|
|
projectAnalysisError(result.error).details?.partial_observation,
|
|
).toEqual(result.error.partialObservation);
|
|
state.failing = false;
|
|
expect((await client.close()).ok).toBe(true);
|
|
expect(state.attempts).toBe(2);
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
expect(result.error.partialObservation).toBeDefined();
|
|
if (cancelDuringClose)
|
|
expect(result.error.cleanupPrimary?.partialObservation).toEqual(
|
|
result.error.partialObservation,
|
|
);
|
|
},
|
|
);
|
|
|
|
it.each(
|
|
(["inspect_macho", "list_architectures"] as const).flatMap((operation) =>
|
|
[false, true].map((producerFails) => ({ operation, producerFails })),
|
|
),
|
|
)(
|
|
"retains the $operation producer outcome when cancellation arrives during successful close (producer fails: $producerFails)",
|
|
async ({ operation, producerFails }) => {
|
|
const root = await createTestTempDirectory("rea-macho-cancel-close-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, inspectionImage());
|
|
const target = await nativeMachoTargetForFile(path);
|
|
const probe = await open(path, "r");
|
|
const prototype = Object.getPrototypeOf(probe) as FileHandle;
|
|
await probe.close();
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({
|
|
lipo: producerFails
|
|
? "unrecognized producer output\n"
|
|
: `Non-fat file: ${path} is architecture: arm64\n`,
|
|
}),
|
|
"darwin",
|
|
).createClient(target);
|
|
const controller = new AbortController();
|
|
const reason = new Error("cancelled during successful close");
|
|
const original = prototype.stat;
|
|
const stat = vi
|
|
.spyOn(prototype, "stat")
|
|
.mockImplementationOnce(async function (
|
|
this: FileHandle,
|
|
...args: Parameters<FileHandle["stat"]>
|
|
) {
|
|
const close = this.close.bind(this);
|
|
this.close = async () => {
|
|
controller.abort(reason);
|
|
await close();
|
|
};
|
|
return Reflect.apply(original, this, args);
|
|
});
|
|
onTestFinished(async () => {
|
|
stat.mockRestore();
|
|
await client.close();
|
|
});
|
|
const result = await client.execute(
|
|
operation,
|
|
{},
|
|
{ signal: controller.signal },
|
|
);
|
|
if (result.ok) throw new Error("Expected cancellation");
|
|
expect(result.error).toMatchObject({
|
|
_tag: "AnalysisCancelledError",
|
|
cause: reason,
|
|
cleanupIncomplete: false,
|
|
});
|
|
if (producerFails) {
|
|
expect(result.error.partialObservation).toBeUndefined();
|
|
expect(projectAnalysisError(result.error)).toMatchObject({
|
|
details: {
|
|
diagnostics: {
|
|
previous_error: {
|
|
code: "unreadable_output",
|
|
details: {
|
|
captured_output: { stdout: "unrecognized producer output\n" },
|
|
},
|
|
},
|
|
},
|
|
},
|
|
});
|
|
} else {
|
|
expect(result.error.partialObservation).toMatchObject({
|
|
operation,
|
|
subject: { local_path: path, identity: { sha256: target.sha256 } },
|
|
normalized_result: { provenance: expect.any(Array) },
|
|
});
|
|
}
|
|
expect((await client.close()).ok).toBe(true);
|
|
},
|
|
);
|
|
vi.mock("../domain/apple/machoCommandNames.js", async (importOriginal) => {
|
|
const actual =
|
|
await importOriginal<
|
|
typeof import("../domain/apple/machoCommandNames.js")
|
|
>();
|
|
return {
|
|
...actual,
|
|
readMachoCommandNames: (
|
|
...args: Parameters<typeof actual.readMachoCommandNames>
|
|
) =>
|
|
control.read === undefined
|
|
? actual.readMachoCommandNames(...args)
|
|
: control.read(),
|
|
};
|
|
});
|
|
|
|
it("reports target mutation after a throwing binary reader and retains the producer failure", async () => {
|
|
const root = await createTestTempDirectory("rea-macho-target-mutation-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, "selected source bytes");
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({
|
|
lipo: `Non-fat file: ${path} is architecture: arm64\n`,
|
|
}),
|
|
"darwin",
|
|
).createClient(await nativeMachoTargetForFile(path));
|
|
control.read = async () => {
|
|
await writeFile(path, "changed source bytes!");
|
|
throw new MachoCommandNamesLimitError(23, "records");
|
|
};
|
|
try {
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (result.ok) throw new Error("Expected target mutation refusal");
|
|
expect(result.error._tag).toBe("AnalysisArtifactChangedError");
|
|
expect(projectAnalysisError(result.error)).toMatchObject({
|
|
details: {
|
|
diagnostics: {
|
|
previous_error: {
|
|
code: "resource_constraint",
|
|
details: { operation: "inspect_macho" },
|
|
},
|
|
},
|
|
},
|
|
});
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
} finally {
|
|
control.read = undefined;
|
|
await client.close();
|
|
}
|
|
});
|
|
|
|
it("retains cancellation and a throwing reader's failure through final verification", async () => {
|
|
const root = await createTestTempDirectory("rea-macho-reader-cancel-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, "selected source bytes");
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({
|
|
lipo: `Non-fat file: ${path} is architecture: arm64\n`,
|
|
}),
|
|
"darwin",
|
|
).createClient(await nativeMachoTargetForFile(path));
|
|
const controller = new AbortController();
|
|
const reason = new Error("cancel after reader failure");
|
|
control.read = async () => {
|
|
controller.abort(reason);
|
|
throw new MachoCommandNamesLimitError(23, "records");
|
|
};
|
|
try {
|
|
const result = await client.execute(
|
|
"inspect_macho",
|
|
{},
|
|
{ signal: controller.signal },
|
|
);
|
|
if (result.ok) throw new Error("Expected cancellation");
|
|
expect(result.error._tag).toBe("AnalysisCancelledError");
|
|
expect(projectAnalysisError(result.error)).toMatchObject({
|
|
details: {
|
|
diagnostics: { previous_error: { code: "resource_constraint" } },
|
|
},
|
|
});
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
} finally {
|
|
control.read = undefined;
|
|
await client.close();
|
|
}
|
|
});
|
|
|
|
it("retains mutation and reader failure while descriptor cleanup is retried", async () => {
|
|
const root = await createTestTempDirectory("rea-macho-reader-close-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, "selected source bytes");
|
|
const target = await nativeMachoTargetForFile(path);
|
|
const probe = await open(path, "r");
|
|
const prototype = Object.getPrototypeOf(probe) as FileHandle;
|
|
await probe.close();
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({
|
|
lipo: `Non-fat file: ${path} is architecture: arm64\n`,
|
|
}),
|
|
"darwin",
|
|
).createClient(target);
|
|
const state = { failing: true, attempts: 0 };
|
|
const original = prototype.stat;
|
|
const stat = vi
|
|
.spyOn(prototype, "stat")
|
|
.mockImplementationOnce(async function (
|
|
this: FileHandle,
|
|
...args: Parameters<FileHandle["stat"]>
|
|
) {
|
|
const close = this.close.bind(this);
|
|
this.close = async () => {
|
|
state.attempts += 1;
|
|
if (state.failing)
|
|
throw new Error("controlled Mach-O descriptor close failure");
|
|
await close();
|
|
};
|
|
return Reflect.apply(original, this, args);
|
|
});
|
|
control.read = async () => {
|
|
await writeFile(path, "changed source bytes!");
|
|
throw new MachoCommandNamesLimitError(23, "records");
|
|
};
|
|
onTestFinished(async () => {
|
|
control.read = undefined;
|
|
stat.mockRestore();
|
|
state.failing = false;
|
|
await client.close();
|
|
});
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (result.ok) throw new Error("Expected cleanup failure");
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources).toEqual([path]);
|
|
expect(result.error.cleanupPrimary?._tag).toBe(
|
|
"AnalysisArtifactChangedError",
|
|
);
|
|
expect(result.error.cleanupPrimary?.diagnostics).toMatchObject({
|
|
previous_error: { code: "resource_constraint" },
|
|
});
|
|
expect(state.attempts).toBe(1);
|
|
state.failing = false;
|
|
expect((await client.close()).ok).toBe(true);
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
expect(state.attempts).toBe(2);
|
|
});
|
|
|
|
it("retains a returned command failure and captured output when close fails", async () => {
|
|
const root = await createTestTempDirectory("rea-macho-command-close-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, "selected source bytes");
|
|
const target = await nativeMachoTargetForFile(path);
|
|
const probe = await open(path, "r");
|
|
const prototype = Object.getPrototypeOf(probe) as FileHandle;
|
|
await probe.close();
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({ lipo: "unrecognized producer output\n" }),
|
|
"darwin",
|
|
).createClient(target);
|
|
const state = { failing: true, attempts: 0 };
|
|
const original = prototype.stat;
|
|
const stat = vi
|
|
.spyOn(prototype, "stat")
|
|
.mockImplementationOnce(async function (
|
|
this: FileHandle,
|
|
...args: Parameters<FileHandle["stat"]>
|
|
) {
|
|
const close = this.close.bind(this);
|
|
this.close = async () => {
|
|
state.attempts += 1;
|
|
if (state.failing)
|
|
throw new Error("controlled Mach-O descriptor close failure");
|
|
await close();
|
|
};
|
|
return Reflect.apply(original, this, args);
|
|
});
|
|
onTestFinished(async () => {
|
|
stat.mockRestore();
|
|
state.failing = false;
|
|
await client.close();
|
|
});
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (result.ok) throw new Error("Expected cleanup failure");
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources).toEqual([path]);
|
|
expect(result.error.cleanupPrimary).toMatchObject({
|
|
_tag: "AnalysisOutputError",
|
|
capturedOutput: { stdout: "unrecognized producer output\n", exit_code: 0 },
|
|
});
|
|
expect(projectAnalysisError(result.error)).toMatchObject({
|
|
details: { diagnostics: { previous_error: { code: "unreadable_output" } } },
|
|
});
|
|
expect(state.attempts).toBe(1);
|
|
state.failing = false;
|
|
expect((await client.close()).ok).toBe(true);
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
expect(state.attempts).toBe(2);
|
|
});
|
|
|
|
it("preserves a returned command failure and late cancellation through close retry", async () => {
|
|
const root = await createTestTempDirectory("rea-macho-command-cancel-close-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, "selected source bytes");
|
|
const target = await nativeMachoTargetForFile(path);
|
|
const probe = await open(path, "r");
|
|
const prototype = Object.getPrototypeOf(probe) as FileHandle;
|
|
await probe.close();
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({ lipo: "unrecognized producer output\n" }),
|
|
"darwin",
|
|
).createClient(target);
|
|
const controller = new AbortController();
|
|
const cancelReason = new Error("cancelled during descriptor close");
|
|
const state = { failing: true };
|
|
const original = prototype.stat;
|
|
const stat = vi
|
|
.spyOn(prototype, "stat")
|
|
.mockImplementationOnce(async function (
|
|
this: FileHandle,
|
|
...args: Parameters<FileHandle["stat"]>
|
|
) {
|
|
const close = this.close.bind(this);
|
|
this.close = async () => {
|
|
if (state.failing) {
|
|
controller.abort(cancelReason);
|
|
throw new Error("controlled Mach-O descriptor close failure");
|
|
}
|
|
await close();
|
|
};
|
|
return Reflect.apply(original, this, args);
|
|
});
|
|
onTestFinished(async () => {
|
|
stat.mockRestore();
|
|
state.failing = false;
|
|
await client.close();
|
|
});
|
|
const result = await client.execute(
|
|
"inspect_macho",
|
|
{},
|
|
{ signal: controller.signal },
|
|
);
|
|
if (result.ok) throw new Error("Expected cleanup failure");
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupPrimary).toMatchObject({
|
|
_tag: "AnalysisOutputError",
|
|
capturedOutput: { stdout: "unrecognized producer output\n" },
|
|
});
|
|
expect(projectAnalysisError(result.error)).toMatchObject({
|
|
details: {
|
|
diagnostics: {
|
|
previous_error: { code: "unreadable_output" },
|
|
completion_cancellation: { code: "cancelled" },
|
|
},
|
|
},
|
|
});
|
|
state.failing = false;
|
|
expect((await client.close()).ok).toBe(true);
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
});
|
|
|
|
it.each([
|
|
["truncated fixed fields", "Mach-O fixed command fields are truncated", 1],
|
|
["invalid string offset", "Mach-O command string offset is invalid", 2],
|
|
] as const)(
|
|
"reports malformed binary %s as invalid input with its reason",
|
|
async (_case, reason, mode) => {
|
|
const { machoImage, dylibCommand, LC } =
|
|
await import("../artifacts/apple/MachoImage.fixture.js");
|
|
const command =
|
|
mode === 1
|
|
? new Uint8Array([2, 0, 0, 0, 8, 0, 0, 0])
|
|
: dylibCommand(LC.LOAD_DYLIB, "lib");
|
|
if (mode === 2)
|
|
new DataView(command.buffer).setUint32(8, command.length, true);
|
|
const root = await createTestTempDirectory("rea-malformed-macho-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, machoImage({ commands: [command] }));
|
|
const client = new NativeMacOSProvider(
|
|
{},
|
|
new NativeFixtureRunner({
|
|
lipo: `Non-fat file: ${path} is architecture: arm64\n`,
|
|
}),
|
|
"darwin",
|
|
).createClient(await nativeMachoTargetForFile(path));
|
|
try {
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (result.ok) throw new Error("Expected malformed input refusal");
|
|
expect(result.error).toMatchObject({
|
|
_tag: "AnalysisInputError",
|
|
operation: "inspect_macho",
|
|
issues: [
|
|
{
|
|
path: ["path"],
|
|
reason: "invalid_format",
|
|
message: `Selected artifact ${path}: ${reason}`,
|
|
},
|
|
],
|
|
});
|
|
} finally {
|
|
await client.close();
|
|
}
|
|
},
|
|
);
|
|
|
|
it.each(
|
|
(["inspect_macho", "list_architectures"] as const).flatMap((operation) => [
|
|
...[false, true].flatMap((cancelDuringClose) =>
|
|
[false, true].map((failDescriptorClose) => ({
|
|
operation,
|
|
cancelDuringClose,
|
|
failDescriptorClose,
|
|
changeTarget: false,
|
|
})),
|
|
),
|
|
{
|
|
operation,
|
|
cancelDuringClose: false,
|
|
failDescriptorClose: false,
|
|
changeTarget: true,
|
|
},
|
|
]),
|
|
)(
|
|
"keeps $operation command cleanup live through finalization (cancel: $cancelDuringClose, failed close: $failDescriptorClose, changed target: $changeTarget)",
|
|
async ({
|
|
operation,
|
|
cancelDuringClose,
|
|
failDescriptorClose,
|
|
changeTarget,
|
|
}) => {
|
|
const root = await createTestTempDirectory("rea-macho-command-owner-");
|
|
const path = join(root, "fixture.macho");
|
|
await writeFile(path, inspectionImage());
|
|
const target = await nativeMachoTargetForFile(path);
|
|
// The exited event handle and cleanup callback are inert; no process starts.
|
|
const process = Object.assign(new EventEmitter(), {
|
|
exitCode: 1,
|
|
signalCode: null,
|
|
stdout: null,
|
|
stderr: null,
|
|
kill: () => {
|
|
throw new Error("Exited fixture must not be signalled");
|
|
},
|
|
});
|
|
let mayClean = false;
|
|
let cleanupAttempts = 0;
|
|
const owner = new ProviderProcessSupervisor({
|
|
process,
|
|
ownsProcessLifetime: true,
|
|
cleanup: async () => {
|
|
cleanupAttempts++;
|
|
return mayClean
|
|
? { cleaned: true, signaled: false }
|
|
: { cleaned: false, reason: "worker remains owned" };
|
|
},
|
|
});
|
|
process.emit("close", 1, null);
|
|
const physical = new Error("physical command read failure");
|
|
const failure = new NativeCommandFailure(
|
|
"lipo",
|
|
"io",
|
|
1,
|
|
{ cause: physical, cleanupOwner: owner },
|
|
{
|
|
stdout: "partial native output",
|
|
stderr: "read failed",
|
|
stdoutBytes: 21,
|
|
stderrBytes: 11,
|
|
exitCode: 1,
|
|
signal: null,
|
|
truncated: false,
|
|
},
|
|
"worker remains owned",
|
|
["native-command-process"],
|
|
);
|
|
const runner = new XcrunCommandRunner({}, async () => {
|
|
if (changeTarget) await writeFile(path, "changed Mach-O source bytes");
|
|
return err(failure);
|
|
});
|
|
const client = new NativeMacOSProvider({}, runner, "darwin").createClient(
|
|
target,
|
|
);
|
|
const controller = new AbortController();
|
|
const reason = { request: "cancel during descriptor close" };
|
|
let descriptorCloseFails = failDescriptorClose;
|
|
const probe = await open(path, "r");
|
|
const prototype = Object.getPrototypeOf(probe) as FileHandle;
|
|
await probe.close();
|
|
const original = prototype.stat;
|
|
const stat = vi
|
|
.spyOn(prototype, "stat")
|
|
.mockImplementationOnce(async function (
|
|
this: FileHandle,
|
|
...args: Parameters<FileHandle["stat"]>
|
|
) {
|
|
const close = this.close.bind(this);
|
|
this.close = async () => {
|
|
if (cancelDuringClose) controller.abort(reason);
|
|
if (descriptorCloseFails) throw new Error("descriptor remains owned");
|
|
await close();
|
|
};
|
|
return Reflect.apply(original, this, args);
|
|
});
|
|
onTestFinished(async () => {
|
|
stat.mockRestore();
|
|
descriptorCloseFails = false;
|
|
mayClean = true;
|
|
expect((await client.close()).ok).toBe(true);
|
|
});
|
|
const result = await client.execute(
|
|
operation,
|
|
{},
|
|
{ signal: controller.signal },
|
|
);
|
|
if (result.ok) throw new Error("Expected command failure");
|
|
expect(result.error._tag).toBe("ProviderAdapterError");
|
|
const primary = primaryAnalysisError(result.error);
|
|
if (changeTarget) {
|
|
expect(primary._tag).toBe("AnalysisArtifactChangedError");
|
|
expect(primary.diagnostics).toMatchObject({
|
|
previous_error: {
|
|
details: {
|
|
captured_output: {
|
|
stdout: "partial native output",
|
|
stderr: "read failed",
|
|
},
|
|
},
|
|
},
|
|
});
|
|
} else {
|
|
expect(primary.cause).toBeInstanceOf(NativeCommandFailure);
|
|
if (!(primary.cause instanceof NativeCommandFailure))
|
|
throw new Error("Expected the runner's physical command failure");
|
|
expect(primary.cause.cause).toBe(failure);
|
|
expect(primary.capturedOutput).toMatchObject({
|
|
stdout: "partial native output",
|
|
stderr: "read failed",
|
|
});
|
|
}
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources.toSorted()).toEqual(
|
|
[...(failDescriptorClose ? [path] : []), "native-command-process"].sort(),
|
|
);
|
|
expect(primary.secondaryFailures).toEqual(
|
|
cancelDuringClose
|
|
? [
|
|
expect.objectContaining({
|
|
_tag: "AnalysisCancelledError",
|
|
cause: reason,
|
|
}),
|
|
]
|
|
: [],
|
|
);
|
|
descriptorCloseFails = false;
|
|
const blocked = await client.close();
|
|
expect(blocked.ok).toBe(false);
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources).toEqual(["native-command-process"]);
|
|
expect(cleanupAttempts).toBe(1);
|
|
mayClean = true;
|
|
expect((await client.close()).ok).toBe(true);
|
|
expect(cleanupAttempts).toBe(2);
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
expect(result.error.cleanupResources).toEqual([]);
|
|
},
|
|
);
|