mirror of
https://github.com/morluto/rea.git
synced 2026-11-19 21:23:45 +00:00
* fix(process): name the fields a located divergence compared `first_divergence` handed back the whole observation on each side, so a caller that saw `changed` had to diff two large objects by hand to learn what the comparison actually judged. Reported in #8204: the same deterministic CLI captured twice reports `terminal`, `exit`, and `filesystem` changed, and the report names no field. A located divergence now carries `fields`, the sorted leaf paths that differ in the projection the comparison judged, for example `files[3].path`, `pid`, `process_samples[0].pid`, or `$` when a whole observation is present on one side only. Positions are bracketed array indices; the list is bounded to eight names because the report names a difference rather than copying the observation, and `left` and `right` still retain both complete observations. The list is computed from the comparable projection, not the observed values, so capture-local timing (`at_ms`, `dispatched_at_ms`, `elapsed_ms`, `sent_at_ms`) is never named unless a `trace_spec` explicitly selects it. That keeps the names honest about what the comparison measured. Naming a volatile value is not a claim of equivalence. A per-run temporary root or PID still counts as a difference; the exclusion path remains capture-time normalization (`normalization.paths`, `normalization.pids`, `normalization.patterns`), which must match on both sides because comparison refuses captures under different rules. `fields` is optional in the contract. `readComparisonResult` re-validates `normalized_result` of authenticated Evidence, so a required field would reject records written before this change. Producing code always populates it. Validation: `tsc --noEmit` clean; `oxlint` reports only the four pre-existing complexity/length warnings this file already carried; `scripts/ci/static-check-report.mjs lint` 0 errors; module boundaries and architecture guards pass; `oxfmt --check` clean on the touched files; `completeness-enum-guard`, `optional-fact-default-guard`, and `rea-numeric-limits` pass; `scan:todos` and `verify-test-discovery` clean; jscpd within budget. 194 focused domain tests passed, including five new cases covering a temporary-path leaf inside a filesystem checkpoint, a fully populated process sample, the eight-name bound, one-sided presence as `$`, and an authenticated payload without `fields`. No live process capture was exercised on this host. Refs #8204 * fix(process): honor trace timing policy in divergence fields --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>