Files
reverse-engineering-anything/tests/boundary/providers/cutterBridgeProducer.test.ts
T
4aa51bfe19 fix(reverse): reconcile cleanup ownership and mutation diagnostics (#2799)
* feat(process): add owned debugger shutdown lifecycle

* feat(reverse): add local inspection commands

* feat(gdb): add persistent debugger integration

* feat(cutter): add Cutter bridge integration

* test(reverse): enforce complete integration coverage

* fix(process): preserve debugger shutdown ownership

* fix(reverse): retain evidence across interrupted commands

* fix(gdb): honor captured provider environment

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* fix(server): snapshot provider environment at creation

* fix(reverse): close review gaps with complete coverage

* fix(reverse): address inspection review findings

* fix(gdb): bound sessions and retain cleanup ownership

* fix(ci): require reverse-tools quality lane

* fix(process): unref inherited debugger output pipes

* fix(reverse): address remaining PR 1960 findings

* fix(gdb): address remaining PR 1961 findings

* fix(reverse): account for unrestricted provider execution

* fix(process): retain debugger ownership until safe shutdown

* fix(process): preserve replacement debugger sessions

* fix(reverse): preserve admission and output provenance

* fix(process): retain exited debugger until output settles

* fix(mcp): bound provider admission and debugger cleanup

* fix(reverse): preserve failure provenance and classify E2BIG

* fix(gdb): preserve startup cleanup and detach safety

* fix(process): retain debugger ownership after detach failure

* fix(reverse): preserve mutation and failure provenance

* fix(gdb): address debugger review findings

* fix(reverse): rebind sessions after external mutation

* fix(process): cap debugger output after exit

* fix(gdb): protect one-shot detach verification

* feat(debugger): add reverse tool coverage gate

* test(debugger): cover integrated failure paths

* fix(gdb): bound and preserve session observations

* fix(gdb): address review regressions

* style: format merged integration files

* fix(reverse): preserve session and output evidence

* refactor(gdb): share repeated test and partial result setup

* fix(gdb): invalidate TTY proof for Python aliases

* fix(reverse): retain failure output byte counts

* test(process): synchronize late debugger output

* fix(gdb): invalidate TTY proof for wrapped commands

* fix(gdb): recognize wit command abbreviation

* test(reverse): wait for cancelled descendant readiness

* test(reverse): bound descendant cancellation cleanup

* style(reverse): format integration tests and adapters

* style: format reverse engineering integration files

* test(reverse): remove duplicate environment harness

* test(gdb): share session startup assertions

* fix(gdb): invalidate output proof for command abbreviations

* test(reverse): share composition edge case scenarios

* fix(ci): recognize verification and mutation tool entries

* test(rizin): cover successful fake inferior detach

* test(cli): align full output failure envelope

* test(cli): isolate reverse command lifecycle service

* test(process): share debugger output fixture setup

* fix(binary): preserve high-bit Windows signature bytes

* style(binary): format Windows signature parser

* test(mcp): preserve call coverage in unchanged comparison

* fix(ci): include reverse tools Vitest configs in lint cache

* fix(mcp): preserve target content on delivery errors

* ci: align duplication ceiling with expanded suite

* test(reverse): allow signal admission mutants

* fix(reverse): bound retained cleanup failures to process owners

* fix(test): replace drifting mutation ranges with owned selectors

* fix(reverse): admit persistent commands and retain cleanup ownership

* fix(cutter): recover timed-out commands from exact receipts

* fix(cutter): reject unsupported bridge request kinds

* fix(ci): repair client format and shared verification fixtures

* fix(native): preserve debugger cleanup ownership and bridge authentication

* test(native): retain diagnostics without perfect coverage requirements

* chore(licenses): refresh locked dependency inventory and notices

* fix(test): exclude transient command locks from mutation sandboxes

* fix(gdb): admit only platforms with safe detach verification

* fix(cutter): retain bounded completion receipts until acknowledgement

* fix(cutter): acknowledge commands rejected before UI dispatch

* test(reverse): fail cancellation checks before fixture teardown

* test(gdb): clean up the retained broken-stdin fixture owner

* docs(test): clarify focused provider verification scope

* fix(rizin): retain close cleanup failures

* fix(gdb): wait for inferior stop and bound MI buffering

* fix(cutter): retain failed receipt acknowledgements

* fix(rizin): return retained session identity on rebind failure

* fix(gdb): preserve startup cancellation and lossy status

* fix(rizin): retain launch provenance and assemble frames once

* fix(cutter): recover receipts across callers and bound discovery

* docs: describe debugger evidence and bridge recovery

* fix(process): keep cleanup incomplete while writers remain

Stopping a debugger no longer reports success when inherited output
streams stay open, so BinarySession cannot reopen a binary a child is
still changing. Concurrent Cutter cleanup retries share one receipt
acknowledgement instead of treating a consumed receipt as failure.

* fix(debuggers): recover cleanup with captured process identities

* fix(analysis): retire sessions after unrestricted commands

* fix(cli): preserve completed evidence after cleanup recovery

* fix(cutter): bound frame collection and coalesce cleanup

* fix(windows): resolve selected provider paths absolutely

* fix(gdb): report decoding loss in failed startup evidence

* fix(rizin): scope decoding loss to collected command frames

* test(mcp): cover snapshot retirement in reverse tools CI

---------

Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com>
Co-authored-by: REA Maintainers <noreply@github.com>
Co-authored-by: OpenAI Codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-10-14 04:47:34 +08:00

265 lines
8.1 KiB
TypeScript

import { execFileSync } from "node:child_process";
import { chmod, mkdtemp, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join, resolve } from "node:path";
import { expect, it } from "vitest";
import { CutterBridgeClient } from "../../../src/cutter/CutterBridgeClient.js";
import { CutterBridgeService } from "../../../src/cutter/CutterBridgeService.js";
import {
createTestProcessRegistry,
waitForExit,
} from "../../../tests/support/process/processFixture.js";
const startPythonBridge = async () => {
const directory = await mkdtemp(join(tmpdir(), "rea-cutter-receipt-"));
await chmod(directory, 0o700);
const processes = createTestProcessRegistry();
const child = processes.spawn(
"python3",
[resolve("tests/fixtures/cutter_bridge_protocol_test.py"), "--serve"],
{ env: { ...process.env, REA_CUTTER_BRIDGE_DIR: directory } },
);
let stdout = "";
let stderr = "";
child.stdout.setEncoding("utf8");
child.stderr.setEncoding("utf8");
child.stdout.on("data", (chunk: string) => {
stdout += chunk;
});
child.stderr.on("data", (chunk: string) => {
stderr += chunk;
});
try {
await new Promise<void>((resolveReady, rejectReady) => {
const timeout = setTimeout(
() =>
rejectReady(
new Error(`Python bridge did not become ready: ${stderr}`),
),
5_000,
);
const onData = (_chunk: string): void => {
if (!stdout.includes("ready\n")) return;
clearTimeout(timeout);
child.stdout.off("data", onData);
resolveReady();
};
child.stdout.on("data", onData);
child.once("error", (error) => {
clearTimeout(timeout);
rejectReady(error);
});
child.once("exit", (code, signal) => {
if (stdout.includes("ready\n")) return;
clearTimeout(timeout);
rejectReady(
new Error(
`Python bridge exited before ready (${code ?? signal}): ${stderr}`,
),
);
});
if (stdout.includes("ready\n")) onData("");
});
const client = new CutterBridgeClient({
...process.env,
REA_CUTTER_BRIDGE_DIR: directory,
});
const discovery = await client.listSessions();
const session = discovery.sessions[0];
if (session === undefined) throw new Error("Python bridge session missing");
return {
client,
directory,
session,
stderr: () => stderr,
async close(): Promise<void> {
child.stdin.end("shutdown\n");
const exited = await waitForExit(child, 3_000);
try {
await processes.shutdown();
} finally {
await rm(directory, { recursive: true, force: true });
}
if (!exited) throw new Error(`Python bridge did not exit: ${stderr}`);
},
};
} catch (error) {
child.stdin.end("shutdown\n");
await waitForExit(child, 3_000);
await processes.shutdown();
await rm(directory, { recursive: true, force: true });
throw error;
}
};
it("authenticates bridge peers before payloads and permits status recovery after a poisoned UI timeout", () => {
execFileSync(
"python3",
[resolve("tests/fixtures/cutter_bridge_protocol_test.py")],
{
encoding: "utf8",
timeout: 10_000,
},
);
});
it("round-trips authenticated status and command bytes across the Python producer boundary", async () => {
const bridge = await startPythonBridge();
try {
const { client, session } = bridge;
expect(session.document_generation).toBe(4);
expect(session.current_file).toBe("/tmp/cutter-interop-雪.bin");
for (let index = 0; index <= 64; index += 1) {
await expect(
client.execute({
sessionId: session.session_id,
expectedGeneration: 3,
command: "iI",
json: false,
}),
).rejects.toThrow("List sessions again");
}
const result = await client.execute({
sessionId: session.session_id,
expectedGeneration: session.document_generation,
command: 'print("雪 ☃️ \\\"quoted\\\" \\\\ slash\\nline\\ttab")',
json: false,
});
expect(result.output).toBe(
'round-trip: 雪 ☃️ quote=" slash=\\\\ line=\\n tab=\\t',
);
expect(result.executionState).toBe("complete");
expect(result.documentGeneration).toBe(4);
expect(result.currentFile).toBe("/tmp/cutter-interop-雪.bin");
expect(result.outputTruncated).toBe(false);
} finally {
await bridge.close();
}
});
it("preserves caller A service cleanup proof after caller B acknowledges A", async () => {
const bridge = await startPythonBridge();
try {
const commandInput = {
session_id: bridge.session.session_id,
expected_generation: bridge.session.document_generation,
command: "fixture-unknown",
json: false,
};
const callerA = new CutterBridgeService(bridge.client);
const executionA = await callerA.execute(commandInput);
expect(executionA).toMatchObject({
ok: false,
error: { cleanupIncomplete: true },
});
const callerB = new CutterBridgeService(
new CutterBridgeClient({
...process.env,
REA_CUTTER_BRIDGE_DIR: bridge.directory,
}),
);
await expect(
callerB.execute({
...commandInput,
command: "iI",
json: false,
}),
).resolves.toMatchObject({ ok: true });
await expect(callerA.retryCleanup()).resolves.toEqual({
ok: true,
value: null,
});
await expect(
callerA.execute({ ...commandInput, command: "iI" }),
).resolves.toMatchObject({ ok: true });
} finally {
await bridge.close();
}
});
it("recovers orphan receipts across more than 64 fresh CLI clients", async () => {
const bridge = await startPythonBridge();
try {
for (let index = 0; index < 65; index += 1) {
const freshClient = new CutterBridgeClient({
...process.env,
REA_CUTTER_BRIDGE_DIR: bridge.directory,
});
const execution = await freshClient.execute({
sessionId: bridge.session.session_id,
expectedGeneration: bridge.session.document_generation,
command: "fixture-unknown",
json: false,
});
expect(execution.executionState, `orphan ${index}`).toBe("unknown");
}
const nextInvocation = new CutterBridgeClient({
...process.env,
REA_CUTTER_BRIDGE_DIR: bridge.directory,
});
await expect(
nextInvocation.execute({
sessionId: bridge.session.session_id,
expectedGeneration: bridge.session.document_generation,
command: "iI",
json: false,
}),
).resolves.toMatchObject({ executionState: "complete" });
} finally {
await bridge.close();
}
});
it("retains failed receipt acknowledgements and retries before another command", async () => {
const bridge = await startPythonBridge();
try {
await expect(
bridge.client.execute({
sessionId: bridge.session.session_id,
expectedGeneration: bridge.session.document_generation,
command: "fixture-fail-ack",
json: false,
}),
).resolves.toMatchObject({ executionState: "complete" });
await expect(
bridge.client.execute({
sessionId: bridge.session.session_id,
expectedGeneration: bridge.session.document_generation,
command: "iI",
json: false,
}),
).resolves.toMatchObject({ executionState: "complete" });
} finally {
await bridge.close();
}
});
it("retains a receipt when an ACK reply omits its acknowledgement field", async () => {
const bridge = await startPythonBridge();
try {
await expect(
bridge.client.execute({
sessionId: bridge.session.session_id,
expectedGeneration: bridge.session.document_generation,
command: "fixture-malformed-ack",
json: false,
}),
).resolves.toMatchObject({ executionState: "complete" });
await expect(
bridge.client.execute({
sessionId: bridge.session.session_id,
expectedGeneration: bridge.session.document_generation,
command: "iI",
json: false,
}),
).resolves.toMatchObject({ executionState: "complete" });
} finally {
await bridge.close();
}
});