Files
reverse-engineering-anything/tests/acceptance/browser/observationDurationCli.test.ts
T
IvenKoo 80f533da8a fix(cli): bound advertised decimal-token schemas by the domain range (#9808)
`cliDecimalField` published the domain range on the integer branch and only
the fixed `^[0-9]+$` guard on the decimal-token branch, and JSON Schema
bounds do not constrain strings. A client validating raw argv text against
`--schema` therefore admitted out-of-range tokens such as `--row-limit=0` or
`--block-size=255` that the parser rejects with `VALIDATION_ERROR`.

Publish the domain range on the token branch through the schema-constraint
owner, keeping the CLI's decimal leading-zero convention and the existing
parser diagnostics: the declaration is metadata, so accepted values and
`too_small`/`too_big` messages are unchanged. Non-range refinements such as
the power-of-two entropy block size stay parser-only, and an open-ended
domain still publishes its floor. The getting-started guide states the same
contract.

Fixes #9348
2026-11-18 09:11:20 -05:00

86 lines
2.5 KiB
TypeScript

import { Ajv2020 } from "ajv/dist/2020.js";
import { expect } from "vitest";
import { startFakeCdpBrowser } from "../../fixtures/fakeCdpBrowser.js";
import { cliTest } from "../../support/cli/cliFixture.js";
cliTest(
"rejects empty observation selections before connecting to a browser",
async ({ cli }) => {
for (const selection of [["--observation-ms="], ["--observation-ms", ""]]) {
const result = await cli.run({
arguments: [
"inspect-web-page",
"http://127.0.0.1:9",
"page",
...selection,
"--json",
],
});
expect(result.exitCode).toBe(1);
expect(result.json).toMatchObject({
code: "VALIDATION_ERROR",
fieldErrors: expect.arrayContaining([
expect.objectContaining({ path: "observationMs" }),
]),
});
}
},
);
cliTest(
"preserves the default capture window and explicit zero through CDP",
async ({ cli }) => {
const browser = await startFakeCdpBrowser();
try {
for (const [selection, expected] of [
[[], 500],
[["--observation-ms=0"], 0],
] as const) {
const result = await cli.run({
arguments: [
"inspect-web-page",
browser.endpoint,
"allowed-page",
...selection,
"--json",
],
});
expect(result.exitCode, result.stderr).toBe(0);
expect(result.json).toMatchObject({
normalized_result: { capture_window: { observation_ms: expected } },
});
}
} finally {
await browser.close();
}
},
);
cliTest(
"advertises the lexical guard after SDK conversion",
async ({ cli }) => {
const result = await cli.run({
arguments: ["inspect-web-page", "--schema", "--json"],
});
expect(result.exitCode).toBe(0);
const observationMs = (
result.json as {
options: {
properties: Record<string, Parameters<Ajv2020["compile"]>[0]>;
};
}
).options.properties.observationMs;
if (observationMs === undefined)
throw new Error("inspect-web-page advertises no observationMs");
expect(observationMs).toMatchObject({
default: 500,
anyOf: [{ type: "integer", minimum: 0 }, { type: "string" }],
});
const validate = new Ajv2020({ strict: false }).compile(observationMs);
for (const token of ["0", "0500", "9007199254740991"])
expect(validate(token), token).toBe(true);
for (const token of ["9007199254740992", "0x10"])
expect(validate(token), token).toBe(false);
},
);