mirror of
https://github.com/affaan-m/ECC.git
synced 2026-11-17 13:32:18 +00:00
fix(pi): show ecc-doctor report immediately when run
This commit is contained in:
1 parent
b38be6a7f6
commit
66a96a5fdb
2 files changed
+61
-1
No files matched your search
@@ -759,7 +759,7 @@ export default function (pi: ExtensionAPI): void {
|
||||
content: buildDoctorReport(ctx),
|
||||
display: true,
|
||||
},
|
||||
{ deliverAs: "nextTurn" }
|
||||
{ triggerTurn: false }
|
||||
)
|
||||
},
|
||||
})
|
||||
|
||||
@@ -44,6 +44,8 @@ const assert = require("assert")
|
||||
const fs = require("fs")
|
||||
const os = require("os")
|
||||
const path = require("path")
|
||||
const vm = require("vm")
|
||||
const ts = require("typescript")
|
||||
const { spawnSync, execFile } = require("child_process")
|
||||
const { resolveHookRuntime } = require(
|
||||
path.join(__dirname, "..", "..", ".pi", "extensions", "hook-runtime.js")
|
||||
@@ -528,6 +530,64 @@ async function main() {
|
||||
)
|
||||
}],
|
||||
|
||||
["ecc-doctor emits report immediately without nextTurn delivery delay", async () => {
|
||||
const commands = new Map()
|
||||
const messages = []
|
||||
const mockPi = {
|
||||
on: () => {},
|
||||
registerCommand: (name, def) => commands.set(name, def),
|
||||
sendMessage: (msg, opts) => messages.push({ msg, opts }),
|
||||
}
|
||||
const compiled = ts.transpileModule(extensionSource, {
|
||||
compilerOptions: { module: ts.ModuleKind.CommonJS, target: ts.ScriptTarget.ES2020 },
|
||||
}).outputText
|
||||
const mod = { exports: {} }
|
||||
vm.runInNewContext(compiled, {
|
||||
module: mod,
|
||||
exports: mod.exports,
|
||||
__dirname: path.resolve(repoRoot, ".pi", "extensions"),
|
||||
process,
|
||||
require: name => {
|
||||
if (name === "./hook-runtime.js") {
|
||||
return require(path.resolve(repoRoot, ".pi", "extensions", "hook-runtime.js"))
|
||||
}
|
||||
return require(name)
|
||||
},
|
||||
})
|
||||
|
||||
mod.exports.default(mockPi)
|
||||
|
||||
const doctorCmd = commands.get("ecc-doctor")
|
||||
assert.ok(
|
||||
doctorCmd && typeof doctorCmd.handler === "function",
|
||||
"expected ecc-doctor command to register a handler"
|
||||
)
|
||||
|
||||
const mockCtx = {
|
||||
cwd: repoRoot,
|
||||
ui: { notify: () => {} },
|
||||
}
|
||||
|
||||
await doctorCmd.handler({}, mockCtx)
|
||||
|
||||
assert.strictEqual(messages.length, 1, "expected ecc-doctor to send exactly one message")
|
||||
assert.strictEqual(messages[0].msg?.customType, "ecc-doctor", "expected ecc-doctor customType")
|
||||
assert.strictEqual(messages[0].msg?.display, true, "expected ecc-doctor report to be visible")
|
||||
assert.ok(
|
||||
typeof messages[0].msg?.content === "string" && messages[0].msg.content.trim().length > 0,
|
||||
"expected ecc-doctor report content to be nonempty"
|
||||
)
|
||||
assert.strictEqual(
|
||||
messages[0].opts?.triggerTurn,
|
||||
false,
|
||||
"expected ecc-doctor to pass triggerTurn: false so running diagnostics does not invoke the LLM"
|
||||
)
|
||||
assert.ok(
|
||||
messages[0].opts?.deliverAs !== "nextTurn",
|
||||
"expected ecc-doctor not to queue with deliverAs: nextTurn; in Pi, queued delivery stalls display until next turn"
|
||||
)
|
||||
}],
|
||||
|
||||
["bounds hook execution with a timeout and a maxBuffer", () => {
|
||||
assert.ok(
|
||||
extensionSource.includes("timeout"),
|
||||
|
||||
Reference in new issue
Block a user