Commit Graph
1842 Commits
Author SHA1 Message Date
haelyra cd28a61264 Integrate L4XB PR #3667 2026-10-25 19:19:04 -04:00
haelyra 272ae0d25b Integrate L4XB PR #3666 2026-10-25 19:19:04 -04:00
haelyra f390400944 Merge pull request #3583 from Tivonsico/fix/skill-run-timestamp-type-20261014
fix(skill-tracker): reject non-string execution timestamps
2026-10-25 19:16:34 -04:00
haelyra 7f0b6ce500 fix(install): reject malformed empty-container JSONC commas 2026-10-25 18:20:40 -04:00
haelyra f4e8f6eb3e Merge reviewed OpenCode JSONC fix from #3590 2026-10-25 18:17:10 -04:00
haelyra e3292b0010 Merge pull request #3594 from ketpatil77/fix/managed-hook-config-bom
fix(hooks): honor managed preferences in BOM-prefixed config
2026-10-25 17:44:47 -04:00
haelyra e494799377 Merge pull request #3654 from affaan-m/stewardship/verified-pr-batch-3569-3578-owned
Integrate 34 reviewed ECC fixes with verified follow-up patches
2026-10-25 15:39:22 -04:00
haelyra 108ff18624 feat(ci): limit Issue bursts and open submissions per author (#3723)
Verified with 30 exact-head hosted checks, 31 combined PR and Issue tests, workflow security validation, and a live read-only Issue replay.
2026-10-25 15:16:53 -04:00
haelyra 90d94d4424 test: fix Windows install and ck hook expectations 2026-10-25 14:46:45 -04:00
4c28a7be9e ci: audit closed-issue delivery claims — cited PRs must actually be merged (#3522)
* ci: audit closed-issue delivery claims — cited PRs must actually be merged

Follow-up to #3223: an issue closed as 'fixed in #N' while #N was closed
without merging (or does not exist) leaves a completion claim that does not
hold. The weekly maintenance workflow now runs a read-only audit over issues
closed in the last 30 days, extracts delivery-claim PR references from issue
bodies and close-window comments, verifies each cited PR's merge state, and
reports findings to the step summary.

Design constraints:
- Read-only: no comments, no closes, no labels; findings are advisory and
  the run always stays green so the weekly audit never blocks maintenance.
- Unverifiable counts as unmerged: a 404 PR or an API failure fails the
  verdict, because an unverifiable claim is exactly the failure mode.
- Pure decision functions are exported for tests; a first live run against
  this repository surfaced one real finding (#3408 cites #3060, which does
  not resolve), included here as the motivating sample.

8 unit/contract tests: extraction, windowing (close comments included),
the #3223 unmerged-citation failure mode, the all-clear summary, workflow
contract, and a no-write guard.

* ci: rework audit evidence contract — claims vs context, four PR states, visible completeness

Revision per the #3522 review (reviewer ran the CLI through 19 controlled
cases plus a bounded live check of #3408):

- Bind findings to asserted delivery claims. Closing wording ('Delivered
  through #N'), claim verbs (fixed/shipped/landed/resolved/...), and bare
  'PR #N' inside closing comments are claims; historical mentions, quoted
  lines, fenced examples, negated claims, and tracking-only references are
  reported as contextual references and never produce findings. On the live
  #3408 the audit now recognizes the closing claim #3500 (merged) instead of
  flagging the historical #3060 text.
- Separate observed states: merged / open-unmerged / closed-unmerged /
  unknown (404, rate limit, transient). Unknown claims are advisory manual-
  verification items, not failed claims; each row carries the claim snippet,
  its source link, and the observation time. Checked claims are listed even
  when passing, so the report is traceable rather than an opaque all-clear.
- Paginate issue and comment collection (--paginate --slurp), bound comment
  requests (200) and PR checks (100), and surface skipped pages, rate limits,
  and retrieval failures as an explicit incomplete audit instead of an empty
  all-clear. A live-run maxBuffer overflow on the paginated issue list was
  caught and fixed (64MB); the audit reported it as incomplete before the fix.
- Scope the job to read access: job-level contents/issues/pull-requests read.

13 contract/unit tests including a CLI fixture (stub gh) that places the
relevant issue on page two and forces a comment-fetch failure.

* ci: report incomplete audit at PR check cap

---------

Co-authored-by: chenhz01 <chenhz01@users.noreply.github.com>
Co-authored-by: haelyra <49814733+haelyra@users.noreply.github.com>
2026-10-25 14:41:22 -04:00
L4XB 10e7c5800f fix(hooks): recognize Prettier's TypeScript and JSON5 config files
Prettier's config searcher also reads .prettierrc.json5, .prettierrc.ts/.mts/.cts and prettier.config.ts/.mts/.cts. resolve-formatter knew none of them, so a project configured only through prettier.config.ts was never formatted by post-edit-format, quality-gate or the Stop batch. config-protection's rc pattern stopped at .yaml/.toml, so an existing .prettierrc.ts or .prettierrc.json5 could be edited freely.
2026-10-22 23:51:32 +02:00
L4XB cd1f5b74e2 fix(hooks): match tsc diagnostics by the file they name
The Stop typecheck reported every tsc line that contained the edited path anywhere. A root index.ts has the relative path `index.ts`, which every `src/index.ts(...)` diagnostic contains, so a clean root file was reported with the errors of src/index.ts. The same happened to src/utils.ts with web/src/utils.ts, and to any file named in another file's message.

Compare the path that starts the diagnostic (`path(line,col): `), keeping the slash normalization for Windows.
2026-10-22 23:42:21 +02:00
haelyra a1e84ca67a fix(opensource): permit only untracked reports at publish gate 2026-10-20 18:53:51 -04:00
haelyra 3ffb0d90af Merge branch 'stewardship/verified-pr-batch-3602-3621-owned' into stewardship/verified-pr-batch-3569-3578-owned 2026-10-20 18:42:12 -04:00
haelyra 6e11d21dd1 Merge branch 'stewardship/verified-pr-batch-3538-3566' into stewardship/verified-pr-batch-3602-3621-owned 2026-10-20 18:41:32 -04:00
haelyra a6db53f835 fix(inspection): normalize diagnostic-looking Windows filenames 2026-10-20 18:41:19 -04:00
haelyra 071e1fea6d fix(integration): address reviewer portability and guidance 2026-10-20 18:40:59 -04:00
haelyra fcff074e6f Merge branch 'stewardship/verified-pr-batch-3538-3566' into stewardship/verified-pr-batch-3602-3621-owned 2026-10-20 18:28:33 -04:00
haelyra c04d00c15e fix(integration): address review findings in docs and diagnostics 2026-10-20 18:17:37 -04:00
Wen 79d22134e6 fix(opensource-pipeline): drop copied reports from the index even when .gitignore re-includes them
A .gitignore rule outranks .git/info/exclude, so a source project that ships !FORK_REPORT.md made git add -A stage the report. Remove both reports from the index after staging, in the forker's first commit and in every fold-in amend. The history test now runs both documented blocks against a negating .gitignore, prints the Passed/Failed summary for run-all.js, and skips on Windows like the publish-guard test.

(cherry picked from commit f493d9ff66)
2026-10-20 18:01:44 -04:00
Wen feff29fd80 fix(opensource-pipeline): keep pre-existing reports out of the first fork commit
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit 35909e548e)
2026-10-20 18:01:44 -04:00
Wen 1acdd02fb4 fix(opensource-pipeline): publish only the commit the sanitizer scanned
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit 21d914fa77)
2026-10-20 18:01:44 -04:00
Wen f933bad11b fix(frontend-slides): ignore CDPATH when resolving input and output paths
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit 6b53bedc74)
2026-10-20 18:01:43 -04:00
Wen ea8b48860e fix(frontend-slides): make relative PDF output paths absolute before export
The "resolve output to absolute path" step only rebuilt
"$OUTPUT_DIR/$(basename ...)", so ./slides.pdf stayed relative. The
script then cd's into a temp dir, Playwright writes the PDF there, and
the temp dir is deleted. The script prints "PDF exported successfully!"
and then fails on du under set -e, with no PDF produced. This is the
script's own documented example.

Resolve the output directory with cd + pwd, as the input path already
does, and add a stubbed regression test (no network or browser).

Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit f91c14749e)
2026-10-20 18:01:43 -04:00
Wen 59868a9404 fix(ck): escape the skill dir for bash when SessionStart fills it in
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit 00a03ab84f)
2026-10-20 18:01:42 -04:00
Wen cf3408097c fix(ck): run commands from the skill directory and pass JSON through a heredoc
- SKILL.md invoked every script through ~/.claude/skills/ck, which does
  not exist when ck is installed as part of the ECC plugin, so every
  /ck:* command failed with MODULE_NOT_FOUND. Use ${CLAUDE_SKILL_DIR}
  and tell non-Claude hosts to substitute the skill directory. Scripts
  still run from the project directory, since they use it as the
  project path.
- The documented SessionStart command quoted "~/...", which the shell
  never expands. Use $HOME and explain the plugin-install case.
- /ck:init and /ck:save piped JSON through echo '<json>'. Any apostrophe
  ends the quoted string, and init JSON carries README/package.json
  text. Pass it through a quoted heredoc instead.
- session-start.mjs and shared.mjs resolve SKILL.md next to the code
  (import.meta.url), and the hook expands ${CLAUDE_SKILL_DIR} in the
  text it injects.
- encodeProjectPath only replaced '/', while Claude Code maps every
  non-alphanumeric character to '-'. Memory entries for projects whose
  path has a space or dot went to a directory Claude Code never reads.

Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit c920005c2b)
2026-10-20 18:01:42 -04:00
Wen 6839f58cd3 test(delivery-gate): select an interpreter only if it runs Python 3
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit fe861f8983)
2026-10-20 18:01:41 -04:00
Wen 936cf3d040 fix(delivery-gate): honor stop_hook_active and match Claude Code project dir encoding
quality-gate.py never read stop_hook_active, so a condition the agent
cannot fix (disk below 15 GB, an unwritable growth-log) blocked every
Stop and kept the session generating turns. Exit 0 when Claude Code
reports that the Stop hook already forced a continuation.

The memory dir lookup only mapped '/', '\' and ':' to '-'. Claude Code
maps every non-alphanumeric character, so for any project path with a
space the memory dir was never found and enforcement silently became
warn-only.

Align SKILL.md with the code: disk thresholds (remind 50 / warn 30 /
block 15), the disk block applies to every session, the learning-lib
rule and its examples, stderr messages, and the hook timeout, which
Claude Code reads in seconds (5000 meant 83 minutes).

Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit a1385c4397)
2026-10-20 18:01:41 -04:00
haelyra 45a021ea11 test: remove extra trailing blank line from installer coverage 2026-10-20 17:41:33 -04:00
Eneko Ruiz 21e0ab5271 fix(session-aliases): reject array-shaped alias maps
(cherry picked from commit b1668579f6)
2026-10-20 17:40:59 -04:00
Eneko Ruiz 0bdb6a52ab fix: validate session alias titles before saving
(cherry picked from commit e4f9aac414)
2026-10-20 17:40:58 -04:00
Alan Vo 67034687f3 Fix CLAUDE_CONFIG_DIR tilde expansion, blank path fallback, and inline WSL resolver parity
(cherry picked from commit 617ab29f8d)
2026-10-20 17:40:58 -04:00
Alan Vo 5701a4f2e1 fix: respect CLAUDE_CONFIG_DIR with WSL Windows-path conversion
(cherry picked from commit aaacbc7592)
2026-10-20 17:40:58 -04:00
Eneko Ruiz f1c6692f99 fix: include the oldest dashboard window boundary
(cherry picked from commit e32d1a4e4d)
2026-10-20 17:40:58 -04:00
Eneko Ruiz 65f7dfb735 fix: reject missing session database and limit values
(cherry picked from commit 299899941d)
2026-10-20 17:40:57 -04:00
Eneko Ruiz 8f72869987 fix: reject negative execution counters
(cherry picked from commit fed9eebed5)
2026-10-20 17:40:57 -04:00
Eneko Ruiz 3ac640f6cc fix: sort missing inspection dates after pre-epoch timestamps
(cherry picked from commit 774dfd6894)
2026-10-20 17:40:57 -04:00
Eneko Ruiz c2a28b2963 fix: order failure pattern timestamps chronologically
(cherry picked from commit 075d55e9cb)
2026-10-20 17:40:57 -04:00
haelyra 14693070a1 fix: normalize apostrophes inside quoted Windows paths
(cherry picked from commit 8ab9358e18)
2026-10-20 17:38:38 -04:00
Eneko Ruiz c73353e2c7 fix: normalize Windows backup filename suffixes
(cherry picked from commit f685582ebe)
2026-10-20 17:38:38 -04:00
Eneko Ruiz 9388e06ec7 fix: preserve diagnostics after extensionless Windows paths
(cherry picked from commit 2a2e6e3848)
2026-10-20 17:38:38 -04:00
Eneko Ruiz 58b191c25d fix: normalize trailing Windows paths and spaced filenames
(cherry picked from commit c31b1dd80c)
2026-10-20 17:38:38 -04:00
Eneko Ruiz 0931f66775 fix: normalize Windows paths containing spaces and Unicode
(cherry picked from commit 25b775edc1)
2026-10-20 17:38:37 -04:00
Eneko Ruiz 9824f422d2 fix: normalize Windows file paths in failure patterns
(cherry picked from commit e0de4739a9)
2026-10-20 17:38:37 -04:00
haelyra acc24a226f test: align Antigravity guide check with pinned release
(cherry picked from commit da132808b4)
2026-10-20 17:38:26 -04:00
Gaurav Dubey e4666abb01 fix(opencode): ship @opencode-ai/plugin as a runtime dependency
The compiled OpenCode tools import `tool` from `@opencode-ai/plugin/tool`
at module top level, and the hooks plugin imports those tools statically.
The package was only a devDependency, so production installs (OpenCode's
npm plugin cache, `npm install --omit=dev`) could not resolve it and the
whole plugin failed to load.

Move it to `dependencies` and add a build-opencode regression test that
fails when the built bundle imports a package not declared as a runtime
dependency.

Fixes #3543

(cherry picked from commit 106024070e)
2026-10-20 17:38:25 -04:00
Eneko Ruiz 5367671a22 fix: reject missing session inspection option values
(cherry picked from commit a6619f5efd)
2026-10-20 17:38:13 -04:00
ethereal49 f7c6809bd7 fix(commands): address Santa Loop review feedback
(cherry picked from commit 3a0e3313d5)
2026-10-20 17:38:05 -04:00
ethereal49 4aa28ccac5 fix(commands): honor Codex model configuration in Santa Loop
(cherry picked from commit 2109d97b40)
2026-10-20 17:38:04 -04:00
30b68924ae fix(install): treat .pi as a foreign platform path (#3560)
The platform-configs module lists `.pi`, but PLATFORM_SOURCE_PATH_OWNERS
had no entry for it, so isForeignPlatformPath() returned false and every
install-apply target (e.g. `--target opencode`) copied the Pi harness
adapter (.pi/README.md, .pi/extensions/*) into its config root and
recorded it as ECC-managed.

Pi consumes ECC through `pi install`, not install-apply, so map `.pi` to
the `pi` owner. No install target has that id, so the directory is now
filtered out everywhere, like `.codex`, `.cursor`, and `.zed`.

Add regression tests for the opencode plan and for every registered
target.

Fixes #3558

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: haelyra <49814733+haelyra@users.noreply.github.com>
2026-10-20 15:37:53 -04:00