Commit Graph
651 Commits
Author SHA1 Message Date
haelyra 40327476c4 fix: harden review fixtures and isolate audit verification metadata 2026-11-16 13:35:34 -05:00
haelyra 0d5391a486 Merge remote-tracking branch 'origin/pr-3932' into stewardship/20261116 2026-11-16 13:24:55 -05:00
haelyra df287caae9 Merge remote-tracking branch 'origin/pr-3914' into stewardship/20261116 2026-11-16 13:24:34 -05:00
haelyra f2f3375838 Merge remote-tracking branch 'origin/pr-3921' into stewardship/20261116
# Conflicts:
#	manifests/context-packs/skill-triggers@1.json
2026-11-16 13:24:32 -05:00
haelyra 88e8a4db07 Merge remote-tracking branch 'origin/pr-3894' into stewardship/20261116 2026-11-16 13:20:47 -05:00
Neo e6538e2428 fix(hooks): scope MCP health cache to the resolved server 2026-11-13 15:17:12 -05:00
Afloat 0619ff16bd test(metrics): verify NotebookEdit security boundaries
Exercise the real hook with isolated runtime directories. Verify that raw
cell content stays out of persisted metrics and is not executed, notebook
paths remain inert metadata, and traversal session IDs cannot select a
bridge file. Preserve the hook's pass-through input contract.

The focused notebook and bridge suites pass all 36 cases. Targeted
statement/line, branch and function coverage is 91.9%, 85.18% and 100%.
Changed-file ESLint and diff checks pass.
2026-11-13 01:09:07 +08:00
yuhoyuho 322e347a86 fix(gateguard): gate DROP DATABASE, DROP SCHEMA and ALTER TABLE ... DROP COLUMN
DESTRUCTIVE_SQL matched only DROP TABLE, DELETE FROM and TRUNCATE.
`psql -c "DROP DATABASE prod"`, `DROP SCHEMA public CASCADE` and
`ALTER TABLE users DROP COLUMN email` went to the routine gate instead
of the destructive gate, even though each loses at least as much data
as DROP TABLE.

Add DROP DATABASE, DROP SCHEMA and an ALTER TABLE ... DROP COLUMN arm
to the phrase check. The DROP COLUMN arm stops at `;` so it never
matches across two statements. It requires the COLUMN keyword so
ALTER COLUMN ... DROP DEFAULT / DROP NOT NULL stay passive. Existing
literal and quote stripping keeps SQL strings, commit messages and
echo mentions passive.

Update the gateguard trigger list (en, ja-JP, zh-CN) and rebind the
skill-triggers registry digest for the SKILL.md body edit. Skill
descriptions and triggers are unchanged.
2026-11-12 01:08:39 +09:00
Afloat 87b4eed5c1 fix(metrics): fingerprint and track native notebook edits 2026-11-11 21:39:50 +08:00
Angga Julyananda Pradana b37b73248b fix(hooks): preserve Git built-ins with same-name aliases 2026-11-08 12:20:15 +07:00
Angga Julyananda Pradana 69e9facd5a fix: block command-supplied Git alias invocations 2026-11-08 11:45:35 +07:00
haelyra f5ff589cd1 fix: close remaining integration security gaps 2026-11-06 00:10:49 -05:00
haelyra bfb4dbe7b0 fix: harden integration security findings 2026-11-06 00:03:44 -05:00
haelyra b2ea647d41 fix: reconcile combined integration test contracts 2026-11-05 23:53:59 -05:00
haelyra d97367cf76 fix: reconcile reviewed skills, manifests, and dependency locks 2026-11-05 23:38:04 -05:00
haelyra a032472448 Merge reviewed PR #2856
# Conflicts:
#	manifests/context-packs/skill-triggers@1.json
2026-11-05 23:28:21 -05:00
haelyra c9ebc0f2d1 Merge reviewed PR #3853
# Conflicts:
#	scripts/hooks/run-with-flags.js
2026-11-05 23:24:32 -05:00
haelyra cf5c041ea8 Merge reviewed PR #3848 2026-11-05 23:24:06 -05:00
haelyra 5ebf7bd92f Merge reviewed PR #3598
# Conflicts:
#	manifests/context-packs/skill-triggers@1.json
#	manifests/install-profiles.json
2026-11-05 23:13:12 -05:00
haelyra ba3042a85d Merge reviewed PR #2496 2026-11-05 23:13:00 -05:00
haelyra 8b19acc97d Merge reviewed PR #3819
# Conflicts:
#	tests/hooks/block-no-verify.test.js
2026-11-05 23:12:26 -05:00
haelyra da69978575 Merge reviewed PR #3818 2026-11-05 23:12:13 -05:00
haelyra d6c9d06386 Merge reviewed PR #3871
# Conflicts:
#	manifests/context-packs/skill-triggers@1.json
2026-11-05 23:11:24 -05:00
haelyra 01e4f8bd44 Merge reviewed PR #3864 2026-11-05 23:11:09 -05:00
haelyra fceb970215 Merge reviewed PR #3862 2026-11-05 23:11:09 -05:00
haelyra 75322d5bb0 Merge reviewed PR #3675 2026-11-05 23:11:08 -05:00
haelyra 5d64ad64f3 Merge reviewed PR #3672
# Conflicts:
#	scripts/hooks/pre-bash-commit-quality.js
2026-11-05 23:10:59 -05:00
haelyra 912fc63c41 Merge reviewed PR #3671 2026-11-05 23:10:45 -05:00
haelyra 632aeb4d76 Merge reviewed PR #3663 2026-11-05 23:10:32 -05:00
haelyra ab10daba18 Merge reviewed PR #3870 2026-11-05 23:10:32 -05:00
haelyra 932d83073e Merge reviewed PR #3858 2026-11-05 23:10:32 -05:00
haelyra 22596737f7 Merge reviewed PR #3829 2026-11-05 23:09:32 -05:00
haelyra 759a3ba299 Merge reviewed PR #3822 2026-11-05 23:09:32 -05:00
haelyra 44de2e5996 Merge reviewed PR #3814 2026-11-05 23:09:32 -05:00
Rahul Selvaraj feac4f52ba fix(hooks): match the full classifier notice, isolate test env
CLASSIFIER_NOTICE matched by prefix, so a pasted notice followed by a
user question was dropped from both summary paths. Anchor it to the
whole message so trailing user text is kept, and add a regression test.

Also pass ECC_SKIP_LLM_SUMMARY=1 in the withTranscript fixture helper so
an inherited ECC_LLM_SUMMARY_INTERVAL=1 cannot trigger claude -p.

Refs #3867

Assisted-by: Claude <noreply@anthropic.com>
2026-11-06 08:47:21 +08:00
montjeffrey 16a200e4bc test(clv2): isolate the launcher tests and cover aliases the Install Manager may not own
Clear CLV2_NO_PROJECT and PYTHON_MANAGER_DEFAULT from the inherited
environment: with CLV2_NO_PROJECT=1 exported, detect-project.sh returned
before hashing and the project-hash test failed.

Add cases where the alias should be kept: Microsoft Store Python also
provides it, so either package may own it, and PYTHON_MANAGER_DEFAULT is
set, which the alias honours and the Python\bin shortcut does not.
2026-11-05 14:07:51 -05:00
L4XB fee3d08666 fix(hooks): drop line continuations before checking text after a commit here-document
In double quotes Bash drops a backslash-newline before it expands
anything, so a tail of `$\<newline>HOME` after the substitution's `)` is
`$HOME` and expands. The expansion check read the tail with the
continuation still in it and saw an escaped newline, so the hook
validated `fix: a$HOME` with no warning. Continuations are now dropped
first, while other escapes stay for the check: `\$\<newline>HOME` is
still the literal `$HOME`.
2026-11-05 14:36:26 +01:00
Karim Masmoudi f0f68e6307 fix(continuous-learning-v2): redact short-payload JWTs and suffixed sk- keys
A JWT with a short claims segment such as e30 ({}) matched neither the
full JWT branch nor the cut-tail branch and was saved as is. The payload
segment now only needs one character.

A generic sk- key followed by "-" or "_" failed its lookahead and was
skipped whole. It is now redacted to the end of the token. Branch names
like sk-learn-upgrade stay readable because they have fewer than 20
alphanumerics after the prefix.

Adds a test that the two pattern copies in observe.sh are identical and
that they run in linear time on 300 KB of adversarial input (#2278).
2026-11-05 14:15:21 +01:00
L4XB 32284723b2 test(hooks): move the output summary tests into their own file
The redaction and privacy cases grew session-activity-tracker.test.js to 845 lines, past the 800 that AGENTS.md allows. They move to session-activity-tracker-output.test.js; the original file is back to 758 lines.
2026-11-05 13:29:55 +01:00
L4XB 2ff19fafa0 fix(hooks): read text after a commit here-document's substitution
In `-m "$(cat <<'EOF' … EOF\n)."` Bash drops the body's trailing newlines
and adds the period, so Git records `fix: update input.`, but the hook
checked only the here-document and missed the trailing-period warning.
Read the rest of the quoted value after the substitution's `)` and add
it to the message as double-quoted text. Commands or an expansion after
the here-document make the message unverifiable, as an expansion in an
unquoted body already does. The here-document reading moves into
readHeredocMessage, which also returns the Bash 3.2 note.
2026-11-05 13:22:57 +01:00
L4XB 30eb570117 fix(hooks): read NUL-ended delimiters, Bash blanks before #, and long bodies
Bash ends a decoded $'...' string at its first NUL, so `cat <<$'EOF\0X'`
ends at the line EOF, but the splitter looked for EOF\0X and swallowed
the commands after the body. A carriage return or a no-break space is
not a blank to Bash, so `echo foo\r# && npm run dev` runs the dev
server, but the splitter read the # as a comment. And spreading a long
substitution's segments into push() threw RangeError, which the hook's
catch turned into an allow. Truncate the decoded part at the NUL, use
Bash's blanks for word starts, and append the segments one at a time.
2026-11-05 13:07:21 +01:00
L4XB 31866936b9 fix(hooks): keep printf arguments literal, model descriptor copies, charge expansion
printf decoded escapes in %s arguments too, so `printf '%s' 'gi\t push
--no-verify' | sh` read as `gi<tab> push` and passed, while the shell
reads `gi\t` as `git`. Escapes are now decoded in the format and in %b
arguments only. `1<&3` and the move `1>&3-` copy a descriptor like
`1>&3`, so restoring a saved stdout is followed. The format-reuse loop
charges the work budget before each piece, so a short command cannot
expand into a huge string. The bash-backed tests now run what the shell
reads with a stub git, which also sees how the shell unescapes words.
2026-11-05 12:59:29 +01:00
L4XB bf71cdfff1 fix(hooks): follow each producer's descriptors into the shell
A group or pipeline producer counted whatever its redirections said, so
`{ echo 'git push --no-verify' >/dev/null | cat; } | bash` was blocked
although bash reads nothing, and printf filled no %s, so
`printf 'git %s --no-verify\n' push | sh` got through. shell-scan now
keeps a redirection's descriptor, and a stage's output counts only when
its descriptors, the stages after it and an `exec` earlier in its group
take it to the shell; an `exec` is carried only where it adds output.
printf fills %s, %b and %c and reuses its format; other conversions are
read like an unmodeled command. The header states what the model covers.
2026-11-05 12:27:55 +01:00
L4XB ae681a2a66 Merge remote-tracking branch 'origin/main' into fix/block-no-verify-group-piped-into-shell 2026-11-05 12:18:59 +01:00
L4XB a3ced7db06 fix(hooks): keep no structured tool result in activity history
The tracker serialized any structured result with JSON.stringify before
redaction, so an encoding nested in it, such as a double-escaped JSON
token, reached tool-usage.jsonl whole, and Claude Code's Bash stdout went
in as text. Keep text only from the adapter's tool_output, as main did,
and from Claude Code's tool_response only the sizes of stdout and stderr
and its interrupted and image flags. Any other structure is left out.
2026-11-05 11:35:43 +01:00
L4XB 6b9ff09542 Merge remote-tracking branch 'origin/main' into fix/hooks-read-tool-response
# Conflicts:
#	scripts/hooks/hook-input.js
#	tests/hooks/hook-input.test.js
2026-11-05 11:33:26 +01:00
Rahul Selvaraj 846a561a7b fix(hooks): drop classifier notices from LLM summary input
The safety-classifier notice filter only covered the mechanical summary.
When generateSessionSummary runs (low context or message interval),
extractConversationText read the raw transcript and passed the notice to
the LLM as a user turn, so it could still reach saved context.

Move the check into one shared isClassifierNotice() in
scripts/lib/llm-summary.js and use it in both userMessageText() and
extractConversationText(). Add LLM-path regression tests, and split the
session-end classifier-notice tests into small functions (<50 lines).

Refs #3867

Assisted-by: Claude <noreply@anthropic.com>
2026-11-05 18:06:51 +08:00
haelyra 94d2c659ba fix(hooks): scan substitutions nested in expanded here-document bodies
The dev-guard half of 7632669d from #3735: segments that the splitter
reads from an expanded here-document body are scanned again, so a dev
command in a substitution nested inside one is still found.

(split from commit 7632669d28)
2026-11-05 11:05:56 +01:00
L4XB 4ae1f0d812 Merge remote-tracking branch 'origin/main' into fix/commit-quality-subject-line 2026-11-05 10:49:41 +01:00
L4XB 8c67067582 fix(hooks): join continued lines of a commit here-document as bash does
In an unquoted here-document, Bash removes a backslash-newline before Git
receives the message, so `fix: \` followed by `Update input.` commits
`fix: Update input.`, and a delimiter line right after a continued line
does not end the body. Read the body that way, keep `<<-` from stripping
the tabs of a continued line, and drop the backslash before $, ` and \.

A quoted body stays literal, as Bash 4 and later and zsh read it. Inside
"$(...)", Bash 3.2 joins its lines too, so the hook now notes when that
would change the subject.
2026-11-05 10:49:40 +01:00