Files
ECC/tests/lib/shell-split.test.js
T
L4XB 2eee66a6c1 fix(hooks): split shell segments at newlines, keeping here-document bodies whole
splitShellSegments() split at &&, ||, ; and & but not at a newline, so a multi-line command such as "cd app\nnpm run dev" was one segment led by cd, and the dev-server block let the dev server through. A newline now ends a segment. The body of a here-document (<<EOF, <<-EOF, <<'EOF') stays in the segment of the command that reads it, so a README written with cat <<EOF that mentions npm run dev is not blocked; a here-string (<<<) or a shift such as $((x << 2)) is not read as one.
2026-10-23 01:45:20 +02:00

141 lines
5.1 KiB
JavaScript

'use strict';
const assert = require('assert');
const { splitShellSegments } = require('../../scripts/lib/shell-split');
console.log('=== Testing shell-split.js ===\n');
let passed = 0;
let failed = 0;
function test(desc, fn) {
try {
fn();
console.log(` ✓ ${desc}`);
passed++;
} catch (e) {
console.log(` ✗ ${desc}: ${e.message}`);
failed++;
}
}
// Basic operators
console.log('Basic operators:');
test('&& splits into two segments', () => {
assert.deepStrictEqual(splitShellSegments('echo hi && echo bye'), ['echo hi', 'echo bye']);
});
test('|| splits into two segments', () => {
assert.deepStrictEqual(splitShellSegments('echo hi || echo bye'), ['echo hi', 'echo bye']);
});
test('; splits into two segments', () => {
assert.deepStrictEqual(splitShellSegments('echo hi; echo bye'), ['echo hi', 'echo bye']);
});
test('single & splits (background)', () => {
assert.deepStrictEqual(splitShellSegments('sleep 1 & echo hi'), ['sleep 1', 'echo hi']);
});
// Redirection operators should NOT split
console.log('\nRedirection operators (should NOT split):');
test('2>&1 stays as one segment', () => {
const segs = splitShellSegments('cmd 2>&1 | grep error');
assert.strictEqual(segs.length, 1);
});
test('&> stays as one segment', () => {
const segs = splitShellSegments('cmd &> /dev/null');
assert.strictEqual(segs.length, 1);
});
test('>& stays as one segment', () => {
const segs = splitShellSegments('cmd >& /dev/null');
assert.strictEqual(segs.length, 1);
});
// Quoting
console.log('\nQuoting:');
test('double-quoted && not split', () => {
const segs = splitShellSegments('tmux new -d "cd /app && echo hi"');
assert.strictEqual(segs.length, 1);
});
test('single-quoted && not split', () => {
const segs = splitShellSegments("tmux new -d 'cd /app && echo hi'");
assert.strictEqual(segs.length, 1);
});
test('double-quoted ; not split', () => {
const segs = splitShellSegments('echo "hello; world"');
assert.strictEqual(segs.length, 1);
});
// Escaped quotes
console.log('\nEscaped quotes:');
test('escaped double quote inside double quotes', () => {
const segs = splitShellSegments('echo "hello \\"world\\"" && echo bye');
assert.strictEqual(segs.length, 2);
});
test('escaped single quote inside single quotes', () => {
const segs = splitShellSegments("echo 'hello \\'world\\'' && echo bye");
assert.strictEqual(segs.length, 2);
});
// Escaped operators outside quotes
console.log('\nEscaped operators outside quotes:');
test('escaped && outside quotes not split', () => {
const segs = splitShellSegments('tmux new-session -d bash -lc cd /app \\&\\& npm run dev');
assert.strictEqual(segs.length, 1);
});
test('escaped ; outside quotes not split', () => {
const segs = splitShellSegments('echo hello \\; echo bye');
assert.strictEqual(segs.length, 1);
});
// Complex real-world cases
console.log('\nReal-world cases:');
test('tmux new-session with quoted compound command', () => {
const segs = splitShellSegments('tmux new-session -d -s dev "cd /app && npm run dev"');
assert.strictEqual(segs.length, 1);
assert.ok(segs[0].includes('tmux'));
assert.ok(segs[0].includes('npm run dev'));
});
test('chained: tmux ls then bare dev', () => {
const segs = splitShellSegments('tmux ls; npm run dev');
assert.strictEqual(segs.length, 2);
assert.strictEqual(segs[1], 'npm run dev');
});
test('background dev server', () => {
const segs = splitShellSegments('npm run dev & echo started');
assert.strictEqual(segs.length, 2);
assert.strictEqual(segs[0], 'npm run dev');
});
test('empty string returns empty array', () => {
assert.deepStrictEqual(splitShellSegments(''), []);
});
test('single command no operators', () => {
assert.deepStrictEqual(splitShellSegments('npm run dev'), ['npm run dev']);
});
// Newlines and here-documents
console.log('\nNewlines and here-documents:');
test('a newline splits into two segments', () => {
assert.deepStrictEqual(splitShellSegments('cd app\nnpm run dev'), ['cd app', 'npm run dev']);
assert.deepStrictEqual(splitShellSegments('a && b\n\nc'), ['a', 'b', 'c']);
});
test('an escaped or quoted newline does not split', () => {
assert.deepStrictEqual(splitShellSegments('npm run \\\ndev'), ['npm run \\\ndev']);
assert.deepStrictEqual(splitShellSegments('echo "a\nb"'), ['echo "a\nb"']);
});
test('a here-document body stays with its command', () => {
assert.deepStrictEqual(
splitShellSegments('cat <<EOF > notes.md\na && b\nnpm run dev\nEOF\nls'),
['cat <<EOF > notes.md\na && b\nnpm run dev\nEOF', 'ls']
);
assert.deepStrictEqual(
splitShellSegments("cat <<-'END'\n\tnpm run dev\n\tEND\nls"),
["cat <<-'END'\n\tnpm run dev\n\tEND", 'ls']
);
assert.deepStrictEqual(splitShellSegments('cat <<A <<B\na\nA\nb\nB\nnext'), ['cat <<A <<B\na\nA\nb\nB', 'next']);
});
test('a here-string or a shift is not a here-document', () => {
assert.deepStrictEqual(splitShellSegments('cat <<< x && y'), ['cat <<< x', 'y']);
assert.deepStrictEqual(splitShellSegments('echo $((x << 2))\nnext'), ['echo $((x << 2))', 'next']);
});
console.log(`\n=== Results: ${passed} passed, ${failed} failed ===`);
if (failed > 0) process.exit(1);