Merge #636: keep fixture commits independent of user signing settings

This commit is contained in:
Addy Osmani authored and GitHub committed 2026-10-10 01:23:00 -07:00
commit 10c5687dc4
2 files changed
+22

No files matched your search

+21
View File
@@ -621,3 +621,24 @@ test('materializes a git baseline and applies a working-tree patch', () => {
fs.rmSync(workspace, { recursive: true, force: true });
}
});
test('fixture baseline commits ignore inherited user signing requirements', () => {
const root = makeSandbox();
const config = path.join(root, 'global.gitconfig');
const temp = fs.mkdtempSync(path.join(os.tmpdir(), 'fixture-signing-test-'));
try {
fs.writeFileSync(config, '[commit]\n\tgpgsign = true\n[gpg]\n\tprogram = definitely-missing-eval-signer\n');
const result = spawnSync(process.execPath, ['-e', `
const fs = require('node:fs');
const { materializeWorkspace } = require(${JSON.stringify(path.join(root, 'scripts', 'run-evals.js'))});
let workspace;
try { workspace = materializeWorkspace({ files: ['project/context.txt'] }); }
finally { if (workspace) fs.rmSync(workspace, { recursive: true, force: true }); }
`], { cwd: root, encoding: 'utf8', env: { ...process.env, GIT_CONFIG_GLOBAL: config, TMPDIR: temp, TMP: temp, TEMP: temp } });
assert.equal(result.status, 0, result.stdout + result.stderr);
} finally {
fs.rmSync(root, { recursive: true, force: true });
fs.rmSync(temp, { recursive: true, force: true });
}
});
+1
View File
@@ -412,6 +412,7 @@ function materializeWorkspace(ev) {
// throwaway workspace.
execFileSync('git', ['init', '--quiet'], { cwd: workspace });
execFileSync('git', ['config', 'core.autocrlf', 'false'], { cwd: workspace });
execFileSync('git', ['config', 'commit.gpgsign', 'false'], { cwd: workspace });
execFileSync('git', ['config', 'user.name', 'Skill Eval'], { cwd: workspace });
execFileSync('git', ['config', 'user.email', 'skill-eval@example.invalid'], { cwd: workspace });
execFileSync('git', ['add', '--all'], { cwd: workspace });