mirror of
https://github.com/addyosmani/agent-skills.git
synced 2026-10-26 15:05:04 +00:00
docs: /review and /test run in the main session; align review severity labels
docs/agents.md and two persona files said /review and /test wrap the code-reviewer and test-engineer personas. They invoke a skill in the main session and spawn nothing (#681). The review commands also still asked for Critical/Important/Suggestion while the skill and persona use Critical/Required/Optional/Nit, and /ship named the old labels.
This commit is contained in:
1 parent
1be8e34187
commit
2bdbe1f5a6
10 files changed
+12
-10
No files matched your search
@@ -12,5 +12,5 @@ Review the current changes (staged or recent commits) across all five axes:
|
|||||||
4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill)
|
4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill)
|
||||||
5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill)
|
5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill)
|
||||||
|
|
||||||
Categorize findings as Critical, Important, or Suggestion.
|
Categorize findings as Critical, Required, Optional, or Nit.
|
||||||
Output a structured review with specific file:line references and fix recommendations.
|
Output a structured review with specific file:line references and fix recommendations.
|
||||||
@@ -29,7 +29,7 @@ Constraints (from Claude Code's subagent model):
|
|||||||
|
|
||||||
Once all three reports are back, the main agent (not a sub-persona) synthesizes them:
|
Once all three reports are back, the main agent (not a sub-persona) synthesizes them:
|
||||||
|
|
||||||
1. **Code Quality** — Aggregate Critical/Important findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers.
|
1. **Code Quality** — Aggregate Critical/Required findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers.
|
||||||
2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis.
|
2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis.
|
||||||
3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable.
|
3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable.
|
||||||
4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist).
|
4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist).
|
||||||
|
|||||||
@@ -11,6 +11,6 @@ Review the current changes (staged or recent commits) across all five axes:
|
|||||||
4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill)
|
4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill)
|
||||||
5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill)
|
5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill)
|
||||||
|
|
||||||
Categorize findings as Critical, Important, or Suggestion.
|
Categorize findings as Critical, Required, Optional, or Nit.
|
||||||
Output a structured review with specific file:line references and fix recommendations.
|
Output a structured review with specific file:line references and fix recommendations.
|
||||||
"""
|
"""
|
||||||
@@ -28,7 +28,7 @@ Constraints (from Gemini CLI's subagent model):
|
|||||||
|
|
||||||
Once all three reports are back, the main agent (not a sub-persona) synthesizes them:
|
Once all three reports are back, the main agent (not a sub-persona) synthesizes them:
|
||||||
|
|
||||||
1. **Code Quality** — Aggregate Critical/Important findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers.
|
1. **Code Quality** — Aggregate Critical/Required findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers.
|
||||||
2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis.
|
2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis.
|
||||||
3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable.
|
3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable.
|
||||||
4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist).
|
4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist).
|
||||||
|
|||||||
@@ -35,6 +35,8 @@ Skills encode the workflows, quality gates, and best practices that senior engin
|
|||||||
| Simplify the code | `/code-simplify` | Clarity over cleverness |
|
| Simplify the code | `/code-simplify` | Clarity over cleverness |
|
||||||
| Ship to production | `/ship` | Faster is safer |
|
| Ship to production | `/ship` | Faster is safer |
|
||||||
|
|
||||||
|
In Claude Code these install as plugin commands. Where a built-in command has the same name, as `/review` does, use the namespaced form: `/agent-skills:review`.
|
||||||
|
|
||||||
Want fewer manual steps once the spec exists? **`/build auto`** generates the plan and implements every task in a single approved pass — you approve the plan once, then it runs autonomously. It removes the human stepping *between* tasks, not the verification: every task is still test-driven and committed individually, and it pauses on failures or risky steps.
|
Want fewer manual steps once the spec exists? **`/build auto`** generates the plan and implements every task in a single approved pass — you approve the plan once, then it runs autonomously. It removes the human stepping *between* tasks, not the verification: every task is still test-driven and committed individually, and it pauses on failures or risky steps.
|
||||||
|
|
||||||
Skills also activate automatically based on what you're doing — designing an API triggers `api-and-interface-design`, building UI triggers `frontend-ui-engineering`, and so on.
|
Skills also activate automatically based on what you're doing — designing an API triggers `api-and-interface-design`, building UI triggers `frontend-ui-engineering`, and so on.
|
||||||
|
|||||||
@@ -98,5 +98,5 @@ Categorize every finding, using the same severity labels as the `code-review-and
|
|||||||
## Composition
|
## Composition
|
||||||
|
|
||||||
- **Invoke directly when:** the user asks for a review of a specific change, file, or PR.
|
- **Invoke directly when:** the user asks for a review of a specific change, file, or PR.
|
||||||
- **Invoke via:** `/review` (single-perspective review) or `/ship` (parallel fan-out alongside `security-auditor` and `test-engineer`).
|
- **Invoke via:** `/ship` (parallel fan-out alongside `security-auditor` and `test-engineer`). `/review` runs the `code-review-and-quality` skill in the main session and does not spawn this persona.
|
||||||
- **Do not invoke from another persona.** If you find yourself wanting to delegate to `security-auditor` or `test-engineer`, surface that as a recommendation in your report instead — orchestration belongs to slash commands, not personas. See [docs/agents.md](../docs/agents.md).
|
- **Do not invoke from another persona.** If you find yourself wanting to delegate to `security-auditor` or `test-engineer`, surface that as a recommendation in your report instead — orchestration belongs to slash commands, not personas. See [docs/agents.md](../docs/agents.md).
|
||||||
@@ -91,5 +91,5 @@ When analyzing test coverage:
|
|||||||
## Composition
|
## Composition
|
||||||
|
|
||||||
- **Invoke directly when:** the user asks for test design, coverage analysis, or a Prove-It test for a specific bug.
|
- **Invoke directly when:** the user asks for test design, coverage analysis, or a Prove-It test for a specific bug.
|
||||||
- **Invoke via:** `/test` (TDD workflow) or `/ship` (parallel fan-out for coverage gap analysis alongside `code-reviewer` and `security-auditor`).
|
- **Invoke via:** `/ship` (parallel fan-out for coverage gap analysis alongside `code-reviewer` and `security-auditor`). `/test` runs the `test-driven-development` skill in the main session and does not spawn this persona.
|
||||||
- **Do not invoke from another persona.** Recommendations to add tests belong in your report; the user or a slash command decides when to act on them. See [docs/agents.md](../docs/agents.md).
|
- **Do not invoke from another persona.** Recommendations to add tests belong in your report; the user or a slash command decides when to act on them. See [docs/agents.md](../docs/agents.md).
|
||||||
@@ -11,6 +11,6 @@ Review the current changes (staged or recent commits) across all five axes:
|
|||||||
4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill)
|
4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill)
|
||||||
5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill)
|
5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill)
|
||||||
|
|
||||||
Categorize findings as Critical, Important, or Suggestion.
|
Categorize findings as Critical, Required, Optional, or Nit.
|
||||||
Output a structured review with specific file:line references and fix recommendations.
|
Output a structured review with specific file:line references and fix recommendations.
|
||||||
"""
|
"""
|
||||||
+1
-1
@@ -28,7 +28,7 @@ Constraints (from CLI's subagent model):
|
|||||||
|
|
||||||
Once all three reports are back, the main agent (not a sub-persona) synthesizes them:
|
Once all three reports are back, the main agent (not a sub-persona) synthesizes them:
|
||||||
|
|
||||||
1. **Code Quality** — Aggregate Critical/Important findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers.
|
1. **Code Quality** — Aggregate Critical/Required findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers.
|
||||||
2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis.
|
2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis.
|
||||||
3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable.
|
3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable.
|
||||||
4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist).
|
4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist).
|
||||||
|
|||||||
+2
-2
@@ -34,10 +34,10 @@ Pick this when you want one perspective on the current change and the user is in
|
|||||||
### Slash command (single persona behind it)
|
### Slash command (single persona behind it)
|
||||||
Pick this when there's a repeatable workflow you'd otherwise re-explain every time.
|
Pick this when there's a repeatable workflow you'd otherwise re-explain every time.
|
||||||
|
|
||||||
- `/review` → wraps `code-reviewer` with the project's review skill
|
|
||||||
- `/test` → wraps `test-engineer` with TDD skill
|
|
||||||
- `/webperf` → wraps `web-performance-auditor` for performance-focused audits on web apps
|
- `/webperf` → wraps `web-performance-auditor` for performance-focused audits on web apps
|
||||||
|
|
||||||
|
`/review` and `/test` are not persona wrappers. They run the `code-review-and-quality` and `test-driven-development` skills in the main session, where the conversation's context is. To get `code-reviewer` or `test-engineer` in a fresh context, invoke the persona directly or run `/ship`.
|
||||||
|
|
||||||
### Slash command (orchestrator — fan-out)
|
### Slash command (orchestrator — fan-out)
|
||||||
Pick this only when **independent** investigations can run in parallel and produce reports that a single agent then merges.
|
Pick this only when **independent** investigations can run in parallel and produce reports that a single agent then merges.
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user