OpenSource/jellyfin-web
1
0 Fork 0
mirror of https://github.com/jellyfin/jellyfin-web.git synced 2026-10-26 16:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8521 from thedreaddpirate/saveSubtitlesInternal

Browse Source 
Exposes subtitle save path setting regardless if fetcher is installed
This commit is contained in:
Bill Thornton authored and GitHub committed 2026-09-25 10:44:26 -04:00
2 parents 972a2e9418 7a2050fb75
commit 656667fc72
3 files changed
+42 -36
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

CONTRIBUTORS.md
+1
View File
@@ -110,6 +110,7 @@
- [austinhardaway](https://github.com/austinhardaway)
- [Alex Dickens](https://github.com/alex-dicko)
- [shindouj](https://github.com/shindouj)
- [TheDreadPirate](https://github.com/thedreaddpirate)
## Emby Contributors
src/components/libraryoptionseditor/libraryoptionseditor.js
+3 -1
View File
@@ -406,7 +406,7 @@ function populateMetadataSettings(parent, contentType) {
renderMediaSegmentProviders(parent, availableOptions, {});
renderImageFetchers(parent, availableOptions, {});
renderSimilarItemProviders(parent, availableOptions, {});
availableOptions.SubtitleFetchers.length ? parent.querySelector('.subtitleDownloadSettings').classList.remove('hide') : parent.querySelector('.subtitleDownloadSettings').classList.add('hide');
availableOptions.SubtitleFetchers.length ? parent.querySelector('.subtitleProviderSettings').classList.remove('hide') : parent.querySelector('.subtitleProviderSettings').classList.add('hide');
}).catch(() => {
return Promise.resolve();
});
@@ -557,8 +557,10 @@ export function setContentType(parent, contentType) {
if (contentType === 'tvshows' || contentType === 'movies' || contentType === 'musicvideos' || contentType === 'mixed') {
parent.querySelector('.fldAllowEmbeddedSubtitlesContainer').classList.remove('hide');
parent.querySelector('.subtitleDownloadSettings').classList.remove('hide');
} else {
parent.querySelector('.fldAllowEmbeddedSubtitlesContainer').classList.add('hide');
parent.querySelector('.subtitleDownloadSettings').classList.add('hide');
}
if (contentType === 'music') {
src/components/libraryoptionseditor/libraryoptionseditor.template.html
+38 -35
View File
@@ -166,45 +166,48 @@ <h2>${HeaderChapterImages}</h2>
<div class="subtitleDownloadSettings hide">
<h2>${HeaderSubtitleDownloads}</h2>
<div class="subtitleProviderSettings hide">
<div>
<h3 class="checkboxListLabel">${LabelDownloadLanguages}</h3>
<div class="subtitleDownloadLanguages paperList checkboxList" style="max-height: 10.5em; overflow-y: auto; padding: .5em 1em;">
</div>
</div>
<br />
<div>
<h3 class="checkboxListLabel">${LabelDownloadLanguages}</h3>
<div class="subtitleDownloadLanguages paperList checkboxList" style="max-height: 10.5em; overflow-y: auto; padding: .5em 1em;">
<div class="subtitleFetchers advanced" style="margin-bottom: 2em;">
</div>
<div class="checkboxContainer checkboxContainer-withDescription">
<label>
<input is="emby-checkbox" type="checkbox" id="chkRequirePerfectMatch" checked />
<span>${OptionRequirePerfectSubtitleMatch}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${OptionRequirePerfectSubtitleMatchHelp}</div>
</div>
<div class="checkboxContainer checkboxContainer-withDescription advanced">
<label>
<input is="emby-checkbox" type="checkbox" id="chkSkipIfAudioTrackPresent" />
<span>${LabelSkipIfAudioTrackPresent}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${LabelSkipIfAudioTrackPresentHelp}</div>
</div>
<div class="checkboxContainer checkboxContainer-withDescription advanced">
<label>
<input is="emby-checkbox" type="checkbox" id="chkSkipIfGraphicalSubsPresent" />
<span>${LabelSkipIfGraphicalSubsPresent}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${LabelSkipIfGraphicalSubsPresentHelp}</div>
</div>
</div>
<br />
<div class="subtitleFetchers advanced" style="margin-bottom: 2em;">
</div>
<div class="checkboxContainer checkboxContainer-withDescription">
<label>
<input is="emby-checkbox" type="checkbox" id="chkRequirePerfectMatch" checked />
<span>${OptionRequirePerfectSubtitleMatch}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${OptionRequirePerfectSubtitleMatchHelp}</div>
</div>
<div class="checkboxContainer checkboxContainer-withDescription advanced">
<label>
<input is="emby-checkbox" type="checkbox" id="chkSkipIfAudioTrackPresent" />
<span>${LabelSkipIfAudioTrackPresent}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${LabelSkipIfAudioTrackPresentHelp}</div>
</div>
<div class="checkboxContainer checkboxContainer-withDescription advanced">
<label>
<input is="emby-checkbox" type="checkbox" id="chkSkipIfGraphicalSubsPresent" />
<span>${LabelSkipIfGraphicalSubsPresent}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${LabelSkipIfGraphicalSubsPresentHelp}</div>
</div>
<div class="checkboxContainer checkboxContainer-withDescription advanced">
<label>
<input type="checkbox" is="emby-checkbox" id="chkSaveSubtitlesLocally" checked />
<span>${SaveSubtitlesIntoMediaFolders}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${SaveSubtitlesIntoMediaFoldersHelp}</div>
<div class="fldSaveSubtitlesSettings">
<div class="checkboxContainer checkboxContainer-withDescription">
<label>
<input type="checkbox" is="emby-checkbox" id="chkSaveSubtitlesLocally" checked />
<span>${SaveSubtitlesIntoMediaFolders}</span>
</label>
<div class="fieldDescription checkboxFieldDescription">${SaveSubtitlesIntoMediaFoldersHelp}</div>
</div>
</div>
</div>