Merge pull request #18161 from thedreaddpirate/checkTrickplayMediaDir

Check media directory write permission before generating trickplays
This commit is contained in:
Cody Robibero authored and GitHub committed 2026-09-27 15:30:36 -04:00
commit a1a0441daa
2 files changed
+10

No files matched your search

+1
View File
@@ -244,6 +244,7 @@
- [Oggeb1](https://github.com/Oggeb1)
- [scr4bble](https://github.com/scr4bble)
- [Mateus Bandeira](https://github.com/mateusbandeiraa)
- [TheDreadPirate](https://github.com/thedreaddpirate)
# Emby Contributors
@@ -11,6 +11,7 @@ using AsyncKeyedLock;
using J2N.Collections.Generic.Extensions;
using Jellyfin.Database.Implementations;
using Jellyfin.Database.Implementations.Entities;
using Jellyfin.Extensions;
using MediaBrowser.Common.Configuration;
using MediaBrowser.Controller.Configuration;
using MediaBrowser.Controller.Drawing;
@@ -478,6 +479,14 @@ public partial class TrickplayManager : ITrickplayManager
var mediaStream = mediaSource.VideoStream;
var container = mediaSource.Container;
// Checks for write permission before generating images
if (saveWithMedia)
{
_logger.LogDebug("Verifying write permission in media directory {OutputDir}", outputDir);
Directory.CreateDirectory(outputDir.FullName);
FileHelper.CreateEmpty(Path.Combine(outputDir.FullName, ".jellyfin-trickplay"));
}
_logger.LogInformation("Creating trickplay files at {Width} width, for {Path} [ID: {ItemId}]", actualWidth, mediaPath, video.Id);
imgTempDir = await _mediaEncoder.ExtractVideoImagesOnIntervalAccelerated(
mediaPath,