improving the filtering rules

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@11293 71c3de6d-444a-0410-be80-ed276b4c234a
This commit is contained in:
kohsuke committed 2008-08-06 20:49:45 +00:00
1 parent c3790ef9f9
commit 7bbc1763ac
1 file changed
+29 -13
+29 -13
View File
@@ -1,7 +1,16 @@
<FindBugsFilter>
<Match>
<!-- It's hard to imagine a scenario where Hudson is granted higher privilege but called by a lower privileged client. -->
<Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED" />
<Or>
<!-- It's hard to imagine a scenario where Hudson is granted higher privilege but called by a lower privileged client. -->
<Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED" />
<!-- exposing internal data structure via array is considered OK in Hudson. Hudson really doesn't try to defend against the malicious code -->
<Bug pattern="EI_EXPOSE_REP" />
<Bug pattern="EI_EXPOSE_REP2" />
<!-- FindBugs detect false positives. -->
<Bug pattern="SBSC_USE_STRINGBUFFER_CONCATENATION" />
</Or>
</Match>
<Match>
@@ -21,15 +30,6 @@
<Bug pattern="OS_OPEN_STREAM" />
</Match>
<Match>
<!-- these classes are not meant to be serializable -->
<Or>
<Class name="hudson.maven.MavenBuild$ProxyImpl" />
<Class name="hudson.maven.MavenBuild$ProxyImpl2" />
</Or>
<Bug code="SE" />
</Match>
<Match>
<!-- this use of mutable static field is necessary to propagate a value inside Maven. -->
<Class name="hudson.maven.MavenBuilder" />
@@ -37,8 +37,13 @@
</Match>
<Match>
<!-- this class is not really serialized -->
<Class name="hudson.maven.MavenProbeAction" />
<!-- this class is not serialized -->
<Or>
<Class name="hudson.maven.MavenProbeAction" />
<Class name="hudson.maven.SplittableBuildListener" />
<Class name="hudson.maven.MavenBuild$ProxyImpl" />
<Class name="hudson.maven.MavenBuild$ProxyImpl2" />
</Or>
<Bug code="SE" />
</Match>
@@ -48,4 +53,15 @@
<Bug code="SE" />
</Match>
<Match>
<Class name="hudson.util.ProcessTreeKiller$Unix$UnixSystem" />
<Bug pattern="DMI_HARDCODED_ABSOLUTE_FILENAME" />
</Match>
<Match>
<!-- Can't change this for backward compatibility -->
<Class name="hudson.tasks.BuildWrapper$Environment" />
<Bug pattern="SIC_INNER_SHOULD_BE_STATIC" />
</Match>
</FindBugsFilter>