mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-17 05:52:26 +00:00
Gratuitous use of Permalink constants when there are standard methods for the purpose in Job.
This commit is contained in:
1 parent
f484daf01e
commit
8a79907280
1 file changed
+2
-2
@@ -938,7 +938,7 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
|
||||
@SuppressWarnings("unchecked")
|
||||
protected List<RunT> getEstimatedDurationCandidates() {
|
||||
List<RunT> candidates = new ArrayList<RunT>(3);
|
||||
RunT lastSuccessful = (RunT) Permalink.LAST_SUCCESSFUL_BUILD.resolve(this);
|
||||
RunT lastSuccessful = getLastSuccessfulBuild();
|
||||
int lastSuccessfulNumber = -1;
|
||||
if (lastSuccessful != null) {
|
||||
candidates.add(lastSuccessful);
|
||||
@@ -946,7 +946,7 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
|
||||
}
|
||||
|
||||
int i = 0;
|
||||
RunT r = (RunT) Permalink.LAST_BUILD.resolve(this);
|
||||
RunT r = getLastBuild();
|
||||
List<RunT> fallbackCandidates = new ArrayList<RunT>(3);
|
||||
while (r != null && candidates.size() < 3 && i < 6) {
|
||||
if (!r.isBuilding() && r.getResult() != null && r.getNumber() != lastSuccessfulNumber) {
|
||||
|
||||
Reference in new issue
Block a user