mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-06 00:25:58 +00:00
stephenc asks to use TODO rather than XXX
This commit is contained in:
1 parent
e67746c97f
commit
b1c82f1e30
38 files changed
+52
-52
No files matched your search
@@ -1075,14 +1075,14 @@ public class Util {
|
||||
// we still prefer to try JNA first as PosixAPI supports even smaller platforms.
|
||||
POSIX posix = PosixAPI.jnr();
|
||||
if (posix.isNative()) {
|
||||
// XXX should we rethrow PosixException as IOException here?
|
||||
// TODO should we rethrow PosixException as IOException here?
|
||||
r = posix.symlink(targetPath,symlinkFile.getAbsolutePath());
|
||||
}
|
||||
}
|
||||
}
|
||||
if (r==null) {
|
||||
// if all else fail, fall back to the most expensive approach of forking a process
|
||||
// XXX is this really necessary? JavaPOSIX should do this automatically
|
||||
// TODO is this really necessary? JavaPOSIX should do this automatically
|
||||
r = new LocalProc(new String[]{
|
||||
"ln","-s", targetPath, symlinkPath},
|
||||
new String[0],listener.getLogger(), baseDir).join();
|
||||
|
||||
Reference in new issue
Block a user