mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-16 05:22:22 +00:00
stephenc asks to use TODO rather than XXX
This commit is contained in:
1 parent
e67746c97f
commit
b1c82f1e30
38 files changed
+52
-52
No files matched your search
@@ -451,7 +451,7 @@ public class JenkinsRule implements TestRule, MethodRule, RootAction {
|
||||
// but because there's no explicit dispose method on ClassLoader, they won't get GC-ed until
|
||||
// at some later point, leading to possible file descriptor overflow. So encourage GC now.
|
||||
// see http://bugs.sun.com/view_bug.do?bug_id=4950148
|
||||
// XXX use URLClassLoader.close() in Java 7
|
||||
// TODO use URLClassLoader.close() in Java 7
|
||||
System.gc();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -63,7 +63,7 @@ public class MemoryAssert {
|
||||
* @param max the maximum desired memory usage (in bytes)
|
||||
*/
|
||||
public static void assertHeapUsage(Object o, int max) throws Exception {
|
||||
// XXX could use ScannerUtils.recursiveSizeOf here
|
||||
// TODO could use ScannerUtils.recursiveSizeOf here
|
||||
CountingVisitor v = new CountingVisitor();
|
||||
ScannerUtils.scan(ScannerUtils.skipNonStrongReferencesFilter(), v, Collections.singleton(o), false);
|
||||
int memoryUsage = v.getTotalSize();
|
||||
|
||||
@@ -226,7 +226,7 @@ public class MockFolder extends AbstractItem implements ModifiableTopLevelItemGr
|
||||
}
|
||||
|
||||
@Override public List<Action> getViewActions() {
|
||||
// XXX what should the default be? View.getOwnerViewActions uses Jenkins.actions; Jenkins.viewActions would make more sense as a default;
|
||||
// TODO what should the default be? View.getOwnerViewActions uses Jenkins.actions; Jenkins.viewActions would make more sense as a default;
|
||||
// or should it be empty by default since non-top-level folders probably do not need the same actions as root?
|
||||
return Collections.emptyList();
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user