lsof report from an user (Ray V) revealed file handle leaks here, so maybe some XSLT implementations don't close the stream correctly.

So I decided to open/close streams by myself.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3442 71c3de6d-444a-0410-be80-ed276b4c234a
This commit is contained in:
kohsuke committed 2007-06-14 05:41:48 +00:00
1 parent c1a629781e
commit bfb1f246ee
1 file changed
+11 -1
@@ -56,6 +56,8 @@ import java.io.IOException;
import java.io.PrintWriter;
import java.io.Serializable;
import java.io.StringWriter;
import java.io.BufferedOutputStream;
import java.io.OutputStream;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
@@ -173,7 +175,15 @@ public class SubversionSCM extends SCM implements Serializable {
return createEmptyChangeLog(changelogFile, listener, "log");
}
if(!new SubversionChangeLogBuilder(build,listener,this).run(externals,new StreamResult(changelogFile)))
OutputStream os = new BufferedOutputStream(new FileOutputStream(changelogFile));
boolean r;
try {
r = new SubversionChangeLogBuilder(build, listener, this).run(externals, new StreamResult(changelogFile));
} finally {
os.close();
}
if(!r)
createEmptyChangeLog(changelogFile, listener, "log");
return true;