OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-14 12:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a couple more tests and some comments about the error source.

Browse Source
This commit is contained in:
Jeff Thompson committed 2020-02-11 14:10:12 -07:00
1 parent aad2b10875
commit eead355179
1 file changed
+39 -2
Download Patch File Download Diff File Expand all files Collapse all files
test/src/test/java/jenkins/security/StackTraceSuppressionFilterTest.java
+39 -2
View File
@@ -70,7 +70,9 @@ public class StackTraceSuppressionFilterTest {
// @Test
// public void nonexistentAdjunct() throws Exception {
// // This test belongs in Stapler but it's easy to put it together here.
// /* This test belongs in Stapler but it's easy to put it together here.
// This test is based upon Stapler throwing an exception for this broken request.
// If Stapler is improved to better handle this error, this test may erroneously fail. */
// JenkinsRule.WebClient wc = j.createWebClient();
//
// wc.setThrowExceptionOnFailingStatusCode(false);
@@ -83,7 +85,9 @@ public class StackTraceSuppressionFilterTest {
//
// @Test
// public void nonexistentAdjunctShowsTrace() throws Exception {
// // This test belongs in Stapler but it's easy to put it together here.
// /* This test belongs in Stapler but it's easy to put it together here.
// This test is based upon Stapler throwing an exception for this broken request.
// If Stapler is improved to better handle this error, this test may erroneously fail. */
// JenkinsRule.WebClient wc = j.createWebClient();
// HttpResponses.SHOW_STACK_TRACE = true;
//
@@ -97,6 +101,9 @@ public class StackTraceSuppressionFilterTest {
@Test
public void exception() throws Exception {
/* This test is based upon an incomplete / incorrect project implementation
throwing an uncaught exception.
If Jenkins is improved to better handle this error, this test may erroneously fail. */
FreeStyleProject projectError = createBrokenProject();
JenkinsRule.WebClient wc = j.createWebClient();
@@ -110,6 +117,9 @@ public class StackTraceSuppressionFilterTest {
@Test
public void exceptionShowsTrace() throws Exception {
/* This test is based upon an incomplete / incorrect project implementation
throwing an uncaught exception.
If Jenkins is improved to better handle this error, this test may erroneously fail. */
FreeStyleProject projectError = createBrokenProject();
StackTraceSuppressionFilter.SHOW_STACK_TRACE = true;
@@ -122,6 +132,33 @@ public class StackTraceSuppressionFilterTest {
assertThat(content, not(containsString("An error occurred processing your request. Ask your Jenkins administrator to look up details.")));
}
@Test
public void exceptionEndpoint() throws Exception {
/* This test is based upon a testing endpoint that really shouldn't exist in production code.
If Jenkins is improved to eliminate this endpoint, this test may erroneously fail. */
JenkinsRule.WebClient wc = j.createWebClient();
wc.setThrowExceptionOnFailingStatusCode(false);
HtmlPage page = wc.goTo("exception");
String content = page.getWebResponse().getContentAsString();
assertThat(content, containsString("An error occurred processing your request. Ask your Jenkins administrator to look up details."));
assertThat(content, not(containsString("Oops!")));
}
@Test
public void exceptionEndpointShowsTrace() throws Exception {
/* This test is based upon a testing endpoint that really shouldn't exist in production code.
If Jenkins is improved to eliminate this endpoint, this test may erroneously fail. */
StackTraceSuppressionFilter.SHOW_STACK_TRACE = true;
JenkinsRule.WebClient wc = j.createWebClient();
wc.setThrowExceptionOnFailingStatusCode(false);
HtmlPage page = wc.goTo("exception");
String content = page.getWebResponse().getContentAsString();
assertThat(content, containsString("Oops!"));
assertThat(content, not(containsString("An error occurred processing your request. Ask your Jenkins administrator to look up details.")));
}
private FreeStyleProject createBrokenProject() throws IOException {
TopLevelItemDescriptor descriptor = new TopLevelItemDescriptor(FreeStyleProject.class) {
@Override