- In the context menu, the 'post' flag was set iff 'requiresConfirmation'
was set, even though they're independent (e.g. Prepare for shutdown
requires the former but not the latter)
- /manage screen: The icon (t:summary) does not support POST or
confirmation links, but was set to not link only if no confirmation
was required (i.e. POST links did not POST when the icon was clicked
-- now the icon is not clickable as a workaround)
- /manage screen: All links requiring confirmation did POST, which masked
the fact that the 'Reload from disk' link wasn't set up to require POST
(it was only broken in the context menu). Now, confirmation and POST are
separate flags, and 'Reload from disk' link now requests POST.
Relates to [JENKINS-40700]. The updated displayNames describe the
protocols by using similar verbiage from:
core/src/main/resources/hudson/cli/CliProtocol/description.jelly
core/src/main/resources/hudson/cli/CliProtocol2/description.jelly
core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol/description.jelly
core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol2/description.jelly
core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol3/description.jelly
core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.jelly
At a high level, I wanted to expose to the user, from a security
perspective, whether or not the protocols were secure and how.
* [FIX JENKINS-39268] Properties are not passed to Maven command by Maven build step
* [FIX JENKINS-39268] Properties are not passed to Maven command by Maven build step
* [FIX JENKINS-39268] Properties are not passed to Maven command by Maven build step
* [FIX JENKINS-39268] Changed order in which properties are appended to command line: properties appended later win in case of conflicts
* [FIX JENKINS-39268] More precise messages in some assertions
* [FIX JENKINS-39268] Cleanup unused imports
* [FIX JENKINS-39268] Added functional tests for Maven task.