Commit Graph
32590 Commits
Author SHA1 Message Date
Jesse Glick f72bcaca0d [SECURITY-382] Sign console notes with a MAC. 2016-12-14 17:45:35 -05:00
Stephen Connolly cf0fea0c1f [FIXED JENKINS-40252] Add an Iterable<T> that returns all items unsorted 2016-12-14 20:23:51 +00:00
Oleg Nenashev 1868c8486b Merge pull request #2645 from alvarolobato/JENKINS-28245
[FIX JENKINS-28245] - Allow defining agent ping interval and ping timeout in seconds
2016-12-14 10:38:53 +01:00
Jesse Glick 76aa0727f0 Functions.printStackTrace utility method. 2016-12-12 17:56:24 -05:00
Jesse Glick 24aa20635d Replaced other usages of printStackTrace. 2016-12-12 16:44:10 -05:00
Jesse Glick 7f4ce02e42 Handle circular references. 2016-12-12 16:14:48 -05:00
Jesse Glick 187731fd88 Check for printStackTrace overrides. 2016-12-12 16:06:57 -05:00
Jesse Glick da54171682 Handle suppressed exceptions. 2016-12-12 16:00:30 -05:00
Jesse Glick 106bd3e018 More test coverage. 2016-12-12 15:35:06 -05:00
Jesse Glick b55ef51ab6 More robust & flexible test framework for printThrowable. 2016-12-12 15:05:03 -05:00
Jesse Glick 2abddbdfcc Merge branch 'master' into printStackTrace-JDK-6507809 2016-12-12 14:25:12 -05:00
Daniel Beck e7e51eeb62 Merge pull request #2660 from daniel-beck/JENKINS-39700
[FIX JENKINS-39700] Don't fail when no parameters property for job
2016-12-12 18:04:31 +01:00
Stephen Connolly e2e17da128 since FIXME -> 2.37 2016-12-12 15:22:19 +00:00
Stephen Connolly e18b34caaf Merge pull request #2603 from stephenc/jenkins-39300
[JENKINS-39300] View.getDisplayName() is ignored when rendering tabs
2016-12-12 15:13:46 +00:00
Kohsuke Kawaguchi 476605c549 updated changelog for release 2016-12-11 20:57:35 -08:00
Kohsuke Kawaguchi 49653d1a6d [maven-release-plugin] prepare for next development iteration 2016-12-11 20:50:44 -08:00
Kohsuke Kawaguchi 44133ea90c [maven-release-plugin] prepare release jenkins-2.36 jenkins-2.36 2016-12-11 20:50:44 -08:00
Stephen Connolly 3538931d1e [JENKINS-39300] Fix final test case 2016-12-11 17:09:04 +00:00
Oleg Nenashev 06615d991d CHANGELOG: Noting #2656, #2651, #2656, #2659 2016-12-11 13:00:03 +01:00
Daniel Beck fdba189158 Fix 'since TODO' from #2630 2016-12-10 17:46:25 +01:00
Daniel Beck 8d465c6aa0 Merge pull request #2659 from jglick/Run.getBadgeActions-JENKINS-40281
[JENKINS-40281] Do not try to mutate the result of getActions(Class)
2016-12-10 01:53:39 +01:00
Jesse Glick e4620c6d6d Restoring relevant explanatory comment. 2016-12-09 17:27:46 -05:00
Jesse Glick d4f7fb1896 [SECURITY-321] Prevent existing items from being overwritten even if you cannot DISCOVER them. 2016-12-09 17:18:33 -05:00
Jesse Glick 37419d5de2 [SECURITY-358] Restrict access to metadata used by WorkflowRun. 2016-12-09 10:06:35 -05:00
Stephen Connolly d1c40f4b83 [JENKINS-39300] Update tests 2016-12-09 12:46:24 +00:00
Daniel Beck e43222dde8 [FIX JENKINS-39700] Don't fail when no parameters property for job 2016-12-09 12:02:32 +01:00
andrealaura ba2900b27d [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it … (#2649)
* [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it runs independent from the host OS locale.

* [FIX JENKINS-36044]: Cleanup default-locale after test, to avoid impact to other tests.

*  [FIX JENKINS-36044]: Make test language indepedent.

* [FIX JENKINS-36044]: Cleanup unused imports.
2016-12-09 11:23:58 +01:00
Daniel Beck 7292c91ea0 Merge pull request #2656 from daniel-beck/localizer-1.24-access-modifier
Annotate localizer generated Messages classes with NoExternalUse
2016-12-09 11:19:56 +01:00
Oleg Nenashev 006c6264b6 Merge pull request #2647 from olivergondza/testPluginWrapper
Test plugin wrapper
2016-12-09 11:07:17 +01:00
Jesse Glick c4ee05bcae Make sure Security218BlackBoxTest cleans up threads it starts (#2642)
* Make sure Security218BlackBoxTest cleans up threads it starts.

* Some code simplifications, and possible leak fixes, based on CLI now being AutoCloseable.

* Obsolete comment.
2016-12-09 11:05:49 +01:00
Jesse Glick 8d23041d4b [JENKINS-38514] Retain CauseOfBlockage from JobOffer (#2651)
* Converted to JenkinsRule.

* Improved messages from Node.canTake.

* [FIXED JENKINS-38514] BuildableItem needs to retain information from JobOffer about why it is neither blocked nor building.

* Converted to JenkinsRule.

* Found an existing usage of BecauseNodeIsNotAcceptingTasks.

* Original JENKINS-6598 test was checking behavior we want amended by JENKINS-38514.

* Ensure that a BuildableItem which is simply waiting for a free executor reports that as its CauseOfBlockage.

* Review comments from @oleg-nenashev.
2016-12-09 11:04:22 +01:00
Jesse Glick 5c79beb3ef [FIXED JENKINS-40281] Do not try to mutate the result of getActions(Class). 2016-12-08 18:03:45 -05:00
Oleg Nenashev 5500e5c00b [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods (#2653)
* [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods

* [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence

(cherry picked from commit 29893354a5)
2016-12-08 13:45:28 +01:00
Oleg Nenashev fcfd271ad5 [JENKINS-23271] - Prevent early deallocation of the Proc instance by GC in ProcStarter#join() (#2635)
* [JENKINS-23271] - Prevent the prelimimary deallocation of the Proc instance by GC

It is a hackish way, which likely prevents a preliminary deallocation of the spawned RemoteProc instance, which we see in JENKINS-23271. Proc instance was not actually required in the original code since we were creating and using RemoteInvocationHandler wrapper only, and the theory discussed with @stephenc was that object gets removed by Java8 garbage collector before we get into join().

This fix enforces the persistency of ProcStarter#start() result by adding logging and the enforced volatile field (maybe the last one is not really required, but JIT compiler in Java implementations may be smart enough to skip unused loggers)

This is a pretty old fix from August, which has been soak tested on my instance for several weeks (mid-August => Jenkins World). On the reference instance (just a small Jenkins instance with 4 agents and very frequent builds with CommandInterpreter steps) I saw 2 failures over the period. On the fixed instance - 0. It does not proof anything, but at least the fix was soak tested a bit

* [JENKINS-23271] - Get rid of the procHolderForJoin field

* [JENKINS-23271] - Also put the check into the finally statement as @stephenc proposed

* Remove assert

(cherry picked from commit fd6c6aff92)
2016-12-08 13:45:28 +01:00
Daniel Beck 8de0056065 [FIX SECURITY-380] Don't optimize permission check in getItems() 2016-12-07 21:48:38 +01:00
Stephen Connolly fd2009a971 [JENKINS-38606] Allow legacy localized links to continue working after migration
- This means we can default the migration to enabled
2016-12-07 09:54:04 +00:00
Kanstantsin Shautsou 9172bca30f [FIX JENKINS-40266] Allow override UserProperty.setUser(User) (#2655)
UserProperty may contain nested objects that depend on User. 
On User reconfiguration setUser(User) is called so it should be non-final to have ability override it and update references in nested objects.

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
2016-12-07 00:52:35 +01:00
Daniel Beck eac59f3b5e Annotate localizer generated Messages classes with NoExternalUse
Also update to localizer 1.24 which adds support for this.
2016-12-06 17:17:42 +01:00
Alvaro Lobato dacbe03e0d [JENKINS-39741] - Redirect to login page after authorisation error when checking connectivity to update center and handle any other error.
(cherry picked from commit 5df61d42d0)
2016-12-06 15:21:19 +01:00
Oleg Nenashev e66bfbafa9 Update winp to 1.24. In particular, it addresses issues like [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) (#2619)
### Changes to be picked

### 1.24

Release date: Nov 2, 2016

* [Issue #22](https://github.com/kohsuke/winp/issues/22) - Winp sometimes kills random processes when using killRecursive. ([PR #23](https://github.com/kohsuke/winp/pull/23))
* [WINP-10](https://java.net/jira/browse/WINP-10) - Fix for `getCmdLineAndEnvVars()` which fails on x64 versions of Windows. ([PR #20](https://github.com/kohsuke/winp/pull/20))
* [Issue #24](https://github.com/kohsuke/winp/issues/24) - Wrong folder when using the `winp.folder.preferred` system property (parent instead of the actual folder). ([PR #25](https://github.com/kohsuke/winp/pull/25))
* [Issue #26](https://github.com/kohsuke/winp/issues/26), [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) - Native class now tries loading DLLs via the temp location. ([PR #27](https://github.com/kohsuke/winp/pull/27))

### 1.23

Release date: Fev 16, 2015

* Migrate native components to Visual Studio Community 2013. ([PR #14](https://github.com/kohsuke/winp/pull/14))
* Provide a `winp.unpack.dll.to.parent.dir` property, which disables DLL unpacking to the parent dir. ([PR #14](https://github.com/kohsuke/winp/pull/12))
(cherry picked from commit 63c2f6c5d7)
2016-12-06 15:19:30 +01:00
Daniel Beck 43519b1d5e Noting #2644 #2646 #2653 2016-12-05 16:56:55 +01:00
Kohsuke Kawaguchi 264f1393b3 updated changelog for release 2016-12-04 12:44:03 -08:00
Kohsuke Kawaguchi f106e249b6 [maven-release-plugin] prepare for next development iteration 2016-12-04 12:36:17 -08:00
Kohsuke Kawaguchi 37df0e3a46 [maven-release-plugin] prepare release jenkins-2.35 jenkins-2.35 2016-12-04 12:36:17 -08:00
Oleg Nenashev 29893354a5 [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods (#2653)
* [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods

* [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
2016-12-03 16:55:35 +01:00
Daniel Beck 9fe07a7596 Merge pull request #2654 from batmat/improvehudson.Extension.ordinal
Clarify hudson.Extension#ordinal documentation
2016-11-30 16:09:36 +01:00
Baptiste Mathus b6eb255b22 Clarify hudson.Extension#ordinal documentation
I have to read it many times each time I need it. Hopefully
it's a bit clearer with this addition.
2016-11-30 15:42:29 +01:00
Jesse Glick 9ecc77b9ba [JENKINS-38867] Since tag for #2582. 2016-11-29 10:06:42 -05:00
Alvaro Lobato 6dea3c3f70 [JENKINS-28245] - Finish deadmoose's work to allow defining agent ping interval and ping timeout in seconds 2016-11-29 11:15:16 +01:00
David Hoover d563062747 [FIXED JENKINS-28245] Allow finer-grained tuning of ChannelPinger.
* Allows customization in seconds, not minutes
 * Allows customization of the ping timeout (before, you could set a
   custom interval, but the timeout would always be PingThread's 4
   minute default)

This also drops the serialVersionUID from ChannelPinger.SetUpRemotePing;
without one provided, the JVM will generate one on demand which is
sufficient for the purposes here since these are never persisted and
master & slave run the same compiled code. (And it demonstrably works
since countless other MasterToSlaveCallables fail to specify their own
custom IDs)
2016-11-29 10:28:01 +01:00