* [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it runs independent from the host OS locale.
* [FIX JENKINS-36044]: Cleanup default-locale after test, to avoid impact to other tests.
* [FIX JENKINS-36044]: Make test language indepedent.
* [FIX JENKINS-36044]: Cleanup unused imports.
* Make sure Security218BlackBoxTest cleans up threads it starts.
* Some code simplifications, and possible leak fixes, based on CLI now being AutoCloseable.
* Obsolete comment.
* Converted to JenkinsRule.
* Improved messages from Node.canTake.
* [FIXED JENKINS-38514] BuildableItem needs to retain information from JobOffer about why it is neither blocked nor building.
* Converted to JenkinsRule.
* Found an existing usage of BecauseNodeIsNotAcceptingTasks.
* Original JENKINS-6598 test was checking behavior we want amended by JENKINS-38514.
* Ensure that a BuildableItem which is simply waiting for a free executor reports that as its CauseOfBlockage.
* Review comments from @oleg-nenashev.
* [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods
* [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
(cherry picked from commit 29893354a5)
* [JENKINS-23271] - Prevent the prelimimary deallocation of the Proc instance by GC
It is a hackish way, which likely prevents a preliminary deallocation of the spawned RemoteProc instance, which we see in JENKINS-23271. Proc instance was not actually required in the original code since we were creating and using RemoteInvocationHandler wrapper only, and the theory discussed with @stephenc was that object gets removed by Java8 garbage collector before we get into join().
This fix enforces the persistency of ProcStarter#start() result by adding logging and the enforced volatile field (maybe the last one is not really required, but JIT compiler in Java implementations may be smart enough to skip unused loggers)
This is a pretty old fix from August, which has been soak tested on my instance for several weeks (mid-August => Jenkins World). On the reference instance (just a small Jenkins instance with 4 agents and very frequent builds with CommandInterpreter steps) I saw 2 failures over the period. On the fixed instance - 0. It does not proof anything, but at least the fix was soak tested a bit
* [JENKINS-23271] - Get rid of the procHolderForJoin field
* [JENKINS-23271] - Also put the check into the finally statement as @stephenc proposed
* Remove assert
(cherry picked from commit fd6c6aff92)
UserProperty may contain nested objects that depend on User.
On User reconfiguration setUser(User) is called so it should be non-final to have ability override it and update references in nested objects.
Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
* [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods
* [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
* Allows customization in seconds, not minutes
* Allows customization of the ping timeout (before, you could set a
custom interval, but the timeout would always be PingThread's 4
minute default)
This also drops the serialVersionUID from ChannelPinger.SetUpRemotePing;
without one provided, the JVM will generate one on demand which is
sufficient for the purposes here since these are never persisted and
master & slave run the same compiled code. (And it demonstrably works
since countless other MasterToSlaveCallables fail to specify their own
custom IDs)