Commit Graph
32590 Commits
Author SHA1 Message Date
Vincent Latombe f80c59ab3d [JENKINS-38651] Display actions created through TransientActionFactory in label view
(cherry picked from commit 8d55b1f555)
2016-11-08 14:57:00 +01:00
Oleg Nenashev b10440702f [FIXED JENKINS-38487] - Jenkins startup must not fail in the case of ComputerListener failure (#2610)
Without this code Jenkinbs startup fails if EnvInject fails to find global property file on startup.

Javadoc says "Exceptions will be recorded to the listener. Note that throwing an exception doesn't put the computer offline." regarding the listener method exception, hence we should not block Jenkins startup
(cherry picked from commit 58e1228c99)
2016-11-08 14:54:13 +01:00
Jonathan Fuentes 7e8ea4a967 [FIXED JENKINS-36539] (#2495)
(cherry picked from commit fbb4dc05b5)
2016-11-08 14:50:01 +01:00
Daniel Beck 5e5ba7b8aa Fix URL 2016-11-08 10:47:02 +01:00
Kohsuke Kawaguchi 283938394d updated changelog for release 2016-11-07 19:06:05 -08:00
Kohsuke Kawaguchi 55f563b26b [maven-release-plugin] prepare for next development iteration 2016-11-07 18:58:43 -08:00
Kohsuke Kawaguchi 8ffc4949c3 [maven-release-plugin] prepare release jenkins-2.30 jenkins-2.30 2016-11-07 18:58:43 -08:00
Oleg Nenashev 3065058ef6 Changelog: #2622 is expected to be a final fix 2016-11-08 00:36:13 +01:00
Oleg Nenashev dc6280b946 Changelog: Noting #2624, #2622, #2621 2016-11-08 00:28:02 +01:00
Oleg Nenashev 3e2e017179 [JENKINS-39465] - Fix the AgentProtocol settings persistency handling (#2621)
* [JENKINS-39465] - Tweak processing of enabled and disabled protocols in Jenkins instance

Due to whatever reason, without a definition of an array recipient field the data goes to the disk in the following way:

```
<enabledAgentProtocol>JNLP3-connect</enabledAgentProtocol>
<enabledAgentProtocol>JNLP4-connect</enabledAgentProtocol>
```

It is supposed to processed by Implicit array correctly, but it does not actually happen.
With a fix the data is being stored in another format:

```
  <enabledAgentProtocols>
    <string>JNLP3-connect</string>
    <string>JNLP4-connect</string>
  </enabledAgentProtocols>
```

This data now works correctly and gets deserialized correctly. readResolve() just adds a fallback for the case when Implicit array handling starts behaving correctly (?).

* [JENKINS-39465] - Add configuration roundtrip tests

* [JENKINS-39465] - Jenkins#agentProtocols cache must be invalidated when we reload the configuration

* [JENKINS-39465] - Remove obsolete comment from Tests
2016-11-08 00:07:40 +01:00
Jesse Glick 5aed788dee [FIXED JENKINS-39414] Integrating Stapler 1.248. (#2622) 2016-11-08 00:07:21 +01:00
Sam Van Oort a63b50f4df [FIXED JENKINS-39555] Don't do the actions initialization by helper method (#2624)
* Coarse fix for JENKINS-39555 - don't do the actions initialization by helper method

* Small cleanup of docs, import

* Testcase

* Review changes
2016-11-08 00:06:53 +01:00
Oleg Nenashev 07884f7cc1 Changelog: Add the 2.29 release notice (#2623)
* Changelog: Add the 2.29 release notice

* Fix the link
2016-11-07 22:14:13 +01:00
Oleg Nenashev b0aca1c474 Changelog: Indicate that JENKINS-39414 is not completely fixed in 2.29 2016-11-07 12:01:41 +01:00
Daniel Beck e85e3e2b90 [JENKINS-26940] Print message when installer isn't applicable (#2598)
* [JENKINS-26940] Print message when installer isn't applicable

* [JENKINS-26940] Only print when none found, add test

(cherry picked from commit ae29e6b246)
2016-11-07 10:12:27 +01:00
Oliver Gondža f0618835ce Merge pull request #2618 from jenkinsci/remoting/2.62.2-1
Update remoting to 2.62.2 in stable-2.19.x
2016-11-07 10:08:32 +01:00
Kohsuke Kawaguchi 96b5390ef4 updated changelog for release 2016-11-06 18:50:09 -08:00
Kohsuke Kawaguchi 682be471a9 [maven-release-plugin] prepare for next development iteration 2016-11-06 18:43:11 -08:00
Kohsuke Kawaguchi befc3d9393 [maven-release-plugin] prepare release jenkins-2.29 jenkins-2.29 2016-11-06 18:43:11 -08:00
Oleg Nenashev 62a5dddb3c Update remoting to 2.62.2
This PR picks the latest available version of remoting stable-2.x. All the fixes have been integrated into remoting-3.0 and soaked enough.

* [JENKINS-38539](https://issues.jenkins-ci.org/browse/JENKINS-38539) - 
Stability: Turn on SO_KEEPALIVE by default and provide CLI option to turn it off again.
(https://github.com/jenkinsci/remoting/pull/110)
* [JENKINS-37539](https://issues.jenkins-ci.org/browse/JENKINS-37539) - 
Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty.
(https://github.com/jenkinsci/remoting/pull/101)
* [CID-152201] - 
Fix resource leak in <code>remoting.jnlp.Main</code>.
(https://github.com/jenkinsci/remoting/pull/102)
* [CID-152200,CID-152202] - 
Resource leak in Encryption Cipher I/O streams on exceptional paths.
(https://github.com/jenkinsci/remoting/pull/104)
2016-11-06 23:09:15 +01:00
Oleg Nenashev bf59cf6c6c Changelog: Noting #2607, #2609, #2610, #2611 and #2608 2016-11-06 12:37:25 +01:00
Akbashev Alexander 2e8c3bec8e [FIXED JENKINS-39535] - Optimize get log method (#2607)
* Add some tests to  current behaviour of getLog method

* getLog(maxLines) reads only last maxLines lines now

It should speed up and reduce memory consumption for some plugins (i.e.
Email-ext Plugin).
Also now this method could be used to get last lines of build output in efficient manner.

* Fix issues from code review
2016-11-06 11:25:58 +01:00
Jesse Glick a57b52ec7e [FIXED JENKINS-39454] Do not consider pendings when deciding whether a schedule result should be new or existing, as we have already taken a snapshot of actions. (#2609) 2016-11-05 20:26:24 +01:00
Oleg Nenashev 58e1228c99 [FIXED JENKINS-38487] - Jenkins startup must not fail in the case of ComputerListener failure (#2610)
Without this code Jenkinbs startup fails if EnvInject fails to find global property file on startup.

Javadoc says "Exceptions will be recorded to the listener. Note that throwing an exception doesn't put the computer offline." regarding the listener method exception, hence we should not block Jenkins startup
2016-11-05 21:42:20 +04:00
Jesse Glick 6718a71f4b [JENKINS-39414] Noting merge of #2611. 2016-11-04 15:54:41 -04:00
Jesse Glick d463df122b Merge pull request #2611 from jglick/stapler-1.247
[JENKINS-39414] Stapler 1.247
2016-11-04 15:45:40 -04:00
Jesse Glick 469a434d10 Stapler 1.247. 2016-11-04 11:42:35 -04:00
Stephen Connolly 5106675776 [JENKINS-39300] Address review comments 2016-11-03 21:55:37 +00:00
Stephen Connolly 0b21cfd770 Noting merge of JENKINS-39404 2016-11-03 21:35:06 +00:00
Stephen Connolly 67392ed12a Correct @since TODO tags 2016-11-03 21:33:03 +00:00
Stephen Connolly a005e1e779 Correct @since tags 2016-11-03 21:28:08 +00:00
Stephen Connolly b4fe8b431a Merge pull request #2608 from stephenc/jenkins-39404
[FIXED JENKINS-39404] Restore symmetry by adding removeAction and removeActions methods to Actionable
2016-11-03 21:22:12 +00:00
Andres Rodriguez 6edd35d11b [JENKINS-38814] Use GREEDY RemoteInputStreams (#2583)
(cherry picked from commit b62ad15fef)
2016-11-03 10:28:27 +01:00
lpancescu 2f0632ae18 [JENKINS-10912] Use setInterval in refreshPart (#2539)
* [JENKINS-10912] Use setInterval in refreshPart

The current implementation of refreshPart creates a new closure every 5
seconds, which, in combination with XMLHttpRequest objects, results in a
significant memory leak in all major browsers. By using
window.setInterval to schedule periodic refreshes, only one closure per
id is created. Please see issue #10912 in the Jenkins tracker for
further details.

* Stop periodical calls if we can't find the div

* Don't check if isRunAsTest changed after page load

(cherry picked from commit 096614a6d7)
2016-11-03 10:25:12 +01:00
Ted 1875144a07 fix JENKINS-31768 dead lock while removing computer
(cherry picked from commit c7fd90a879)
2016-11-03 10:23:32 +01:00
Akbashev Alexander 4421d1b94d [FIX JENKINS-23244] Slave build history page has no data and spawns a ton of very long-lived blocking threads on the master (#2584)
Mainly commit are doing two things:
1) Show only selected (visible) builds
2) Query build one-by-one - not it parallel
(cherry picked from commit 2a0ac4f098)
2016-11-03 10:22:22 +01:00
Daniel Beck 5d58ce9f2f Merge pull request #2545 from Vlatombe/JENKINS-38187
[FIX JENKINS-38187] Fix setting JNLP port through system property
(cherry picked from commit 3f5fe7f6b9)
2016-11-03 10:12:59 +01:00
Stephen Connolly 65f3e4b4e4 [JENKINS-39404] Clarify the lack of transaction support and consequent effect on concurrent operations 2016-11-02 09:59:42 +00:00
Stephen Connolly 83f71540af [JENKINS-39404] Oleg wants to reduce the number of times we call Action.equals()
- cannot use a local variable as the optimization only applies while we have not found the action being added
2016-11-02 09:47:30 +00:00
Stephen Connolly 183fac8a63 [JENKINS-39404] Introduce an addOrReplaceAction method with dirty return type
- We cannot modify `replaceAction` to return the dirty flag, in fact most callers probably don't care... but if you do care, we now provide `addOrReplaceAction`
- Clarify the javadocs to reflect that these methods are not going to affect actions added by transient action factories
2016-11-02 09:16:42 +00:00
Stephen Connolly 727485900b [JENKINS-39404] We cannot change these to return a boolean, but doesn't matter because they would always return true 2016-11-01 19:19:32 +00:00
Stephen Connolly 570a74c0a3 [JENKINS-39404] Clarify that you can replaceActions(Foo.class, Bar) where !(Bar instanceof Foo) 2016-11-01 19:17:57 +00:00
Stephen Connolly 92234d4d00 [JENKINS-39404] Make it easier for subclasses and address some code review comments 2016-11-01 19:15:50 +00:00
Kohsuke Kawaguchi 63c203699c [maven-release-plugin] prepare for next development iteration 2016-11-01 12:05:43 -07:00
Kohsuke Kawaguchi 03cb67a52c [maven-release-plugin] prepare release jenkins-2.19.2 jenkins-2.19.2 2016-11-01 12:05:42 -07:00
Stephen Connolly 65de34f7b9 [JENKINS-39404] Minimize non-changes affecting write to disk requirement 2016-11-01 15:36:33 +00:00
Stephen Connolly 320b7d2fa3 [JENKINS-39404] Damn generics... was unusable...
I would need to use <A super Action> which would allow Object.class
2016-11-01 13:33:57 +00:00
Stephen Connolly f03e6fd1ca [JENKINS-39404] Allow a more generic replaceActions 2016-11-01 13:29:56 +00:00
Stephen Connolly 1990e3d09a [FIXED JENKINS-39404] Restore symmetry by adding removeAction and removeActions methods to Actionable 2016-11-01 13:17:25 +00:00
Stephen Connolly beaabb0901 [JENKINS-39300] Sort the views by displayName 2016-11-01 12:57:16 +00:00