Without this code Jenkinbs startup fails if EnvInject fails to find global property file on startup.
Javadoc says "Exceptions will be recorded to the listener. Note that throwing an exception doesn't put the computer offline." regarding the listener method exception, hence we should not block Jenkins startup
(cherry picked from commit 58e1228c99)
* [JENKINS-39465] - Tweak processing of enabled and disabled protocols in Jenkins instance
Due to whatever reason, without a definition of an array recipient field the data goes to the disk in the following way:
```
<enabledAgentProtocol>JNLP3-connect</enabledAgentProtocol>
<enabledAgentProtocol>JNLP4-connect</enabledAgentProtocol>
```
It is supposed to processed by Implicit array correctly, but it does not actually happen.
With a fix the data is being stored in another format:
```
<enabledAgentProtocols>
<string>JNLP3-connect</string>
<string>JNLP4-connect</string>
</enabledAgentProtocols>
```
This data now works correctly and gets deserialized correctly. readResolve() just adds a fallback for the case when Implicit array handling starts behaving correctly (?).
* [JENKINS-39465] - Add configuration roundtrip tests
* [JENKINS-39465] - Jenkins#agentProtocols cache must be invalidated when we reload the configuration
* [JENKINS-39465] - Remove obsolete comment from Tests
* [JENKINS-26940] Print message when installer isn't applicable
* [JENKINS-26940] Only print when none found, add test
(cherry picked from commit ae29e6b246)
* Add some tests to current behaviour of getLog method
* getLog(maxLines) reads only last maxLines lines now
It should speed up and reduce memory consumption for some plugins (i.e.
Email-ext Plugin).
Also now this method could be used to get last lines of build output in efficient manner.
* Fix issues from code review
Without this code Jenkinbs startup fails if EnvInject fails to find global property file on startup.
Javadoc says "Exceptions will be recorded to the listener. Note that throwing an exception doesn't put the computer offline." regarding the listener method exception, hence we should not block Jenkins startup
* [JENKINS-10912] Use setInterval in refreshPart
The current implementation of refreshPart creates a new closure every 5
seconds, which, in combination with XMLHttpRequest objects, results in a
significant memory leak in all major browsers. By using
window.setInterval to schedule periodic refreshes, only one closure per
id is created. Please see issue #10912 in the Jenkins tracker for
further details.
* Stop periodical calls if we can't find the div
* Don't check if isRunAsTest changed after page load
(cherry picked from commit 096614a6d7)
Mainly commit are doing two things:
1) Show only selected (visible) builds
2) Query build one-by-one - not it parallel
(cherry picked from commit 2a0ac4f098)
- We cannot modify `replaceAction` to return the dirty flag, in fact most callers probably don't care... but if you do care, we now provide `addOrReplaceAction`
- Clarify the javadocs to reflect that these methods are not going to affect actions added by transient action factories