Commit Graph
32590 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 52a3a77a75 [maven-release-plugin] prepare for next development iteration 2016-11-28 09:58:56 -08:00
Kohsuke Kawaguchi a7520ef4da [maven-release-plugin] prepare release jenkins-2.19.4 jenkins-2.19.4 2016-11-28 09:58:56 -08:00
Baptiste Mathus a05d9422ef Merge pull request #2646 from batmat/add-level-to-SystemProperties
Be able to specify the log Level when system property is not found
2016-11-28 12:40:30 +01:00
mawinter69 5cc21bc3b9 [JENKINS-39972] export fullName and fullDisplayName (#2644) 2016-11-28 05:44:33 +04:00
Kohsuke Kawaguchi cbb5252045 updated changelog for release 2016-11-27 13:02:20 -08:00
Kohsuke Kawaguchi 36ba8e590d [maven-release-plugin] prepare for next development iteration 2016-11-27 12:55:26 -08:00
Kohsuke Kawaguchi 5346c8b6f2 [maven-release-plugin] prepare release jenkins-2.34 jenkins-2.34 2016-11-27 12:55:26 -08:00
Daniel Beck a11c05d3bd Don't mention #2632
It's not actually a change in anything we deliver.
2016-11-27 15:27:49 +01:00
Oleg Nenashev ab7da714fe Changelog: Noting #2619, #2641, #2582, and #2632 2016-11-27 13:09:55 +03:00
Damian Szczepanik f4d3ec2b4a translation-tool.pl - Feature for adding unique prefix for each missing translation (#2632) 2016-11-27 07:46:24 +01:00
Oleg Nenashev 63c2f6c5d7 Update winp to 1.24. In particular, it addresses issues like [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) (#2619)
### Changes to be picked

### 1.24

Release date: Nov 2, 2016

* [Issue #22](https://github.com/kohsuke/winp/issues/22) - Winp sometimes kills random processes when using killRecursive. ([PR #23](https://github.com/kohsuke/winp/pull/23))
* [WINP-10](https://java.net/jira/browse/WINP-10) - Fix for `getCmdLineAndEnvVars()` which fails on x64 versions of Windows. ([PR #20](https://github.com/kohsuke/winp/pull/20))
* [Issue #24](https://github.com/kohsuke/winp/issues/24) - Wrong folder when using the `winp.folder.preferred` system property (parent instead of the actual folder). ([PR #25](https://github.com/kohsuke/winp/pull/25))
* [Issue #26](https://github.com/kohsuke/winp/issues/26), [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) - Native class now tries loading DLLs via the temp location. ([PR #27](https://github.com/kohsuke/winp/pull/27))

### 1.23

Release date: Fev 16, 2015

* Migrate native components to Visual Studio Community 2013. ([PR #14](https://github.com/kohsuke/winp/pull/14))
* Provide a `winp.unpack.dll.to.parent.dir` property, which disables DLL unpacking to the parent dir. ([PR #14](https://github.com/kohsuke/winp/pull/12))
2016-11-27 07:41:36 +01:00
Oleg Nenashev 8a2d2de2a3 [JENKINS-39805] - Update SSH module to 1.8 (#2641)
`the fix disables some obsolete protocols as per [JENKINS-39805](https://issues.jenkins-ci.org/browse/JENKINS-39805):  AES128CBC, TripleDESCBC.Factory(), and BlowfishCBC

All changes: https://github.com/jenkinsci/sshd-module/compare/sshd-1.7...sshd-1.8
2016-11-27 07:39:58 +01:00
Jesse Glick 6360b96464 [JENKINS-38867] Optimize performance of Actionable.getAllActions (#2582)
* Optimize Actionable.getAllActions.

* Also need to invalidate the cache when new plugins are installed.

* Various improvements to TransientActionFactory caching.
· Move the cache code to TransientActionFactory itself, for better encapsulation.
· Optimize getAction(Class) to not need to call getAllActions; avoids copying lists, and can avoid calling TransientActionFactory at all.
· Ensure that we maintain a separate cache per ExtensionList instance, so that static state is not leaked across Jenkins restarts.

* Updated TransientActionFactory to specify what kinds of actions it could produce.

* It turns out that changing type parameters for an extension, while generally binary-compatible, breaks reflective code in Jenkins and so this is not an option.
… hudson.ExtensionFinder$GuiceFinder$SezpozModule configure
WARNING: Failed to load com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl
java.lang.LinkageError: Failed to resolve class com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:489)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.configure(ExtensionFinder.java:506)
	at …
	at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:280)
	at …
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:472)
	at hudson.ExtensionList.load(ExtensionList.java:349)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:287)
	at hudson.ExtensionList.getComponents(ExtensionList.java:167)
	at jenkins.model.Jenkins$8.onInitMilestoneAttained(Jenkins.java:1082)
	at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:82)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:104)
	at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:176)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.reflect.MalformedParameterizedTypeException
	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.validateConstructorArguments(ParameterizedTypeImpl.java:58)
	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.<init>(ParameterizedTypeImpl.java:51)
	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.make(ParameterizedTypeImpl.java:92)
	at sun.reflect.generics.factory.CoreReflectionFactory.makeParameterizedType(CoreReflectionFactory.java:105)
	at sun.reflect.generics.visitor.Reifier.visitClassTypeSignature(Reifier.java:140)
	at sun.reflect.generics.tree.ClassTypeSignature.accept(ClassTypeSignature.java:49)
	at sun.reflect.generics.repository.ClassRepository.getSuperclass(ClassRepository.java:90)
	at java.lang.Class.getGenericSuperclass(Class.java:777)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:470)
	... 29 more

* Remove actionType override to make for a simpler diff.

* Strengthened test to cover accesses to unrelated context types.

* Strengthening tests in a couple of ways.

* Javadoc improvements suggested by @oleg-nenashev.
2016-11-27 07:38:38 +01:00
Oliver Gondža a077b6ec9c Report dependency version we failed to load, not the one we require 2016-11-25 15:22:25 +01:00
Oliver Gondža 2af7249c6a Remove duplicate or core/src/test/java/hudson/PluginWrapperTest.java 2016-11-25 13:24:49 +01:00
Baptiste Mathus 20d3f11453 Be able to specify the log Level when system property is not found or invalid
Some properties are more important than others. One may for example
 want to log a WARNING instead of the current default CONFIG
when some property can not be found, or has an invalid format
(like a string, when asking for an Integer).
2016-11-25 09:45:28 +01:00
Oliver Gondža 08e0b7d40b Towards 2.32.1 2016-11-24 11:06:49 +01:00
Jesse Glick f50e0b56e5 Clarifying changelog entry for #2633 at @uschindler’s suggestion. 2016-11-22 10:47:12 -05:00
Jesse Glick 578298e70d [SECURITY-354] Using jBCrypt 0.4. 2016-11-21 16:20:38 -05:00
Kohsuke Kawaguchi fada46e738 updated changelog for release 2016-11-20 15:40:10 -08:00
Kohsuke Kawaguchi 98561d9f50 [maven-release-plugin] prepare for next development iteration 2016-11-20 15:32:46 -08:00
Kohsuke Kawaguchi f515245715 [maven-release-plugin] prepare release jenkins-2.33 jenkins-2.33 2016-11-20 15:32:46 -08:00
Oleg Nenashev fca3aa7239 Changelog: Noting #2640, #2633, #2635, #2594 and #2636 2016-11-20 11:20:41 +01:00
Oleg Nenashev fd6c6aff92 [JENKINS-23271] - Prevent early deallocation of the Proc instance by GC in ProcStarter#join() (#2635)
* [JENKINS-23271] - Prevent the prelimimary deallocation of the Proc instance by GC

It is a hackish way, which likely prevents a preliminary deallocation of the spawned RemoteProc instance, which we see in JENKINS-23271. Proc instance was not actually required in the original code since we were creating and using RemoteInvocationHandler wrapper only, and the theory discussed with @stephenc was that object gets removed by Java8 garbage collector before we get into join().

This fix enforces the persistency of ProcStarter#start() result by adding logging and the enforced volatile field (maybe the last one is not really required, but JIT compiler in Java implementations may be smart enough to skip unused loggers)

This is a pretty old fix from August, which has been soak tested on my instance for several weeks (mid-August => Jenkins World). On the reference instance (just a small Jenkins instance with 4 agents and very frequent builds with CommandInterpreter steps) I saw 2 failures over the period. On the fixed instance - 0. It does not proof anything, but at least the fix was soak tested a bit

* [JENKINS-23271] - Get rid of the procHolderForJoin field

* [JENKINS-23271] - Also put the check into the finally statement as @stephenc proposed

* Remove assert
2016-11-20 00:53:42 +01:00
Daniel Beck fbc072ee6c [JENKINS-39883] Remove obsolete property from slave-agent.jnlp file (#2629) 2016-11-19 23:17:48 +01:00
Daniel Beck 33d3899180 Merge pull request #2633 from jglick/remoting.jar
Stop storing three identical copies of remoting.jar in jenkins.war
2016-11-19 22:41:30 +01:00
Daniel Beck 71ed5bf06e Merge pull request #2637 from jglick/TokenBasedRememberMeServices2Test-LoggerRule
Take advantage of LoggerRule to simplify test
2016-11-19 22:40:20 +01:00
Thorsten Scherler 1256285f62 [FIX JENKINS-39034] /i18n/resourceBundle should be conform to the w3c standard about locale negotiation (#2594)
* [parseCountry] Extract region/country and variant from the language parameter in case it is bigger then 2 letters. Add tests for both cases.

* [JENKINS-39034] remove debug system out

* [JENKINS-39034] Only if we have 5 or more character we want to get the country - prevent NPE

* [JENKINS-39034] use split since it is more general

* [JENKINS-39034] Only override country and variant if not already set

* [JENKINS-39034] better test cases to test whether the fallback and variant resolving work corret

* [JENKINS-39034] remove duplicate tests and better name existing ones
2016-11-19 22:30:51 +01:00
Daniel Beck 7f255247af Merge pull request #2636 from alvarolobato/JENKINS-39741-2
[JENKINS-39741] - Redirect to login page after authorisation error when checking connectivity to update center and handle any other error.
2016-11-19 22:20:30 +01:00
Daniel Beck d03c3fa07e Merge pull request #2640 from damianszczepanik/translations
Polish translations for settings
2016-11-19 22:18:06 +01:00
Damian Szczepanik 60f3d0e157 Polish translations for settings 2016-11-19 12:02:26 +01:00
Oleg Nenashev 0399037f84 [FIXED JENKINS-38721, JENKINS-37282] - NPE in "CauseOfInterruption.UserInterruption" when user is missing (#2630)
* [FIXED JENKINS-38721] - Prevent NPE during rendering of "CauseOfInterruption.UserInterruption" when user is missing

It is a regression introduced in JENKINS-36594

* [JENKINS-38721] - Fix typo

(cherry picked from commit 91ad592142)
2016-11-18 08:54:08 +01:00
Andrew Bayer c19a56d214 [SECURITY-343] Restrict API access to NodeMonitor data
Switch to requiring EXTENDED_READ permission for access to NodeMonitor
data. It might theoretically be better if we had more granular
permissions on each NodeMonitor, but that's a bigger change, and since
EXTENDED_READ is already what we use to limit access to serving the
computer's config.xml, I think this is appropriate.
2016-11-17 10:56:36 -08:00
Daniel Beck 6aac6e3159 Add changelog for 2.32 2016-11-16 17:30:18 +01:00
Kohsuke Kawaguchi df1f2b2ba4 Merge branch 'stable-2.19' of github.com:jenkinsci/jenkins into stable-2.19 2016-11-16 07:57:53 -08:00
Kohsuke Kawaguchi b4b0815300 updated changelog for release 2016-11-16 07:56:52 -08:00
Kohsuke Kawaguchi b1d7e0ee3c [maven-release-plugin] prepare for next development iteration 2016-11-16 07:50:00 -08:00
Kohsuke Kawaguchi 4bbf611a7c [maven-release-plugin] prepare release jenkins-2.19.3 jenkins-2.19.3 2016-11-16 07:50:00 -08:00
Kohsuke Kawaguchi 96a9fba82b updated changelog for release 2016-11-16 06:20:54 -08:00
Kohsuke Kawaguchi b75d42edb4 [maven-release-plugin] prepare release jenkins-2.32 jenkins-2.32 2016-11-16 06:13:35 -08:00
Kohsuke Kawaguchi 33c3037dae [maven-release-plugin] prepare for next development iteration 2016-11-16 06:13:35 -08:00
Kohsuke Kawaguchi 61ddae253c Merge remote-tracking branch 'security/security-master' 2016-11-15 22:53:09 -08:00
Jesse Glick e47c681f9f Take advantage of LoggerRule to simplify test. 2016-11-15 17:34:59 +01:00
Alvaro Lobato 5df61d42d0 [JENKINS-39741] - Redirect to login page after authorisation error when checking connectivity to update center and handle any other error. 2016-11-15 15:50:02 +01:00
Jesse Glick 5a163a3b30 Correcting newlines. 2016-11-15 12:43:51 +01:00
Jesse Glick 4ecd9ff1ef Merge branch 'stable-2.19' 2016-11-15 12:33:01 +01:00
Jesse Glick 7706306d21 Merge branch 'security-stable-2.19' into security-master 2016-11-15 12:20:30 +01:00
Jesse Glick 555a863886 Merge branch 'security-stable-2.7' into security-stable-2.19 2016-11-15 09:54:14 +01:00
Jesse Glick 7886b73c1c Merge (-s ours) stable-2.7 into stable-2.19 2016-11-15 09:53:17 +01:00
Kohsuke Kawaguchi 21c1ee5242 updated changelog for release 2016-11-13 18:50:17 -08:00