Oleg Nenashev
798530c692
[FIXED JENKINS-36717] - Enforce FindBugs in the Jenkins core build
2016-08-01 19:49:15 +03:00
Oleg Nenashev
37a8935476
FindBugs: Suppress the warning about the ambigious call according to FB guildelines
2016-08-01 19:48:35 +03:00
Oleg Nenashev
734f16dd70
FindBugs: get rid of the redundant null check in hudson.model.queue.Executables#getEstimatedDurationFor()
2016-08-01 19:35:15 +03:00
Oleg Nenashev
f510d1c039
FindBugs: Log warnings if XMLUtils fail to set the documentBuilderFactory feature value
2016-08-01 19:31:05 +03:00
Oleg Nenashev
e8ed394aca
FindBugs: Wrap BC_IMPOSSIBLE_DOWNCAST in ToolDescriptor for empty array creation fallback
2016-08-01 19:25:08 +03:00
Oleg Nenashev
1b99938fa6
FindBugs: The tool cannot into StringUtils.isBlank(), so we optimize the code to workaround it (not a bug)
2016-08-01 19:13:54 +03:00
Oleg Nenashev
33c98f5da1
FindBugs: Handle the non-realistic case of null Staplerrequest in HudsonPrivateSecurityRealm#newInstance()
2016-08-01 19:08:42 +03:00
Oleg Nenashev
4cfc73b517
FindBugs: Violation of Descriptor newInstance() contract in hudson.scm.RepositoryBrowsers#createInstance deprecated method
2016-08-01 19:05:30 +03:00
Oleg Nenashev
f89cbeb337
FindBugs: Optimize logic of ChannelPinger#pingInterval initialization in order to fix the Integer unboxing issue in the original code
2016-08-01 18:59:30 +03:00
Oleg Nenashev
e5a728b394
FindBugs: Wrong WARNING message formatting in hudson.model.UpdateCenter#createUpdateCenter
2016-08-01 18:54:40 +03:00
Oleg Nenashev
5a9376230b
FindBugs: Wrong message formatting in hudson.model.User#getOrCreate()
2016-08-01 18:53:03 +03:00
Oleg Nenashev
96c9ce19ad
FindBugs: CliManagerImpl#authenticationFilter should be transient , no usages outside constructor
2016-08-01 18:50:46 +03:00
Oleg Nenashev
65d904827f
Queue.ItemList: Be sure we cleanup the list instead of the entire Queue (IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)
2016-08-01 18:42:43 +03:00
Oleg Nenashev
d773642ed0
Suppress warning about writing static SystemProperties#theContext from a non-static method
2016-08-01 18:34:47 +03:00
Oleg Nenashev
92a7385f1e
Merge commit 'd8cae8221e5b5ef3b5276fb53879547169a02504' into findbugs/JENKINS-36717-cleanup
2016-08-01 18:30:04 +03:00
Oleg Nenashev
d8cae8221e
[FIXED JENKINS-36715] - Invoke FindBugs during the Jenkins core build ( #2458 )
...
* Move FindBugs call to the parent POM, always run it and generate XMLs
* Update FindBugs to 3.0.4
* Filter away Stream encoding issues
* Rework FindBugs definitions according to comments from @jtnord
* Generalize configuration, findbugs:findbugs now takes it.
* Add TODOs to FindBugs excludes file
* Remove explicit failOnError
* Fix the typo spotted by @jtnord
2016-08-01 18:20:27 +03:00
Daniel Beck
9d75aa1d79
Fix typos in URL
2016-08-01 16:36:59 +02:00
Daniel Beck
2e904d10bd
Noting #2396 , #2460 , #2469 , #2471 , #2472 , #2478 , #2480 , #2483 , #2484 , #2487
2016-08-01 14:51:11 +02:00
Pierre Dal-Pra
662b3ef734
Fix quoting in undefined parameters warning log ( #2479 )
2016-08-01 13:10:40 +02:00
Kohsuke Kawaguchi
cc3df0b1cb
updated changelog for release
2016-07-31 17:33:13 -07:00
Kohsuke Kawaguchi
fa5179ac32
[maven-release-plugin] prepare for next development iteration
2016-07-31 17:23:11 -07:00
Kohsuke Kawaguchi
e02419c61a
[maven-release-plugin] prepare release jenkins-2.16
jenkins-2.16
2016-07-31 17:23:11 -07:00
Jakub Cechacek
972437dd06
Display delete button only when build is not locked ( #2483 )
2016-07-30 14:55:44 +02:00
Daniel Beck
b27b150257
Merge pull request #2487 from Vlatombe/JENKINS-21486
...
[JENKINS-21486] Fix plugin dependencies resolution, second round.
2016-07-30 14:50:00 +02:00
Vincent Latombe
dff8e806b9
[JENKINS-21486] Only consider plugins detached before the current
...
version
2016-07-29 14:33:56 +02:00
Vincent Latombe
8e3c9dadc1
[JENKINS-21486] Mention both long name, short name and version in console
2016-07-29 14:33:56 +02:00
Vincent Latombe
d8f3bfc8ed
[JENKINS-21486] Cycle monitor should display plugin long name and
...
version
2016-07-29 14:33:56 +02:00
Vincent Latombe
6bf02d514d
[JENKINS-21486] Fix up messages and show plugin version
2016-07-29 14:33:55 +02:00
Vincent Latombe
99fa5f7a49
[JENKINS-21486] Fix :ant from daniel and separate failed plugin from
...
missing
2016-07-29 14:32:48 +02:00
Vincent Latombe
b8f26b34a2
[JENKINS-21486] Simplify dependency errors model and serve consistent
...
messages between console and administrative monitor
2016-07-29 14:32:48 +02:00
Felix Belzunce Arcos
aeb6ad951e
[JENKINS-21485] AdministrativeMonitor for PluginWrapper
2016-07-29 14:32:15 +02:00
Vincent Latombe
646969b690
[JENKINS-21486] Refactoring
2016-07-29 14:31:41 +02:00
Vincent Latombe
43ddbdfc1c
[JENKINS-21486] Fix plugin dependencies resolution
...
* Check that dependencies are enabled. A disabled optional dependency
will not prevent a plugin from loading.
* Check versions of dependencies declared by a plugin before loading it.
If any dependency (even optional) is older than what is required,
then the plugin isn't loaded.
This should prevent use cases where a plugin is loaded but one of its
dependencies is too old so that :
* its @Extension annotated classes cannot be loaded, causing the full
Jenkins to blow up with crapload of exceptions which are tedious to
investigate to understand the root cause.
* NoSuchMethodError and the likes at runtime even though boot has
completed.
Version check (for setups where version list is manually crafted but yet
works) can be disabled by starting Jenkins with
-Dhudson.PluginWrapper.dependenciesVersionCheck.enabled=true
Minor fixes done while implementing this change :
* Fix version parsing in PluginWrapper.Dependency
* Dynamic plugin load didn't check for disabled flag
2016-07-29 14:31:41 +02:00
Stephen Connolly
86e14ddffc
Noting merge of JENKINS-37032, also fixing @since FIXME tags
2016-07-29 13:18:20 +01:00
Stephen Connolly
61c753fca3
Merge pull request #2488 from stephenc/jenkins-37032
...
[JENKINS-37032] Add a UI to allow controlling enabled agent protocols
2016-07-29 13:08:07 +01:00
Stephen Connolly
35e0deaed5
[JENKINS-37032] More documentation of the logic for the preference recording
2016-07-29 13:07:53 +01:00
Stephen Connolly
f02c6c99e8
[JENKINS-37032] Document the logic for the preference recording
2016-07-29 11:50:26 +01:00
Stephen Connolly
eb0f66554a
[JENKINS-37032] Switch to element per protocol XML format
...
- Also switch the A/B testing of JNLP3-connect to via opt-in
- Also mark that JNLP3-connect will be deprecated by JENKINS-36871
- Also start A/B testing the disabling of JNLP-connect and CLI-connect (should be well safe by now)
2016-07-29 10:17:47 +01:00
Stephen Connolly
b012ea9539
[JENKINS-37032] Add display names and optional descriptions
2016-07-29 00:01:32 +01:00
Stephen Connolly
65adca296d
Noting merge of JENKINS-37041
2016-07-28 22:56:59 +01:00
Stephen Connolly
841cba54dd
Merge pull request #2489 from stephenc/jenkins-37041
...
[FIXED JENKINS-37041] Ensure that detached plugins are always at least their minimum version
2016-07-28 21:30:47 +01:00
Jesse Glick
81bc2ef348
Merge pull request #2484 from jglick/ArtifactArchiver.excludes-JENKINS-29922
...
[JENKINS-29922] Correct the default value handling of ArtifactArchiver.excludes
2016-07-28 14:14:55 -04:00
Stephen Connolly
d92fd4cc63
[JENKINS-37041] Address Code review comments
2016-07-28 16:30:17 +01:00
Stephen Connolly
2a450e5ac2
[FIXED JENKINS-37041] Ensure that detached plugins are always at least their minimum version
2016-07-28 16:09:21 +01:00
Jesse Glick
edfffb160a
Merge pull request #2478 from jglick/Test2
...
Tests are not run unless the class name ends with "Test"
2016-07-28 11:02:11 -04:00
Stephen Connolly
17894bc162
[FIXED JENKINS-37032] Add a UI to allow controling the agent protocol enablement
2016-07-28 15:36:33 +01:00
Stephen Connolly
389b05752c
[JENKINS-37031] Advertise the enabled Agent Protocols to enable faster connection negotiation
2016-07-28 12:58:52 +01:00
Stephen Connolly
8e536513e8
[JENKINS-36996] Noting merge
2016-07-27 20:46:55 +01:00
Stephen Connolly
e7b39efff8
Merge pull request #2485 from stephenc/jenkins-36996
...
[FIXED JENKINS-36996] Hide the Java Web Start launcher when the TCP agent port is disabled
2016-07-27 19:42:23 +01:00
Alvaro Lobato
404384eefe
[JENKINS-36908] Make sure that the All view is created ( #2472 )
...
* [JENKINS-36908] Make sure that the All view is created
* Revert old All view behaviour
* Fix changed comment
* Tests
* Delete unwanted file.
2016-07-27 18:31:29 +02:00