Commit Graph
32590 Commits
Author SHA1 Message Date
R. Tyler Croy 2294259b2c [FIXED JENKINS-35641] - Always send usage statistics over HTTPs to the new usage.jenkins.io hostname(#2398)
References INFRA-559
(cherry picked from commit 01db7d36c8)
2016-07-20 15:42:52 +02:00
Oleg Nenashev 3da25a01e3 Update remoting to 2.60 (#2403)
Changes summary:

Fixed issues:
* [JENKINS-22722](https://issues.jenkins-ci.org/browse/JENKINS-22722) -
Make the channel reader tolerant against Socket timeouts.
(https://github.com/jenkinsci/remoting/pull/80)
* [JENKINS-32326](https://issues.jenkins-ci.org/browse/JENKINS-32326) -
Support no_proxy environment variable.
(https://github.com/jenkinsci/remoting/pull/84)
* [JENKINS-35190](https://issues.jenkins-ci.org/browse/JENKINS-35190)  -
Do not invoke PingFailureAnalyzer for agent=>master ping failures.
(https://github.com/jenkinsci/remoting/pull/85)
* [JENKINS-31256](https://issues.jenkins-ci.org/browse/JENKINS-31256) -
 <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection.
(https://github.com/jenkinsci/remoting/pull/87)
* [JENKINS-35494](https://issues.jenkins-ci.org/browse/JENKINS-35494) -
Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class).
(https://github.com/jenkinsci/remoting/pull/88)

Enhancements:
* Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>.
(https://github.com/jenkinsci/remoting/pull/80)
(cherry picked from commit c718516adf)
2016-07-20 15:42:52 +02:00
Daniel Beck 7000cd2c42 [FIX JENKINS-26438] Allow to keep forever with custom build discarder (#2443)
(cherry picked from commit 7acfbec4ab)
2016-07-20 15:42:52 +02:00
Pavel Janousek fb7458f2e6 [JENKINS-34468] CLI command offline-node extracted from core to CLI (#2392)
* [JENKINS-34468] CLI command offline-node extracted from core to CLI

offline-node extended to accept multiple node names
offline-node covered by test-cases

* Fixed translation properties

* Fixes based on Oleg's comments

* Fixed HelpCommandTest test-case

* Minor fixes

* Uses Matchers.instanceOf everywhere instead of Java operator instanceof
2016-07-20 15:30:09 +03:00
Jesse Glick 4ed803cea2 [JENKINS-36666] Defend against some fatal startup errors (#2453)
* [JENKINS-36666] Properly report the reason for a failed call to Task.getDisplayName.

* [JENKINS-36666] Even without passing fatal=false to @Initializer, recover gracefully from a LinkageError in a task.

* Comment.
2016-07-20 14:55:42 +03:00
Felix Belzunce Arcos 40687bdc22 [JENKINS-36748] Do not process null Triggers (#2463)
* [JENKINS-36748] Not process null Triggers

* [JENKINS-36748] Specify job

* [JENKINS-36748] Correctly check NullPointerException
2016-07-20 14:54:17 +03:00
Robert Sandell eb538b5f59 Merge pull request #2466 from rsandell/JENKINS-35493-followup
Remove API restriction on UserDetailsCache
2016-07-19 18:23:42 +02:00
Robert Sandell 27eee166d3 Merge remote-tracking branch 'origin' into JENKINS-35493-followup 2016-07-19 18:22:41 +02:00
Robert Sandell 06e99bd942 Merge pull request #2446 from rsandell/JENKINS-35493
[JENKINS-35493] Introduce a UserDetails cache
2016-07-19 18:21:47 +02:00
Robert Sandell a4a1847d74 Remove API restriction on UserDetailsCache
Followup to #2446 to remove the API restriction
so that the first fix can potentially be picked
for LTS while this stays in the weekly release.
2016-07-19 17:58:03 +02:00
Robert Sandell 84416d5dcc Merge branch 'JENKINS-35493' into JENKINS-35493-followup 2016-07-19 17:56:26 +02:00
Robert Sandell 642138dd34 Invalidate UserDetailsCache when User.fullName changes 2016-07-19 15:38:09 +02:00
Antonio Muniz 6c5fbf0008 Update since tags for Item Categorization API (#2465) 2016-07-19 13:15:06 +02:00
Robert Sandell 082e22c81c Invalidate UserDetailsCache on user rekey and reload 2016-07-19 11:47:42 +02:00
Robert Sandell 5005026b66 Invalidate user details cache when user is removed 2016-07-18 18:13:46 +02:00
Robert Sandell 538332385e Merge remote-tracking branch 'origin/master' into JENKINS-35493 2016-07-18 17:36:56 +02:00
Robert Sandell 1231d82139 Invalidate the key in existanceCache instead of setting null 2016-07-18 12:03:23 +02:00
Kohsuke Kawaguchi 64270cc2ab updated changelog for release 2016-07-17 14:03:11 -07:00
Kohsuke Kawaguchi 9b3785b36c [maven-release-plugin] prepare for next development iteration 2016-07-17 13:57:07 -07:00
Kohsuke Kawaguchi 3fdc58e39d [maven-release-plugin] prepare release jenkins-2.14 jenkins-2.14 2016-07-17 13:57:07 -07:00
Oleg Nenashev 3e3a48ee99 Noting #2443, #2420, #2408, #2433, #2450, #2449, #2448, #2454 2016-07-17 14:02:51 +03:00
Oleg Nenashev 055457d0b8 Merge pull request #2457 from oleg-nenashev/bug/JENKINS-36193
[JENKINS-36193] Raise exception when trying to build a job that is disabled
2016-07-16 22:16:20 +03:00
Jesse Glick c31392d140 [JENKINS-36476] Underprivileged users could not use the default value of a password parameter (#2454)
* [FIXED JENKINS-36476] Do not even send the default password in encrypted form; leave the text field blank, and apply the default upon submission.

* [JENKINS-36476] Use a special token, not the empty string, as the marker for the default value.
2016-07-16 22:14:48 +03:00
Oleg Nenashev 7d5a2e3f36 [JENKINS-36592] Prevent NPE in BlockedBecauseOfBuildInProgress#getDescription() (#2448)
* [JENKINS-36592] Prevent NPE in BlockedBecauseOfBuildInProgress#getDescription() in the case of race condition

* [JENKINS-36592] - Address comments from @jglick

* [JENKINS-36592] - Fix wording. Attempt #2
2016-07-16 22:14:16 +03:00
Oleg Nenashev 890e181626 FindBugs: Synchronize ListView#jobNames access in readResolve (should be harmless) 2016-07-16 03:07:15 +03:00
Oleg Nenashev e682e2b9b8 FindBugs: Avoid boxing/unboxing of Integer in Job#getDynamic() 2016-07-16 03:03:44 +03:00
Oleg Nenashev 6b89ce4a33 FindBugs: Suppress MS_SHOULD_BE_REFACTORED_TO_BE_FINAL in JnlpSlaveAgentProtocol3#Enabled 2016-07-16 03:00:21 +03:00
Oleg Nenashev a13301804f FindBugs: Suppress FB unchecked cast warning in ToolDescriptor@getInstallations() 2016-07-16 02:57:42 +03:00
Oleg Nenashev 8c7355042e FindBugs: Fix real issue with a method contract violation in ListViewColumn defaults retrieval 2016-07-16 02:53:02 +03:00
Oleg Nenashev 2ac529ed5e FindBugs: Handle non-realistic case when null StaplerRequest gets passed into DEfaultCrumbIssuer and Maven step instatinations 2016-07-16 02:37:53 +03:00
Oleg Nenashev 10522b7fec FindBugs: Handle potential null jenkins instance in the DescriptorExtensionList#load() method 2016-07-16 02:34:33 +03:00
Oleg Nenashev 6e7b84bc08 FindBugs: Suppress MS_SHOULD_BE_REFACTORED_TO_BE_FINAL for ChartUtils#awtProblemCause 2016-07-16 02:17:41 +03:00
Oleg Nenashev 3c31cb9692 FindBugs: Suppress DM_GC in hudson.Util#pauseBetweenDeletes(), because it's a desired behavior for custom setting 2016-07-16 02:16:50 +03:00
Oleg Nenashev 52f8ba0e5b FindBugs: Suppress DMI_COLLECTION_OF_URLS in PluginManager since it's safe 2016-07-16 02:15:58 +03:00
Oleg Nenashev 8a330acc5e [JENKINS-36193] - Add direct unit test for the issue 2016-07-15 17:33:29 +03:00
Oleg Nenashev 994fd9ffdd Annotate and document the AsynchronousExecution#getExecutor() method (#2447) 2016-07-15 17:32:47 +04:00
Rupin R Nath 0b517705f5 [FIXED JENKINS-33201 Java JSON exception with an empty parametrized build.] (#2444)
* Fixed JENKINS-33201 [Java JSON exception with an empty parametrized
build.]

* FIXED JENKINS-33201. Changed to FormException instead of Failure

* That fix was never in a released version.

So it cannot have been reverted.

* Lowercase i for consistency

* Remove the concept of yanking dead executors.

* Another unnecessary call to doYank.

* [FIXED JENKINS-27530] Jenkins.reload must also reload the Queue to ensure that every Queue.Item.task corresponds to a live Job, lest nextBuildNumber be bogus.

* [JENKINS-27530] Noting #2439 & #2440.

* FIXED JENKINS-33201. Changed to FormException instead of Failure

* [FIXED JENKINS-33201 .FormException is thrown if parameterDefinitions are not available .

* Changing one more Tab to Space

* Moved checkForEmptyParameters to Job class
2016-07-15 16:53:59 +04:00
Oleg Nenashev 4577cf6ae1 [FIXED JENKINS-36593] - Make ItemCategory#MIN_TOSHOW restricted (#2449)
* [JENKINS-36593] - ItemCategory#MIN_TOSHOW should be restricted

* [JENKINS-36593] - Add Javadoc
2016-07-15 16:50:50 +04:00
Robert Sandell a0431beba6 Turn on autocomplete for job and view name 2016-07-15 12:53:58 +02:00
Oleg Nenashev e5f20ceb45 [FIXED JENKINS-36594] - CauseOfInterruption.UserInterruption#getUser() should not create new users (#2450)
* CauseOfInterruption.UserInterruption#getUser() should not create new users if the user gets deleted before the cause printing call

* [JENKINS-36594] - Print raw username if we cannot create MasterHyperlinkNote
2016-07-15 11:00:09 +04:00
ge-vi 382b04f786 translations for lt language (#2430) 2016-07-15 10:55:49 +04:00
godfath3r 439426236f [JENKINS-36387] Catch exception when scm retry count field is empty. (#2433)
* [JENKINS-36387] Catch exception when scm retry count field is empty.

* Add test for JENKINS-36387

* [JENKINS-36387] Move test in correct place

* [JENKINS-36387] Reproduce actuall behaviour
2016-07-14 21:18:45 +04:00
Stephen Connolly 4fb6e32d80 Noting JENKINS-36629 2016-07-14 16:12:08 +01:00
Stephen Connolly 2e533ef7a0 Merge pull request #2451 from stephenc/optimize-recent-build-stability
[JENKINS-36629] Optimization for recent build stability calculation
2016-07-14 16:08:40 +01:00
Robert Sandell 88c2d8ed04 [JENKINS-18435] Tell browsers not to cache or try to autocomplete forms
Setting autocomplete to "off" will tell browsers not to try to autofill
forms during history navigation. Since this seems to be a prominent
problem in Jenkins I feel it is best to have it default to "off" and let
individual inputs or pages opt-in to enable it instead
to indicate they can handle it.
The standard login page does not seem to use the taglib form tag
so it is not affected, even so, all modern browsers ignores
the autocomplete attribute on username and password fields anyway.
2016-07-14 15:49:28 +02:00
Oliver Gondža 10cb11f9cd Describe pipeline aware alternative of deprecated method (#2452) 2016-07-14 10:36:00 +02:00
Jesse Glick 175aa55c70 Merge pull request #2438 from jglick/LoggerRule
Use LoggerRule
2016-07-13 10:17:03 -04:00
Stephen Connolly 78c0031857 [JENKINS-36629] Use a name that does not assume on disk storage of run records 2016-07-13 08:59:32 +01:00
Stephen Connolly b7c0d93de8 [FIXED JENKINS-36629] Add a test
The test found out that RunMap's subMap implementation only returns loaded builds, so we needed to introduce a method to test if there was a specific run on the disk. For the weather reports we do not care if the record on the disk fails to load
2016-07-12 17:46:31 +01:00
Stephen Connolly 7e0e79de28 Optimization for recent build stability calculation that should at most load two builds into memory for the recently stable case. In the non-recently stable case we just pre-load the most recently stable one and skip loading any intermediary successful ones 2016-07-12 16:15:11 +01:00