Otherwise you get:
java.lang.AssertionError: class org.jvnet.hudson.test.ExtractResourceWithChangesSCM is missing its descriptor
at jenkins.model.Jenkins.getDescriptorOrDie(Jenkins.java:1166)
at hudson.scm.SCM.getDescriptor(SCM.java:654)
at hudson.scm.AutoBrowserHolder.get(AutoBrowserHolder.java:54)
at hudson.scm.SCM.getEffectiveBrowser(SCM.java:136)
at hudson.scm.ChangeLogSet.browserFromBuild(ChangeLogSet.java:82)
at hudson.scm.ChangeLogSet.<init>(ChangeLogSet.java:76)
at org.jvnet.hudson.test.ExtractChangeLogSet.<init>(ExtractChangeLogSet.java:41)
at org.jvnet.hudson.test.ExtractChangeLogParser.parse(ExtractChangeLogParser.java:80)
at org.jvnet.hudson.test.ExtractChangeLogParser.parse(ExtractChangeLogParser.java:52)
at org.jvnet.hudson.test.ExtractChangeLogParser.parse(ExtractChangeLogParser.java:46)
at hudson.model.AbstractBuild.calcChangeSet(AbstractBuild.java:894)
at hudson.model.AbstractBuild.access$600(AbstractBuild.java:104)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:634)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1745)
at …
For people doing JavaScript based page manipulation from JavaScript for
quick UI hack/prototyping, information about what the page is about is
useful, even if it's not completely reliable (e.g., the top page
reporting it's for AllView not for Hudson)
More fun here:
- All this originates from Executor extending Thread.
- There is funky logic in the lock handling code of the JVM that makes assumptions
about how it might proceed with the lock when the thread holding the lock has its
interrupt flag set.
- Really it would be better if Executor did not extend Thread as that way we wouldn't
have to deal with some of that complexity. But OTOH we are where we are and backwards
compatibility may make such a change not possible without a lot of breakage.
- Fixing the issue at hand, firstly requires that interrupting a Computer happens with the
Queue lock held (to speed up tests we have Jenkins.cleanup get the lock for all Computers)
That prevents the Queue maintain thread from getting caught
- Secondly, when removing an executor from a computer we process the removal while
holding the Queue lock, but we move the removal itself to a separate thread if we cannot
get the Queue lock in order to avoid deadlock.
- Also add helper methods to wrap tasks to be performed while holding the lock
and a helper method for Runnables that exposes the tryLock functionality
This allows extensions to veto killing of certain processes.
Issue 9104 is not yet solved by this, it is only part of the solution. The
rest should be taken care of in plugins.
- Typo
- Print error combined
- Set result only when phase like in other code parts.
- Test for expected error message in log
(cherry picked from commit 161a009271)
- Print publisher display name instead of class, so user can understand what publisher in UI was used and failed.
- Setter for artifact archiver shows how it handle status
- Minor typos
- Added test for stacktraces in build log
(cherry picked from commit 92734a8345)
Simple `<l:task post="true" href="someurl"/>` triggers post request as expected
but then proceeds to href as normal link to. If the URL accepts GET then request
is sent twice it if does not after POSTing on background user get
'POST is required' error.
(cherry picked from commit baa192499a)