Commit Graph
32590 Commits
Author SHA1 Message Date
Oleg Nenashev 4c11691a8f [JENKINS-28419] - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter
(cherry picked from commit dab392f80f)
2015-06-08 21:15:20 +02:00
Oleg Nenashev 84d80f57f2 [JENKINS-28446] - Introduce new API method in Queue to optimize the performance of UnlabeledLoadStatistics
(cherry picked from commit 7697bdb4f5)
2015-06-08 21:00:47 +02:00
Oleg Nenashev ece651d4d0 [FIXED JENKINS-28446] - Calculate only tasks without assigned labels
This implementation does not create new methods in API, hence it can be backported.

(cherry picked from commit 294ce778b3)
2015-06-08 21:00:47 +02:00
Oleg Nenashev 56fc386095 [JENKINS-28446] - Direct unit test for the issue
(cherry picked from commit 43b0662641)
2015-06-08 21:00:47 +02:00
Oleg Nenashev de5d83de09 Code documentation/annotation around JENKINS-28446.
Just to prevent similar misuses in the future.

(cherry picked from commit 298e371321)
2015-06-08 21:00:47 +02:00
tfennelly c7264c4668 [FIXED JENKINS-28455] Build History badges don't wrap
(cherry picked from commit 35eb8ac93e)
2015-06-08 20:52:06 +02:00
David Hoover 41dd74dd43 DefaultJnlpSlaveReceiver should return true when rejecting a takeover.
The contract for JnlpAgentReceiver in case of error on a claimed node is
to call handshake.error() but still return true so other handlers don't
take another crack a it.

Also added unit tests DefaultJnlpSlaveReceiver.

(cherry picked from commit 2d452b6eb3)
2015-06-08 20:07:14 +02:00
Martijn Baay 0ce0428f7d Add support for Maven 3 .cmd files in Windows
(cherry picked from commit f7c0a49b4b)
2015-06-08 18:43:34 +02:00
Harald Albers fb47e9b58b Update bundled LDAP plugin in order to restore missing help files
In e91782e78f some help files were removed
from core because they were moved to LDAP plugin.
Unfortunately, these help files are not available in LDAP plugin
versions prior to 1.11.
(cherry picked from commit 824662a84d)
2015-06-08 18:39:05 +02:00
vb-linetco 61681d1d15 avoid IndexOutOfBoundsException when called with 0
return an empty list when called with maxLines = 0
added unit test for getLog(0) returning an empty list

(cherry picked from commit 75f58103d4)
2015-06-08 18:29:51 +02:00
Stephen Connolly ddb0a472ad [FIXED JENKINS-28690] Deadlock in hudson.model.Executor
- Rather fun one here. The Lock code relies on assuming that Thread.interrupted() is clear on entry
- If it then sees Thread.interrupted() set, it will interrupt the current thread in order to set the
  flag again.
- Executor is a thread that does funky things with an overridden interrupt method
- Executor.abortResult() is used to track a build be interrupted or aborted in some other way
- As a result the abortResult can cause a deadlockif there is a genuine interruption
- This fix clears the interrupt flag in abortResult() and uses the write lock in order to ensure:
    - The same lock as used in interrupt() is helf
    - The interrupt flag is clear
- Clearing the interrupt flag should be safe as the only time it is called is immediately after
  an interruption and the resulting exception is caught and rethrown/logged anyway
2015-06-08 14:38:49 +01:00
Ing. Pavel Janousek 65d78d5bd1 Unification of issue passing (all in exceptions) 2015-06-08 15:15:58 +02:00
Kohsuke Kawaguchi 998b2f2be5 updated changelog for release 2015-06-07 21:43:51 -07:00
Kohsuke Kawaguchi bd8a2142c9 [maven-release-plugin] prepare release jenkins-1.617 jenkins-1.617 2015-06-07 21:36:53 -07:00
Kohsuke Kawaguchi 7d2b005008 [maven-release-plugin] prepare for next development iteration 2015-06-07 21:36:53 -07:00
Oleg Nenashev bf7f14b165 [JENKINS-25734] - Prevent NPE in Executor/causeOfDeath page if the field is null
The change does not fix the issue, but it suppresses NPE at least.
2015-06-07 16:05:35 +03:00
Oleg Nenashev 365ce31cff Noting #1724 2015-06-07 12:08:23 +03:00
Oleg Nenashev 695a3d7dab Merge pull request #1724 from oleg-nenashev/AbstractProject_constructor_NPE
[FIXED JENKINS-28654] - Check null nodes condition in AbstractProject constructor
2015-06-07 11:47:10 +03:00
Daniel Beck 29f223a507 Noting #1728 2015-06-06 18:37:05 +02:00
Daniel Beck 31208c3dc2 Merge pull request #1728 from daniel-beck/JENKINS-27739
[FIX JENKINS-27739] Clear cached env vars when node goes online
2015-06-06 18:35:16 +02:00
liorha dc23c1120d Merge branch 'master' into JENKINS-27289-update 2015-06-06 19:16:12 +03:00
Daniel Beck c6d4204af1 [JENKINS-27739] Ensure cache clearing listener runs first 2015-06-06 01:49:27 +02:00
Daniel Beck c569036fca [FIX JENKINS-27739] Clear cached env vars when node goes online 2015-06-05 15:10:26 +02:00
Ing. Pavel Janousek 4f60993f8b Handle correctly missing View/Read permission during view deletion 2015-06-05 14:41:12 +02:00
Ing. Pavel Janousek 1571359f18 Submit an Unexpected exception occurred to Jenkins log too. 2015-06-05 14:04:20 +02:00
Ing. Pavel Janousek ef34eb5aa5 View getView(String name): checkPermission() -> hasPermission() and return NULL if the user doesn't have a READ permission 2015-06-05 14:01:31 +02:00
Daniel Beck 9b3039295e Merge pull request #1727 from thomassuckow/feature/JENKINS-28704
[FIXED JENKINS-28704] Regression for build-history link not opening console
2015-06-05 11:45:54 +02:00
Thomas Suckow 2522ffcb7d [FIXED JENKINS-28704] Regression for build-history link not opening console 2015-06-02 16:30:10 -07:00
liorha 865afbe4b3 fix to return empty enumeration instead of null 2015-06-01 23:18:06 +03:00
liorha 40e75129f4 Contine the JENKINS-27289 ticket: update the getResources as well 2015-06-01 18:06:41 +03:00
Kohsuke Kawaguchi aa0d84a19a updated changelog for release 2015-05-31 19:26:11 -07:00
Kohsuke Kawaguchi 9fb3aa2375 [maven-release-plugin] prepare release jenkins-1.616 jenkins-1.616 2015-05-31 19:15:59 -07:00
Kohsuke Kawaguchi 81d2fc2544 [maven-release-plugin] prepare for next development iteration 2015-05-31 19:15:59 -07:00
Harald Albers 01c036a25b updated German localization 2015-05-31 17:10:48 +02:00
Oleg Nenashev a7ec87c007 [FIXED JENKINS-28654] - Check null nodes condition in AbstractProject constructor 2015-05-31 15:08:14 +03:00
Doug Alcouffe e7fba1e655 NPE fix for AbstractProject polling when node is not available 2015-05-30 15:54:16 -06:00
Kohsuke Kawaguchi 0cace71a51 [maven-release-plugin] prepare for next development iteration 2015-05-29 18:08:03 -07:00
Kohsuke Kawaguchi 0c04593627 [maven-release-plugin] prepare release jenkins-1.609.1 jenkins-1.609.1 2015-05-29 18:08:03 -07:00
Jesse Glick 6bca813768 Starting to write tests for printThrowable. 2015-05-29 08:42:30 -04:00
Jesse Glick 47cb028ac3 Added Javadoc. 2015-05-29 08:04:29 -04:00
Jesse Glick f73255968f Use system line separator. 2015-05-29 07:54:36 -04:00
Jesse Glick 313ccb9646 Merge pull request #1722 from jglick/removeExecutor-NPE
Null safety for removeExecutor
2015-05-29 07:38:34 -04:00
Jesse Glick 532e9d24e8 Merge branch 'master' into printStackTrace-JDK-6507809 2015-05-29 07:31:06 -04:00
Jesse Glick 10401aa7fc Null safety for removeExecutor.
Sometimes observed at end of (passing) WorkflowTest.executorStepRestart in 1.596.1:
Exception in thread "Executor #0 for slave0 : executing PlaceholderExecutable:job/demo/1/:null" java.lang.NullPointerException
	at hudson.model.Computer.removeExecutor(Computer.java:869)
	at hudson.model.Executor.run(Executor.java:272)
2015-05-28 20:03:43 -04:00
Oleg Nenashev 9c443c8d5b Noting #1616 2015-05-27 11:43:50 +03:00
Oleg Nenashev 6c7da9c3c7 Merge branch 'fix-JENKINS-27549' from #1616 2015-05-27 11:36:25 +03:00
Yoann Dubreuil 4c0d3ac623 [FIXED JENKINS-27549] log job full name and catch Throwable (+1 squashed commit)
Squashed commits:
[73308b5] [FIXED JENKINS-27549] job loading can be broken by a NPE in a build trigger
2015-05-27 11:34:25 +03:00
Daniel Beck a594973432 Move JENKINS-28425 and JENKINS-28455 to 1.615 2015-05-26 20:01:36 +02:00
David Hoover 4299e83293 When an AbstractNodeMonitorDescriptor doesn't have a result, request it via triggerUpdate()
It was spinning up its own thread instead of going through normal
channels, so subsequent calls would still think there was no update in
progress and would fire off another.

Lather, rinse, repeat, threadsplosion.
2015-05-26 10:38:08 -07:00
Kohsuke Kawaguchi 5f8eb9de97 updated changelog for release 2015-05-25 21:06:35 -07:00