Oleg Nenashev
32dca8819c
[JENKINS-10629] - Direct unit test for the issue
...
This test also introduces additional round-trip tests for small files
2015-04-14 18:59:38 +03:00
Stephen Connolly
57efbea3d0
Merge pull request #2 from oleg-nenashev/JENKINS-27871
...
[JENKINS-27871] - Added a direct unit test for the issue
2015-04-14 15:16:07 +01:00
Oleg Nenashev
7514e8c6ce
[JENKINS-27871] - Added a direct unit test for the issue
2015-04-14 17:03:53 +03:00
David Hoover
3ad517e73f
Remove unnecessary null check.
...
UserPropery promises it's set, and even if it somehow wasn't, this would
have thrown a NullPointerException two lines earlier.
2015-04-13 22:30:43 -07:00
Oleg Nenashev
38c2f98f21
Merge pull request #1648 from deadmoose/patch-2
...
Name the correct class in javadoc.
builds/358
2015-04-14 07:34:20 +03:00
David Hoover
74ec2f175d
Name the correct class in javadoc.
2015-04-13 16:08:10 -07:00
Felix Belzunce Arcos
6528ff1e86
Tab major clean up
2015-04-13 15:00:12 +02:00
Felix Belzunce Arcos
dab5650683
Corrent tab in assertTrue again
2015-04-13 14:57:58 +02:00
Felix Belzunce Arcos
e5e53be000
Corrent tab in assertTrue
2015-04-13 14:50:46 +02:00
Felix Belzunce Arcos
9afb092b44
Correct tests
2015-04-13 14:47:53 +02:00
Harald Albers
ebffeccd10
Remove empty list item from changelog
2015-04-13 13:36:25 +02:00
Harald Albers
7887dc2df3
Remove extra 1.609 sections from changelog
2015-04-13 13:34:46 +02:00
Stephen Connolly
5880ed8302
[FIXED JENKINS-27708][FIXED JENKINS-27871] Ensure that identification of blocked tasks is using the live state.
...
- The creation of a snapshot itself should be relatively cheap given the expected rate of
job execution. You probably would need 100's of jobs starting execution every iteration
of maintain() before this could even start to become an issue and likely the calculation
of isBuildBlocked(p) will become a bottleneck before updateSnapshot() will. Additionally
since the snapshot itself only ever has at most one reference originating outside of the stack
it should remain in the eden space and thus be cheap to GC.
- JENKINS-27708 comments 225819 and 225906 provide more complex but logically equivalent fixes of
this issue. I am favouring this approach as it is simpler and provides less scope for error as any
new helper methods can just rely on the snapshot being up to date whereas with the other
two candidates if a new helper method is introduced there is the potential to miss adding support
for the live view. The comment 225819 has the risk of introducing extra lock contention while
the comment 225906 version forces every access to the helper methods to pass a second memory
barrier
2015-04-13 09:48:31 +01:00
Kohsuke Kawaguchi
64465feb3d
updated changelog for release
changes/358
2015-04-12 20:08:17 -07:00
Kohsuke Kawaguchi
4adf179d11
updated changelog for release
2015-04-12 19:50:26 -07:00
Kohsuke Kawaguchi
810cb437d5
updated changelog for release
2015-04-12 19:48:55 -07:00
Kohsuke Kawaguchi
427924f2e8
updated changelog for release
2015-04-12 19:03:50 -07:00
Kohsuke Kawaguchi
ccc5428560
updated changelog for release
2015-04-12 19:00:55 -07:00
Kohsuke Kawaguchi
33eb71673f
updated changelog for release
2015-04-12 18:59:48 -07:00
Kohsuke Kawaguchi
767c79a1a3
updated changelog for release
2015-04-12 18:44:40 -07:00
Kohsuke Kawaguchi
74b0a80000
updated changelog for release
2015-04-12 18:34:20 -07:00
Kohsuke Kawaguchi
3594406997
[maven-release-plugin] prepare for next development iteration
2015-04-12 18:28:43 -07:00
Kohsuke Kawaguchi
94cc18a2d7
[maven-release-plugin] prepare release jenkins-1.609
jenkins-1.609
2015-04-12 18:28:42 -07:00
Kohsuke Kawaguchi
3c4b1e63a2
Doc improvements
2015-04-11 12:45:12 -07:00
Kohsuke Kawaguchi
4e2efcda7e
$class is not legacy, stapler-class is, so making sure it's not getting mixed up.
2015-04-11 12:39:29 -07:00
Jesse Glick
37167d5f08
Noting deprecations more widely.
2015-04-11 13:58:49 -04:00
Jesse Glick
8dd079a8f0
findByClassName should not be advertised to outside code.
2015-04-11 13:50:19 -04:00
Jesse Glick
33923db173
Improving Javadoc.
2015-04-11 13:47:29 -04:00
Jesse Glick
c4c7259849
Added @since.
2015-04-11 13:38:49 -04:00
Jesse Glick
8f1883a0ca
Now it passes.
2015-04-11 13:27:54 -04:00
Jesse Glick
724df64116
Merge remote-tracking branch 'origin/JENKINS-26781' into JENKINS-26781
2015-04-11 13:23:42 -04:00
Jesse Glick
33041903ab
[JENKINS-26781] Reproduced problem in test.
...
Besides failing in master, it also fails in 4e0af43 (merge of #1443 ), but passes in the 1.598-SNAPSHOT parent 239caf8 .
2015-04-11 13:21:06 -04:00
ikedam
f0a88e65be
[JENKINS-27505] Collapse tests for JENKINS-27505 to save execution time.
2015-04-11 10:49:17 +09:00
Kohsuke Kawaguchi
8f8aa71e3c
A bit easier formula
2015-04-10 13:17:02 -07:00
Stephen Connolly
0000211df7
[JENKINS-27836] Add test case
2015-04-08 10:44:32 +01:00
Stephen Connolly
9fd4c1a854
[FIXED JENKINS-26520] Noting merge of #1637
2015-04-08 09:47:55 +01:00
Stephen Connolly
6e7e3c8f3a
[FIXED JENKINS-27836] Noting merge of #1570
2015-04-08 09:45:49 +01:00
Jesse Glick
e80c69c433
Merge pull request #1637 from jglick/BUILD_ID-JENKINS-26520
...
[JENKINS-26520] Documentation fix for $BUILD_ID
2015-04-07 16:26:46 -04:00
Stephen Connolly
c2e9423b95
Merge pull request #1570 from ndeloof/ZD-24695
...
prevent removing artifact when build isn’t completed yet
2015-04-07 13:16:15 +01:00
Stephen Connolly
62a33091d2
Another method that should be part of the API
2015-04-07 10:00:36 +01:00
Stephen Connolly
696a7f9620
Add API to allow complete roundtrip from Authentication to User
...
Without this change you need to do:
```
User user;
final SecurityContext oldContext = ACL.impersonate(a);
try {
user = User.current();
} finally {
SecurityContextHolder.setContext(oldContext);
}
```
Which seems incredibly wasteful.
Or else you need to replicate the logic in User.current() which makes that code hard to change.
2015-04-07 09:31:12 +01:00
Daniel Beck
fec557818c
Improve changelog entry for JENKINS-21322
2015-04-07 01:23:13 +02:00
Daniel Beck
f6454983ac
[FIXED JENKINS-27067] Larger minimum popup menu height
2015-04-06 17:59:26 +02:00
Daniel Beck
6228bbaf60
Update changelog.html
2015-04-06 13:32:47 +02:00
Kohsuke Kawaguchi
50dcc54bbf
Packaging scripts have moved to jenkinsci/packaging repo
2015-04-05 19:45:50 -07:00
Kohsuke Kawaguchi
7ed6b00136
Noting that packages come from elsewhere now
2015-04-05 19:44:16 -07:00
Kohsuke Kawaguchi
d974248009
updated changelog for release
2015-04-05 19:03:39 -07:00
Kohsuke Kawaguchi
e544304c0b
[maven-release-plugin] prepare release jenkins-1.608
jenkins-1.608
2015-04-05 18:49:28 -07:00
Kohsuke Kawaguchi
b1bac27272
[maven-release-plugin] prepare for next development iteration
2015-04-05 18:49:28 -07:00
Daniel Beck
ac424c9470
Noting #1604 and #1501
2015-04-04 23:59:35 +02:00