Commit Graph
32590 Commits
Author SHA1 Message Date
Stephen Connolly ef04663b35 fix typos 2015-03-28 07:46:54 +00:00
Stephen Connolly 55db82c0cd Allow control over the creation of different TopLevelItems from the ACL 2015-03-28 07:46:54 +00:00
Stephen Connolly 2dcc16e38f It's whack-a-mole trying to fix this in my own personal time! 2015-03-28 01:08:49 +00:00
Stephen Connolly d9e4e36fde fix build 2015-03-28 00:05:22 +00:00
Kohsuke Kawaguchi fc79e104b3 Merge pull request #1631 from kohsuke/cli-socket-improvements
Set proper socket parameters suitable for CLI communication
2015-03-27 15:29:11 -07:00
Kohsuke Kawaguchi 5055776cd8 Set proper socket parameters suitable for CLI communication
Keep-alive option ensures that the connection won't hang forever. NoDelay option improves performance as the communication over the socket is already datagram oriented.

See: https://developer.cloudbees.com/bin/view/DEV/On-Premise+Executors
2015-03-27 14:20:02 -07:00
Stephen Connolly 7a64e030a3 Merge pull request #1629 from stephenc/fix-build-4044
Fix build 4044
2015-03-27 14:08:56 +00:00
Stephen Connolly 98605d0afb After JENKINS-26391 we need to compare labels based on matching names not instance identity 2015-03-27 13:58:44 +00:00
Stephen Connolly 384e02518c Make test easier to diagnose failures 2015-03-27 13:57:57 +00:00
Stephen Connolly 63d38d35c9 Add @since tags 2015-03-27 13:56:59 +00:00
Stephen Connolly d12d5657a2 Add @since tag 2015-03-27 13:56:06 +00:00
Oliver Gondža ca5b9b6672 [FIXED JENKINS-20989] PeepholePermalink RunListenerImpl oncompleted should be triggered before downstream builds are triggered 2015-03-27 13:31:44 +01:00
Seiji Sogabe af5d831069 fixed COMPILATION ERROR
- queueLengthSnapshot never used.
2015-03-27 21:19:49 +09:00
Oliver Gondža 021c1b381d [JENKINS-20989] Reproduce 2015-03-27 12:45:21 +01:00
Stephen Connolly c5c6ece11e People complained about the javadoc comment on this method 2015-03-27 10:39:31 +00:00
Stephen Connolly 46dc6850ed Noting merges
- JENKINS-15355
- JENKINS-21618
- JENKINS-22941
- JENKINS-25938
- JENKINS-26391
- JENKINS-26900
- JENKINS-27476
- JENKINS-27563
- JENKINS-27564
- JENKINS-27565
- JENKINS-27566

- Fixing link text for JENKINS-6167
2015-03-27 10:32:06 +00:00
Stephen Connolly 86954de76e Merge branch 'wip-loadstats-refactor' 2015-03-27 10:14:25 +00:00
Stephen Connolly 11a8023a97 Merge branch 'christ66-JENKINS_26391' 2015-03-27 09:36:45 +00:00
Stephen Connolly a21e84c13a Merge branch 'JENKINS_26391' of https://github.com/christ66/jenkins into christ66-JENKINS_26391 2015-03-27 09:33:17 +00:00
Jesse Glick 62b62752e7 Merge pull request #1619 from KostyaSha/removeEditorconfig
Remove editorconfig
2015-03-26 17:49:32 -04:00
Jesse Glick 1d254b7dc3 Merge pull request #1627 from stephenc/simplify-executors-display
simplify displaying the executors
2015-03-26 14:24:14 -04:00
Stephen Connolly 3eca1036f2 move logic to a method in Executor 2015-03-26 15:57:53 +00:00
Stephen Connolly d863742dd1 simplify displaying the executors as follow-up to comment by @jglick to #1596 2015-03-26 15:52:48 +00:00
Stephen Connolly 1d818a16fd Merge pull request #1626 from stephenc/fix-since-tags
fix the @since tags
2015-03-26 15:33:45 +00:00
Stephen Connolly 1c253bb352 fix the @since tags 2015-03-26 15:22:33 +00:00
Stephen Connolly ecac963eaf Merge pull request #1596 from stephenc/threadsafe-node-queue
[JENKINS-27565] Fix threading issues with Nodes and Queue
2015-03-26 15:13:51 +00:00
Oliver Gondža 1c781526a6 Test BuildTrigger waits for parent completion 2015-03-26 12:31:27 +01:00
Stephen Connolly 17d6d415e6 Doeth, this didn't pick up the old ones 2015-03-26 10:25:08 +00:00
Oliver Gondža 3964189c5d JUnit4 2015-03-26 10:51:49 +01:00
Jesse Glick bd4d15785f [JENKINS-27607] Noting merge of #1623. 2015-03-25 21:07:00 -04:00
Stephen Connolly 9a7d578a0b Ensure that listeners do not get notified when a computer is killed from a thread with the Queue lock
- We don't know what those listeners will be doing
- I'm not completely happy with having to do it this way, there are some theoretical paths where we end
  up re-acquiring the Queue lock in Computer.kill() but they should not be the normal path
2015-03-26 00:09:43 +00:00
Stephen Connolly 7558a6a384 Merge remote-tracking branch 'origin/master' into threadsafe-node-queue 2015-03-25 23:42:49 +00:00
Jesse Glick e54b19d872 [JENKINS-27055] Noting merge of #1621. 2015-03-25 18:37:10 -04:00
Jesse Glick cfa4b100be Merge pull request #1610 from jglick/Executable-JENKINS-25938
API improvements around Executor/Executable
2015-03-25 18:32:33 -04:00
Jesse Glick 5c6a098997 Merged #1595 and enabled test. 2015-03-25 18:26:45 -04:00
Jesse Glick ac80ef27dd [JENKINS-27607] Reproduced in test. 2015-03-25 18:24:32 -04:00
Stephen Connolly a50bdf9e6d Merge remote-tracking branch 'origin/master' into threadsafe-node-queue 2015-03-25 21:40:33 +00:00
Jesse Glick 86fed62314 Addressing some review comments from @stephenc. 2015-03-25 17:40:19 -04:00
Jesse Glick 5f26494030 @CheckForNull as suggested by @stephenc. 2015-03-25 17:32:59 -04:00
Jesse Glick 0e3b6a9bf8 @GuardedBy as suggested by @stephenc, and some internal Javadoc. 2015-03-25 17:31:56 -04:00
Jesse Glick 546e0ec977 Merge pull request #1 from jenkinsci/pull-1610
Additional change suggestions on top of PR 1610
2015-03-25 16:47:58 -04:00
Kohsuke Kawaguchi 63d3b2641c Fixed a race condition.
IIUC, the expectation here is that Queue.Executable will instantiate AsynchronousException as a handle, start something asynchronously (say send a JMS message) with a callback, and the callback will tickle AsynchronousException.

So AsynchronousException might complete before it gets its executor set. This code change ensures that that case gets handled correctly.
2015-03-25 13:42:24 -07:00
Kohsuke Kawaguchi 4a7c2714dc More minor javadoc 2015-03-25 13:42:24 -07:00
Kohsuke Kawaguchi 47c39daa5c javadoc improvement 2015-03-25 13:42:24 -07:00
Kohsuke Kawaguchi c02f516fa1 javadoc formatting fix for better readability from code editor 2015-03-25 13:42:24 -07:00
Jesse Glick ced8d78db4 As requested by @kohsuke, rename Executables.getExecutor to Executor.of. 2015-03-25 16:16:27 -04:00
Jesse Glick d72d5d2157 Merge branch 'master' into Executable-JENKINS-25938 2015-03-25 15:43:05 -04:00
Richard Mortimer c2c9a3ef37 [FIXED JENKINS-26777] Build reports to be running for 45 yr and counting 2015-03-25 16:51:13 +00:00
Stephen Connolly 8264236a07 Update the retention strategies... the JSR 305 annotations do not seem to be spec'd to apply to child methods also... bold poorly spec'd annotations 2015-03-25 15:42:43 +00:00
Stephen Connolly 89835c85ac Even more fun with GuardedBy 2015-03-25 15:27:15 +00:00