- We will never mind that this is probably the wrong import to use as Jenkins core is consistently using the
wrong one (If anyone asks, for a `javax` import to be correct, it should have a JSR that has passed through voting
and not have a JSR that is still subject to change... OTOH one could argue that if the JSR 305 should ever
become revived from its current dormant state *and* it is decided to include in the JRE *then* the packages
would get moved out of `javax` and into `java` so they are not in final form anyway... but that pre-supposes
that the process of standardization does not modify the annotations and by virtue of being in `javax`
there will be some special case handling by some classloaders which is why depending on the JSR305 versions
is, in my view, a bad plan... anyway this is moot... Jenkins core is going with JSR305 as it currently stands
so we call all go down together!)
The original method of computing load statistics would compute the total and idle counts independently
which could lead to counting errors while jobs started in between the different state counting operations.
This change switches to returning a `LoadStatisticsSnapshot` so that callers will get a single consistent
view of the counts which was valid for at least one point in time during the collection of the snapshot.
The test system I set up to verify resolution of customer(s)' issues driving this change, required
additional changes in order to fully resolve the issues at hand. As a result I am bundling these
changes:
- Moves nodes to being store in separate config files outside of the main config file (improves performance) [FIXED JENKINS-27562]
- Makes the Jenkins is loading screen not block on the extensions loading lock [FIXED JENKINS-27563]
- Removes race condition rendering the list of executors [FIXED JENKINS-27564] [FIXED JENKINS-15355]
- Tidy up the locks that were causing deadlocks with the once retention strategy in durable tasks [FIXED JENKINS-27476]
- Remove any requirement from Jenkins Core to lock on the Queue when rendering the Jenkins UI [FIXED-JENKINS-27566]