Commit Graph
32590 Commits
Author SHA1 Message Date
Stephen Connolly cf9f3cfbed More fun with GuardedBy 2015-03-25 15:25:06 +00:00
Stephen Connolly 91527df490 fix guarded by values 2015-03-25 15:18:46 +00:00
Stephen Connolly 0150209ede Remove jenkins.setNodes(jenkins.getNodes()) style hacks to force the master number of executors to be updated 2015-03-25 14:25:07 +00:00
Stephen Connolly 6a1ed2807a Add some javadoc tags and record the time of the termination request 2015-03-25 14:21:09 +00:00
Stephen Connolly df160d63e2 Use the GuardedBy import that the Jenkins core uses by convention
- We will never mind that this is probably the wrong import to use as Jenkins core is consistently using the
  wrong one (If anyone asks, for a `javax` import to be correct, it should have a JSR that has passed through voting
  and not have a JSR that is still subject to change... OTOH one could argue that if the JSR 305 should ever
  become revived from its current dormant state *and* it is decided to include in the JRE *then* the packages
  would get moved out of `javax` and into `java` so they are not in final form anyway... but that pre-supposes
  that the process of standardization does not modify the annotations and by virtue of being in `javax`
  there will be some special case handling by some classloaders which is why depending on the JSR305 versions
  is, in my view, a bad plan... anyway this is moot... Jenkins core is going with JSR305 as it currently stands
  so we call all go down together!)
2015-03-25 14:20:14 +00:00
Stephen Connolly b8a4a53245 Arg! cannot use Util.isOverridden as these are protected methods 2015-03-25 13:05:46 +00:00
Stephen Connolly 6b8af39b03 [FIXED JENKINS-21618] Ensure that the LoadStatistics return a self-consistent result.
The original method of computing load statistics would compute the total and idle counts independently
which could lead to counting errors while jobs started in between the different state counting operations.
This change switches to returning a `LoadStatisticsSnapshot` so that callers will get a single consistent
view of the counts which was valid for at least one point in time during the collection of the snapshot.
2015-03-25 11:56:11 +00:00
Stephen Connolly c67eddf27b Arg! damn you copy and paste 2015-03-25 11:17:37 +00:00
Stephen Connolly 2d64d160e9 Missing @since and @Restricted 2015-03-25 10:38:10 +00:00
Stephen Connolly dae0a492b5 Minimise diff to reduce merge conflicts with #1610 2015-03-25 10:31:30 +00:00
Stephen Connolly f30444c819 Clarify the cases where we hand-roll in the optimized subset of a save() and how config files are maintained 2015-03-25 10:31:30 +00:00
Stephen Connolly f42e7f80ca Let's keep this private for now 2015-03-25 10:31:29 +00:00
Stephen Connolly 639f063076 Add license header 2015-03-25 10:31:29 +00:00
Stephen Connolly 951b07789c Document locking logic 2015-03-25 10:31:29 +00:00
Stephen Connolly 215186e0f1 Grammar 2015-03-25 10:31:29 +00:00
Stephen Connolly 1844f0d935 Remove dead code while we are at it 2015-03-25 10:31:29 +00:00
Stephen Connolly b4bb963e21 Move SaveableListener notification outside of the lock 2015-03-25 10:31:28 +00:00
Stephen Connolly 5a1999ea30 Let's be extra safe with unlocking the lock...
(yes `} finally { updateSnapshot(); } } finally {` looks ugly but it reduces the amount of indentation changes)
2015-03-25 10:31:28 +00:00
Stephen Connolly 1fe7375391 Document the terminatedBy methods 2015-03-25 10:31:28 +00:00
Stephen Connolly b341589b5d If the number of executors changes, then we need to update the computer list 2015-03-25 10:31:28 +00:00
Stephen Connolly 9cd00e40dd added @since tag as requested by @jglick 2015-03-25 10:30:45 +00:00
Jesse Glick 20c458d993 [FiXED JENKINS-27055] <BUILDID> should now also match numeric build IDs. 2015-03-24 17:40:01 -04:00
Stephen Connolly 2da5fb94a0 Aha! the latest failing test should now be ok 2015-03-24 17:12:36 +00:00
Stephen Connolly 027b8a9b37 fix failing tests (hopefully) 2015-03-24 16:11:25 +00:00
Jesse Glick 9ac2257d0a [FIXED JENKINS-26399] [JENKINS-25975] Merged #1609. 2015-03-24 11:25:38 -04:00
Stephen Connolly ebd0bde9fd Ooops, forgot that the setting of nodes needs to happen while the Queue lock is held and the computer list needs updating afterwards 2015-03-24 15:08:48 +00:00
Stephen Connolly 92147c3597 [FIXED JENKINS-27565] Refactor the Queue and Nodes to use a consistent locking strategy
The test system I set up to verify resolution of customer(s)' issues driving this change, required
additional changes in order to fully resolve the issues at hand. As a result I am bundling these
changes:

- Moves nodes to being store in separate config files outside of the main config file (improves performance) [FIXED JENKINS-27562]
- Makes the Jenkins is loading screen not block on the extensions loading lock [FIXED JENKINS-27563]
- Removes race condition rendering the list of executors [FIXED JENKINS-27564] [FIXED JENKINS-15355]
- Tidy up the locks that were causing deadlocks with the once retention strategy in durable tasks [FIXED JENKINS-27476]
- Remove any requirement from Jenkins Core to lock on the Queue when rendering the Jenkins UI [FIXED-JENKINS-27566]
2015-03-24 14:48:47 +00:00
Jesse Glick b106ae347f Deleting forgotten reference to Executable2. 2015-03-24 08:30:34 -04:00
Jesse Glick bb80340a92 [FIXED JENKINS-26900] AsynchronousExecution.displayCell 2015-03-24 08:27:52 -04:00
Jesse Glick 8589b211f9 [FIXED JENKINS-22941] AsynchronousExecution.blocksRestart 2015-03-24 08:10:08 -04:00
Jesse Glick d073f799a2 Abandoning Executable2; doing everything in AsynchronousExecution. 2015-03-24 07:35:58 -04:00
Kanstantsin Shautsou 9fb3b64072 Remove editorconfig
It doesn't support strip trailing space with "modified lines". That ends with many whitespace changes in old code changes.
2015-03-24 12:25:05 +03:00
Jesse Glick 09f7a2d3d1 [JENKINS-26092] Noting some things that could be improved. 2015-03-23 17:50:39 -04:00
Oliver Gondža b02e71e3df Merge pull request #1618 from sbilinski/polish_translations
Fixed spelling errors in existing Polish translations.
2015-03-23 22:30:47 +01:00
Jesse Glick eb276d857f Added interruptForShutdown flag.
Long-running executions can ignore shutdown events.
2015-03-23 17:25:48 -04:00
Szymon Biliński a6296ebbdd Fixed spelling errors in existing Polish translations. 2015-03-23 21:07:55 +01:00
Kohsuke Kawaguchi 412792a282 Update changelog.html 2015-03-23 11:09:29 -07:00
Kohsuke Kawaguchi dbd262bc0b updated changelog as a part of the release 2015-03-23 10:58:13 -07:00
Jesse Glick 1658b08f43 Merge branch 'master' into Executable-JENKINS-25938 2015-03-23 13:53:57 -04:00
Kohsuke Kawaguchi 520a8683b4 [maven-release-plugin] prepare for next development iteration 2015-03-23 10:33:52 -07:00
Kohsuke Kawaguchi 7809846c90 [maven-release-plugin] prepare release jenkins-1.596.2 jenkins-1.596.2 2015-03-23 10:33:51 -07:00
Kohsuke Kawaguchi a6cd99f210 updated changelog as a part of the release 2015-03-23 10:15:46 -07:00
Kohsuke Kawaguchi 24594e9c0f updated changelog for release 2015-03-23 08:48:08 -07:00
Kohsuke Kawaguchi 6b0f2c0ed9 [maven-release-plugin] prepare for next development iteration 2015-03-23 08:42:19 -07:00
Kohsuke Kawaguchi df66934070 [maven-release-plugin] prepare release jenkins-1.606 jenkins-1.606 2015-03-23 08:42:19 -07:00
Kohsuke Kawaguchi fab7443031 Merge security changes 2015-03-23 08:25:43 -07:00
Jesse Glick 94b427f849 Merge branch 'master' into JenkinsRule-additions 2015-03-23 10:31:26 -04:00
Kohsuke Kawaguchi c6d54a1682 Merge pull request #1614 from jzjzjzj/patch-2
typo in .editorconfig
2015-03-22 21:32:06 -07:00
Kohsuke Kawaguchi 8c3b703df8 Merge pull request #1615 from simon-andrews/patch-1
Fix typo in "legacy authentication strategy" description.
2015-03-22 21:31:39 -07:00
Simon Andrews 51a398a55c Fix typo in legacy authentication strategy description. 2015-03-22 20:46:26 -04:00